From: Kevin Wolf <kwolf@redhat.com>
Date: Mon, 12 Mar 2012 09:30:02 +0000 (+0100)
Subject: tracetool: Forbid argument name 'next'
X-Git-Tag: v1.1-rc0~126^2~44
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=fa6b8733c93107d7fcd7018d1822e93ba9edaa94;p=qemu.git

tracetool: Forbid argument name 'next'

It has happened more than once that patches that look perfectly sane
and work with simpletrace broke systemtap because they use 'next' as an
argument name for a tracing function. However, 'next' is a keyword for
systemtap, so we shouldn't use it.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---

diff --git a/scripts/tracetool b/scripts/tracetool
index 47389b62e..7b1c142b6 100755
--- a/scripts/tracetool
+++ b/scripts/tracetool
@@ -81,6 +81,10 @@ get_args()
     args=${1#*\(}
     args=${args%%\)*}
     echo "$args"
+
+    if (echo "$args" | grep "[ *]next\($\|[, ]\)" > /dev/null 2>&1); then
+        echo -e "\n#error 'next' is a bad argument name (clash with systemtap keyword)\n "
+    fi
 }
 
 # Get the argument name list of a trace event