From: Florian Westphal Date: Tue, 12 Jun 2018 16:36:19 +0000 (+0200) Subject: netfilter: xt_connmark: fix list corruption on rmmod X-Git-Tag: Ubuntu-5.4-5.4.0-11.14~5121^2~15^2~1 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=fc6ddbecce440df74fb4491c17c372b52cf5be83;p=mirror_ubuntu-focal-kernel.git netfilter: xt_connmark: fix list corruption on rmmod This needs to use xt_unregister_targets, else new revision is left on the list which then causes list to point to a target struct that has been free'd. Fixes: 472a73e00757 ("netfilter: xt_conntrack: Support bit-shifting for CONNMARK & MARK targets.") Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- diff --git a/net/netfilter/xt_connmark.c b/net/netfilter/xt_connmark.c index 94df000abb92..29c38aa7f726 100644 --- a/net/netfilter/xt_connmark.c +++ b/net/netfilter/xt_connmark.c @@ -211,7 +211,7 @@ static int __init connmark_mt_init(void) static void __exit connmark_mt_exit(void) { xt_unregister_match(&connmark_mt_reg); - xt_unregister_target(connmark_tg_reg); + xt_unregister_targets(connmark_tg_reg, ARRAY_SIZE(connmark_tg_reg)); } module_init(connmark_mt_init);