tests: cleanup concurrent.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup clonetest.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup api_reboot.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

sync: modify error string

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

utils: move recursive_destroy() from cfgsng to utils.

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Merge pull request #2441 from 2xsec/coverity

coverity: #1425816

coverity: #1425816

Explicit null dereferenced

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Merge pull request #2440 from brauner/2018-06-30/console_fixes

terminal: security fixes

tests: remove duplicate file_exists() definition

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

attach: do not make terminal raw

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

CODING_STYLE: add section about using strlcat()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

start: delete terminal on error

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

terminal: set FD_CLOEXEC on pty file descriptors

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>

utils: add fd_cloexec()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>

terminal: safely retrieve path of slave device

openpty() is a horrible function that uses strcpy() into the char *name
argument if name != NULL. We can't rely on the path being sane in all cases so
let's split out the name retrieval to ttyname_r().

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: simplify lxc_setup_dev_console()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2437 from 2xsec/bugfix

tools: share internal API symbols

tools: lxc-wait: remove the trailing .

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-top: fix coding style of strncmp

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-start: remove the trailing .

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-snapshot: fix coding style of strncmp

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-device: remove the trailing . & fix coding style of strncmp

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-destroy: remove the trailing .

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-create: remove the trailing . & fix coding style of strncmp

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-copy: remove the trailing . & fix coding style of strncmp

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-config: fix coding style of strncmp

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-checkpoint: remove the trailing .

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-autostart: remove the trailing . & fix coding style of strncmp

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: remote tool_list, tool_utils

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: arguments: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-monitor: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-create: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-snapshot: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-checkpoint: fix log name

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-checkpoint: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-unshare: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-top: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-copy: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-execute: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-device: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-destroy: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-console: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-config: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-ls: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-info: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

utils: code cleanups

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-autostart: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Merge pull request #2438 from brauner/2018-06-29/linux-v4.18

autodev: adapt to changes in Linux 4.18

autodev: adapt to changes in Linux 4.18

Starting with commit
55956b59df33 ("vfs: Allow userns root to call mknod on owned filesystems.")
Linux will allow mknod() in user namespaces for userns root if CAP_MKNOD is
available.
However, these device nodes are useless since

static struct super_block *alloc_super(struct file_system_type *type, int flags,
                                       struct user_namespace *user_ns)
{
        /* <snip> */

        if (s->s_user_ns != &init_user_ns)
                s->s_iflags |= SB_I_NODEV;

        /* <snip> */
}

will set the SB_I_NODEV flag on the filesystem. When a device node created in
non-init userns is open()ed the call chain will hit:

bool may_open_dev(const struct path *path)
{
        return !(path->mnt->mnt_flags & MNT_NODEV) &&
                !(path->mnt->mnt_sb->s_iflags & SB_I_NODEV);
}

which will cause an EPERM because the device node is located on an fs
owned by non-init-userns and thus doesn't grant access to device nodes due to
SB_I_NODEV.

The solution is straightforward. Unless you're real root you should bind-mount
device nodes.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tools: lxc-attach: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-cgroup: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-wait: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-unfreeze: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-freeze: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-stop: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-start: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Merge pull request #2434 from 2xsec/bugfix

tools: fix quiet option is not working

tools: cgroup, freeze, unfreeze, wait: change fprintf => lxc_error

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: fix quiet option is not working

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Merge pull request #2433 from brauner/2018-06-26/fix_android

log: account for Android's Bionic's strerror_r()

Merge pull request #2430 from duguhaotian/work

clear ONLCR flag for container pty

log: account for Android's Bionic's strerror_r()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

clear ONLCR flag for container pty

now container pty output log, use \r\n as a newline flag.
This is a windows type, so we need to change it. By clear
ONLCR can reach it.

Signed-off-by: duguhaotian <duguhaotian@gmail.com>

Merge pull request #2431 from 2xsec/bugfix

log: change LOG macros using strerror to SYS* macros

log: change ERROR macro using sterror to SYSERROR

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

log: remove strerror() from SYSERROR call

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

log: change DEBUG, INFO, TRACE, NOTICE macro using strerror to SYS* macro

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

log: change WARN macro using strerror to SYSWARN

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Merge pull request #2429 from 2xsec/bugfix

log: add strerror_r macro

log: add lxc_log_strerror_r macro

Let's ensure that we always use the thread-safe strerror_r() function and add
an approriate macro.
Additionally, define SYS*() macros for all log levels. They will use the new
macro and ensure thread-safe retrieval of errno values.

Signed-off-by: 2xsec <dh48.jeong@samsung.com>
[christian.brauner@ubuntu.com: simplify lxc_log_strerror_r macro]
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2428 from 2xsec/bugfix

move some comments in lxc.spec.in

move some comments in lxc.spec.in

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Merge pull request #2425 from brauner/2018-06-22/cleanups

commands: simplify lxc_cmd()

Merge pull request #2426 from 2xsec/bugfix

monitor: change exit() => _exit() system call in child process

monitor: change exit() => _exit() system call in child process

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

commands: simplify lxc_cmd()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2419 from 2xsec/bugfix

secure coding: strcat => strncat

btrfs: add to check return size of strlcat

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

confile: strncat => strlcat

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

utils: strncat => strlcat

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

tool_utils: strncat => strlcat

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

pam_cgfs: strncat => strlcat

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

conf: strncat => strlcat

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

cgfsng: strncat => strlcat

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

btrfs: fix wrong buffer size to append string

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

secure coding: cgfsng: strncat, strlcpy

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

secure coding: strcat => strncat

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

Merge pull request #2423 from brauner/2018-06-20/fix_arch

btrfs: s/strncat()/strlcat()/g

btrfs: s/strncat()/strlcat()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2422 from monstermunchkin/fix/busybox-template

templates: Fix busybox template

Merge pull request #2420 from brauner/2018-06-20/strlcat

include: add strlcat() implementation

templates: Fix busybox template

Use `busybox --list`, and exclude the `busybox` applet if necessary.

Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>

include: add strlcat() implementation

CC: Donghwa Jeong <dh48.jeong@samsung.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2418 from 2xsec/bugfix

fix fd handle leak

fix pointer c is dereferenced after checking null

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

fix fd handle leak

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

Merge pull request #2417 from 2xsec/bugfix

secure coding: #3 strcpy => strlcpy

secure coding: #3 strcpy => strlcpy

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

Merge pull request #2416 from 2xsec/bugfix

conf: remove unused argument

Merge pull request #2415 from 2xsec/bugfix

secure coding: #2 strcpy => strlcpy