]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
scsi: snic: Fix possible memory leak if device_add() fails
authorZhu Wang <wangzhu9@huawei.com>
Tue, 1 Aug 2023 11:14:21 +0000 (19:14 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 8 Aug 2023 01:34:08 +0000 (21:34 -0400)
commit41320b18a0e0dfb236dba4edb9be12dba1878156
tree759e7020c2e66081966f0139e841ceddb86d3858
parent04b5b5cb0136ce970333a9c6cec7e46adba1ea3a
scsi: snic: Fix possible memory leak if device_add() fails

If device_add() returns error, the name allocated by dev_set_name() needs
be freed. As the comment of device_add() says, put_device() should be used
to give up the reference in the error path. So fix this by calling
put_device(), then the name can be freed in kobject_cleanp().

Fixes: c8806b6c9e82 ("snic: driver for Cisco SCSI HBA")
Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
Acked-by: Narsimhulu Musini <nmusini@cisco.com>
Link: https://lore.kernel.org/r/20230801111421.63651-1-wangzhu9@huawei.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/snic/snic_disc.c