]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/xe/mmio: fix build warning for BAR resize on 32-bit
authorArnd Bergmann <arnd@arndb.de>
Mon, 26 Feb 2024 12:46:37 +0000 (13:46 +0100)
committerLucas De Marchi <lucas.demarchi@intel.com>
Wed, 28 Feb 2024 19:38:12 +0000 (11:38 -0800)
commitf5d3983366c0b88ec388b3407b29c1c0862ee2b8
treee3688da8b4a54575b8b3f1823a0ec2eb7347d5bc
parent0e6fec6da25167a568fbaeb8401d8172069124ad
drm/xe/mmio: fix build warning for BAR resize on 32-bit

clang complains about a nonsensical test on builds with a 32-bit phys_addr_t,
which means resizing will always fail:

drivers/gpu/drm/xe/xe_mmio.c:109:23: error: result of comparison of constant 4294967296 with expression of type 'resource_size_t' (aka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare]
  109 |                     root_res->start > 0x100000000ull)
      |                     ~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~

Previously, BAR resize was always disallowed on 32-bit kernels, but
this apparently changed recently. Since 32-bit machines can in theory
support PAE/LPAE for large address spaces, this may end up useful,
so change the driver to shut up the warning but still work when
phys_addr_t/resource_size_t is 64 bit wide.

Fixes: 9a6e6c14bfde ("drm/xe/mmio: Use non-atomic writeq/readq variant for 32b")
Fixes: 237412e45390 ("drm/xe: Enable 32bits build")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Acked-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240226124736.1272949-2-arnd@kernel.org
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/xe_mmio.c