From 49943af70f1a8168283baceed2b95a42530c4749 Mon Sep 17 00:00:00 2001 From: Po-Hsu Lin Date: Fri, 6 Dec 2019 13:07:00 +0100 Subject: [PATCH] selftests/net: correct the return value for run_afpackettests BugLink: https://bugs.launchpad.net/bugs/1825778 The run_afpackettests will be marked as passed regardless the return value of those sub-tests in the script: -------------------- running psock_tpacket test -------------------- [FAIL] selftests: run_afpackettests [PASS] Fix this by changing the return value for each tests. Signed-off-by: Po-Hsu Lin Signed-off-by: David S. Miller (backported from commit 8c03557c3f25271e62e39154af66ebdd1b59c9ca) [PHLin: backported with the same logic] Signed-off-by: Po-Hsu Lin Acked-by: Thadeu Lima de Souza Cascardo Acked-by: Connor Kuehl Signed-off-by: Kleber Sacilotto de Souza --- tools/testing/selftests/net/run_afpackettests | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/testing/selftests/net/run_afpackettests b/tools/testing/selftests/net/run_afpackettests index 21fe149e3de1..f4abc9f9cfeb 100755 --- a/tools/testing/selftests/net/run_afpackettests +++ b/tools/testing/selftests/net/run_afpackettests @@ -6,12 +6,14 @@ if [ $(id -u) != 0 ]; then exit 0 fi +ret=0 echo "--------------------" echo "running psock_fanout test" echo "--------------------" ./psock_fanout if [ $? -ne 0 ]; then echo "[FAIL]" + ret=1 else echo "[PASS]" fi @@ -22,6 +24,8 @@ echo "--------------------" ./psock_tpacket if [ $? -ne 0 ]; then echo "[FAIL]" + ret=1 else echo "[PASS]" fi +exit $ret -- 2.39.2