From b483e39524be82e44caa2804145415d17713a6a5 Mon Sep 17 00:00:00 2001 From: AJFISH Date: Fri, 6 Jul 2007 18:48:06 +0000 Subject: [PATCH] Updated comments for IntelCompiler specific warnings git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3133 6f19259b-4bc3-4df7-8a09-765794883524 --- MdePkg/Include/Ia32/ProcessorBind.h | 17 +++++++++++++++++ MdePkg/Include/Ipf/ProcessorBind.h | 21 +++++++++++---------- MdePkg/Include/x64/ProcessorBind.h | 18 ++++++++++++++++++ 3 files changed, 46 insertions(+), 10 deletions(-) diff --git a/MdePkg/Include/Ia32/ProcessorBind.h b/MdePkg/Include/Ia32/ProcessorBind.h index 61273e624c..2dccac4eb0 100644 --- a/MdePkg/Include/Ia32/ProcessorBind.h +++ b/MdePkg/Include/Ia32/ProcessorBind.h @@ -27,6 +27,23 @@ #pragma pack() #endif +#if __INTEL_COMPILER +// +// Disable ICC's remark #1418: external function definition with no prior declaration. +// This is legal ANSI C code so we disable the remark that is turned on with /W4 +// +#pragma warning ( disable : 1418 ) + + +// +// Disable ICC's remark #1419: external declaration in primary source file +// This is legal ANSI C code so we disable the remark that is turned on with /W4 +// +#pragma warning ( disable : 1419 ) + +#endif + + #if _MSC_EXTENSIONS // diff --git a/MdePkg/Include/Ipf/ProcessorBind.h b/MdePkg/Include/Ipf/ProcessorBind.h index a383868fc6..fdc0a4dd3b 100644 --- a/MdePkg/Include/Ipf/ProcessorBind.h +++ b/MdePkg/Include/Ipf/ProcessorBind.h @@ -28,28 +28,29 @@ #pragma pack() -#if _MSC_EXTENSIONS - -// -// Disable warning that make it impossible to compile at /W4 -// This only works for Microsoft tools. Copied from the -// IA-32 version of efibind.h -// - #if __INTEL_COMPILER // -// Disable ICC's error #1418: external function definition with no prior declaration +// Disable ICC's remark #1418: external function definition with no prior declaration. +// This is legal ANSI C code so we disable the remark that is turned on with /W4 // #pragma warning ( disable : 1418 ) // -// Disable ICC's error #1419: external declaration in primary source file +// Disable ICC's remark #1419: external declaration in primary source file +// This is legal ANSI C code so we disable the remark that is turned on with /W4 // #pragma warning ( disable : 1419 ) #endif + +#if _MSC_EXTENSIONS +// +// Disable warning that make it impossible to compile at /W4 +// This only works for Microsoft tools. +// + // // Disabling bitfield type checking warnings. // diff --git a/MdePkg/Include/x64/ProcessorBind.h b/MdePkg/Include/x64/ProcessorBind.h index d0c02c3474..a4a1a35e35 100644 --- a/MdePkg/Include/x64/ProcessorBind.h +++ b/MdePkg/Include/x64/ProcessorBind.h @@ -28,6 +28,24 @@ #pragma pack() #endif + +#if __INTEL_COMPILER +// +// Disable ICC's remark #1418: external function definition with no prior declaration. +// This is legal ANSI C code so we disable the remark that is turned on with /W4 +// +#pragma warning ( disable : 1418 ) + + +// +// Disable ICC's remark #1419: external declaration in primary source file +// This is legal ANSI C code so we disable the remark that is turned on with /W4 +// +#pragma warning ( disable : 1419 ) + +#endif + + #if _MSC_EXTENSIONS // -- 2.39.2