From f4e4c77984c69f7fd57f0c9f7b2f89eb4d9e852e Mon Sep 17 00:00:00 2001
From: =?utf8?q?Fabian=20Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
Date: Wed, 10 Nov 2021 12:41:04 +0100
Subject: [PATCH] disk reassign: fix assigning to unused slot
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

this broke with the previous simplification.

Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
 PVE/API2/Qemu.pm | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 323c294..4404da9 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -3554,10 +3554,17 @@ __PACKAGE__->register_method({
 		if PVE::QemuServer::check_running($vmid) && $disk !~ m/^unused\d+$/;
 
 	    # now re-parse using target disk slot format
-	    $drive = PVE::QemuServer::parse_drive(
-	        $target_disk,
-	        $source_conf->{$disk},
-	    );
+	    if ($target_disk =~ /^unused\d+$/) {
+		$drive = PVE::QemuServer::parse_drive(
+		    $target_disk,
+		    $source_volid,
+		);
+	    } else {
+		$drive = PVE::QemuServer::parse_drive(
+		    $target_disk,
+		    $source_conf->{$disk},
+		);
+	    }
 	    die "failed to parse source disk for target disk format - $@\n" if !$drive;
 
 	    my $repl_conf = PVE::ReplicationConfig->new();
-- 
2.39.2