From 13221cf2b4016b18b24e68d7972ed0dbfdc769bd Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Wed, 2 Aug 2017 12:10:50 -0400 Subject: [PATCH] pimd: Clean back pointer upon deletion The channel_oil has a back pointer(up) to the upstream data structure. If we are planning on keeping the channel oil (due to ref count issues) longer than keeping the upstream, when we delete the upstream we were not clearing the back pointer to up. This would result in a situation where if that memory has started to be used again it will cause a crash and other fun things. Ticket: CM-17092 Signed-off-by: Donald Sharp --- pimd/pim_upstream.c | 1 + 1 file changed, 1 insertion(+) diff --git a/pimd/pim_upstream.c b/pimd/pim_upstream.c index a8506501e..95d1a840f 100644 --- a/pimd/pim_upstream.c +++ b/pimd/pim_upstream.c @@ -153,6 +153,7 @@ static void upstream_channel_oil_detach(struct pim_upstream *up) /* Detaching from channel_oil, channel_oil may exist post del, but upstream would not keep reference of it */ + up->channel_oil->up = NULL; pim_channel_oil_del(up->channel_oil); up->channel_oil = NULL; } -- 2.39.2