From 060a437fe97dea07b2d9c671e69deb833ca6b8b7 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Tue, 7 Mar 2023 18:17:43 +0100 Subject: [PATCH] cert info: minimal code reduction shorter and avoids variable are longer in scope than they're used too Signed-off-by: Thomas Lamprecht --- src/PVE/Certificate.pm | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/PVE/Certificate.pm b/src/PVE/Certificate.pm index c65fd31..03f27fc 100644 --- a/src/PVE/Certificate.pm +++ b/src/PVE/Certificate.pm @@ -222,7 +222,7 @@ sub get_certificate_fingerprint { return $fp; } -sub check_certificate_matches_key { +sub assert_certificate_matches_key { my ($cert_path, $key_path) = @_; die "No certificate path given!\n" if !$cert_path; @@ -291,13 +291,11 @@ sub get_certificate_info { $info->{fingerprint} = Net::SSLeay::X509_get_fingerprint($cert, 'sha256'); - my $subject = Net::SSLeay::X509_get_subject_name($cert); - if ($subject) { + if (my $subject = Net::SSLeay::X509_get_subject_name($cert)) { $info->{subject} = Net::SSLeay::X509_NAME_oneline($subject); } - my $issuer = Net::SSLeay::X509_get_issuer_name($cert); - if ($issuer) { + if (my $issuer = Net::SSLeay::X509_get_issuer_name($cert)) { $info->{issuer} = Net::SSLeay::X509_NAME_oneline($issuer); } -- 2.39.5