From 122482a398db9f02287efce9eec26e08dac82bcd Mon Sep 17 00:00:00 2001 From: John Snow Date: Thu, 5 Feb 2015 12:41:29 -0500 Subject: [PATCH] qtest/ahci: Assert sector size in identify test A minor sanity check to assert that the sector size is 512. The current block layer code deeply assumes that the IDE sector size will be 512 bytes, so we carry forward that assumption here. This is useful for the DMA tests, which currently assume that a sector will always be 512 bytes. Signed-off-by: John Snow Reviewed-by: Paolo Bonzini Message-id: 1423158090-25580-19-git-send-email-jsnow@redhat.com Signed-off-by: Stefan Hajnoczi --- tests/ahci-test.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/ahci-test.c b/tests/ahci-test.c index 3a0131aa66..f595b96a94 100644 --- a/tests/ahci-test.c +++ b/tests/ahci-test.c @@ -663,6 +663,7 @@ static void ahci_test_identify(AHCIQState *ahci) uint16_t buff[256]; unsigned px; int rc; + uint16_t sect_size; const size_t buffsize = 512; g_assert(ahci != NULL); @@ -710,6 +711,9 @@ static void ahci_test_identify(AHCIQState *ahci) string_bswap16(&buff[23], 8); rc = memcmp(&buff[23], "version ", 8); g_assert_cmphex(rc, ==, 0); + + sect_size = le16_to_cpu(*((uint16_t *)(&buff[5]))); + g_assert_cmphex(sect_size, ==, 0x200); } /******************************************************************************/ -- 2.39.5