From 12f089b5de5fb47f97133442b6df9b2b88681437 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Wed, 19 Aug 2020 18:47:08 +0200 Subject: [PATCH] api: ACME renew: handle error from revoking old cert gracefully this normally just means that the old cert is already expired, we do not care for that - after all: we got a new (renewed) valid cert successfully. Signed-off-by: Thomas Lamprecht --- PVE/API2/ACME.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/API2/ACME.pm b/PVE/API2/ACME.pm index 8eb04a7d..33890dac 100644 --- a/PVE/API2/ACME.pm +++ b/PVE/API2/ACME.pm @@ -301,7 +301,8 @@ __PACKAGE__->register_method ({ die "$@\n" if $@; print "Revoking old certificate\n"; - $acme->revoke_certificate($old_cert); + eval { $acme->revoke_certificate($old_cert) }; + warn "Revoke request to CA failed: $@" if $@; }; return $rpcenv->fork_worker("acmerenew", undef, $authuser, $realcmd); -- 2.39.5