From 21e5ae5b36de7834911c3e4de2dc1bee34c44c5d Mon Sep 17 00:00:00 2001 From: Dominik Csapak Date: Tue, 23 Apr 2024 14:15:00 +0200 Subject: [PATCH] ui: backup job editor: fix disable behavior for fleecing storage commit 569b0388 (ui: fix reset behavior of backup job editor) disabled the fleecing storage field by default (as that is the default state) to fix the reset behavior. This broke editing the job when fleecing was enabled and the user did not navigate to the advanced tab yet. It seems that the 'bind' here only gets triggered once the panel is rendered, but we actually need it before that. To work around the issue for now, manually enable/disable the field when toggling the fleecing checkbox. (Though this warrants a bit of deeper investigation into this bind behavior) Signed-off-by: Dominik Csapak --- www/manager6/panel/BackupAdvancedOptions.js | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/www/manager6/panel/BackupAdvancedOptions.js b/www/manager6/panel/BackupAdvancedOptions.js index f1810637..650946fe 100644 --- a/www/manager6/panel/BackupAdvancedOptions.js +++ b/www/manager6/panel/BackupAdvancedOptions.js @@ -18,6 +18,17 @@ Ext.define('PVE.panel.BackupAdvancedOptions', { controller: { xclass: 'Ext.app.ViewController', + + toggleFleecing: function(cb, value) { + let me = this; + me.lookup('fleecingStorage').setDisabled(!value); + }, + + control: { + 'proxmoxcheckbox[reference=fleecingEnabled]': { + change: 'toggleFleecing', + }, + } }, onGetValues: function(formValues) { @@ -181,14 +192,11 @@ Ext.define('PVE.panel.BackupAdvancedOptions', { xtype: 'pveStorageSelector', name: 'fleecing-storage', fieldLabel: gettext('Fleecing Storage'), - reference: 'storageSelector', + reference: 'fleecingStorage', clusterView: true, storageContent: 'images', allowBlank: false, disabled: true, - bind: { - disabled: '{!fleecingEnabled.checked}', - }, }, endFlex: 2, endColumn: { -- 2.39.5