From 221908d2aebfaa0b48c890f79721bd31f14ab99d Mon Sep 17 00:00:00 2001 From: Eh2406 Date: Tue, 6 Nov 2018 20:40:18 -0500 Subject: [PATCH] document that meta_fuss tests are flaky, and to ignore. --- tests/testsuite/support/resolver.rs | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/tests/testsuite/support/resolver.rs b/tests/testsuite/support/resolver.rs index ae89eaf71..4c7ad3288 100644 --- a/tests/testsuite/support/resolver.rs +++ b/tests/testsuite/support/resolver.rs @@ -460,12 +460,16 @@ pub fn registry_strategy( /// This test is to test the generator to ensure /// that it makes registries with large dependency trees +/// +/// This is a form of randomized testing, if you are unlucky it can fail. +/// A failure on it's own is not a big dael. If you did not change the +/// `registry_strategy` then feel free to retry without concern. #[test] fn meta_test_deep_trees_from_strategy() { let mut dis = [0; 21]; let strategy = registry_strategy(50, 20, 60); - for _ in 0..64 { + for _ in 0..128 { let PrettyPrintRegistry(input) = strategy .new_tree(&mut TestRunner::default()) .unwrap() @@ -488,19 +492,23 @@ fn meta_test_deep_trees_from_strategy() { } panic!( - "In 640 tries we did not see a wide enough distribution of dependency trees! dis: {:?}", + "In 1280 tries we did not see a wide enough distribution of dependency trees! dis: {:?}", dis ); } /// This test is to test the generator to ensure /// that it makes registries that include multiple versions of the same library +/// +/// This is a form of randomized testing, if you are unlucky it can fail. +/// A failure on its own is not a big deal. If you did not change the +/// `registry_strategy` then feel free to retry without concern. #[test] fn meta_test_multiple_versions_strategy() { let mut dis = [0; 10]; let strategy = registry_strategy(50, 20, 60); - for _ in 0..64 { + for _ in 0..128 { let PrettyPrintRegistry(input) = strategy .new_tree(&mut TestRunner::default()) .unwrap() @@ -524,7 +532,7 @@ fn meta_test_multiple_versions_strategy() { } } panic!( - "In 640 tries we did not see a wide enough distribution of multiple versions of the same library! dis: {:?}", + "In 1280 tries we did not see a wide enough distribution of multiple versions of the same library! dis: {:?}", dis ); } -- 2.39.5