From 28fd7b090d1b416f1e94e52abd08bf16fd404649 Mon Sep 17 00:00:00 2001 From: "Zhang, Chao B" Date: Thu, 8 Feb 2018 14:22:39 +0800 Subject: [PATCH] SecurityPkg: Tcg2Smm: Refine type cast in pointer abstraction Pointer subtraction is not performed by pointers to elements of the same array object. Such behavior is undefined by C11 standard and might lead to potential issues, Refine pointer subtraction by first casting each pointer to UINTN. Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chao Zhang Reviewed-by: Hao Wu --- SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c b/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c index 6eb62ae64c..c3cee834ae 100644 --- a/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c +++ b/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c @@ -543,7 +543,7 @@ UpdatePossibleResource ( // DataPtr += 2; if (DataPtr < DataEndPtr) { - SetMem(DataPtr, (UINTN)(DataEndPtr - DataPtr), AML_NOOP_OP); + SetMem(DataPtr, (UINTN)DataEndPtr - (UINTN)DataPtr, AML_NOOP_OP); } return EFI_SUCCESS; -- 2.39.2