From 29aeae683353e08ba08f4dc4bb202b4fc35d3661 Mon Sep 17 00:00:00 2001 From: Micah Morton Date: Wed, 25 Sep 2019 21:43:53 +0000 Subject: [PATCH] LSM: SafeSetID: Stop releasing uninitialized ruleset BugLink: https://launchpad.net/bugs/1845391 The first time a rule set is configured for SafeSetID, we shouldn't be trying to release the previously configured ruleset, since there isn't one. Currently, the pointer that would point to a previously configured ruleset is uninitialized on first rule set configuration, leading to a crash when we try to call release_ruleset with that pointer. Acked-by: Jann Horn Signed-off-by: Micah Morton (cherry picked from commit 21ab8580b383f27b7f59b84ac1699cb26d6c3d69) Signed-off-by: Tyler Hicks Acked-by: John Johansen Acked-by: Steve Beattie Signed-off-by: Seth Forshee --- security/safesetid/securityfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/security/safesetid/securityfs.c b/security/safesetid/securityfs.c index d568e17dd773..74a13d432ed8 100644 --- a/security/safesetid/securityfs.c +++ b/security/safesetid/securityfs.c @@ -187,7 +187,8 @@ out_free_rule: out_free_buf: kfree(buf); out_free_pol: - release_ruleset(pol); + if (pol) + release_ruleset(pol); return err; } -- 2.39.5