From 2e8f56f2a9417692b758fee9ee5a01d857dd980f Mon Sep 17 00:00:00 2001 From: Miquel Raynal Date: Tue, 28 Apr 2020 11:43:01 +0200 Subject: [PATCH] mtd: rawnand: jedec: Define the number of parameter pages Use a macro to define the number of parameter page instead of hardcoding it everywhere. Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon Link: https://lore.kernel.org/linux-mtd/20200428094302.14624-9-miquel.raynal@bootlin.com --- drivers/mtd/nand/raw/nand_jedec.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/raw/nand_jedec.c b/drivers/mtd/nand/raw/nand_jedec.c index 9b540e76f84f..0cd322a8be24 100644 --- a/drivers/mtd/nand/raw/nand_jedec.c +++ b/drivers/mtd/nand/raw/nand_jedec.c @@ -16,6 +16,8 @@ #include "internals.h" +#define JEDEC_PARAM_PAGES 3 + /* * Check if the NAND chip is JEDEC compliant, returns 1 if it is, 0 otherwise. */ @@ -47,7 +49,7 @@ int nand_jedec_detect(struct nand_chip *chip) goto free_jedec_param_page; } - for (i = 0; i < 3; i++) { + for (i = 0; i < JEDEC_PARAM_PAGES; i++) { ret = nand_read_data_op(chip, p, sizeof(*p), true); if (ret) { ret = 0; @@ -59,7 +61,7 @@ int nand_jedec_detect(struct nand_chip *chip) break; } - if (i == 3) { + if (i == JEDEC_PARAM_PAGES) { pr_err("Could not find valid JEDEC parameter page; aborting\n"); goto free_jedec_param_page; } -- 2.39.5