From 311fb72a272a2c66e611d08e1950cb756f245838 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Fri, 24 Mar 2023 11:51:35 +0100 Subject: [PATCH] language selector: increase only picker list view As that's what matters for the selection, having parts of the already selected language cut off is not really a big deal as either one knows the language and the initial native part is enough or the picker needs to be opened for changing selection anyway. But, we can give the field itself a bit more space by reducing the label width to 75, which is enough for all languages as grepping our PO files for "Language" and their translation, it seems that the widest one comes from Euskara (Basque) with its "Hizkuntza" having 9 characters. This way we avoid having to many different Fixes: 454ff6e ("language selector: increase field width") Signed-off-by: Thomas Lamprecht --- src/form/LanguageSelector.js | 5 +++++ src/window/LanguageEdit.js | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/form/LanguageSelector.js b/src/form/LanguageSelector.js index 92f28b1..9167902 100644 --- a/src/form/LanguageSelector.js +++ b/src/form/LanguageSelector.js @@ -3,4 +3,9 @@ Ext.define('Proxmox.form.LanguageSelector', { xtype: 'proxmoxLanguageSelector', comboItems: Proxmox.Utils.language_array(), + + matchFieldWidth: false, + listConfig: { + width: 300, + }, }); diff --git a/src/window/LanguageEdit.js b/src/window/LanguageEdit.js index e1ba6cc..2269a45 100644 --- a/src/window/LanguageEdit.js +++ b/src/window/LanguageEdit.js @@ -35,10 +35,10 @@ Ext.define('Proxmox.window.LanguageEditWindow', { { xtype: 'proxmoxLanguageSelector', fieldLabel: gettext('Language'), + labelWidth: 75, bind: { value: '{language}', }, - width: 400, }, ], buttons: [ -- 2.39.2