From 33e2ba78eeaa9b56f27b7174d66ca5180832623b Mon Sep 17 00:00:00 2001 From: Hao Wu Date: Tue, 15 Dec 2015 05:43:08 +0000 Subject: [PATCH] MdeModulePkg UfsPassThru: ASSERT if params are NULL in SignalCallerEvent In function SignalCallerEvent(), 'Private' and 'TransReq' are dereferenced before NULL checking. Since the function assumes that both 'Private' and 'TransReq' passed in are not NULL pointer, this commit will add an ASSERT to make sure the above assumption is satisfied. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu Reviewed-by: Feng Tian git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19266 6f19259b-4bc3-4df7-8a09-765794883524 --- MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c b/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c index 4fbe199390..81653af5a8 100644 --- a/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c +++ b/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c @@ -2191,6 +2191,8 @@ SignalCallerEvent ( EDKII_UFS_HOST_CONTROLLER_PROTOCOL *UfsHc; EFI_EVENT CallerEvent; + ASSERT ((Private != NULL) && (TransReq != NULL)); + UfsHc = Private->UfsHostController; CallerEvent = TransReq->CallerEvent; @@ -2214,9 +2216,8 @@ SignalCallerEvent ( TransReq->CmdDescHost ); } - if (TransReq != NULL) { - FreePool (TransReq); - } + + FreePool (TransReq); gBS->SignalEvent (CallerEvent); return; -- 2.39.2