From 4a67ca44f131d945fcd1d00884618800eb446fbb Mon Sep 17 00:00:00 2001 From: Bhanuprakash Bodireddy Date: Sun, 1 Oct 2017 08:57:38 +0100 Subject: [PATCH] ofproto: Remove break after OVS_NOT_REACHED. The break statement would never be executed as OVS_NOT_REACHED() internally invokes abort() and causes process termination. Signed-off-by: Bhanuprakash Bodireddy Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif-ipfix.c | 1 - ofproto/ofproto-dpif-xlate.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/ofproto/ofproto-dpif-ipfix.c b/ofproto/ofproto-dpif-ipfix.c index 645268d21..4d168784b 100644 --- a/ofproto/ofproto-dpif-ipfix.c +++ b/ofproto/ofproto-dpif-ipfix.c @@ -1314,7 +1314,6 @@ ipfix_def_options_template_fields(enum ipfix_options_template opt_tmpl_type, case NUM_IPFIX_OPTIONS_TEMPLATE: default: OVS_NOT_REACHED(); - break; } return 0; diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index 667960d70..468cd160c 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofproto-dpif-xlate.c @@ -3231,7 +3231,6 @@ propagate_tunnel_data_to_flow(struct xlate_ctx *ctx, struct eth_addr dmac, case __OVS_VPORT_TYPE_MAX: default: OVS_NOT_REACHED(); - break; } /* * Update base_flow first followed by flow as the dst_flow gets modified @@ -5950,7 +5949,6 @@ xlate_generic_encap_action(struct xlate_ctx *ctx, default: /* New packet type was checked during decoding. */ OVS_NOT_REACHED(); - break; } if (!ctx->error) { -- 2.39.5