From 4d8b658c8c5b58356df1722bb60c70dc9faec7f1 Mon Sep 17 00:00:00 2001 From: Anuradha Karuppiah Date: Wed, 20 May 2020 14:56:36 -0700 Subject: [PATCH] zebra: evpn-mh: add error logs on ES processing failures Cleanup some of the XXX added during development of MH. Signed-off-by: Anuradha Karuppiah --- zebra/zebra_evpn_mh.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/zebra/zebra_evpn_mh.c b/zebra/zebra_evpn_mh.c index 2567171c5..7634b1255 100644 --- a/zebra/zebra_evpn_mh.c +++ b/zebra/zebra_evpn_mh.c @@ -1201,7 +1201,6 @@ static int zebra_evpn_es_send_del_to_client(struct zebra_evpn_es *es) return zserv_send_message(client, s); } -/* XXX - call any time ZEBRA_EVPNES_LOCAL gets set or cleared */ static void zebra_evpn_es_re_eval_send_to_client(struct zebra_evpn_es *es, bool es_evi_re_reval) { @@ -1497,7 +1496,9 @@ static int zebra_evpn_remote_es_del(esi_t *esi, struct in_addr vtep_ip) es = zebra_evpn_es_find(esi); if (!es) { - /* XXX - error log */ + zlog_warn("remote es %s vtep %pI4 del failed, es missing", + esi_to_str(esi, buf, sizeof(buf)), + &vtep_ip); return -1; } @@ -1538,7 +1539,9 @@ static int zebra_evpn_remote_es_add(esi_t *esi, struct in_addr vtep_ip) if (!es) { es = zebra_evpn_es_new(esi); if (!es) { - /* XXX - error log */ + zlog_warn("remote es %s vtep %pI4 add failed, es missing", + esi_to_str(esi, buf, sizeof(buf)), + &vtep_ip); return -1; } } -- 2.39.5