From 7ed025e1d5ace4aede5785ad54168cf763991a95 Mon Sep 17 00:00:00 2001 From: Dietmar Maurer Date: Fri, 13 Sep 2013 06:53:03 +0200 Subject: [PATCH] bump version to 3.1-11 vzdump: fix hook script environment --- PVE/VZDump.pm | 6 +++++- debian/changelog.Debian | 6 ++++++ defines.mk | 2 +- vzdump-hook-script.pl | 8 +++++++- 4 files changed, 19 insertions(+), 3 deletions(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 0bef3fdf..339bdbd5 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -646,7 +646,11 @@ sub run_hook_script { local %ENV; - foreach my $ek (qw(vmtype dumpdir hostname tarfile logfile storeid)) { + # set immutable opts directly (so they are available in all phases) + $ENV{STOREID} = $opts->{storage} if $opts->{storage}; + $ENV{DUMPDIR} = $opts->{dumpdir} if $opts->{dumpdir}; + + foreach my $ek (qw(vmtype hostname tarfile logfile)) { $ENV{uc($ek)} = $task->{$ek} if $task->{$ek}; } diff --git a/debian/changelog.Debian b/debian/changelog.Debian index 277c4f3e..49fe5fa5 100644 --- a/debian/changelog.Debian +++ b/debian/changelog.Debian @@ -1,3 +1,9 @@ +pve-manager (3.1-11) unstable; urgency=low + + * vzdump: fix hook script environment for job-* phase + + -- Proxmox Support Team Fri, 13 Sep 2013 06:55:30 +0200 + pve-manager (3.1-10) unstable; urgency=low * vzdump: pass storage ID to hook scripts diff --git a/defines.mk b/defines.mk index b1635093..995aea7d 100644 --- a/defines.mk +++ b/defines.mk @@ -2,7 +2,7 @@ RELEASE=3.1 VERSION=3.1 PACKAGE=pve-manager -PACKAGERELEASE=10 +PACKAGERELEASE=11 BINDIR=${DESTDIR}/usr/bin PERLLIBDIR=${DESTDIR}/usr/share/perl5 diff --git a/vzdump-hook-script.pl b/vzdump-hook-script.pl index b345677c..b03fdc2d 100755 --- a/vzdump-hook-script.pl +++ b/vzdump-hook-script.pl @@ -12,6 +12,12 @@ if ($phase eq 'job-start' || $phase eq 'job-end' || $phase eq 'job-abort') { + my $dumpdir = $ENV{DUMPDIR}; + + my $storeid = $ENV{STOREID}; + + print "HOOK-ENV: dumpdir=$dumpdir;storeid=$storeid\n"; + # do what you want } elsif ($phase eq 'backup-start' || @@ -39,7 +45,7 @@ if ($phase eq 'job-start' || # logfile is only available in phase 'log-end' my $logfile = $ENV{LOGFILE}; - print "HOOK-ENV: vmtype=$vmtype;dumpdir=$dumpdir;hostname=$hostname;tarfile=$tarfile;logfile=$logfile\n"; + print "HOOK-ENV: vmtype=$vmtype;dumpdir=$dumpdir;storeid=$storeid;hostname=$hostname;tarfile=$tarfile;logfile=$logfile\n"; # example: copy resulting backup file to another host using scp if ($phase eq 'backup-end') { -- 2.39.2