From 90e52483bf572fd6d15bdfa5e0904ed0aa8b4199 Mon Sep 17 00:00:00 2001 From: Sami Mujawar Date: Tue, 9 Jul 2019 15:11:49 +0100 Subject: [PATCH] DynamicTablesPkg: Fix ACPI table rev field width The VS2017 compiler reports 'warning C4244: '=': conversion from 'const UINT32' to 'UINT8', possible loss of data' when the ACPI table revision field is being updated. The width of the revision field in the EFI_ACPI_DESCRIPTION_HEADER struct is 8-bit wide. Therefore, to fix the above warning make the ACPI Table revision field usage 8-bit wide across Dynamic Tables Framework. Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov --- DynamicTablesPkg/Include/AcpiTableGenerator.h | 4 ++-- DynamicTablesPkg/Include/StandardNameSpaceObjects.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/DynamicTablesPkg/Include/AcpiTableGenerator.h b/DynamicTablesPkg/Include/AcpiTableGenerator.h index e46717e6e8..b55feb4e75 100644 --- a/DynamicTablesPkg/Include/AcpiTableGenerator.h +++ b/DynamicTablesPkg/Include/AcpiTableGenerator.h @@ -287,10 +287,10 @@ typedef struct AcpiTableGenerator { UINT32 AcpiTableSignature; /// The ACPI table revision. - UINT32 AcpiTableRevision; + UINT8 AcpiTableRevision; /// The minimum supported ACPI table revision. - UINT32 MinAcpiTableRevision; + UINT8 MinAcpiTableRevision; /// The ACPI table creator ID. UINT32 CreatorId; diff --git a/DynamicTablesPkg/Include/StandardNameSpaceObjects.h b/DynamicTablesPkg/Include/StandardNameSpaceObjects.h index 21bb7de404..0ba6b16369 100644 --- a/DynamicTablesPkg/Include/StandardNameSpaceObjects.h +++ b/DynamicTablesPkg/Include/StandardNameSpaceObjects.h @@ -79,7 +79,7 @@ typedef struct CmAStdObjAcpiTableInfo { UINT32 AcpiTableSignature; /// The ACPI table revision - UINT32 AcpiTableRevision; + UINT8 AcpiTableRevision; /// The ACPI Table Generator ID ACPI_TABLE_GENERATOR_ID TableGeneratorId; -- 2.39.5