From 93eb8e31f38b3eb612e522c62e8932d7fd576ff9 Mon Sep 17 00:00:00 2001 From: Paolo Bonzini Date: Wed, 10 Aug 2016 10:05:03 +0200 Subject: [PATCH] checkpatch: check for CVS keywords on all sources These should apply to all files, not just C/C++. Tweak the regular expression to check for whole words, to avoid false positives on Perl variables starting with "Id". Signed-off-by: Paolo Bonzini --- scripts/checkpatch.pl | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 082c4cecc9..fea576d1b4 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1354,6 +1354,11 @@ sub process { WARN("adding a line without newline at end of file\n" . $herecurr); } +# check for RCS/CVS revision markers + if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|\b)/) { + WARN("CVS style keyword markers, these will _not_ be updated\n". $herecurr); + } + # tabs are only allowed in assembly source code, and in # some scripts we imported from other projects. next if ($realfile =~ /\.(s|S)$/); @@ -1368,11 +1373,6 @@ sub process { # check we are in a valid C source file if not then ignore this hunk next if ($realfile !~ /\.(h|c|cpp)$/); -# check for RCS/CVS revision markers - if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) { - WARN("CVS style keyword markers, these will _not_ be updated\n". $herecurr); - } - # Check for potential 'bare' types my ($stat, $cond, $line_nr_next, $remain_next, $off_next, $realline_next); -- 2.39.2