From 9a594f594dd40295db1b55c442f3d55c0be3bbfc Mon Sep 17 00:00:00 2001 From: Wolfgang Bumiller Date: Fri, 21 Jun 2024 13:46:36 +0200 Subject: [PATCH] Revert "esxi: improve error handling for fuse mount tool" This reverts commit d80420bca8ef5c78bcb9bfabb2a3e6c74667ce49. This diverts stderr of the fuse process to a pipe, which makes no sense as it runs daemonized in a scope, also, the pipe fd was used as a ready-signal, which now does not trigger anymore. --- src/PVE/Storage/ESXiPlugin.pm | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm index 4bcd7ff..b8bce0e 100644 --- a/src/PVE/Storage/ESXiPlugin.pm +++ b/src/PVE/Storage/ESXiPlugin.pm @@ -222,9 +222,6 @@ sub esxi_mount : prototype($$$;$) { // die "failed to get file descriptor flags: $!\n"; fcntl($wr, F_SETFD, $flags & ~FD_CLOEXEC) // die "failed to remove CLOEXEC flag from fd: $!\n"; - - open(STDERR, ">&", $wr) or die "unable to redirect STDERR: $!\n"; - # FIXME: use the user/group options! exec {$ESXI_FUSE_TOOL} $ESXI_FUSE_TOOL, @@ -248,7 +245,7 @@ sub esxi_mount : prototype($$$;$) { undef $wr; my $result = do { local $/ = undef; <$rd> }; - if ($result =~ /^ERROR: (.*)$/i) { + if ($result =~ /^ERROR: (.*)$/) { die "$1\n"; } -- 2.39.5