From 9a8a18f9fa27f72cfdb9da75f10bffc9ab621e33 Mon Sep 17 00:00:00 2001 From: William Tu Date: Tue, 17 Mar 2020 16:12:21 -0700 Subject: [PATCH] conntrack: Fix NULL pointer dereference. Coverity CID 279957 reports NULL pointer derefence when 'conn' is NULL and calling ct_print_conn_info. Cc: Usman Ansari Signed-off-by: William Tu Acked-by: Dumitru Ceara --- lib/conntrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index ff5a89457..001a37ff6 100644 --- a/lib/conntrack.c +++ b/lib/conntrack.c @@ -1302,7 +1302,7 @@ process_one(struct conntrack *ct, struct dp_packet *pkt, if (!conn) { pkt->md.ct_state |= CS_TRACKED | CS_INVALID; char *log_msg = xasprintf("Missing master conn %p", rev_conn); - ct_print_conn_info(conn, log_msg, VLL_INFO, true, true); + ct_print_conn_info(rev_conn, log_msg, VLL_INFO, true, true); free(log_msg); return; } -- 2.39.5