From aae5a44ff5a22c3c3398e68c89a4513c75725fd7 Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Tue, 13 Oct 2015 19:10:21 +0200 Subject: [PATCH] greybus: connection: replace pr_err with dev_err Replace a couple of pr_err with more informative dev_err and clean up the messages somewhat. Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/connection.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/connection.c b/drivers/staging/greybus/connection.c index bd3f83b2ccb6..1158674f2201 100644 --- a/drivers/staging/greybus/connection.c +++ b/drivers/staging/greybus/connection.c @@ -178,7 +178,7 @@ gb_connection_create_range(struct greybus_host_device *hd, * about holding the connection lock. */ if (bundle && gb_connection_intf_find(bundle->intf, cport_id)) { - pr_err("duplicate interface cport id 0x%04hx\n", cport_id); + dev_err(parent, "cport 0x%04hx already connected\n", cport_id); return NULL; } @@ -223,8 +223,8 @@ gb_connection_create_range(struct greybus_host_device *hd, connection->hd_cport_id = CPORT_ID_BAD; put_device(&connection->dev); - pr_err("failed to add connection device for cport 0x%04hx\n", - cport_id); + dev_err(parent, "failed to register connection to cport %04hx: %d\n", + cport_id, retval); goto err_remove_ida; } -- 2.39.5