From b3ea07f71ee0abbeb26779f88594b1c7e037e124 Mon Sep 17 00:00:00 2001 From: Dietmar Maurer Date: Mon, 29 Oct 2012 12:15:43 +0100 Subject: [PATCH] fix memory leak in QMP Client (many thanks to Stefan!) --- Makefile | 2 +- PVE/QMPClient.pm | 5 +++++ changelog.Debian | 6 ++++++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 7835a2a8..8d098f15 100644 --- a/Makefile +++ b/Makefile @@ -2,7 +2,7 @@ RELEASE=2.2 VERSION=2.0 PACKAGE=qemu-server -PKGREL=63 +PKGREL=64 DESTDIR= PREFIX=/usr diff --git a/PVE/QMPClient.pm b/PVE/QMPClient.pm index 9829986a..4fdb7f3b 100755 --- a/PVE/QMPClient.pm +++ b/PVE/QMPClient.pm @@ -7,6 +7,7 @@ use IO::Multiplex; use POSIX qw(EINTR EAGAIN); use JSON; use Time::HiRes qw(usleep gettimeofday tv_interval); +use Scalar::Util qw(weaken); use Data::Dumper; @@ -35,6 +36,10 @@ sub new { $mux->set_callback_object($self); + # make sure perl doesn't believe this is a circular reference as we + # delete mux in DESTROY + weaken($mux->{_object}); + return $self; } diff --git a/changelog.Debian b/changelog.Debian index ef17485a..06cc400b 100644 --- a/changelog.Debian +++ b/changelog.Debian @@ -1,3 +1,9 @@ +qemu-server (2.0-64) unstable; urgency=low + + * fix memory leak in QMP Client (many thanks to Stefan!) + + -- Proxmox Support Team Mon, 29 Oct 2012 12:14:51 +0100 + qemu-server (2.0-63) unstable; urgency=low * fix bug in vmtar -- 2.39.5