From bdf51d2ae9e0c0340ff221ab36368065d0af821d Mon Sep 17 00:00:00 2001 From: Donatas Abraitis Date: Fri, 5 Aug 2022 15:27:59 +0300 Subject: [PATCH] tests: Check if ORF filtering works correctly when modifying prefix-lists Signed-off-by: Donatas Abraitis --- tests/topotests/bgp_orf/__init__.py | 0 tests/topotests/bgp_orf/r1/bgpd.conf | 9 ++ tests/topotests/bgp_orf/r1/zebra.conf | 8 ++ tests/topotests/bgp_orf/r2/bgpd.conf | 9 ++ tests/topotests/bgp_orf/r2/zebra.conf | 4 + tests/topotests/bgp_orf/test_bgp_orf.py | 159 ++++++++++++++++++++++++ 6 files changed, 189 insertions(+) create mode 100644 tests/topotests/bgp_orf/__init__.py create mode 100644 tests/topotests/bgp_orf/r1/bgpd.conf create mode 100644 tests/topotests/bgp_orf/r1/zebra.conf create mode 100644 tests/topotests/bgp_orf/r2/bgpd.conf create mode 100644 tests/topotests/bgp_orf/r2/zebra.conf create mode 100644 tests/topotests/bgp_orf/test_bgp_orf.py diff --git a/tests/topotests/bgp_orf/__init__.py b/tests/topotests/bgp_orf/__init__.py new file mode 100644 index 000000000..e69de29bb diff --git a/tests/topotests/bgp_orf/r1/bgpd.conf b/tests/topotests/bgp_orf/r1/bgpd.conf new file mode 100644 index 000000000..800bf1b7a --- /dev/null +++ b/tests/topotests/bgp_orf/r1/bgpd.conf @@ -0,0 +1,9 @@ +! +router bgp 65001 + no bgp ebgp-requires-policy + neighbor 192.168.1.2 remote-as external + address-family ipv4 unicast + redistribute connected + neighbor 192.168.1.2 capability orf prefix-list both + exit-address-family +! diff --git a/tests/topotests/bgp_orf/r1/zebra.conf b/tests/topotests/bgp_orf/r1/zebra.conf new file mode 100644 index 000000000..85ab53102 --- /dev/null +++ b/tests/topotests/bgp_orf/r1/zebra.conf @@ -0,0 +1,8 @@ +! +int lo + ip address 10.10.10.1/32 + ip address 10.10.10.2/32 +! +int r1-eth0 + ip address 192.168.1.1/24 +! diff --git a/tests/topotests/bgp_orf/r2/bgpd.conf b/tests/topotests/bgp_orf/r2/bgpd.conf new file mode 100644 index 000000000..8c488aa10 --- /dev/null +++ b/tests/topotests/bgp_orf/r2/bgpd.conf @@ -0,0 +1,9 @@ +router bgp 65002 + no bgp ebgp-requires-policy + neighbor 192.168.1.1 remote-as external + address-family ipv4 unicast + neighbor 192.168.1.1 capability orf prefix-list both + neighbor 192.168.1.1 prefix-list r1 in + exit-address-family +! +ip prefix-list r1 seq 5 permit 10.10.10.1/32 diff --git a/tests/topotests/bgp_orf/r2/zebra.conf b/tests/topotests/bgp_orf/r2/zebra.conf new file mode 100644 index 000000000..cffe82736 --- /dev/null +++ b/tests/topotests/bgp_orf/r2/zebra.conf @@ -0,0 +1,4 @@ +! +int r2-eth0 + ip address 192.168.1.2/24 +! diff --git a/tests/topotests/bgp_orf/test_bgp_orf.py b/tests/topotests/bgp_orf/test_bgp_orf.py new file mode 100644 index 000000000..cb74b85b7 --- /dev/null +++ b/tests/topotests/bgp_orf/test_bgp_orf.py @@ -0,0 +1,159 @@ +#!/usr/bin/env python + +# Copyright (c) 2022 by +# Donatas Abraitis +# +# Permission to use, copy, modify, and/or distribute this software +# for any purpose with or without fee is hereby granted, provided +# that the above copyright notice and this permission notice appear +# in all copies. +# +# THE SOFTWARE IS PROVIDED "AS IS" AND NETDEF DISCLAIMS ALL WARRANTIES +# WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF +# MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL NETDEF BE LIABLE FOR +# ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY +# DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, +# WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS +# ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE +# OF THIS SOFTWARE. +# + +""" +Test if BGP ORF filtering is working correctly when modifying +prefix-list. + +Initially advertise 10.10.10.1/32 from R1 to R2. Add new prefix +10.10.10.2/32 to r1 prefix list on R2. Test if we updated ORF +prefix-list correctly. +""" + +import os +import sys +import json +import pytest +import functools + +pytestmark = pytest.mark.bgpd + +CWD = os.path.dirname(os.path.realpath(__file__)) +sys.path.append(os.path.join(CWD, "../")) + +# pylint: disable=C0413 +from lib import topotest +from lib.topogen import Topogen, TopoRouter, get_topogen + +pytestmark = [pytest.mark.bgpd] + + +def setup_module(mod): + topodef = {"s1": ("r1", "r2")} + tgen = Topogen(topodef, mod.__name__) + tgen.start_topology() + + router_list = tgen.routers() + + for i, (rname, router) in enumerate(router_list.items(), 1): + router.load_config( + TopoRouter.RD_ZEBRA, os.path.join(CWD, "{}/zebra.conf".format(rname)) + ) + router.load_config( + TopoRouter.RD_BGP, os.path.join(CWD, "{}/bgpd.conf".format(rname)) + ) + + tgen.start_router() + + +def teardown_module(mod): + tgen = get_topogen() + tgen.stop_topology() + + +def test_bgp_orf(): + tgen = get_topogen() + + if tgen.routers_have_failure(): + pytest.skip(tgen.errors) + + r1 = tgen.gears["r1"] + r2 = tgen.gears["r2"] + + def _bgp_converge_r1(): + output = json.loads( + r1.vtysh_cmd( + "show bgp ipv4 unicast neighbor 192.168.1.2 advertised-routes json" + ) + ) + expected = {"advertisedRoutes": {"10.10.10.1/32": {}, "10.10.10.2/32": None}} + return topotest.json_cmp(output, expected) + + test_func = functools.partial(_bgp_converge_r1) + _, result = topotest.run_and_expect(test_func, None, count=60, wait=0.5) + assert result is None, "Can't apply ORF from R1 to R2" + + def _bgp_converge_r2(): + output = json.loads(r2.vtysh_cmd("show bgp ipv4 unicast summary json")) + expected = { + "peers": { + "192.168.1.1": { + "pfxRcd": 1, + "pfxSnt": 1, + "state": "Established", + "peerState": "OK", + } + } + } + return topotest.json_cmp(output, expected) + + test_func = functools.partial(_bgp_converge_r2) + _, result = topotest.run_and_expect(test_func, None, count=60, wait=0.5) + assert result is None, "ORF filtering is not working from R1 to R2" + + r2.vtysh_cmd( + """ + configure terminal + ip prefix-list r1 seq 10 permit 10.10.10.2/32 + """ + ) + + def _bgp_orf_changed_r1(): + output = json.loads( + r1.vtysh_cmd( + "show bgp ipv4 unicast neighbor 192.168.1.2 advertised-routes json" + ) + ) + expected = {"advertisedRoutes": {"10.10.10.1/32": {}, "10.10.10.2/32": {}}} + return topotest.json_cmp(output, expected) + + test_func = functools.partial(_bgp_orf_changed_r1) + _, result = topotest.run_and_expect(test_func, None, count=60, wait=0.5) + assert result is None, "Can't apply new ORF from R1 to R2" + + def _bgp_orf_changed_r2(): + output = json.loads(r2.vtysh_cmd("show bgp ipv4 unicast json")) + expected = { + "routes": { + "10.10.10.1/32": [{"valid": True}], + "10.10.10.2/32": [{"valid": True}], + } + } + return topotest.json_cmp(output, expected) + + test_func = functools.partial(_bgp_orf_changed_r2) + _, result = topotest.run_and_expect(test_func, None, count=60, wait=0.5) + assert result is None, "New ORF filtering is not working from R1 to R2" + + r2.vtysh_cmd( + """ + configure terminal + no ip prefix-list r1 seq 10 permit 10.10.10.2/32 + """ + ) + + test_func = functools.partial(_bgp_converge_r1) + _, result = topotest.run_and_expect(test_func, None, count=60, wait=0.5) + assert result is None, "Can't apply initial ORF from R1 to R2" + + +if __name__ == "__main__": + args = ["-s"] + sys.argv[1:] + sys.exit(pytest.main(args)) -- 2.39.5