From c9e1e28b61953fe36af62e99ab886f40723423c4 Mon Sep 17 00:00:00 2001 From: Laszlo Ersek Date: Wed, 27 Feb 2019 22:10:45 +0100 Subject: [PATCH] Maintainers.txt: clarify Reviewer requirements and responsibilities The current language for "Package Reviewer" only vaguely hints that Package Reviewers should be able to provide guidance and directions. Make this more obvious. Cc: Andrew Fish Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Liming Gao Cc: Michael D Kinney Cc: Philippe Mathieu-Daude Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek Reviewed-by: Liming Gao Reviewed-by: Andrew Fish Reviewed-by: Philippe Mathieu-Daude --- Maintainers.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 61c57587a6..be77898ee2 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -20,7 +20,10 @@ Descriptions of section entries: M: Package Maintainer: Cc address for patches and questions. Responsible for reviewing and pushing package changes to source control. R: Package Reviewer: Cc address for patches and questions. Reviewers help - maintainers review code, but don't have push access. + maintainers review code, but don't have push access. A designated Package + Reviewer is reasonably familiar with the Package (or some modules + thereof), and/or provides testing or regression testing for the Package + (or some modules thereof), in certain platforms and environments. W: Web-page with status/info T: SCM tree type and location. Type is one of: git, svn. S: Status, one of the following: -- 2.39.2