From e140c75ed9f6897c682e7ac321ef64948f005e64 Mon Sep 17 00:00:00 2001 From: Bryan O'Donoghue Date: Tue, 21 Jul 2015 23:50:09 +0100 Subject: [PATCH] greybus: loopback: add commentary to sysfs variables Add some missing comments. Add a TODO to look at doing iteration_count with KOBJ_CHANGE event instead of having user-space poll the value reported in iteration_count to determine when a test set is complete. Signed-off-by: Bryan O'Donoghue Reviewed-by: Patrick Titiano Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/loopback.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c index 65973948a091..cc19f1be7e2f 100644 --- a/drivers/staging/greybus/loopback.c +++ b/drivers/staging/greybus/loopback.c @@ -137,8 +137,11 @@ gb_loopback_stats_attrs(latency); gb_loopback_stats_attrs(frequency); /* Quantity of data sent and received on this cport */ gb_loopback_stats_attrs(throughput); +/* Number of errors encountered during loop */ gb_loopback_ro_attr(error, d); +/* The current index of the for (i = 0; i < iteration_max; i++) loop */ gb_loopback_ro_attr(iteration_count, u); +/* TODO iteration_count might be better with the KOBJ_CHANGE event */ /* * Type of loopback message to send based on protocol type definitions -- 2.39.5