From e4a70a41fbff075b0a552bdc052c024ec6a3b6eb Mon Sep 17 00:00:00 2001 From: Fabian Ebner Date: Thu, 17 Mar 2022 12:31:01 +0100 Subject: [PATCH] api: clone vm: check against cloning running TPM state early Drive keys are sorted when cloning and 'tpmstate0' comes late, so it was likely that potentially large disks were already copied just to be removed again, because of the TPM state restriction at the end. Signed-off-by: Fabian Ebner --- PVE/API2/Qemu.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 1dd0cf2..91fb4df 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -3151,6 +3151,9 @@ __PACKAGE__->register_method({ # no need to copy unused images, because VMID(owner) changes anyways next if $opt =~ m/^unused\d+$/; + die "cannot clone TPM state while VM is running\n" + if $full && $running && !$snapname && $opt eq 'tpmstate0'; + # always change MAC! address if ($opt =~ m/^net(\d+)$/) { my $net = PVE::QemuServer::parse_net($value); -- 2.39.2