From e8a392d91c879a1d4f877fd69fb9fb52983fd271 Mon Sep 17 00:00:00 2001 From: Sharath Ramamurthy Date: Sun, 8 Aug 2021 11:28:07 +0530 Subject: [PATCH] zebra: fix for issues found during static analysis This patch addresses fix for issues found during static analysis. rt_netlink - initialise vtep if there is NDA_DST attribute if_netlink - initialise vni_start and vni_end Signed-off-by: Sharath Ramamurthy --- zebra/if_netlink.c | 3 +++ zebra/rt_netlink.c | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/zebra/if_netlink.c b/zebra/if_netlink.c index c097e2377..02b9ab9d7 100644 --- a/zebra/if_netlink.c +++ b/zebra/if_netlink.c @@ -737,6 +737,9 @@ static int netlink_bridge_vxlan_vlan_vni_map_update(struct interface *ifp, struct zebra_vxlan_vni vni_start; struct rtattr *aftb[IFLA_BRIDGE_VLAN_TUNNEL_MAX + 1]; + memset(&vni_start, 0, sizeof(vni_start)); + memset(&vni_end, 0, sizeof(vni_end)); + for (i = RTA_DATA(af_spec), rem = RTA_PAYLOAD(af_spec); RTA_OK(i, rem); i = RTA_NEXT(i, rem)) { diff --git a/zebra/rt_netlink.c b/zebra/rt_netlink.c index f205f297d..d09318a5a 100644 --- a/zebra/rt_netlink.c +++ b/zebra/rt_netlink.c @@ -3536,7 +3536,8 @@ static int netlink_macfdb_change(struct nlmsghdr *h, int len, ns_id_t ns_id) IPV4_MAX_BYTELEN); snprintfrr(dst_buf, sizeof(dst_buf), " dst %pI4", &vtep_ip); - } + } else + memset(&vtep_ip, 0, sizeof(vtep_ip)); if (tb[NDA_NH_ID]) nhg_id = *(uint32_t *)RTA_DATA(tb[NDA_NH_ID]); -- 2.39.5