From f003ceb36ed68a4618032e158cf18bdaa6acb1d0 Mon Sep 17 00:00:00 2001
From: Dietmar Maurer <dietmar@proxmox.com>
Date: Wed, 26 Apr 2017 18:05:02 +0200
Subject: [PATCH] pmgspamreport: do not escape character in tooltip -  does not
 work with most browsers

Use template toolkit filter for hrefs.
---
 PMG/CLI/pmgspamreport.pm          |  4 ++--
 templates/spamreport-verbose.tmpl | 10 +++++-----
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/PMG/CLI/pmgspamreport.pm b/PMG/CLI/pmgspamreport.pm
index 0f2f321..d6529f2 100755
--- a/PMG/CLI/pmgspamreport.pm
+++ b/PMG/CLI/pmgspamreport.pm
@@ -9,7 +9,6 @@ use Time::Local;
 use Clone 'clone';
 use Mail::Header;
 use POSIX qw(strftime);
-use URI::Escape;
 
 use PVE::SafeSyslog;
 use PVE::Tools;
@@ -96,7 +95,7 @@ sub get_item_data {
     $title .= sprintf("File: %s", encode_entities($ref->{file}));
 
     # fixme: urlencode?
-    $data->{title} = uri_escape($title);
+    $data->{title} = $title;
 
     return $data;
 }
@@ -294,6 +293,7 @@ __PACKAGE__->register_method ({
 		    # fixme: my $ticket = Proxmox::Utils::create_ticket ($lastref);
 		    my $ticket = "TEST";
 		    $data->{ticket} = $ticket;
+		    $data->{managehref} = "https://$fqdn:$port?ticket=$ticket";
 		    $data->{mailcount} = $mailcount;
 
 		    my $sendto = $redirect ? $redirect : $creceiver;
diff --git a/templates/spamreport-verbose.tmpl b/templates/spamreport-verbose.tmpl
index 90fe54f..7631a6d 100644
--- a/templates/spamreport-verbose.tmpl
+++ b/templates/spamreport-verbose.tmpl
@@ -11,8 +11,8 @@
 
 <div align=center>
 
-<form action='[% actionhref %]' method='POST'>
-<input type=hidden name=ticket value='[% ticket %]'>
+<form action='[% actionhref | uri %]' method='POST'>
+<input type=hidden name=ticket value='[% ticket | uri %]'>
 
 <table width='100%'>
   <tr>
@@ -26,13 +26,13 @@
   <!--start entries-->
   [% FOREACH item IN items %]
   <tr title='[% item.title %]'>
-    <td><input type=checkbox name=cselect value='[% item.ticket %]'></td>
+    <td><input type=checkbox name=cselect value='[% item.ticket | uri %]'></td>
     <td>[% item.from %]</td>
     <td align=right>[% item.date %] [% item.time %]</td>
   </tr>
   <tr title='[% item.title %]'>
     <td></td>
-    <td colspan=2><a style='cursor:pointer;' href='[% item.href %]'>
+    <td colspan=2><a style='cursor:pointer;' href='[% item.href | url %]'>
 	<b>[% item.subject %]</b></a></td>
   </tr>
   <tr><td colspan=3><hr></td></tr>
@@ -52,7 +52,7 @@
   
 </table>
 
-<p>Please use the <a href='[% manage %]?ticket=[% ticket %]'>web interface</a> to manage your spam quarantine.</p>
+<p>Please use the <a href='[% managehref | url %]'>web interface</a> to manage your spam quarantine.</p>
 <p>Powered by <a target=_blank href='http://www.proxmox.com'>Proxmox</a>.</p>
 </div>
 
-- 
2.39.5