From fa6b8733c93107d7fcd7018d1822e93ba9edaa94 Mon Sep 17 00:00:00 2001 From: Kevin Wolf Date: Mon, 12 Mar 2012 10:30:02 +0100 Subject: [PATCH] tracetool: Forbid argument name 'next' It has happened more than once that patches that look perfectly sane and work with simpletrace broke systemtap because they use 'next' as an argument name for a tracing function. However, 'next' is a keyword for systemtap, so we shouldn't use it. Signed-off-by: Kevin Wolf --- scripts/tracetool | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/scripts/tracetool b/scripts/tracetool index 47389b62e..7b1c142b6 100755 --- a/scripts/tracetool +++ b/scripts/tracetool @@ -81,6 +81,10 @@ get_args() args=${1#*\(} args=${args%%\)*} echo "$args" + + if (echo "$args" | grep "[ *]next\($\|[, ]\)" > /dev/null 2>&1); then + echo -e "\n#error 'next' is a bad argument name (clash with systemtap keyword)\n " + fi } # Get the argument name list of a trace event -- 2.39.2