From c1b2092d5ea0e4fa64dfc0edfa9ce3a97026e436 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Fabian=20Gr=C3=BCnbichler?= Date: Tue, 9 Jan 2024 10:25:11 +0100 Subject: [PATCH] qemu_volume_snapshot_delete: drop (now) unused parameter MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit since we always determine the deviceid, passing in a possibly wrong value makes no sense and could actually re-introduce bugs. Signed-off-by: Fabian Grünbichler Reviewed-by: Fiona Ebner --- PVE/QemuConfig.pm | 3 +-- PVE/QemuServer.pm | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm index d49d8823..ca30eda0 100644 --- a/PVE/QemuConfig.pm +++ b/PVE/QemuConfig.pm @@ -406,9 +406,8 @@ sub __snapshot_delete_vol_snapshot { return if PVE::QemuServer::drive_is_cdrom($drive); my $storecfg = PVE::Storage::config(); my $volid = $drive->{file}; - my $device = "drive-$ds"; - PVE::QemuServer::qemu_volume_snapshot_delete($vmid, $device, $storecfg, $volid, $snapname); + PVE::QemuServer::qemu_volume_snapshot_delete($vmid, $storecfg, $volid, $snapname); push @$unused, $volid; } diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index cdbaa0ee..bbd19186 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -4670,7 +4670,7 @@ sub qemu_volume_snapshot { } sub qemu_volume_snapshot_delete { - my ($vmid, $deviceid, $storecfg, $volid, $snap) = @_; + my ($vmid, $storecfg, $volid, $snap) = @_; my $running = check_running($vmid); my $attached_deviceid; -- 2.39.5