BaseTools: use predefined constants instead of local strings

[mirror_edk2.git] / BaseTools / Source / Python / AutoGen / AutoGen.py

diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py
index 69c1ef4eba319436b3e1a86a72f44643f918b1f5..bd443fe6261aefc0cf68112569e082e1e04790ba 100644 (file)
--- a/BaseTools/Source/Python/AutoGen/AutoGen.py
+++ b/BaseTools/Source/Python/AutoGen/AutoGen.py
@@ -259,7 +259,7 @@ class WorkspaceAutoGen(AutoGen):
         self.BuildDatabase  = MetaFileDb\r
         self.MetaFile       = ActivePlatform\r
         self.WorkspaceDir   = WorkspaceDir\r
-        self.Platform       = self.BuildDatabase[self.MetaFile, 'COMMON', Target, Toolchain]\r
+        self.Platform       = self.BuildDatabase[self.MetaFile, TAB_COMMON, Target, Toolchain]\r
         GlobalData.gActivePlatform = self.Platform\r
         self.BuildTarget    = Target\r
         self.ToolChain      = Toolchain\r
@@ -788,7 +788,7 @@ class WorkspaceAutoGen(AutoGen):
                             # Here we just need to get FILE_GUID from INF file, use 'COMMON' as ARCH attribute. and use \r
                             # BuildObject from one of AutoGenObjectList is enough.\r
                             #\r
-                            InfObj = self.AutoGenObjectList[0].BuildDatabase.WorkspaceDb.BuildObject[PathClassObj, 'COMMON', self.BuildTarget, self.ToolChain]\r
+                            InfObj = self.AutoGenObjectList[0].BuildDatabase.WorkspaceDb.BuildObject[PathClassObj, TAB_COMMON, self.BuildTarget, self.ToolChain]\r
                             if not InfObj.Guid.upper() in _GuidDict.keys():\r
                                 _GuidDict[InfObj.Guid.upper()] = FfsFile\r
                             else:\r
@@ -1338,7 +1338,7 @@ class PlatformAutoGen(AutoGen):
                     EdkLogger.error("build", FILE_READ_FAILURE, "Can not find VPD map file %s to fix up VPD offset." % VpdMapFilePath)\r
 \r
                 NvStoreOffset = int(NvStoreOffset,16) if NvStoreOffset.upper().startswith("0X") else int(NvStoreOffset)\r
-                default_skuobj = PcdNvStoreDfBuffer[0].SkuInfoList.get("DEFAULT")\r
+                default_skuobj = PcdNvStoreDfBuffer[0].SkuInfoList.get(TAB_DEFAULT)\r
                 maxsize = self.VariableInfo.VpdRegionSize  - NvStoreOffset if self.VariableInfo.VpdRegionSize else len(default_skuobj.DefaultValue.split(","))\r
                 var_data = self.VariableInfo.PatchNVStoreDefaultMaxSize(maxsize)\r
 \r
@@ -1346,7 +1346,7 @@ class PlatformAutoGen(AutoGen):
                     default_skuobj.DefaultValue = var_data\r
                     PcdNvStoreDfBuffer[0].DefaultValue = var_data\r
                     PcdNvStoreDfBuffer[0].SkuInfoList.clear()\r
-                    PcdNvStoreDfBuffer[0].SkuInfoList['DEFAULT'] = default_skuobj\r
+                    PcdNvStoreDfBuffer[0].SkuInfoList[TAB_DEFAULT] = default_skuobj\r
                     PcdNvStoreDfBuffer[0].MaxDatumSize = str(len(default_skuobj.DefaultValue.split(",")))\r
 \r
         return OrgVpdFile\r
@@ -1577,12 +1577,12 @@ class PlatformAutoGen(AutoGen):
                    PcdKey in VpdPcdDict:\r
                     Pcd = VpdPcdDict[PcdKey]\r
                     SkuValueMap = {}\r
-                    DefaultSku = Pcd.SkuInfoList.get('DEFAULT')\r
+                    DefaultSku = Pcd.SkuInfoList.get(TAB_DEFAULT)\r
                     if DefaultSku:\r
                         PcdValue = DefaultSku.DefaultValue\r
                         if PcdValue not in SkuValueMap:\r
                             SkuValueMap[PcdValue] = []\r
-                            VpdFile.Add(Pcd, 'DEFAULT',DefaultSku.VpdOffset)\r
+                            VpdFile.Add(Pcd, TAB_DEFAULT,DefaultSku.VpdOffset)\r
                         SkuValueMap[PcdValue].append(DefaultSku)\r
 \r
                     for (SkuName,Sku) in Pcd.SkuInfoList.items():\r
@@ -1641,9 +1641,9 @@ class PlatformAutoGen(AutoGen):
                             # just pick the a value to determine whether is unicode string type\r
                             SkuValueMap = {}\r
                             SkuObjList = DscPcdEntry.SkuInfoList.items()\r
-                            DefaultSku = DscPcdEntry.SkuInfoList.get('DEFAULT')\r
+                            DefaultSku = DscPcdEntry.SkuInfoList.get(TAB_DEFAULT)\r
                             if DefaultSku:\r
-                                defaultindex = SkuObjList.index(('DEFAULT',DefaultSku))\r
+                                defaultindex = SkuObjList.index((TAB_DEFAULT,DefaultSku))\r
                                 SkuObjList[0],SkuObjList[defaultindex] = SkuObjList[defaultindex],SkuObjList[0]\r
                             for (SkuName,Sku) in SkuObjList:\r
                                 Sku.VpdOffset = Sku.VpdOffset.strip() \r
@@ -1767,7 +1767,7 @@ class PlatformAutoGen(AutoGen):
                 for (SkuName,SkuId) in allskuset:\r
                     if type(SkuId) in (str,unicode) and eval(SkuId) == 0 or SkuId == 0:\r
                         continue\r
-                    pcd.SkuInfoList[SkuName] = copy.deepcopy(pcd.SkuInfoList['DEFAULT'])\r
+                    pcd.SkuInfoList[SkuName] = copy.deepcopy(pcd.SkuInfoList[TAB_DEFAULT])\r
                     pcd.SkuInfoList[SkuName].SkuId = SkuId\r
         self.AllPcdList = self._NonDynamicPcdList + self._DynamicPcdList\r
 \r
@@ -2390,7 +2390,7 @@ class PlatformAutoGen(AutoGen):
             if self.Platform.SkuName in self.Platform.SkuIds:\r
                 SkuName = self.Platform.SkuName\r
             else:\r
-                SkuName = 'DEFAULT'\r
+                SkuName = TAB_DEFAULT\r
             ToPcd.SkuInfoList = {\r
                 SkuName : SkuInfoClass(SkuName, self.Platform.SkuIds[SkuName][0], '', '', '', '', '', ToPcd.DefaultValue)\r
             }\r
@@ -3420,7 +3420,7 @@ class ModuleAutoGen(AutoGen):
         if self._BinaryFileList is None:\r
             self._BinaryFileList = []\r
             for F in self.Module.Binaries:\r
-                if F.Target not in ['COMMON', '*'] and F.Target != self.BuildTarget:\r
+                if F.Target not in [TAB_COMMON, '*'] and F.Target != self.BuildTarget:\r
                     continue\r
                 self._BinaryFileList.append(F)\r
                 self._ApplyBuildRule(F, F.Type)\r