]> git.proxmox.com Git - mirror_edk2.git/blobdiff - BaseTools/Source/Python/Workspace/DscBuildData.py
BaseTools: Correct PCD generation logic to make sure DB is use
[mirror_edk2.git] / BaseTools / Source / Python / Workspace / DscBuildData.py
index a5fceb9e2b614ee681f6de590451d058acd6df27..7594b45771ea7b479146c97b2cfbf55dc222a699 100644 (file)
@@ -845,14 +845,14 @@ class DscBuildData(PlatformBuildClassObject):
             for pcdname in Pcds:\r
                 pcd = Pcds[pcdname]\r
                 Pcds[pcdname].SkuInfoList = {"DEFAULT":pcd.SkuInfoList[skuid] for skuid in pcd.SkuInfoList if skuid in available_sku}\r
-                if type(pcd) is StructurePcd and pcd.OverrideValues:\r
-                    Pcds[pcdname].OverrideValues = {"DEFAULT":pcd.OverrideValues[skuid] for skuid in pcd.OverrideValues if skuid in available_sku}\r
+                if type(pcd) is StructurePcd and pcd.SkuOverrideValues:\r
+                    Pcds[pcdname].SkuOverrideValues = {"DEFAULT":pcd.SkuOverrideValues[skuid] for skuid in pcd.SkuOverrideValues if skuid in available_sku}\r
         else:\r
             for pcdname in Pcds:\r
                 pcd = Pcds[pcdname]\r
                 Pcds[pcdname].SkuInfoList = {skuid:pcd.SkuInfoList[skuid] for skuid in pcd.SkuInfoList if skuid in available_sku}\r
-                if type(pcd) is StructurePcd and pcd.OverrideValues:\r
-                    Pcds[pcdname].OverrideValues = {skuid:pcd.OverrideValues[skuid] for skuid in pcd.OverrideValues if skuid in available_sku}\r
+                if type(pcd) is StructurePcd and pcd.SkuOverrideValues:\r
+                    Pcds[pcdname].SkuOverrideValues = {skuid:pcd.SkuOverrideValues[skuid] for skuid in pcd.SkuOverrideValues if skuid in available_sku}\r
         return Pcds\r
     def CompleteHiiPcdsDefaultStores(self,Pcds):\r
         HiiPcd = [Pcds[pcd] for pcd in Pcds if Pcds[pcd].Type in [self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_HII], self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_EX_HII]]]\r
@@ -945,9 +945,18 @@ class DscBuildData(PlatformBuildClassObject):
         return structure_pcd_data\r
 \r
     def UpdateStructuredPcds(self, TypeList, AllPcds):\r
+\r
+        DynamicPcdType = [self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_DEFAULT],\r
+                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_HII],\r
+                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_VPD],\r
+                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_EX_DEFAULT],\r
+                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_EX_HII],\r
+                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_EX_VPD]]\r
+\r
         Pcds = AllPcds\r
         DefaultStoreMgr = DefaultStore(self.DefaultStores)\r
-        SkuIds = set([skuid for pcdobj in AllPcds.values() for skuid in pcdobj.SkuInfoList.keys()])\r
+        SkuIds = self.SkuIdMgr.AvailableSkuIdSet\r
+        SkuIds.update({'DEFAULT':0})\r
         DefaultStores = set([storename for pcdobj in AllPcds.values() for skuobj in pcdobj.SkuInfoList.values() for storename in skuobj.DefaultStoreDict.keys()])\r
 \r
         S_PcdSet = []\r
@@ -1003,13 +1012,19 @@ class DscBuildData(PlatformBuildClassObject):
         if S_pcd_set:\r
             GlobalData.gStructurePcd[self.Arch] = S_pcd_set\r
         for stru_pcd in S_pcd_set.values():\r
-            if stru_pcd.Type not in [self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_DEFAULT],\r
-                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_HII],\r
-                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_VPD],\r
-                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_EX_DEFAULT],\r
-                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_EX_HII],\r
-                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_EX_VPD]]:\r
+            if stru_pcd.Type not in DynamicPcdType:\r
                 continue\r
+            for skuid in SkuIds:\r
+                if skuid in stru_pcd.SkuOverrideValues:\r
+                    continue\r
+                nextskuid = self.SkuIdMgr.GetNextSkuId(skuid)\r
+                NoDefault = False\r
+                while nextskuid not in stru_pcd.SkuOverrideValues:\r
+                    if nextskuid == "DEFAULT":\r
+                        NoDefault = True\r
+                        break\r
+                    nextskuid = self.SkuIdMgr.GetNextSkuId(nextskuid)\r
+                stru_pcd.SkuOverrideValues[skuid] = copy.deepcopy(stru_pcd.SkuOverrideValues[nextskuid]) if not NoDefault else copy.deepcopy({defaultstorename: stru_pcd.DefaultValues for defaultstorename in DefaultStores} if DefaultStores else {'STANDARD':stru_pcd.DefaultValues})\r
             if stru_pcd.Type in [self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_HII], self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_EX_HII]]:\r
                 for skuid in SkuIds:\r
                     nextskuid = skuid\r
@@ -1020,7 +1035,6 @@ class DscBuildData(PlatformBuildClassObject):
                                 NoDefault = True\r
                                 break\r
                             nextskuid = self.SkuIdMgr.GetNextSkuId(nextskuid)\r
-                        stru_pcd.SkuOverrideValues[skuid] = {}\r
                     if NoDefault:\r
                         continue\r
                     PcdDefaultStoreSet = set([defaultstorename  for defaultstorename in stru_pcd.SkuOverrideValues[nextskuid]])\r
@@ -1029,22 +1043,13 @@ class DscBuildData(PlatformBuildClassObject):
                     for defaultstoreid in DefaultStores:\r
                         if defaultstoreid not in stru_pcd.SkuOverrideValues[skuid]:\r
                             stru_pcd.SkuOverrideValues[skuid][defaultstoreid] = copy.deepcopy(stru_pcd.SkuOverrideValues[nextskuid][mindefaultstorename])\r
-            for skuid in SkuIds:\r
-                if skuid in stru_pcd.SkuOverrideValues:\r
-                    continue\r
-                nextskuid = self.SkuIdMgr.GetNextSkuId(skuid)\r
-                NoDefault = False\r
-                while nextskuid not in stru_pcd.SkuOverrideValues:\r
-                    if nextskuid == "DEFAULT":\r
-                        NoDefault = True\r
-                        break\r
-                    nextskuid = self.SkuIdMgr.GetNextSkuId(nextskuid)\r
-                stru_pcd.SkuOverrideValues[skuid] = copy.deepcopy(stru_pcd.SkuOverrideValues[nextskuid]) if not NoDefault else copy.deepcopy({defaultstorename: stru_pcd.DefaultValues for defaultstorename in DefaultStores})\r
+\r
         Str_Pcd_Values = self.GenerateByteArrayValue(S_pcd_set)\r
         if Str_Pcd_Values:\r
             for (skuname,StoreName,PcdGuid,PcdName,PcdValue) in Str_Pcd_Values:\r
                 str_pcd_obj = S_pcd_set.get((PcdName, PcdGuid))\r
                 if str_pcd_obj is None:\r
+                    print PcdName, PcdGuid\r
                     raise\r
                 if str_pcd_obj.Type in [self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_HII],\r
                                         self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_EX_HII]]:\r
@@ -1059,7 +1064,16 @@ class DscBuildData(PlatformBuildClassObject):
                         str_pcd_obj.DefaultValue = PcdValue\r
                 else:\r
                     if skuname not in str_pcd_obj.SkuInfoList:\r
-                        str_pcd_obj.SkuInfoList[skuname] = SkuInfoClass(SkuIdName=skuname, SkuId=self.SkuIds[skuname][0], DefaultValue=PcdValue)\r
+                        nextskuid = self.SkuIdMgr.GetNextSkuId(skuname)\r
+                        NoDefault = False\r
+                        while nextskuid not in str_pcd_obj.SkuInfoList:\r
+                            if nextskuid == "DEFAULT":\r
+                                NoDefault = True\r
+                                break\r
+                            nextskuid = self.SkuIdMgr.GetNextSkuId(nextskuid)\r
+                        str_pcd_obj.SkuInfoList[skuname] = copy.deepcopy(str_pcd_obj.SkuInfoList[nextskuid]) if not NoDefault else SkuInfoClass(SkuIdName=skuname, SkuId=self.SkuIds[skuname][0], DefaultValue=PcdValue)\r
+                        str_pcd_obj.SkuInfoList[skuname].SkuId = self.SkuIds[skuname][0]\r
+                        str_pcd_obj.SkuInfoList[skuname].SkuIdName = skuname\r
                     else:\r
                         str_pcd_obj.SkuInfoList[skuname].DefaultValue = PcdValue\r
             for str_pcd_obj in S_pcd_set.values():\r
@@ -1076,6 +1090,15 @@ class DscBuildData(PlatformBuildClassObject):
                 str_pcd_obj.MaxDatumSize = self.GetStructurePcdMaxSize(str_pcd_obj)\r
                 Pcds[str_pcd_obj.TokenCName, str_pcd_obj.TokenSpaceGuidCName] = str_pcd_obj\r
 \r
+            for pcdkey in Pcds:\r
+                pcd = Pcds[pcdkey]\r
+                if 'DEFAULT' not in pcd.SkuInfoList.keys() and 'COMMON' in pcd.SkuInfoList.keys():\r
+                    pcd.SkuInfoList['DEFAULT'] = pcd.SkuInfoList['COMMON']\r
+                    del(pcd.SkuInfoList['COMMON'])\r
+                elif 'DEFAULT' in pcd.SkuInfoList.keys() and 'COMMON' in pcd.SkuInfoList.keys():\r
+                    del(pcd.SkuInfoList['COMMON'])\r
+\r
+        map(self.FilterSkuSettings,[Pcds[pcdkey] for pcdkey in Pcds if Pcds[pcdkey].Type in DynamicPcdType])\r
         return Pcds\r
 \r
     ## Retrieve non-dynamic PCD settings\r
@@ -1241,7 +1264,7 @@ class DscBuildData(PlatformBuildClassObject):
             CApp = CApp + '{\n'\r
             CApp = CApp + '  UINT32  Size;\n'\r
             CApp = CApp + '  UINT32  FieldSize;\n'\r
-            CApp = CApp + '  UINT8   *Value;\n'\r
+            CApp = CApp + '  CHAR8   *Value;\n'\r
             CApp = CApp + '  UINT32  OriginalSize;\n'\r
             CApp = CApp + '  VOID    *OriginalPcd;\n'\r
             CApp = CApp + '  %s      *Pcd;\n' % (Pcd.DatumType)\r
@@ -1411,7 +1434,7 @@ class DscBuildData(PlatformBuildClassObject):
         else:\r
             MakeApp = MakeApp + PcdGccMakefile\r
             MakeApp = MakeApp + 'APPNAME = %s\n' % (PcdValueInitName) + 'OBJECTS = %s/%s.o\n' % (self.OutputPath, PcdValueInitName) + \\r
-                      'include $(MAKEROOT)/Makefiles/app.makefile\n' + 'BUILD_CFLAGS += -Wno-error\n' + 'INCLUDE +='\r
+                      'include $(MAKEROOT)/Makefiles/app.makefile\n' + 'BUILD_CFLAGS += -Wno-pointer-to-int-cast -Wno-unused-variable\n' + 'INCLUDE +='\r
 \r
         PlatformInc = {}\r
         for Cache in self._Bdb._CACHE_.values():\r
@@ -1449,11 +1472,43 @@ class DscBuildData(PlatformBuildClassObject):
         File.write(InitByteValue)\r
         File.close()\r
 \r
+        Messages = ''\r
         if sys.platform == "win32":\r
             StdOut, StdErr = self.ExecuteCommand ('nmake clean & nmake -f %s' % (MakeFileName))\r
+            Messages = StdOut\r
         else:\r
             StdOut, StdErr = self.ExecuteCommand ('make clean & make -f %s' % (MakeFileName))\r
-        Messages = StdOut.split('\r')\r
+            Messages = StdErr\r
+        Messages = Messages.split('\n')\r
+        for Message in Messages:\r
+            if " error" in Message:\r
+                FileInfo = Message.strip().split('(')\r
+                if len (FileInfo) > 1:\r
+                    FileName = FileInfo [0]\r
+                    FileLine = FileInfo [1].split (')')[0]\r
+                else:\r
+                    FileInfo = Message.strip().split(':')\r
+                    FileName = FileInfo [0]\r
+                    FileLine = FileInfo [1]\r
+\r
+                File = open (FileName, 'r')\r
+                FileData = File.readlines()\r
+                File.close()\r
+                error_line = FileData[int (FileLine) - 1]\r
+                if r"//" in error_line:\r
+                    c_line,dsc_line = error_line.split(r"//")\r
+                else:\r
+                    dsc_line = error_line\r
+\r
+                message_itmes = Message.split(":")\r
+                Index = 0\r
+                for item in message_itmes:\r
+                    if "PcdValueInit.c" in item:\r
+                        Index = message_itmes.index(item)\r
+                        message_itmes[Index] = dsc_line.strip()\r
+                        break\r
+\r
+                EdkLogger.error("build", PCD_STRUCTURE_PCD_ERROR, ":".join(message_itmes[Index:]))\r
 \r
         PcdValueInitExe = PcdValueInitName\r
         if not sys.platform == "win32":\r
@@ -1553,13 +1608,26 @@ class DscBuildData(PlatformBuildClassObject):
                 del(pcd.SkuInfoList['COMMON'])\r
             elif 'DEFAULT' in pcd.SkuInfoList.keys() and 'COMMON' in pcd.SkuInfoList.keys():\r
                 del(pcd.SkuInfoList['COMMON'])\r
-            if self.SkuIdMgr.SkuUsageType == self.SkuIdMgr.SINGLE:\r
-                if 'DEFAULT' in pcd.SkuInfoList.keys() and self.SkuIdMgr.SystemSkuId not in pcd.SkuInfoList.keys():\r
-                    pcd.SkuInfoList[self.SkuIdMgr.SystemSkuId] = pcd.SkuInfoList['DEFAULT']\r
-                del(pcd.SkuInfoList['DEFAULT'])\r
+\r
+        map(self.FilterSkuSettings,Pcds.values())\r
 \r
         return Pcds\r
 \r
+    def FilterSkuSettings(self, PcdObj):\r
+\r
+        if self.SkuIdMgr.SkuUsageType == self.SkuIdMgr.SINGLE:\r
+            if 'DEFAULT' in PcdObj.SkuInfoList.keys() and self.SkuIdMgr.SystemSkuId not in PcdObj.SkuInfoList.keys():\r
+                PcdObj.SkuInfoList[self.SkuIdMgr.SystemSkuId] = PcdObj.SkuInfoList['DEFAULT']\r
+            PcdObj.SkuInfoList = {'DEFAULT':PcdObj.SkuInfoList[self.SkuIdMgr.SystemSkuId]}\r
+            PcdObj.SkuInfoList['DEFAULT'].SkuIdName = 'DEFAULT'\r
+            PcdObj.SkuInfoList['DEFAULT'].SkuId = '0'\r
+\r
+        elif self.SkuIdMgr.SkuUsageType == self.SkuIdMgr.DEFAULT:\r
+            PcdObj.SkuInfoList = {'DEFAULT':PcdObj.SkuInfoList['DEFAULT']}\r
+\r
+        return PcdObj\r
+\r
+\r
     def CompareVarAttr(self, Attr1, Attr2):\r
         if not Attr1 or not Attr2:  # for empty string\r
             return True\r
@@ -1731,11 +1799,6 @@ class DscBuildData(PlatformBuildClassObject):
             elif 'DEFAULT' in pcd.SkuInfoList.keys() and 'COMMON' in pcd.SkuInfoList.keys():\r
                 del(pcd.SkuInfoList['COMMON'])\r
 \r
-            if self.SkuIdMgr.SkuUsageType == self.SkuIdMgr.SINGLE:\r
-                if 'DEFAULT' in pcd.SkuInfoList.keys() and self.SkuIdMgr.SystemSkuId not in pcd.SkuInfoList.keys():\r
-                    pcd.SkuInfoList[self.SkuIdMgr.SystemSkuId] = pcd.SkuInfoList['DEFAULT']\r
-                del(pcd.SkuInfoList['DEFAULT'])\r
-\r
             if pcd.MaxDatumSize.strip():\r
                 MaxSize = int(pcd.MaxDatumSize, 0)\r
             else:\r
@@ -1755,6 +1818,9 @@ class DscBuildData(PlatformBuildClassObject):
         if not rt:\r
             invalidpcd = ",".join(invalidhii)\r
             EdkLogger.error('build', PCD_VARIABLE_INFO_ERROR, Message='The same HII PCD must map to the same EFI variable for all SKUs', File=self.MetaFile, ExtraData=invalidpcd)\r
+\r
+        map(self.FilterSkuSettings,Pcds.values())\r
+\r
         return Pcds\r
 \r
     def CheckVariableNameAssignment(self,Pcds):\r
@@ -1854,11 +1920,9 @@ class DscBuildData(PlatformBuildClassObject):
                 del(pcd.SkuInfoList['COMMON'])\r
             elif 'DEFAULT' in pcd.SkuInfoList.keys() and 'COMMON' in pcd.SkuInfoList.keys():\r
                 del(pcd.SkuInfoList['COMMON'])\r
-            if self.SkuIdMgr.SkuUsageType == self.SkuIdMgr.SINGLE:\r
-                if 'DEFAULT' in pcd.SkuInfoList.keys() and self.SkuIdMgr.SystemSkuId not in pcd.SkuInfoList.keys():\r
-                    pcd.SkuInfoList[self.SkuIdMgr.SystemSkuId] = pcd.SkuInfoList['DEFAULT']\r
-                del(pcd.SkuInfoList['DEFAULT'])\r
 \r
+\r
+        map(self.FilterSkuSettings,Pcds.values())\r
         return Pcds\r
 \r
     ## Add external modules\r