Fix some typo and coding style issues in BaseCryptLib instances.

[mirror_edk2.git] / CryptoPkg / Library / BaseCryptLib / Hash / CryptMd4.c

diff --git a/CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4.c b/CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4.c
index a5769133ed1efb160ef0ed98fc1e5d9bf1036fd2..633d34379032b5c9ad9537e6d709bf2e4813bb66 100644 (file)
--- a/CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4.c
+++ b/CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4.c
@@ -1,7 +1,7 @@
 /** @file\r
   MD4 Digest Wrapper Implementation over OpenSSL.\r
 \r
-Copyright (c) 2010, Intel Corporation. All rights reserved.<BR>\r
+Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.<BR>\r
 This program and the accompanying materials\r
 are licensed and made available under the terms and conditions of the BSD License\r
 which accompanies this distribution.  The full text of the license may be found at\r
@@ -30,14 +30,14 @@ Md4GetContextSize (
   //\r
   // Retrieves the OpenSSL MD4 Context Size\r
   //\r
-  return (UINTN)(sizeof (MD4_CTX));\r
+  return (UINTN) (sizeof (MD4_CTX));\r
 }\r
 \r
 /**\r
   Initializes user-supplied memory pointed by Md4Context as MD4 hash context for\r
   subsequent use.\r
 \r
-  If Md4Context is NULL, then ASSERT().\r
+  If Md4Context is NULL, then return FALSE.\r
 \r
   @param[out]  Md4Context  Pointer to MD4 context being initialized.\r
 \r
@@ -52,21 +52,23 @@ Md4Init (
   )\r
 {\r
   //\r
-  // ASSERT if Md4Context is NULL.\r
+  // Check input parameters.\r
   //\r
-  ASSERT (Md4Context != NULL);\r
+  if (Md4Context == NULL) {\r
+    return FALSE;\r
+  }\r
 \r
   //\r
   // OpenSSL MD4 Context Initialization\r
   //\r
-  return (BOOLEAN) (MD4_Init ((MD4_CTX *)Md4Context));\r
+  return (BOOLEAN) (MD4_Init ((MD4_CTX *) Md4Context));\r
 }\r
 \r
 /**\r
   Makes a copy of an existing MD4 context.\r
 \r
-  If Md4Context is NULL, then ASSERT().\r
-  If NewMd4Context is NULL, then ASSERT().\r
+  If Md4Context is NULL, then return FALSE.\r
+  If NewMd4Context is NULL, then return FALSE.\r
 \r
   @param[in]  Md4Context     Pointer to MD4 context being copied.\r
   @param[out] NewMd4Context  Pointer to new MD4 context.\r
@@ -83,10 +85,11 @@ Md4Duplicate (
   )\r
 {\r
   //\r
-  // ASSERT if Md4Context or NewMd4Context is NULL.\r
+  // Check input parameters.\r
   //\r
-  ASSERT (Md4Context    != NULL);\r
-  ASSERT (NewMd4Context != NULL);\r
+  if (Md4Context == NULL || NewMd4Context == NULL) {\r
+    return FALSE;\r
+  }\r
 \r
   CopyMem (NewMd4Context, Md4Context, sizeof (MD4_CTX));\r
 \r
@@ -101,7 +104,7 @@ Md4Duplicate (
   MD4 context should be already correctly intialized by Md4Init(), and should not be finalized\r
   by Md4Final(). Behavior with invalid context is undefined.\r
 \r
-  If Md4Context is NULL, then ASSERT().\r
+  If Md4Context is NULL, then return FALSE.\r
 \r
   @param[in, out]  Md4Context  Pointer to the MD4 context.\r
   @param[in]       Data        Pointer to the buffer containing the data to be hashed.\r
@@ -120,21 +123,23 @@ Md4Update (
   )\r
 {\r
   //\r
-  // ASSERT if Md4Context is NULL\r
+  // Check input parameters.\r
   //\r
-  ASSERT (Md4Context != NULL);\r
+  if (Md4Context == NULL) {\r
+    return FALSE;\r
+  }\r
 \r
   //\r
-  // ASSERT if invalid parameters, in case that only DataLength was checked in OpenSSL\r
+  // Check invalid parameters, in case that only DataLength was checked in OpenSSL\r
   //\r
-  if (Data == NULL) {\r
-    ASSERT (DataSize == 0);\r
+  if (Data == NULL && DataSize != 0) {\r
+    return FALSE;\r
   }\r
 \r
   //\r
   // OpenSSL MD4 Hash Update\r
   //\r
-  return (BOOLEAN) (MD4_Update ((MD4_CTX *)Md4Context, Data, DataSize));\r
+  return (BOOLEAN) (MD4_Update ((MD4_CTX *) Md4Context, Data, DataSize));\r
 }\r
 \r
 /**\r
@@ -146,8 +151,8 @@ Md4Update (
   MD4 context should be already correctly intialized by Md4Init(), and should not be\r
   finalized by Md4Final(). Behavior with invalid MD4 context is undefined.\r
 \r
-  If Md4Context is NULL, then ASSERT().\r
-  If HashValue is NULL, then ASSERT().\r
+  If Md4Context is NULL, then return FALSE.\r
+  If HashValue is NULL, then return FALSE.\r
 \r
   @param[in, out]  Md4Context  Pointer to the MD4 context.\r
   @param[out]      HashValue   Pointer to a buffer that receives the MD4 digest\r
@@ -165,13 +170,14 @@ Md4Final (
   )\r
 {\r
   //\r
-  // ASSERT if Md4Context is NULL or HashValue is NULL\r
+  // Check input parameters.\r
   //\r
-  ASSERT (Md4Context != NULL);\r
-  ASSERT (HashValue  != NULL);\r
+  if (Md4Context == NULL || HashValue == NULL) {\r
+    return FALSE;\r
+  }\r
 \r
   //\r
   // OpenSSL MD4 Hash Finalization\r
   //\r
-  return (BOOLEAN) (MD4_Final (HashValue, (MD4_CTX *)Md4Context));\r
+  return (BOOLEAN) (MD4_Final (HashValue, (MD4_CTX *) Md4Context));\r
 }\r