1. Remove conducting ASSERT in BaseCryptLib.

[mirror_edk2.git] / CryptoPkg / Library / BaseCryptLib / Hash / CryptMd5.c

diff --git a/CryptoPkg/Library/BaseCryptLib/Hash/CryptMd5.c b/CryptoPkg/Library/BaseCryptLib/Hash/CryptMd5.c
index 8d5e6ed89d106ad0b642be5af31b118898f80b36..1d852c74951682313bfed192230a1a1c5a1ab130 100644 (file)
--- a/CryptoPkg/Library/BaseCryptLib/Hash/CryptMd5.c
+++ b/CryptoPkg/Library/BaseCryptLib/Hash/CryptMd5.c
@@ -1,7 +1,7 @@
 /** @file\r
   MD5 Digest Wrapper Implementation over OpenSSL.\r
 \r
-Copyright (c) 2009 - 2010, Intel Corporation. All rights reserved.<BR>\r
+Copyright (c) 2009 - 2012, Intel Corporation. All rights reserved.<BR>\r
 This program and the accompanying materials\r
 are licensed and made available under the terms and conditions of the BSD License\r
 which accompanies this distribution.  The full text of the license may be found at\r
@@ -39,7 +39,7 @@ Md5GetContextSize (
   Initializes user-supplied memory pointed by Md5Context as MD5 hash context for\r
   subsequent use.\r
 \r
-  If Md5Context is NULL, then ASSERT().\r
+  If Md5Context is NULL, then return FALSE.\r
 \r
   @param[out]  Md5Context  Pointer to MD5 context being initialized.\r
 \r
@@ -54,9 +54,11 @@ Md5Init (
   )\r
 {\r
   //\r
-  // ASSERT if Md5Context is NULL.\r
+  // Check input parameters.\r
   //\r
-  ASSERT (Md5Context != NULL);\r
+  if ((Md5Context == NULL)) {\r
+    return FALSE;\r
+  }\r
 \r
   //\r
   // OpenSSL MD5 Context Initialization\r
@@ -67,8 +69,8 @@ Md5Init (
 /**\r
   Makes a copy of an existing MD5 context.\r
 \r
-  If Md5Context is NULL, then ASSERT().\r
-  If NewMd5Context is NULL, then ASSERT().\r
+  If Md5Context is NULL, then return FALSE.\r
+  If NewMd5Context is NULL, then return FALSE.\r
 \r
   @param[in]  Md5Context     Pointer to MD5 context being copied.\r
   @param[out] NewMd5Context  Pointer to new MD5 context.\r
@@ -85,10 +87,11 @@ Md5Duplicate (
   )\r
 {\r
   //\r
-  // ASSERT if Md5Context or NewMd5Context is NULL.\r
+  // Check input parameters.\r
   //\r
-  ASSERT (Md5Context    != NULL);\r
-  ASSERT (NewMd5Context != NULL);\r
+  if (Md5Context == NULL || NewMd5Context == NULL) {\r
+    return FALSE;\r
+  }\r
 \r
   CopyMem (NewMd5Context, Md5Context, sizeof (MD5_CTX));\r
 \r
@@ -103,7 +106,7 @@ Md5Duplicate (
   MD5 context should be already correctly intialized by Md5Init(), and should not be finalized\r
   by Md5Final(). Behavior with invalid context is undefined.\r
 \r
-  If Md5Context is NULL, then ASSERT().\r
+  If Md5Context is NULL, then return FALSE.\r
 \r
   @param[in, out]  Md5Context  Pointer to the MD5 context.\r
   @param[in]       Data        Pointer to the buffer containing the data to be hashed.\r
@@ -122,15 +125,17 @@ Md5Update (
   )\r
 {\r
   //\r
-  // ASSERT if Md5Context is NULL\r
+  // Check input parameters.\r
   //\r
-  ASSERT (Md5Context != NULL);\r
+  if (Md5Context == NULL) {\r
+    return FALSE;\r
+  }\r
 \r
   //\r
-  // ASSERT if invalid parameters, in case that only DataLength was checked in OpenSSL\r
+  // Check invalid parameters, in case that only DataLength was checked in OpenSSL\r
   //\r
-  if (Data == NULL) {\r
-    ASSERT (DataSize == 0);\r
+  if (Data == NULL && (DataSize != 0)) {\r
+    return FALSE;\r
   }\r
 \r
   //\r
@@ -148,8 +153,8 @@ Md5Update (
   MD5 context should be already correctly intialized by Md5Init(), and should not be\r
   finalized by Md5Final(). Behavior with invalid MD5 context is undefined.\r
 \r
-  If Md5Context is NULL, then ASSERT().\r
-  If HashValue is NULL, then ASSERT().\r
+  If Md5Context is NULL, then return FALSE.\r
+  If HashValue is NULL, then return FALSE.\r
 \r
   @param[in, out]  Md5Context  Pointer to the MD5 context.\r
   @param[out]      HashValue   Pointer to a buffer that receives the MD5 digest\r
@@ -167,10 +172,11 @@ Md5Final (
   )\r
 {\r
   //\r
-  // ASSERT if Md5Context is NULL or HashValue is NULL\r
+  // Check input parameters.\r
   //\r
-  ASSERT (Md5Context != NULL);\r
-  ASSERT (HashValue  != NULL);\r
+  if (Md5Context == NULL || HashValue == NULL) {\r
+    return FALSE;\r
+  }\r
 \r
   //\r
   // OpenSSL MD5 Hash Finalization\r