This is NULL.\r
Data is NULL.\r
DataSize is 0.\r
+ DataSize is invalid for DataType.\r
@retval EFI_UNSUPPORTED The DataType is unsupported.\r
@retval EFI_ACCESS_DENIED If the DataType is one of below:\r
EfiTlsClientRandom\r
EFI_STATUS Status;\r
TLS_INSTANCE *Instance;\r
UINT16 *CipherId;\r
+ UINTN CipherCount;\r
UINTN Index;\r
\r
EFI_TPL OldTpl;\r
Status = TlsSetConnectionEnd (Instance->TlsConn, *((EFI_TLS_CONNECTION_END *) Data));\r
break;\r
case EfiTlsCipherList:\r
+ if (DataSize % sizeof (EFI_TLS_CIPHER) != 0) {\r
+ Status = EFI_INVALID_PARAMETER;\r
+ goto ON_EXIT;\r
+ }\r
+\r
CipherId = AllocatePool (DataSize);\r
if (CipherId == NULL) {\r
Status = EFI_OUT_OF_RESOURCES;\r
goto ON_EXIT;\r
}\r
\r
- for (Index = 0; Index < DataSize / sizeof (EFI_TLS_CIPHER); Index++) {\r
+ CipherCount = DataSize / sizeof (EFI_TLS_CIPHER);\r
+ for (Index = 0; Index < CipherCount; Index++) {\r
*(CipherId +Index) = HTONS (*(((UINT16 *) Data) + Index));\r
}\r
\r
- Status = TlsSetCipherList (Instance->TlsConn, CipherId, DataSize / sizeof (EFI_TLS_CIPHER));\r
+ Status = TlsSetCipherList (Instance->TlsConn, CipherId, CipherCount);\r
\r
FreePool (CipherId);\r
break;\r