]> git.proxmox.com Git - mirror_edk2.git/blobdiff - SecurityPkg/Tcg/TcgPei/TcgPei.c
SecurityPkg: Apply uncrustify changes
[mirror_edk2.git] / SecurityPkg / Tcg / TcgPei / TcgPei.c
index 536bd5a40820ba37067856a13e8d942924a487e1..5aa80511aa814e9146333ab6a3affe04553747b4 100644 (file)
@@ -39,7 +39,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Library/BaseCryptLib.h>\r
 #include <Library/PerformanceLib.h>\r
 \r
-BOOLEAN                 mImageInMemory  = FALSE;\r
+BOOLEAN  mImageInMemory = FALSE;\r
 \r
 EFI_PEI_PPI_DESCRIPTOR  mTpmInitializedPpiList = {\r
   EFI_PEI_PPI_DESCRIPTOR_PPI | EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST,\r
@@ -74,15 +74,15 @@ EFI_PEI_PPI_DESCRIPTOR  mTpmInitializationDonePpiList = {
 EFI_STATUS\r
 EFIAPI\r
 HashLogExtendEvent (\r
-  IN      EDKII_TCG_PPI             *This,\r
-  IN      UINT64                    Flags,\r
-  IN      UINT8                     *HashData,\r
-  IN      UINTN                     HashDataLen,\r
-  IN      TCG_PCR_EVENT_HDR         *NewEventHdr,\r
-  IN      UINT8                     *NewEventData\r
+  IN      EDKII_TCG_PPI      *This,\r
+  IN      UINT64             Flags,\r
+  IN      UINT8              *HashData,\r
+  IN      UINTN              HashDataLen,\r
+  IN      TCG_PCR_EVENT_HDR  *NewEventHdr,\r
+  IN      UINT8              *NewEventData\r
   );\r
 \r
-EDKII_TCG_PPI mEdkiiTcgPpi = {\r
+EDKII_TCG_PPI  mEdkiiTcgPpi = {\r
   HashLogExtendEvent\r
 };\r
 \r
@@ -95,17 +95,17 @@ EFI_PEI_PPI_DESCRIPTOR  mTcgPpiList = {
 //\r
 // Number of firmware blobs to grow by each time we run out of room\r
 //\r
-#define FIRMWARE_BLOB_GROWTH_STEP 4\r
+#define FIRMWARE_BLOB_GROWTH_STEP  4\r
 \r
-EFI_PLATFORM_FIRMWARE_BLOB *mMeasuredBaseFvInfo;\r
-UINT32 mMeasuredMaxBaseFvIndex = 0;\r
-UINT32 mMeasuredBaseFvIndex = 0;\r
+EFI_PLATFORM_FIRMWARE_BLOB  *mMeasuredBaseFvInfo;\r
+UINT32                      mMeasuredMaxBaseFvIndex = 0;\r
+UINT32                      mMeasuredBaseFvIndex    = 0;\r
 \r
-EFI_PLATFORM_FIRMWARE_BLOB *mMeasuredChildFvInfo;\r
-UINT32 mMeasuredMaxChildFvIndex = 0;\r
-UINT32 mMeasuredChildFvIndex = 0;\r
+EFI_PLATFORM_FIRMWARE_BLOB  *mMeasuredChildFvInfo;\r
+UINT32                      mMeasuredMaxChildFvIndex = 0;\r
+UINT32                      mMeasuredChildFvIndex    = 0;\r
 \r
-EFI_PEI_FIRMWARE_VOLUME_INFO_MEASUREMENT_EXCLUDED_PPI *mMeasurementExcludedFvPpi;\r
+EFI_PEI_FIRMWARE_VOLUME_INFO_MEASUREMENT_EXCLUDED_PPI  *mMeasurementExcludedFvPpi;\r
 \r
 /**\r
   Lock physical presence if needed.\r
@@ -120,9 +120,9 @@ EFI_PEI_FIRMWARE_VOLUME_INFO_MEASUREMENT_EXCLUDED_PPI *mMeasurementExcludedFvPpi
 EFI_STATUS\r
 EFIAPI\r
 PhysicalPresencePpiNotifyCallback (\r
-  IN EFI_PEI_SERVICES              **PeiServices,\r
-  IN EFI_PEI_NOTIFY_DESCRIPTOR     *NotifyDescriptor,\r
-  IN VOID                          *Ppi\r
+  IN EFI_PEI_SERVICES           **PeiServices,\r
+  IN EFI_PEI_NOTIFY_DESCRIPTOR  *NotifyDescriptor,\r
+  IN VOID                       *Ppi\r
   );\r
 \r
 /**\r
@@ -139,9 +139,9 @@ PhysicalPresencePpiNotifyCallback (
 EFI_STATUS\r
 EFIAPI\r
 FirmwareVolumeInfoPpiNotifyCallback (\r
-  IN EFI_PEI_SERVICES              **PeiServices,\r
-  IN EFI_PEI_NOTIFY_DESCRIPTOR     *NotifyDescriptor,\r
-  IN VOID                          *Ppi\r
+  IN EFI_PEI_SERVICES           **PeiServices,\r
+  IN EFI_PEI_NOTIFY_DESCRIPTOR  *NotifyDescriptor,\r
+  IN VOID                       *Ppi\r
   );\r
 \r
 /**\r
@@ -158,12 +158,12 @@ FirmwareVolumeInfoPpiNotifyCallback (
 EFI_STATUS\r
 EFIAPI\r
 EndofPeiSignalNotifyCallBack (\r
-  IN EFI_PEI_SERVICES              **PeiServices,\r
-  IN EFI_PEI_NOTIFY_DESCRIPTOR     *NotifyDescriptor,\r
-  IN VOID                          *Ppi\r
+  IN EFI_PEI_SERVICES           **PeiServices,\r
+  IN EFI_PEI_NOTIFY_DESCRIPTOR  *NotifyDescriptor,\r
+  IN VOID                       *Ppi\r
   );\r
 \r
-EFI_PEI_NOTIFY_DESCRIPTOR           mNotifyList[] = {\r
+EFI_PEI_NOTIFY_DESCRIPTOR  mNotifyList[] = {\r
   {\r
     EFI_PEI_PPI_DESCRIPTOR_NOTIFY_CALLBACK,\r
     &gPeiLockPhysicalPresencePpiGuid,\r
@@ -204,12 +204,12 @@ EFI_PEI_NOTIFY_DESCRIPTOR           mNotifyList[] = {
 EFI_STATUS\r
 EFIAPI\r
 EndofPeiSignalNotifyCallBack (\r
-  IN EFI_PEI_SERVICES              **PeiServices,\r
-  IN EFI_PEI_NOTIFY_DESCRIPTOR     *NotifyDescriptor,\r
-  IN VOID                          *Ppi\r
+  IN EFI_PEI_SERVICES           **PeiServices,\r
+  IN EFI_PEI_NOTIFY_DESCRIPTOR  *NotifyDescriptor,\r
+  IN VOID                       *Ppi\r
   )\r
 {\r
-  MEASURED_HOB_DATA *MeasuredHobData;\r
+  MEASURED_HOB_DATA  *MeasuredHobData;\r
 \r
   MeasuredHobData = NULL;\r
 \r
@@ -218,12 +218,12 @@ EndofPeiSignalNotifyCallBack (
   //\r
   // Create a Guid hob to save all measured Fv\r
   //\r
-  MeasuredHobData = BuildGuidHob(\r
+  MeasuredHobData = BuildGuidHob (\r
                       &gMeasuredFvHobGuid,\r
-                      sizeof(UINTN) + sizeof(EFI_PLATFORM_FIRMWARE_BLOB) * (mMeasuredBaseFvIndex + mMeasuredChildFvIndex)\r
+                      sizeof (UINTN) + sizeof (EFI_PLATFORM_FIRMWARE_BLOB) * (mMeasuredBaseFvIndex + mMeasuredChildFvIndex)\r
                       );\r
 \r
-  if (MeasuredHobData != NULL){\r
+  if (MeasuredHobData != NULL) {\r
     //\r
     // Save measured FV info enty number\r
     //\r
@@ -232,12 +232,12 @@ EndofPeiSignalNotifyCallBack (
     //\r
     // Save measured base Fv info\r
     //\r
-    CopyMem (MeasuredHobData->MeasuredFvBuf, mMeasuredBaseFvInfo, sizeof(EFI_PLATFORM_FIRMWARE_BLOB) * (mMeasuredBaseFvIndex));\r
+    CopyMem (MeasuredHobData->MeasuredFvBuf, mMeasuredBaseFvInfo, sizeof (EFI_PLATFORM_FIRMWARE_BLOB) * (mMeasuredBaseFvIndex));\r
 \r
     //\r
     // Save measured child Fv info\r
     //\r
-    CopyMem (&MeasuredHobData->MeasuredFvBuf[mMeasuredBaseFvIndex] , mMeasuredChildFvInfo, sizeof(EFI_PLATFORM_FIRMWARE_BLOB) * (mMeasuredChildFvIndex));\r
+    CopyMem (&MeasuredHobData->MeasuredFvBuf[mMeasuredBaseFvIndex], mMeasuredChildFvInfo, sizeof (EFI_PLATFORM_FIRMWARE_BLOB) * (mMeasuredChildFvIndex));\r
   }\r
 \r
   PERF_CALLBACK_END (&gEfiEndOfPeiSignalPpiGuid);\r
@@ -300,16 +300,16 @@ TpmCommHashAll (
 EFI_STATUS\r
 EFIAPI\r
 HashLogExtendEvent (\r
-  IN      EDKII_TCG_PPI             *This,\r
-  IN      UINT64                    Flags,\r
-  IN      UINT8                     *HashData,\r
-  IN      UINTN                     HashDataLen,\r
-  IN      TCG_PCR_EVENT_HDR         *NewEventHdr,\r
-  IN      UINT8                     *NewEventData\r
+  IN      EDKII_TCG_PPI      *This,\r
+  IN      UINT64             Flags,\r
+  IN      UINT8              *HashData,\r
+  IN      UINTN              HashDataLen,\r
+  IN      TCG_PCR_EVENT_HDR  *NewEventHdr,\r
+  IN      UINT8              *NewEventData\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  VOID                              *HobData;\r
+  EFI_STATUS  Status;\r
+  VOID        *HobData;\r
 \r
   if (GetFirstGuidHob (&gTpmErrorHobGuid) != NULL) {\r
     return EFI_DEVICE_ERROR;\r
@@ -337,28 +337,29 @@ HashLogExtendEvent (
   }\r
 \r
   HobData = BuildGuidHob (\r
-             &gTcgEventEntryHobGuid,\r
-             sizeof (*NewEventHdr) + NewEventHdr->EventSize\r
-             );\r
+              &gTcgEventEntryHobGuid,\r
+              sizeof (*NewEventHdr) + NewEventHdr->EventSize\r
+              );\r
   if (HobData == NULL) {\r
     Status = EFI_OUT_OF_RESOURCES;\r
     goto Done;\r
   }\r
 \r
   CopyMem (HobData, NewEventHdr, sizeof (*NewEventHdr));\r
-  HobData = (VOID *) ((UINT8*)HobData + sizeof (*NewEventHdr));\r
+  HobData = (VOID *)((UINT8 *)HobData + sizeof (*NewEventHdr));\r
   CopyMem (HobData, NewEventData, NewEventHdr->EventSize);\r
 \r
 Done:\r
   if ((Status == EFI_DEVICE_ERROR) || (Status == EFI_TIMEOUT)) {\r
     DEBUG ((DEBUG_ERROR, "HashLogExtendEvent - %r. Disable TPM.\n", Status));\r
-    BuildGuidHob (&gTpmErrorHobGuid,0);\r
+    BuildGuidHob (&gTpmErrorHobGuid, 0);\r
     REPORT_STATUS_CODE (\r
       EFI_ERROR_CODE | EFI_ERROR_MINOR,\r
       (PcdGet32 (PcdStatusCodeSubClassTpmDevice) | EFI_P_EC_INTERFACE_ERROR)\r
       );\r
     Status = EFI_DEVICE_ERROR;\r
   }\r
+\r
   return Status;\r
 }\r
 \r
@@ -375,10 +376,10 @@ Done:
 EFI_STATUS\r
 EFIAPI\r
 MeasureCRTMVersion (\r
-  IN      EFI_PEI_SERVICES          **PeiServices\r
+  IN      EFI_PEI_SERVICES  **PeiServices\r
   )\r
 {\r
-  TCG_PCR_EVENT_HDR                 TcgEventHdr;\r
+  TCG_PCR_EVENT_HDR  TcgEventHdr;\r
 \r
   //\r
   // Use FirmwareVersion string to represent CRTM version.\r
@@ -387,15 +388,15 @@ MeasureCRTMVersion (
 \r
   TcgEventHdr.PCRIndex  = 0;\r
   TcgEventHdr.EventType = EV_S_CRTM_VERSION;\r
-  TcgEventHdr.EventSize = (UINT32) StrSize((CHAR16*)PcdGetPtr (PcdFirmwareVersionString));\r
+  TcgEventHdr.EventSize = (UINT32)StrSize ((CHAR16 *)PcdGetPtr (PcdFirmwareVersionString));\r
 \r
   return HashLogExtendEvent (\r
            &mEdkiiTcgPpi,\r
            0,\r
-           (UINT8*)PcdGetPtr (PcdFirmwareVersionString),\r
+           (UINT8 *)PcdGetPtr (PcdFirmwareVersionString),\r
            TcgEventHdr.EventSize,\r
            &TcgEventHdr,\r
-           (UINT8*)PcdGetPtr (PcdFirmwareVersionString)\r
+           (UINT8 *)PcdGetPtr (PcdFirmwareVersionString)\r
            );\r
 }\r
 \r
@@ -415,24 +416,24 @@ MeasureCRTMVersion (
 EFI_STATUS\r
 EFIAPI\r
 MeasureFvImage (\r
-  IN EFI_PHYSICAL_ADDRESS           FvBase,\r
-  IN UINT64                         FvLength\r
+  IN EFI_PHYSICAL_ADDRESS  FvBase,\r
+  IN UINT64                FvLength\r
   )\r
 {\r
-  UINT32                            Index;\r
-  EFI_STATUS                        Status;\r
-  EFI_PLATFORM_FIRMWARE_BLOB        FvBlob;\r
-  TCG_PCR_EVENT_HDR                 TcgEventHdr;\r
-  EFI_PHYSICAL_ADDRESS              FvOrgBase;\r
-  EFI_PHYSICAL_ADDRESS              FvDataBase;\r
-  EFI_PEI_HOB_POINTERS              Hob;\r
-  EDKII_MIGRATED_FV_INFO            *MigratedFvInfo;\r
+  UINT32                      Index;\r
+  EFI_STATUS                  Status;\r
+  EFI_PLATFORM_FIRMWARE_BLOB  FvBlob;\r
+  TCG_PCR_EVENT_HDR           TcgEventHdr;\r
+  EFI_PHYSICAL_ADDRESS        FvOrgBase;\r
+  EFI_PHYSICAL_ADDRESS        FvDataBase;\r
+  EFI_PEI_HOB_POINTERS        Hob;\r
+  EDKII_MIGRATED_FV_INFO      *MigratedFvInfo;\r
 \r
   //\r
   // Check if it is in Excluded FV list\r
   //\r
   if (mMeasurementExcludedFvPpi != NULL) {\r
-    for (Index = 0; Index < mMeasurementExcludedFvPpi->Count; Index ++) {\r
+    for (Index = 0; Index < mMeasurementExcludedFvPpi->Count; Index++) {\r
       if (mMeasurementExcludedFvPpi->Fv[Index].FvBase == FvBase) {\r
         DEBUG ((DEBUG_INFO, "The FV which is excluded by TcgPei starts at: 0x%x\n", FvBase));\r
         DEBUG ((DEBUG_INFO, "The FV which is excluded by TcgPei has the size: 0x%x\n", FvLength));\r
@@ -444,7 +445,7 @@ MeasureFvImage (
   //\r
   // Check whether FV is in the measured FV list.\r
   //\r
-  for (Index = 0; Index < mMeasuredBaseFvIndex; Index ++) {\r
+  for (Index = 0; Index < mMeasuredBaseFvIndex; Index++) {\r
     if (mMeasuredBaseFvInfo[Index].BlobBase == FvBase) {\r
       return EFI_SUCCESS;\r
     }\r
@@ -455,17 +456,18 @@ MeasureFvImage (
   //\r
   FvOrgBase  = FvBase;\r
   FvDataBase = FvBase;\r
-  Hob.Raw  = GetFirstGuidHob (&gEdkiiMigratedFvInfoGuid);\r
+  Hob.Raw    = GetFirstGuidHob (&gEdkiiMigratedFvInfoGuid);\r
   while (Hob.Raw != NULL) {\r
     MigratedFvInfo = GET_GUID_HOB_DATA (Hob);\r
-    if ((MigratedFvInfo->FvNewBase == (UINT32) FvBase) && (MigratedFvInfo->FvLength == (UINT32) FvLength)) {\r
+    if ((MigratedFvInfo->FvNewBase == (UINT32)FvBase) && (MigratedFvInfo->FvLength == (UINT32)FvLength)) {\r
       //\r
       // Found the migrated FV info\r
       //\r
-      FvOrgBase  = (EFI_PHYSICAL_ADDRESS) (UINTN) MigratedFvInfo->FvOrgBase;\r
-      FvDataBase = (EFI_PHYSICAL_ADDRESS) (UINTN) MigratedFvInfo->FvDataBase;\r
+      FvOrgBase  = (EFI_PHYSICAL_ADDRESS)(UINTN)MigratedFvInfo->FvOrgBase;\r
+      FvDataBase = (EFI_PHYSICAL_ADDRESS)(UINTN)MigratedFvInfo->FvDataBase;\r
       break;\r
     }\r
+\r
     Hob.Raw = GET_NEXT_HOB (Hob);\r
     Hob.Raw = GetNextGuidHob (&gEdkiiMigratedFvInfoGuid, Hob.Raw);\r
   }\r
@@ -479,17 +481,17 @@ MeasureFvImage (
   DEBUG ((DEBUG_INFO, "The FV which is measured by TcgPei starts at: 0x%x\n", FvBlob.BlobBase));\r
   DEBUG ((DEBUG_INFO, "The FV which is measured by TcgPei has the size: 0x%x\n", FvBlob.BlobLength));\r
 \r
-  TcgEventHdr.PCRIndex = 0;\r
+  TcgEventHdr.PCRIndex  = 0;\r
   TcgEventHdr.EventType = EV_EFI_PLATFORM_FIRMWARE_BLOB;\r
   TcgEventHdr.EventSize = sizeof (FvBlob);\r
 \r
   Status = HashLogExtendEvent (\r
              &mEdkiiTcgPpi,\r
              0,\r
-             (UINT8*) (UINTN) FvDataBase,\r
-             (UINTN) FvBlob.BlobLength,\r
+             (UINT8 *)(UINTN)FvDataBase,\r
+             (UINTN)FvBlob.BlobLength,\r
              &TcgEventHdr,\r
-             (UINT8*) &FvBlob\r
+             (UINT8 *)&FvBlob\r
              );\r
 \r
   //\r
@@ -525,16 +527,16 @@ MeasureFvImage (
 EFI_STATUS\r
 EFIAPI\r
 MeasureMainBios (\r
-  IN      EFI_PEI_SERVICES          **PeiServices\r
+  IN      EFI_PEI_SERVICES  **PeiServices\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  UINT32                            FvInstances;\r
-  EFI_PEI_FV_HANDLE                 VolumeHandle;\r
-  EFI_FV_INFO                       VolumeInfo;\r
-  EFI_PEI_FIRMWARE_VOLUME_PPI       *FvPpi;\r
+  EFI_STATUS                   Status;\r
+  UINT32                       FvInstances;\r
+  EFI_PEI_FV_HANDLE            VolumeHandle;\r
+  EFI_FV_INFO                  VolumeInfo;\r
+  EFI_PEI_FIRMWARE_VOLUME_PPI  *FvPpi;\r
 \r
-  FvInstances    = 0;\r
+  FvInstances = 0;\r
   while (TRUE) {\r
     //\r
     // Traverse all firmware volume instances of Static Core Root of Trust for Measurement\r
@@ -558,10 +560,10 @@ MeasureMainBios (
                &VolumeInfo.FvFormat,\r
                0,\r
                NULL,\r
-               (VOID**)&FvPpi\r
+               (VOID **)&FvPpi\r
                );\r
     if (!EFI_ERROR (Status)) {\r
-      MeasureFvImage ((EFI_PHYSICAL_ADDRESS) (UINTN) VolumeInfo.FvStart, VolumeInfo.FvSize);\r
+      MeasureFvImage ((EFI_PHYSICAL_ADDRESS)(UINTN)VolumeInfo.FvStart, VolumeInfo.FvSize);\r
     }\r
 \r
     FvInstances++;\r
@@ -584,9 +586,9 @@ MeasureMainBios (
 EFI_STATUS\r
 EFIAPI\r
 FirmwareVolumeInfoPpiNotifyCallback (\r
-  IN EFI_PEI_SERVICES               **PeiServices,\r
-  IN EFI_PEI_NOTIFY_DESCRIPTOR      *NotifyDescriptor,\r
-  IN VOID                           *Ppi\r
+  IN EFI_PEI_SERVICES           **PeiServices,\r
+  IN EFI_PEI_NOTIFY_DESCRIPTOR  *NotifyDescriptor,\r
+  IN VOID                       *Ppi\r
   )\r
 {\r
   EFI_PEI_FIRMWARE_VOLUME_INFO_PPI  *Fv;\r
@@ -594,7 +596,7 @@ FirmwareVolumeInfoPpiNotifyCallback (
   EFI_PEI_FIRMWARE_VOLUME_PPI       *FvPpi;\r
   UINTN                             Index;\r
 \r
-  Fv = (EFI_PEI_FIRMWARE_VOLUME_INFO_PPI *) Ppi;\r
+  Fv = (EFI_PEI_FIRMWARE_VOLUME_INFO_PPI *)Ppi;\r
 \r
   //\r
   // The PEI Core can not dispatch or load files from memory mapped FVs that do not support FvPpi.\r
@@ -603,7 +605,7 @@ FirmwareVolumeInfoPpiNotifyCallback (
              &Fv->FvFormat,\r
              0,\r
              NULL,\r
-             (VOID**)&FvPpi\r
+             (VOID **)&FvPpi\r
              );\r
   if (EFI_ERROR (Status)) {\r
     return EFI_SUCCESS;\r
@@ -613,8 +615,7 @@ FirmwareVolumeInfoPpiNotifyCallback (
   // This is an FV from an FFS file, and the parent FV must have already been measured,\r
   // No need to measure twice, so just record the FV and return\r
   //\r
-  if (Fv->ParentFvName != NULL || Fv->ParentFileName != NULL ) {\r
-\r
+  if ((Fv->ParentFvName != NULL) || (Fv->ParentFileName != NULL)) {\r
     if (mMeasuredChildFvIndex >= mMeasuredMaxChildFvIndex) {\r
       mMeasuredChildFvInfo = ReallocatePool (\r
                                sizeof (EFI_PLATFORM_FIRMWARE_BLOB) * mMeasuredMaxChildFvIndex,\r
@@ -624,21 +625,23 @@ FirmwareVolumeInfoPpiNotifyCallback (
       ASSERT (mMeasuredChildFvInfo != NULL);\r
       mMeasuredMaxChildFvIndex = mMeasuredMaxChildFvIndex + FIRMWARE_BLOB_GROWTH_STEP;\r
     }\r
+\r
     //\r
     // Check whether FV is in the measured child FV list.\r
     //\r
     for (Index = 0; Index < mMeasuredChildFvIndex; Index++) {\r
-      if (mMeasuredChildFvInfo[Index].BlobBase == (EFI_PHYSICAL_ADDRESS) (UINTN) Fv->FvInfo) {\r
+      if (mMeasuredChildFvInfo[Index].BlobBase == (EFI_PHYSICAL_ADDRESS)(UINTN)Fv->FvInfo) {\r
         return EFI_SUCCESS;\r
       }\r
     }\r
-    mMeasuredChildFvInfo[mMeasuredChildFvIndex].BlobBase   = (EFI_PHYSICAL_ADDRESS) (UINTN) Fv->FvInfo;\r
+\r
+    mMeasuredChildFvInfo[mMeasuredChildFvIndex].BlobBase   = (EFI_PHYSICAL_ADDRESS)(UINTN)Fv->FvInfo;\r
     mMeasuredChildFvInfo[mMeasuredChildFvIndex].BlobLength = Fv->FvInfoSize;\r
     mMeasuredChildFvIndex++;\r
     return EFI_SUCCESS;\r
   }\r
 \r
-  return MeasureFvImage ((EFI_PHYSICAL_ADDRESS) (UINTN) Fv->FvInfo, Fv->FvInfoSize);\r
+  return MeasureFvImage ((EFI_PHYSICAL_ADDRESS)(UINTN)Fv->FvInfo, Fv->FvInfoSize);\r
 }\r
 \r
 /**\r
@@ -657,15 +660,15 @@ FirmwareVolumeInfoPpiNotifyCallback (
 EFI_STATUS\r
 EFIAPI\r
 PhysicalPresencePpiNotifyCallback (\r
-  IN EFI_PEI_SERVICES               **PeiServices,\r
-  IN EFI_PEI_NOTIFY_DESCRIPTOR      *NotifyDescriptor,\r
-  IN VOID                           *Ppi\r
+  IN EFI_PEI_SERVICES           **PeiServices,\r
+  IN EFI_PEI_NOTIFY_DESCRIPTOR  *NotifyDescriptor,\r
+  IN VOID                       *Ppi\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  TPM_PERMANENT_FLAGS               TpmPermanentFlags;\r
-  PEI_LOCK_PHYSICAL_PRESENCE_PPI    *LockPhysicalPresencePpi;\r
-  TPM_PHYSICAL_PRESENCE             PhysicalPresenceValue;\r
+  EFI_STATUS                      Status;\r
+  TPM_PERMANENT_FLAGS             TpmPermanentFlags;\r
+  PEI_LOCK_PHYSICAL_PRESENCE_PPI  *LockPhysicalPresencePpi;\r
+  TPM_PHYSICAL_PRESENCE           PhysicalPresenceValue;\r
 \r
   Status = Tpm12GetCapabilityFlagPermanent (&TpmPermanentFlags);\r
   if (EFI_ERROR (Status)) {\r
@@ -679,14 +682,14 @@ PhysicalPresencePpiNotifyCallback (
     //\r
     // Lock TPM LifetimeLock is required, and LifetimeLock is not locked yet.\r
     //\r
-    PhysicalPresenceValue = TPM_PHYSICAL_PRESENCE_LIFETIME_LOCK;\r
+    PhysicalPresenceValue                          = TPM_PHYSICAL_PRESENCE_LIFETIME_LOCK;\r
     TpmPermanentFlags.physicalPresenceLifetimeLock = TRUE;\r
 \r
     if (PcdGetBool (PcdPhysicalPresenceCmdEnable)) {\r
-      PhysicalPresenceValue |= TPM_PHYSICAL_PRESENCE_CMD_ENABLE;\r
+      PhysicalPresenceValue                      |= TPM_PHYSICAL_PRESENCE_CMD_ENABLE;\r
       TpmPermanentFlags.physicalPresenceCMDEnable = TRUE;\r
     } else {\r
-      PhysicalPresenceValue |= TPM_PHYSICAL_PRESENCE_CMD_DISABLE;\r
+      PhysicalPresenceValue                      |= TPM_PHYSICAL_PRESENCE_CMD_DISABLE;\r
       TpmPermanentFlags.physicalPresenceCMDEnable = FALSE;\r
     }\r
 \r
@@ -707,8 +710,8 @@ PhysicalPresencePpiNotifyCallback (
   //\r
   // 2. Lock physical presence if it is required.\r
   //\r
-  LockPhysicalPresencePpi = (PEI_LOCK_PHYSICAL_PRESENCE_PPI *) Ppi;\r
-  if (!LockPhysicalPresencePpi->LockPhysicalPresence ((CONST EFI_PEI_SERVICES**) PeiServices)) {\r
+  LockPhysicalPresencePpi = (PEI_LOCK_PHYSICAL_PRESENCE_PPI *)Ppi;\r
+  if (!LockPhysicalPresencePpi->LockPhysicalPresence ((CONST EFI_PEI_SERVICES **)PeiServices)) {\r
     return EFI_SUCCESS;\r
   }\r
 \r
@@ -736,8 +739,8 @@ PhysicalPresencePpiNotifyCallback (
   // Lock physical presence\r
   //\r
   Status = Tpm12PhysicalPresence (\r
-              TPM_PHYSICAL_PRESENCE_LOCK\r
-              );\r
+             TPM_PHYSICAL_PRESENCE_LOCK\r
+             );\r
   return Status;\r
 }\r
 \r
@@ -762,6 +765,7 @@ IsTpmUsable (
   if (EFI_ERROR (Status)) {\r
     return FALSE;\r
   }\r
+\r
   return (BOOLEAN)(!TpmPermanentFlags.deactivated);\r
 }\r
 \r
@@ -778,17 +782,17 @@ IsTpmUsable (
 EFI_STATUS\r
 EFIAPI\r
 PeimEntryMP (\r
-  IN      EFI_PEI_SERVICES          **PeiServices\r
+  IN      EFI_PEI_SERVICES  **PeiServices\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
+  EFI_STATUS  Status;\r
 \r
   Status = PeiServicesLocatePpi (\r
-               &gEfiPeiFirmwareVolumeInfoMeasurementExcludedPpiGuid,\r
-               0,\r
-               NULL,\r
-               (VOID**)&mMeasurementExcludedFvPpi\r
-               );\r
+             &gEfiPeiFirmwareVolumeInfoMeasurementExcludedPpiGuid,\r
+             0,\r
+             NULL,\r
+             (VOID **)&mMeasurementExcludedFvPpi\r
+             );\r
   // Do not check status, because it is optional\r
 \r
   Status = Tpm12RequestUseTpm ();\r
@@ -835,15 +839,15 @@ PeimEntryMP (
 EFI_STATUS\r
 EFIAPI\r
 PeimEntryMA (\r
-  IN       EFI_PEI_FILE_HANDLE      FileHandle,\r
-  IN CONST EFI_PEI_SERVICES         **PeiServices\r
+  IN       EFI_PEI_FILE_HANDLE  FileHandle,\r
+  IN CONST EFI_PEI_SERVICES     **PeiServices\r
   )\r
 {\r
-  EFI_STATUS                        Status;\r
-  EFI_STATUS                        Status2;\r
-  EFI_BOOT_MODE                     BootMode;\r
+  EFI_STATUS     Status;\r
+  EFI_STATUS     Status2;\r
+  EFI_BOOT_MODE  BootMode;\r
 \r
-  if (!CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceTpm12Guid)){\r
+  if (!CompareGuid (PcdGetPtr (PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceTpm12Guid)) {\r
     DEBUG ((DEBUG_ERROR, "No TPM12 instance required!\n"));\r
     return EFI_UNSUPPORTED;\r
   }\r
@@ -863,7 +867,7 @@ PeimEntryMA (
   // In S3 path, skip shadow logic. no measurement is required\r
   //\r
   if (BootMode != BOOT_ON_S3_RESUME) {\r
-    Status = (**PeiServices).RegisterForShadow(FileHandle);\r
+    Status = (**PeiServices).RegisterForShadow (FileHandle);\r
     if (Status == EFI_ALREADY_STARTED) {\r
       mImageInMemory = TRUE;\r
     } else if (Status == EFI_NOT_FOUND) {\r
@@ -884,7 +888,8 @@ PeimEntryMA (
       } else {\r
         Status = Tpm12Startup (TPM_ST_CLEAR);\r
       }\r
-      if (EFI_ERROR (Status) ) {\r
+\r
+      if (EFI_ERROR (Status)) {\r
         goto Done;\r
       }\r
     }\r
@@ -907,19 +912,20 @@ PeimEntryMA (
   }\r
 \r
   if (mImageInMemory) {\r
-    Status = PeimEntryMP ((EFI_PEI_SERVICES**)PeiServices);\r
+    Status = PeimEntryMP ((EFI_PEI_SERVICES **)PeiServices);\r
     return Status;\r
   }\r
 \r
 Done:\r
   if (EFI_ERROR (Status)) {\r
     DEBUG ((DEBUG_ERROR, "TPM error! Build Hob\n"));\r
-    BuildGuidHob (&gTpmErrorHobGuid,0);\r
+    BuildGuidHob (&gTpmErrorHobGuid, 0);\r
     REPORT_STATUS_CODE (\r
       EFI_ERROR_CODE | EFI_ERROR_MINOR,\r
       (PcdGet32 (PcdStatusCodeSubClassTpmDevice) | EFI_P_EC_INTERFACE_ERROR)\r
       );\r
   }\r
+\r
   //\r
   // Always install TpmInitializationDonePpi no matter success or fail.\r
   // Other driver can know TPM initialization state by TpmInitializedPpi.\r