]> git.proxmox.com Git - mirror_edk2.git/blobdiff - SecurityPkg/Tcg/TcgSmm/TcgSmm.c
SecurityPkg: Apply uncrustify changes
[mirror_edk2.git] / SecurityPkg / Tcg / TcgSmm / TcgSmm.c
index 25f443c04fa1b31ed5f05353f9f20cbbae56c9f2..96327a483ba9dfbd222519322210d5d834c6af9b 100644 (file)
@@ -38,29 +38,29 @@ TCG_NVS                    *mTcgNvs;
 EFI_STATUS\r
 EFIAPI\r
 PhysicalPresenceCallback (\r
-  IN EFI_HANDLE                  DispatchHandle,\r
-  IN CONST VOID                  *Context,\r
-  IN OUT VOID                    *CommBuffer,\r
-  IN OUT UINTN                   *CommBufferSize\r
+  IN EFI_HANDLE  DispatchHandle,\r
+  IN CONST VOID  *Context,\r
+  IN OUT VOID    *CommBuffer,\r
+  IN OUT UINTN   *CommBufferSize\r
   )\r
 {\r
-  EFI_STATUS                     Status;\r
-  UINTN                          DataSize;\r
-  EFI_PHYSICAL_PRESENCE          PpData;\r
-  EFI_PHYSICAL_PRESENCE_FLAGS    Flags;\r
-  BOOLEAN                        RequestConfirmed;\r
+  EFI_STATUS                   Status;\r
+  UINTN                        DataSize;\r
+  EFI_PHYSICAL_PRESENCE        PpData;\r
+  EFI_PHYSICAL_PRESENCE_FLAGS  Flags;\r
+  BOOLEAN                      RequestConfirmed;\r
 \r
   //\r
   // Get the Physical Presence variable\r
   //\r
   DataSize = sizeof (EFI_PHYSICAL_PRESENCE);\r
-  Status = mSmmVariable->SmmGetVariable (\r
-                           PHYSICAL_PRESENCE_VARIABLE,\r
-                           &gEfiPhysicalPresenceGuid,\r
-                           NULL,\r
-                           &DataSize,\r
-                           &PpData\r
-                           );\r
+  Status   = mSmmVariable->SmmGetVariable (\r
+                             PHYSICAL_PRESENCE_VARIABLE,\r
+                             &gEfiPhysicalPresenceGuid,\r
+                             NULL,\r
+                             &DataSize,\r
+                             &PpData\r
+                             );\r
 \r
   DEBUG ((DEBUG_INFO, "[TPM] PP callback, Parameter = %x\n", mTcgNvs->PhysicalPresence.Parameter));\r
   if (mTcgNvs->PhysicalPresence.Parameter == ACPI_FUNCTION_RETURN_REQUEST_RESPONSE_TO_OS) {\r
@@ -71,16 +71,19 @@ PhysicalPresenceCallback (
       DEBUG ((DEBUG_ERROR, "[TPM] Get PP variable failure! Status = %r\n", Status));\r
       return EFI_SUCCESS;\r
     }\r
+\r
     mTcgNvs->PhysicalPresence.ReturnCode  = PP_RETURN_TPM_OPERATION_RESPONSE_SUCCESS;\r
     mTcgNvs->PhysicalPresence.LastRequest = PpData.LastPPRequest;\r
     mTcgNvs->PhysicalPresence.Response    = PpData.PPResponse;\r
-  } else if ((mTcgNvs->PhysicalPresence.Parameter == ACPI_FUNCTION_SUBMIT_REQUEST_TO_BIOS)\r
-          || (mTcgNvs->PhysicalPresence.Parameter == ACPI_FUNCTION_SUBMIT_REQUEST_TO_BIOS_2)) {\r
+  } else if (  (mTcgNvs->PhysicalPresence.Parameter == ACPI_FUNCTION_SUBMIT_REQUEST_TO_BIOS)\r
+            || (mTcgNvs->PhysicalPresence.Parameter == ACPI_FUNCTION_SUBMIT_REQUEST_TO_BIOS_2))\r
+  {\r
     if (EFI_ERROR (Status)) {\r
       mTcgNvs->PhysicalPresence.ReturnCode = TCG_PP_SUBMIT_REQUEST_TO_PREOS_GENERAL_FAILURE;\r
       DEBUG ((DEBUG_ERROR, "[TPM] Get PP variable failure! Status = %r\n", Status));\r
       return EFI_SUCCESS;\r
     }\r
+\r
     if (mTcgNvs->PhysicalPresence.Request == PHYSICAL_PRESENCE_SET_OPERATOR_AUTH) {\r
       //\r
       // This command requires UI to prompt user for Auth data.\r
@@ -90,35 +93,37 @@ PhysicalPresenceCallback (
     }\r
 \r
     if (PpData.PPRequest != mTcgNvs->PhysicalPresence.Request) {\r
-      PpData.PPRequest = (UINT8) mTcgNvs->PhysicalPresence.Request;\r
-      DataSize = sizeof (EFI_PHYSICAL_PRESENCE);\r
-      Status = mSmmVariable->SmmSetVariable (\r
-                               PHYSICAL_PRESENCE_VARIABLE,\r
-                               &gEfiPhysicalPresenceGuid,\r
-                               EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
-                               DataSize,\r
-                               &PpData\r
-                               );\r
+      PpData.PPRequest = (UINT8)mTcgNvs->PhysicalPresence.Request;\r
+      DataSize         = sizeof (EFI_PHYSICAL_PRESENCE);\r
+      Status           = mSmmVariable->SmmSetVariable (\r
+                                         PHYSICAL_PRESENCE_VARIABLE,\r
+                                         &gEfiPhysicalPresenceGuid,\r
+                                         EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
+                                         DataSize,\r
+                                         &PpData\r
+                                         );\r
     }\r
 \r
     if (EFI_ERROR (Status)) {\r
       mTcgNvs->PhysicalPresence.ReturnCode = TCG_PP_SUBMIT_REQUEST_TO_PREOS_GENERAL_FAILURE;\r
       return EFI_SUCCESS;\r
     }\r
+\r
     mTcgNvs->PhysicalPresence.ReturnCode = TCG_PP_SUBMIT_REQUEST_TO_PREOS_SUCCESS;\r
 \r
     if (mTcgNvs->PhysicalPresence.Request >= TCG_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION) {\r
       DataSize = sizeof (EFI_PHYSICAL_PRESENCE_FLAGS);\r
-      Status = mSmmVariable->SmmGetVariable (\r
-                               PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
-                               &gEfiPhysicalPresenceGuid,\r
-                               NULL,\r
-                               &DataSize,\r
-                               &Flags\r
-                               );\r
+      Status   = mSmmVariable->SmmGetVariable (\r
+                                 PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
+                                 &gEfiPhysicalPresenceGuid,\r
+                                 NULL,\r
+                                 &DataSize,\r
+                                 &Flags\r
+                                 );\r
       if (EFI_ERROR (Status)) {\r
         Flags.PPFlags = TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_PROVISION;\r
       }\r
+\r
       mTcgNvs->PhysicalPresence.ReturnCode = TcgPpVendorLibSubmitRequestToPreOSFunction (mTcgNvs->PhysicalPresence.Request, Flags.PPFlags);\r
     }\r
   } else if (mTcgNvs->PhysicalPresence.Parameter == ACPI_FUNCTION_GET_USER_CONFIRMATION_STATUS_FOR_REQUEST) {\r
@@ -127,17 +132,18 @@ PhysicalPresenceCallback (
       DEBUG ((DEBUG_ERROR, "[TPM] Get PP variable failure! Status = %r\n", Status));\r
       return EFI_SUCCESS;\r
     }\r
+\r
     //\r
     // Get the Physical Presence flags\r
     //\r
     DataSize = sizeof (EFI_PHYSICAL_PRESENCE_FLAGS);\r
-    Status = mSmmVariable->SmmGetVariable (\r
-                             PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
-                             &gEfiPhysicalPresenceGuid,\r
-                             NULL,\r
-                             &DataSize,\r
-                             &Flags\r
-                             );\r
+    Status   = mSmmVariable->SmmGetVariable (\r
+                               PHYSICAL_PRESENCE_FLAGS_VARIABLE,\r
+                               &gEfiPhysicalPresenceGuid,\r
+                               NULL,\r
+                               &DataSize,\r
+                               &Flags\r
+                               );\r
     if (EFI_ERROR (Status)) {\r
       mTcgNvs->PhysicalPresence.ReturnCode = TCG_PP_GET_USER_CONFIRMATION_BLOCKED_BY_BIOS_CONFIGURATION;\r
       DEBUG ((DEBUG_ERROR, "[TPM] Get PP flags failure! Status = %r\n", Status));\r
@@ -160,6 +166,7 @@ PhysicalPresenceCallback (
         if ((Flags.PPFlags & TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_PROVISION) != 0) {\r
           RequestConfirmed = TRUE;\r
         }\r
+\r
         break;\r
 \r
       case PHYSICAL_PRESENCE_CLEAR:\r
@@ -167,19 +174,22 @@ PhysicalPresenceCallback (
         if ((Flags.PPFlags & TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_CLEAR) != 0) {\r
           RequestConfirmed = TRUE;\r
         }\r
+\r
         break;\r
 \r
       case PHYSICAL_PRESENCE_DEFERRED_PP_UNOWNERED_FIELD_UPGRADE:\r
         if ((Flags.PPFlags & TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_MAINTENANCE) != 0) {\r
           RequestConfirmed = TRUE;\r
         }\r
+\r
         break;\r
 \r
       case PHYSICAL_PRESENCE_ENABLE_ACTIVATE_CLEAR_ENABLE_ACTIVATE:\r
       case PHYSICAL_PRESENCE_CLEAR_ENABLE_ACTIVATE:\r
-        if ((Flags.PPFlags & TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_CLEAR) != 0 && (Flags.PPFlags & TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_PROVISION) != 0) {\r
+        if (((Flags.PPFlags & TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_CLEAR) != 0) && ((Flags.PPFlags & TCG_BIOS_TPM_MANAGEMENT_FLAG_NO_PPI_PROVISION) != 0)) {\r
           RequestConfirmed = TRUE;\r
         }\r
+\r
         break;\r
 \r
       case PHYSICAL_PRESENCE_SET_NO_PPI_PROVISION_FALSE:\r
@@ -204,6 +214,7 @@ PhysicalPresenceCallback (
     } else {\r
       mTcgNvs->PhysicalPresence.ReturnCode = TCG_PP_GET_USER_CONFIRMATION_ALLOWED_AND_PPUSER_REQUIRED;\r
     }\r
+\r
     if (mTcgNvs->PhysicalPresence.Request >= TCG_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION) {\r
       mTcgNvs->PhysicalPresence.ReturnCode = TcgPpVendorLibGetUserConfirmationStatusFunction (mTcgNvs->PhysicalPresence.Request, Flags.PPFlags);\r
     }\r
@@ -212,7 +223,6 @@ PhysicalPresenceCallback (
   return EFI_SUCCESS;\r
 }\r
 \r
-\r
 /**\r
   Software SMI callback for MemoryClear which is called from ACPI method.\r
 \r
@@ -233,28 +243,28 @@ PhysicalPresenceCallback (
 EFI_STATUS\r
 EFIAPI\r
 MemoryClearCallback (\r
-  IN EFI_HANDLE                  DispatchHandle,\r
-  IN CONST VOID                  *Context,\r
-  IN OUT VOID                    *CommBuffer,\r
-  IN OUT UINTN                   *CommBufferSize\r
+  IN EFI_HANDLE  DispatchHandle,\r
+  IN CONST VOID  *Context,\r
+  IN OUT VOID    *CommBuffer,\r
+  IN OUT UINTN   *CommBufferSize\r
   )\r
 {\r
-  EFI_STATUS                     Status;\r
-  UINTN                          DataSize;\r
-  UINT8                          MorControl;\r
+  EFI_STATUS  Status;\r
+  UINTN       DataSize;\r
+  UINT8       MorControl;\r
 \r
   mTcgNvs->MemoryClear.ReturnCode = MOR_REQUEST_SUCCESS;\r
   if (mTcgNvs->MemoryClear.Parameter == ACPI_FUNCTION_DSM_MEMORY_CLEAR_INTERFACE) {\r
-    MorControl = (UINT8) mTcgNvs->MemoryClear.Request;\r
+    MorControl = (UINT8)mTcgNvs->MemoryClear.Request;\r
   } else if (mTcgNvs->MemoryClear.Parameter == ACPI_FUNCTION_PTS_CLEAR_MOR_BIT) {\r
     DataSize = sizeof (UINT8);\r
-    Status = mSmmVariable->SmmGetVariable (\r
-                             MEMORY_OVERWRITE_REQUEST_VARIABLE_NAME,\r
-                             &gEfiMemoryOverwriteControlDataGuid,\r
-                             NULL,\r
-                             &DataSize,\r
-                             &MorControl\r
-                             );\r
+    Status   = mSmmVariable->SmmGetVariable (\r
+                               MEMORY_OVERWRITE_REQUEST_VARIABLE_NAME,\r
+                               &gEfiMemoryOverwriteControlDataGuid,\r
+                               NULL,\r
+                               &DataSize,\r
+                               &MorControl\r
+                               );\r
     if (EFI_ERROR (Status)) {\r
       mTcgNvs->MemoryClear.ReturnCode = MOR_REQUEST_GENERAL_FAILURE;\r
       DEBUG ((DEBUG_ERROR, "[TPM] Get MOR variable failure! Status = %r\n", Status));\r
@@ -264,6 +274,7 @@ MemoryClearCallback (
     if (MOR_CLEAR_MEMORY_VALUE (MorControl) == 0x0) {\r
       return EFI_SUCCESS;\r
     }\r
+\r
     MorControl &= ~MOR_CLEAR_MEMORY_BIT_MASK;\r
   } else {\r
     mTcgNvs->MemoryClear.ReturnCode = MOR_REQUEST_GENERAL_FAILURE;\r
@@ -272,13 +283,13 @@ MemoryClearCallback (
   }\r
 \r
   DataSize = sizeof (UINT8);\r
-  Status = mSmmVariable->SmmSetVariable (\r
-                           MEMORY_OVERWRITE_REQUEST_VARIABLE_NAME,\r
-                           &gEfiMemoryOverwriteControlDataGuid,\r
-                           EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
-                           DataSize,\r
-                           &MorControl\r
-                           );\r
+  Status   = mSmmVariable->SmmSetVariable (\r
+                             MEMORY_OVERWRITE_REQUEST_VARIABLE_NAME,\r
+                             &gEfiMemoryOverwriteControlDataGuid,\r
+                             EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
+                             DataSize,\r
+                             &MorControl\r
+                             );\r
   if (EFI_ERROR (Status)) {\r
     mTcgNvs->MemoryClear.ReturnCode = MOR_REQUEST_GENERAL_FAILURE;\r
     DEBUG ((DEBUG_ERROR, "[TPM] Set MOR variable failure! Status = %r\n", Status));\r
@@ -300,38 +311,39 @@ MemoryClearCallback (
 **/\r
 VOID *\r
 AssignOpRegion (\r
-  EFI_ACPI_DESCRIPTION_HEADER    *Table,\r
-  UINT32                         Name,\r
-  UINT16                         Size\r
+  EFI_ACPI_DESCRIPTION_HEADER  *Table,\r
+  UINT32                       Name,\r
+  UINT16                       Size\r
   )\r
 {\r
-  EFI_STATUS                     Status;\r
-  AML_OP_REGION_32_8             *OpRegion;\r
-  EFI_PHYSICAL_ADDRESS           MemoryAddress;\r
+  EFI_STATUS            Status;\r
+  AML_OP_REGION_32_8    *OpRegion;\r
+  EFI_PHYSICAL_ADDRESS  MemoryAddress;\r
 \r
   MemoryAddress = SIZE_4GB - 1;\r
 \r
   //\r
   // Patch some pointers for the ASL code before loading the SSDT.\r
   //\r
-  for (OpRegion  = (AML_OP_REGION_32_8 *) (Table + 1);\r
-       OpRegion <= (AML_OP_REGION_32_8 *) ((UINT8 *) Table + Table->Length);\r
-       OpRegion  = (AML_OP_REGION_32_8 *) ((UINT8 *) OpRegion + 1)) {\r
+  for (OpRegion  = (AML_OP_REGION_32_8 *)(Table + 1);\r
+       OpRegion <= (AML_OP_REGION_32_8 *)((UINT8 *)Table + Table->Length);\r
+       OpRegion  = (AML_OP_REGION_32_8 *)((UINT8 *)OpRegion + 1))\r
+  {\r
     if ((OpRegion->OpRegionOp  == AML_EXT_REGION_OP) &&\r
         (OpRegion->NameString  == Name) &&\r
         (OpRegion->DWordPrefix == AML_DWORD_PREFIX) &&\r
-        (OpRegion->BytePrefix  == AML_BYTE_PREFIX)) {\r
-\r
-      Status = gBS->AllocatePages(AllocateMaxAddress, EfiACPIMemoryNVS, EFI_SIZE_TO_PAGES (Size), &MemoryAddress);\r
+        (OpRegion->BytePrefix  == AML_BYTE_PREFIX))\r
+    {\r
+      Status = gBS->AllocatePages (AllocateMaxAddress, EfiACPIMemoryNVS, EFI_SIZE_TO_PAGES (Size), &MemoryAddress);\r
       ASSERT_EFI_ERROR (Status);\r
       ZeroMem ((VOID *)(UINTN)MemoryAddress, Size);\r
-      OpRegion->RegionOffset = (UINT32) (UINTN) MemoryAddress;\r
-      OpRegion->RegionLen    = (UINT8) Size;\r
+      OpRegion->RegionOffset = (UINT32)(UINTN)MemoryAddress;\r
+      OpRegion->RegionLen    = (UINT8)Size;\r
       break;\r
     }\r
   }\r
 \r
-  return (VOID *) (UINTN) MemoryAddress;\r
+  return (VOID *)(UINTN)MemoryAddress;\r
 }\r
 \r
 /**\r
@@ -346,26 +358,25 @@ PublishAcpiTable (
   VOID\r
   )\r
 {\r
-  EFI_STATUS                     Status;\r
-  EFI_ACPI_TABLE_PROTOCOL        *AcpiTable;\r
-  UINTN                          TableKey;\r
-  EFI_ACPI_DESCRIPTION_HEADER    *Table;\r
-  UINTN                          TableSize;\r
+  EFI_STATUS                   Status;\r
+  EFI_ACPI_TABLE_PROTOCOL      *AcpiTable;\r
+  UINTN                        TableKey;\r
+  EFI_ACPI_DESCRIPTION_HEADER  *Table;\r
+  UINTN                        TableSize;\r
 \r
   Status = GetSectionFromFv (\r
              &gEfiCallerIdGuid,\r
              EFI_SECTION_RAW,\r
              0,\r
-             (VOID **) &Table,\r
+             (VOID **)&Table,\r
              &TableSize\r
              );\r
   ASSERT_EFI_ERROR (Status);\r
 \r
-\r
   //\r
   // Measure to PCR[0] with event EV_POST_CODE ACPI DATA\r
   //\r
-  TpmMeasureAndLogData(\r
+  TpmMeasureAndLogData (\r
     0,\r
     EV_POST_CODE,\r
     EV_POSTCODE_INFO_ACPI_DATA,\r
@@ -374,25 +385,24 @@ PublishAcpiTable (
     TableSize\r
     );\r
 \r
-\r
   ASSERT (Table->OemTableId == SIGNATURE_64 ('T', 'c', 'g', 'T', 'a', 'b', 'l', 'e'));\r
-  CopyMem (Table->OemId, PcdGetPtr (PcdAcpiDefaultOemId), sizeof (Table->OemId) );\r
-  mTcgNvs = AssignOpRegion (Table, SIGNATURE_32 ('T', 'N', 'V', 'S'), (UINT16) sizeof (TCG_NVS));\r
+  CopyMem (Table->OemId, PcdGetPtr (PcdAcpiDefaultOemId), sizeof (Table->OemId));\r
+  mTcgNvs = AssignOpRegion (Table, SIGNATURE_32 ('T', 'N', 'V', 'S'), (UINT16)sizeof (TCG_NVS));\r
   ASSERT (mTcgNvs != NULL);\r
 \r
   //\r
   // Publish the TPM ACPI table\r
   //\r
-  Status = gBS->LocateProtocol (&gEfiAcpiTableProtocolGuid, NULL, (VOID **) &AcpiTable);\r
+  Status = gBS->LocateProtocol (&gEfiAcpiTableProtocolGuid, NULL, (VOID **)&AcpiTable);\r
   ASSERT_EFI_ERROR (Status);\r
 \r
   TableKey = 0;\r
-  Status = AcpiTable->InstallAcpiTable (\r
-                        AcpiTable,\r
-                        Table,\r
-                        TableSize,\r
-                        &TableKey\r
-                        );\r
+  Status   = AcpiTable->InstallAcpiTable (\r
+                          AcpiTable,\r
+                          Table,\r
+                          TableSize,\r
+                          &TableKey\r
+                          );\r
   ASSERT_EFI_ERROR (Status);\r
 \r
   return Status;\r
@@ -414,8 +424,8 @@ PublishAcpiTable (
 EFI_STATUS\r
 EFIAPI\r
 InitializeTcgSmm (\r
-  IN EFI_HANDLE                  ImageHandle,\r
-  IN EFI_SYSTEM_TABLE            *SystemTable\r
+  IN EFI_HANDLE        ImageHandle,\r
+  IN EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
   EFI_STATUS                     Status;\r
@@ -423,7 +433,7 @@ InitializeTcgSmm (
   EFI_SMM_SW_REGISTER_CONTEXT    SwContext;\r
   EFI_HANDLE                     SwHandle;\r
 \r
-  if (!CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceTpm12Guid)){\r
+  if (!CompareGuid (PcdGetPtr (PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceTpm12Guid)) {\r
     DEBUG ((DEBUG_ERROR, "No TPM12 instance required!\n"));\r
     return EFI_UNSUPPORTED;\r
   }\r
@@ -434,28 +444,30 @@ InitializeTcgSmm (
   //\r
   // Get the Sw dispatch protocol and register SMI callback functions.\r
   //\r
-  Status = gSmst->SmmLocateProtocol (&gEfiSmmSwDispatch2ProtocolGuid, NULL, (VOID**)&SwDispatch);\r
+  Status = gSmst->SmmLocateProtocol (&gEfiSmmSwDispatch2ProtocolGuid, NULL, (VOID **)&SwDispatch);\r
   ASSERT_EFI_ERROR (Status);\r
-  SwContext.SwSmiInputValue = (UINTN) -1;\r
-  Status = SwDispatch->Register (SwDispatch, PhysicalPresenceCallback, &SwContext, &SwHandle);\r
+  SwContext.SwSmiInputValue = (UINTN)-1;\r
+  Status                    = SwDispatch->Register (SwDispatch, PhysicalPresenceCallback, &SwContext, &SwHandle);\r
   ASSERT_EFI_ERROR (Status);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
-  mTcgNvs->PhysicalPresence.SoftwareSmi = (UINT8) SwContext.SwSmiInputValue;\r
 \r
-  SwContext.SwSmiInputValue = (UINTN) -1;\r
-  Status = SwDispatch->Register (SwDispatch, MemoryClearCallback, &SwContext, &SwHandle);\r
+  mTcgNvs->PhysicalPresence.SoftwareSmi = (UINT8)SwContext.SwSmiInputValue;\r
+\r
+  SwContext.SwSmiInputValue = (UINTN)-1;\r
+  Status                    = SwDispatch->Register (SwDispatch, MemoryClearCallback, &SwContext, &SwHandle);\r
   ASSERT_EFI_ERROR (Status);\r
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
-  mTcgNvs->MemoryClear.SoftwareSmi = (UINT8) SwContext.SwSmiInputValue;\r
+\r
+  mTcgNvs->MemoryClear.SoftwareSmi = (UINT8)SwContext.SwSmiInputValue;\r
 \r
   //\r
   // Locate SmmVariableProtocol.\r
   //\r
-  Status = gSmst->SmmLocateProtocol (&gEfiSmmVariableProtocolGuid, NULL, (VOID**)&mSmmVariable);\r
+  Status = gSmst->SmmLocateProtocol (&gEfiSmmVariableProtocolGuid, NULL, (VOID **)&mSmmVariable);\r
   ASSERT_EFI_ERROR (Status);\r
 \r
   return EFI_SUCCESS;\r