]> git.proxmox.com Git - mirror_edk2.git/blobdiff - ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c
Add code to check whether the pointer 'CorrectedPath' and 'FullPath' are NULL before...
[mirror_edk2.git] / ShellPkg / Library / UefiShellLevel2CommandsLib / Ls.c
index 440d2450f5c068ef537564493fb66ab93f8841fe..63af5eab18884d216110df720440073607260719 100644 (file)
@@ -1,7 +1,8 @@
 /** @file\r
   Main file for ls shell level 2 function.\r
 \r
-  Copyright (c) 2009 - 2010, Intel Corporation. All rights reserved.<BR>\r
+  Copyright (c) 2013 Hewlett-Packard Development Company, L.P.\r
+  Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved.<BR>\r
   This program and the accompanying materials\r
   are licensed and made available under the terms and conditions of the BSD License\r
   which accompanies this distribution.  The full text of the license may be found at\r
 #include <Guid/FileSystemInfo.h>\r
 \r
 /**\r
-  print out the list of files and directories from the LS command\r
+  print out the standard format output volume entry.\r
 \r
-  @param[in] Rec            TRUE to automatically recurse into each found directory\r
-                            FALSE to only list the specified directory.\r
-  @param[in] Attribs        List of required Attribute for display.\r
-                            If 0 then all non-system and non-hidden files will be printed.\r
-  @param[in] Sfo            TRUE to use Standard Format Output, FALSE otherwise\r
-  @param[in] Path           String with starting path.\r
-  @param[in] First          TRUE for the original and FALSE for any recursion spawned instances.\r
-  @param[in] Count          The count of bits enabled in Attribs.\r
-  @param[in] TimeZone       The current time zone offset.\r
-\r
-  @retval SHELL_SUCCESS     the printing was sucessful.\r
+  @param[in] TheList           a list of files from the volume.\r
 **/\r
-SHELL_STATUS\r
+EFI_STATUS\r
 EFIAPI\r
-PrintLsOutput(\r
-  IN CONST BOOLEAN Rec,\r
-  IN CONST UINT64  Attribs,\r
-  IN CONST BOOLEAN Sfo,\r
-  IN CONST CHAR16  *Path,\r
-  IN CONST BOOLEAN First,\r
-  IN CONST UINTN   Count,\r
-  IN CONST INT16   TimeZone\r
+PrintSfoVolumeInfoTableEntry(\r
+  IN CONST EFI_SHELL_FILE_INFO *TheList\r
   )\r
 {\r
   EFI_STATUS            Status;\r
-  EFI_SHELL_FILE_INFO   *ListHead;\r
   EFI_SHELL_FILE_INFO   *Node;\r
-  SHELL_STATUS          ShellStatus;\r
-  UINT64                FileCount;\r
-  UINT64                DirCount;\r
-  UINT64                FileSize;\r
   CHAR16                *DirectoryName;\r
-  UINTN                 LongestPath;\r
   EFI_FILE_SYSTEM_INFO  *SysInfo;\r
   UINTN                 SysInfoSize;\r
   SHELL_FILE_HANDLE     ShellFileHandle;\r
-  CHAR16                *CorrectedPath;\r
   EFI_FILE_PROTOCOL     *EfiFpHandle;\r
 \r
-  FileCount     = 0;\r
-  DirCount      = 0;\r
-  FileSize      = 0;\r
-  ListHead      = NULL;\r
-  ShellStatus   = SHELL_SUCCESS;\r
-  LongestPath   = 0;\r
-  CorrectedPath = NULL;\r
+  //\r
+  // Get the first valid handle (directories)\r
+  //\r
+  for ( Node = (EFI_SHELL_FILE_INFO *)GetFirstNode(&TheList->Link)\r
+      ; !IsNull(&TheList->Link, &Node->Link) && Node->Handle == NULL\r
+      ; Node = (EFI_SHELL_FILE_INFO *)GetNextNode(&TheList->Link, &Node->Link)\r
+     );\r
 \r
-  CorrectedPath = StrnCatGrow(&CorrectedPath, NULL, Path, 0);\r
-  ASSERT(CorrectedPath != NULL);\r
-  ShellCommandCleanPath(CorrectedPath);\r
+  if (Node->Handle == NULL) {\r
+    DirectoryName = GetFullyQualifiedPath(((EFI_SHELL_FILE_INFO *)GetFirstNode(&TheList->Link))->FullName);\r
 \r
-  Status = ShellOpenFileMetaArg((CHAR16*)CorrectedPath, EFI_FILE_MODE_READ, &ListHead);\r
-  if (EFI_ERROR(Status)) {\r
-    return (SHELL_DEVICE_ERROR);\r
-  }\r
-  if (ListHead == NULL || IsListEmpty(&ListHead->Link)) {\r
     //\r
-    // On the first one only we expect to find something...\r
-    // do we find the . and .. directories otherwise?\r
+    // We need to open something up to get system information\r
     //\r
-    if (First) {\r
-      return (SHELL_NOT_FOUND);\r
-    }\r
-    return (SHELL_SUCCESS);\r
-  }\r
+    Status = gEfiShellProtocol->OpenFileByName(\r
+      DirectoryName,\r
+      &ShellFileHandle,\r
+      EFI_FILE_MODE_READ\r
+      );\r
+\r
+    ASSERT_EFI_ERROR(Status);\r
+    FreePool(DirectoryName);\r
 \r
-  if (Sfo && First) {\r
     //\r
-    // Get the first valid handle (directories)\r
+    // Get the Volume Info from ShellFileHandle\r
     //\r
-    for ( Node = (EFI_SHELL_FILE_INFO *)GetFirstNode(&ListHead->Link)\r
-        ; !IsNull(&ListHead->Link, &Node->Link) && Node->Handle == NULL\r
-        ; Node = (EFI_SHELL_FILE_INFO *)GetNextNode(&ListHead->Link, &Node->Link)\r
-       );\r
-\r
-    if (Node->Handle == NULL) {\r
-      DirectoryName = GetFullyQualifiedPath(((EFI_SHELL_FILE_INFO *)GetFirstNode(&ListHead->Link))->FullName);\r
-\r
-      //\r
-      // We need to open something up to get system information\r
-      //\r
-      Status = gEfiShellProtocol->OpenFileByName(\r
-        DirectoryName,\r
-        &ShellFileHandle,\r
-        EFI_FILE_MODE_READ);\r
-\r
-      ASSERT_EFI_ERROR(Status);\r
-      FreePool(DirectoryName);\r
-\r
-      //\r
-      // Get the Volume Info from ShellFileHandle\r
-      //\r
-      SysInfo     = NULL;\r
-      SysInfoSize = 0;\r
-      EfiFpHandle = ConvertShellHandleToEfiFileProtocol(ShellFileHandle);\r
+    SysInfo     = NULL;\r
+    SysInfoSize = 0;\r
+    EfiFpHandle = ConvertShellHandleToEfiFileProtocol(ShellFileHandle);\r
+    Status = EfiFpHandle->GetInfo(\r
+      EfiFpHandle,\r
+      &gEfiFileSystemInfoGuid,\r
+      &SysInfoSize,\r
+      SysInfo\r
+      );\r
+\r
+    if (Status == EFI_BUFFER_TOO_SMALL) {\r
+      SysInfo = AllocateZeroPool(SysInfoSize);\r
       Status = EfiFpHandle->GetInfo(\r
         EfiFpHandle,\r
         &gEfiFileSystemInfoGuid,\r
         &SysInfoSize,\r
-        SysInfo);\r
-\r
-      if (Status == EFI_BUFFER_TOO_SMALL) {\r
-        SysInfo = AllocateZeroPool(SysInfoSize);\r
-        Status = EfiFpHandle->GetInfo(\r
-          EfiFpHandle,\r
-          &gEfiFileSystemInfoGuid,\r
-          &SysInfoSize,\r
-          SysInfo);\r
-      }\r
+        SysInfo\r
+        );\r
+    }\r
 \r
-      ASSERT_EFI_ERROR(Status);\r
+    ASSERT_EFI_ERROR(Status);\r
 \r
-      gEfiShellProtocol->CloseFile(ShellFileHandle);\r
-    } else {\r
-      //\r
-      // Get the Volume Info from Node->Handle\r
-      //\r
-      SysInfo = NULL;\r
-      SysInfoSize = 0;\r
-      EfiFpHandle = ConvertShellHandleToEfiFileProtocol(Node->Handle);\r
+    gEfiShellProtocol->CloseFile(ShellFileHandle);\r
+  } else {\r
+    //\r
+    // Get the Volume Info from Node->Handle\r
+    //\r
+    SysInfo = NULL;\r
+    SysInfoSize = 0;\r
+    EfiFpHandle = ConvertShellHandleToEfiFileProtocol(Node->Handle);\r
+    Status = EfiFpHandle->GetInfo(\r
+      EfiFpHandle,\r
+      &gEfiFileSystemInfoGuid,\r
+      &SysInfoSize,\r
+      SysInfo\r
+      );\r
+\r
+    if (Status == EFI_BUFFER_TOO_SMALL) {\r
+      SysInfo = AllocateZeroPool(SysInfoSize);\r
       Status = EfiFpHandle->GetInfo(\r
         EfiFpHandle,\r
         &gEfiFileSystemInfoGuid,\r
         &SysInfoSize,\r
-        SysInfo);\r
-\r
-      if (Status == EFI_BUFFER_TOO_SMALL) {\r
-        SysInfo = AllocateZeroPool(SysInfoSize);\r
-        Status = EfiFpHandle->GetInfo(\r
-          EfiFpHandle,\r
-          &gEfiFileSystemInfoGuid,\r
-          &SysInfoSize,\r
-          SysInfo);\r
-      }\r
-\r
-      ASSERT_EFI_ERROR(Status);\r
+        SysInfo\r
+        );\r
     }\r
 \r
+    ASSERT_EFI_ERROR(Status);\r
+  }\r
+\r
+  ShellPrintHiiEx (\r
+    -1,\r
+    -1,\r
+    NULL,\r
+    STRING_TOKEN (STR_GEN_SFO_HEADER),\r
+    gShellLevel2HiiHandle,\r
+    L"ls"\r
+    );\r
+  //\r
+  // print VolumeInfo table\r
+  //\r
+  ASSERT(SysInfo != NULL);\r
+  ShellPrintHiiEx (\r
+    0,\r
+    gST->ConOut->Mode->CursorRow,\r
+    NULL,\r
+    STRING_TOKEN (STR_LS_SFO_VOLINFO),\r
+    gShellLevel2HiiHandle,\r
+    SysInfo->VolumeLabel,\r
+    SysInfo->VolumeSize,\r
+    SysInfo->ReadOnly?L"TRUE":L"FALSE",\r
+    SysInfo->FreeSpace,\r
+    SysInfo->BlockSize\r
+    );\r
+\r
+  SHELL_FREE_NON_NULL(SysInfo);\r
+\r
+  return (Status);\r
+}\r
+\r
+/**\r
+  print out the info on a single file.\r
+\r
+  @param[in] Sfo      TRUE if in SFO, false otherwise.\r
+  @param[in] TheNode  the EFI_SHELL_FILE_INFO node to print out information on.\r
+  @param[in] Files    incremented if a file is printed.\r
+  @param[in] Size     incremented by file size.\r
+  @param[in] Dirs     incremented if a directory is printed.\r
+\r
+**/\r
+VOID\r
+EFIAPI\r
+PrintFileInformation(\r
+  IN CONST BOOLEAN              Sfo, \r
+  IN CONST EFI_SHELL_FILE_INFO  *TheNode, \r
+  IN UINT64                     *Files, \r
+  IN UINT64                     *Size, \r
+  IN UINT64                     *Dirs\r
+  )\r
+{\r
+  ASSERT(Files    != NULL);\r
+  ASSERT(Size     != NULL);\r
+  ASSERT(Dirs     != NULL);\r
+  ASSERT(TheNode  != NULL);\r
+\r
+  if (Sfo) {\r
+    //\r
+    // Print the FileInfo Table\r
+    //\r
     ShellPrintHiiEx (\r
-      -1,\r
-      -1,\r
+      0,\r
+      gST->ConOut->Mode->CursorRow,\r
       NULL,\r
-      STRING_TOKEN (STR_GEN_SFO_HEADER),\r
+      STRING_TOKEN (STR_LS_SFO_FILEINFO),\r
       gShellLevel2HiiHandle,\r
-      L"ls");\r
+      TheNode->FullName,\r
+      TheNode->Info->FileSize,\r
+      TheNode->Info->PhysicalSize,\r
+      (TheNode->Info->Attribute & EFI_FILE_ARCHIVE)   != 0?L"a":L"",\r
+      (TheNode->Info->Attribute & EFI_FILE_DIRECTORY) != 0?L"d":L"",\r
+      (TheNode->Info->Attribute & EFI_FILE_HIDDEN)    != 0?L"h":L"",\r
+      (TheNode->Info->Attribute & EFI_FILE_READ_ONLY) != 0?L"r":L"",\r
+      (TheNode->Info->Attribute & EFI_FILE_SYSTEM)    != 0?L"s":L"",\r
+      TheNode->Info->CreateTime.Hour,\r
+      TheNode->Info->CreateTime.Minute,\r
+      TheNode->Info->CreateTime.Second,\r
+      TheNode->Info->CreateTime.Day,\r
+      TheNode->Info->CreateTime.Month,\r
+      TheNode->Info->CreateTime.Year,\r
+      TheNode->Info->LastAccessTime.Hour,\r
+      TheNode->Info->LastAccessTime.Minute,\r
+      TheNode->Info->LastAccessTime.Second,\r
+      TheNode->Info->LastAccessTime.Day,\r
+      TheNode->Info->LastAccessTime.Month,\r
+      TheNode->Info->LastAccessTime.Year,\r
+      TheNode->Info->ModificationTime.Hour,\r
+      TheNode->Info->ModificationTime.Minute,\r
+      TheNode->Info->ModificationTime.Second,\r
+      TheNode->Info->ModificationTime.Day,\r
+      TheNode->Info->ModificationTime.Month,\r
+      TheNode->Info->ModificationTime.Year\r
+      );\r
+  } else {\r
     //\r
-    // print VolumeInfo table\r
+    // print this one out...\r
+    // first print the universal start, next print the type specific name format, last print the CRLF\r
     //\r
-    ASSERT(SysInfo != NULL);\r
     ShellPrintHiiEx (\r
-      0,\r
-      gST->ConOut->Mode->CursorRow,\r
+      -1,\r
+      -1,\r
       NULL,\r
-      STRING_TOKEN (STR_LS_SFO_VOLINFO),\r
+      STRING_TOKEN (STR_LS_LINE_START_ALL),\r
       gShellLevel2HiiHandle,\r
-      SysInfo->VolumeLabel,\r
-      SysInfo->VolumeSize,\r
-      SysInfo->ReadOnly?L"TRUE":L"FALSE",\r
-      SysInfo->FreeSpace,\r
-      SysInfo->BlockSize\r
-     );\r
-    if (SysInfo != NULL) {\r
-      FreePool(SysInfo);\r
+      &TheNode->Info->ModificationTime,\r
+      (TheNode->Info->Attribute & EFI_FILE_DIRECTORY) != 0?L"<DIR>":L"",\r
+      (TheNode->Info->Attribute & EFI_FILE_READ_ONLY) != 0?L'r':L' ',\r
+      TheNode->Info->FileSize\r
+      );\r
+    if (TheNode->Info->Attribute & EFI_FILE_DIRECTORY) {\r
+      (*Dirs)++;\r
+      ShellPrintHiiEx (\r
+        -1,\r
+        -1,\r
+        NULL,\r
+        STRING_TOKEN (STR_LS_LINE_END_DIR),\r
+        gShellLevel2HiiHandle,\r
+        TheNode->FileName\r
+        );\r
+    } else {\r
+      (*Files)++;\r
+      (*Size) += TheNode->Info->FileSize;\r
+      if ( (gUnicodeCollation->StriColl(gUnicodeCollation, (CHAR16*)L".nsh", (CHAR16*)&(TheNode->FileName[StrLen (TheNode->FileName) - 4])) == 0)\r
+        || (gUnicodeCollation->StriColl(gUnicodeCollation, (CHAR16*)L".efi", (CHAR16*)&(TheNode->FileName[StrLen (TheNode->FileName) - 4])) == 0)\r
+       ){\r
+        ShellPrintHiiEx (\r
+          -1,\r
+          -1,\r
+          NULL,\r
+          STRING_TOKEN (STR_LS_LINE_END_EXE),\r
+          gShellLevel2HiiHandle,\r
+          TheNode->FileName\r
+          );\r
+      } else {\r
+        ShellPrintHiiEx (\r
+          -1,\r
+          -1,\r
+          NULL,\r
+          STRING_TOKEN (STR_LS_LINE_END_FILE),\r
+          gShellLevel2HiiHandle,\r
+          TheNode->FileName\r
+          );\r
+      }\r
     }\r
   }\r
+}\r
 \r
-  if (!Sfo) {\r
-    //\r
-    // get directory name from path...\r
-    //\r
-    DirectoryName = GetFullyQualifiedPath(CorrectedPath);\r
+/**\r
+  print out the header when not using standard format output.\r
+\r
+  @param[in] Path           String with starting path.\r
+**/\r
+VOID\r
+EFIAPI\r
+PrintNonSfoHeader(\r
+  IN CONST CHAR16 *Path\r
+  )\r
+{\r
+  CHAR16 *DirectoryName;\r
 \r
+  //\r
+  // get directory name from path...\r
+  //\r
+  DirectoryName = GetFullyQualifiedPath(Path);\r
+\r
+  if (DirectoryName != NULL) {\r
     //\r
     // print header\r
     //\r
@@ -200,163 +286,194 @@ PrintLsOutput(
       STRING_TOKEN (STR_LS_HEADER_LINE1),\r
       gShellLevel2HiiHandle,\r
       DirectoryName\r
-     );\r
-    FreePool(DirectoryName);\r
+      );\r
+\r
+    SHELL_FREE_NON_NULL(DirectoryName);\r
+  }\r
+}\r
+\r
+/**\r
+  print out the footer when not using standard format output.\r
+\r
+  @param[in] Files            The number of files.\r
+  @param[in] Size             The size of files in bytes.\r
+  @param[in] Dirs             The number of directories.\r
+**/\r
+VOID\r
+EFIAPI\r
+PrintNonSfoFooter(\r
+  IN UINT64                     Files, \r
+  IN UINT64                     Size, \r
+  IN UINT64                     Dirs\r
+  )\r
+{\r
+  //\r
+  // print footer\r
+  //\r
+  ShellPrintHiiEx (\r
+    -1,\r
+    -1,\r
+    NULL,\r
+    STRING_TOKEN (STR_LS_FOOTER_LINE),\r
+    gShellLevel2HiiHandle,\r
+    Files,\r
+    Size,\r
+    Dirs\r
+   );\r
+}\r
+\r
+/**\r
+  print out the list of files and directories from the LS command\r
+\r
+  @param[in] Rec            TRUE to automatically recurse into each found directory\r
+                            FALSE to only list the specified directory.\r
+  @param[in] Attribs        List of required Attribute for display.\r
+                            If 0 then all non-system and non-hidden files will be printed.\r
+  @param[in] Sfo            TRUE to use Standard Format Output, FALSE otherwise\r
+  @param[in] RootPath       String with starting path to search in.\r
+  @param[in] SearchString   String with search string.\r
+  @param[in] Found          Set to TRUE, if anyone were found.\r
+  @param[in] Count          The count of bits enabled in Attribs.\r
+  @param[in] TimeZone       The current time zone offset.\r
+\r
+  @retval SHELL_SUCCESS     the printing was sucessful.\r
+**/\r
+SHELL_STATUS\r
+EFIAPI\r
+PrintLsOutput(\r
+  IN CONST BOOLEAN Rec,\r
+  IN CONST UINT64  Attribs,\r
+  IN CONST BOOLEAN Sfo,\r
+  IN CONST CHAR16  *RootPath,\r
+  IN CONST CHAR16  *SearchString,\r
+  IN       BOOLEAN *Found,\r
+  IN CONST UINTN   Count,\r
+  IN CONST INT16   TimeZone\r
+  )\r
+{\r
+  EFI_STATUS            Status;\r
+  EFI_SHELL_FILE_INFO   *ListHead;\r
+  EFI_SHELL_FILE_INFO   *Node;\r
+  SHELL_STATUS          ShellStatus;\r
+  UINT64                FileCount;\r
+  UINT64                DirCount;\r
+  UINT64                FileSize;\r
+  UINTN                 LongestPath;\r
+  CHAR16                *CorrectedPath;\r
+  BOOLEAN               FoundOne;\r
+  BOOLEAN               HeaderPrinted;\r
+\r
+  HeaderPrinted = FALSE;\r
+  FileCount     = 0;\r
+  DirCount      = 0;\r
+  FileSize      = 0;\r
+  ListHead      = NULL;\r
+  ShellStatus   = SHELL_SUCCESS;\r
+  LongestPath   = 0;\r
+  CorrectedPath = NULL;\r
+\r
+  if (Found != NULL) {\r
+    FoundOne = *Found;\r
+  } else {\r
+    FoundOne = FALSE;\r
   }\r
-  for ( Node = (EFI_SHELL_FILE_INFO *)GetFirstNode(&ListHead->Link)\r
-      ; !IsNull(&ListHead->Link, &Node->Link)\r
-      ; Node = (EFI_SHELL_FILE_INFO *)GetNextNode(&ListHead->Link, &Node->Link)\r
-     ){\r
-    ASSERT(Node != NULL);\r
-    if (LongestPath < StrSize(Node->FullName)) {\r
-      LongestPath = StrSize(Node->FullName);\r
+\r
+  CorrectedPath = StrnCatGrow(&CorrectedPath, &LongestPath, RootPath,     0);\r
+  if (CorrectedPath == NULL) {\r
+    return SHELL_OUT_OF_RESOURCES;\r
+  }\r
+  if (CorrectedPath[StrLen(CorrectedPath)-1] != L'\\'\r
+    &&CorrectedPath[StrLen(CorrectedPath)-1] != L'/') {\r
+    CorrectedPath = StrnCatGrow(&CorrectedPath, &LongestPath, L"\\",     0);\r
+  }\r
+  CorrectedPath = StrnCatGrow(&CorrectedPath, &LongestPath, SearchString, 0);\r
+  if (CorrectedPath == NULL) {\r
+    return (SHELL_OUT_OF_RESOURCES);\r
+  }\r
+\r
+  PathCleanUpDirectories(CorrectedPath);\r
+\r
+  Status = ShellOpenFileMetaArg((CHAR16*)CorrectedPath, EFI_FILE_MODE_READ, &ListHead);\r
+  if (!EFI_ERROR(Status)) {\r
+    if (ListHead == NULL || IsListEmpty(&ListHead->Link)) {\r
+      SHELL_FREE_NON_NULL(CorrectedPath);\r
+      return (SHELL_SUCCESS);\r
     }\r
-    ASSERT(Node->Info != NULL);\r
-    ASSERT((Node->Info->Attribute & EFI_FILE_VALID_ATTR) == Node->Info->Attribute);\r
-    if (Attribs == 0) {\r
-      //\r
-      // NOT system & NOT hidden\r
-      //\r
-      if ( (Node->Info->Attribute & EFI_FILE_SYSTEM)\r
-        || (Node->Info->Attribute & EFI_FILE_HIDDEN)\r
-       ){\r
-        continue;\r
+\r
+    if (Sfo && Found == NULL) {\r
+      PrintSfoVolumeInfoTableEntry(ListHead);\r
+    }\r
+\r
+    for ( Node = (EFI_SHELL_FILE_INFO *)GetFirstNode(&ListHead->Link), LongestPath = 0\r
+        ; !IsNull(&ListHead->Link, &Node->Link)\r
+        ; Node = (EFI_SHELL_FILE_INFO *)GetNextNode(&ListHead->Link, &Node->Link)\r
+        ){\r
+      ASSERT(Node != NULL);\r
+      if (LongestPath < StrSize(Node->FullName)) {\r
+        LongestPath = StrSize(Node->FullName);\r
       }\r
-    } else if (Attribs != EFI_FILE_VALID_ATTR) {\r
-      if (Count == 1) {\r
+      ASSERT(Node->Info != NULL);\r
+      ASSERT((Node->Info->Attribute & EFI_FILE_VALID_ATTR) == Node->Info->Attribute);\r
+      if (Attribs == 0) {\r
         //\r
-        // the bit must match\r
+        // NOT system & NOT hidden\r
         //\r
-        if ( (Node->Info->Attribute & Attribs) != Attribs) {\r
+        if ( (Node->Info->Attribute & EFI_FILE_SYSTEM)\r
+          || (Node->Info->Attribute & EFI_FILE_HIDDEN)\r
+         ){\r
           continue;\r
         }\r
-      } else {\r
+      } else if ((Attribs != EFI_FILE_VALID_ATTR) ||\r
+                 (Count == 5)) {\r
         //\r
-        // exact match on all bits\r
+        // Only matches the bits which "Attribs" contains, not\r
+        // all files/directories with any of the bits.\r
+        // Count == 5 is used to tell the difference between a user\r
+        // specifying all bits (EX: -arhsda) and just specifying\r
+        // -a (means display all files with any attribute).\r
         //\r
-        if ( Node->Info->Attribute != Attribs) {\r
+        if ( (Node->Info->Attribute & Attribs) != Attribs) {\r
           continue;\r
         }\r
       }\r
-    }\r
 \r
-    if (Sfo) {\r
-      //\r
-      // Print the FileInfo Table\r
-      //\r
-    ShellPrintHiiEx (\r
-      0,\r
-      gST->ConOut->Mode->CursorRow,\r
-      NULL,\r
-      STRING_TOKEN (STR_LS_SFO_FILEINFO),\r
-      gShellLevel2HiiHandle,\r
-      Node->FullName,\r
-      Node->Info->FileSize,\r
-      Node->Info->PhysicalSize,\r
-      (Node->Info->Attribute & EFI_FILE_ARCHIVE)   != 0?L"a":L"",\r
-      (Node->Info->Attribute & EFI_FILE_DIRECTORY) != 0?L"d":L"",\r
-      (Node->Info->Attribute & EFI_FILE_HIDDEN)    != 0?L"h":L"",\r
-      (Node->Info->Attribute & EFI_FILE_READ_ONLY) != 0?L"r":L"",\r
-      (Node->Info->Attribute & EFI_FILE_SYSTEM)    != 0?L"s":L"",\r
-      Node->Info->CreateTime.Hour,\r
-      Node->Info->CreateTime.Minute,\r
-      Node->Info->CreateTime.Second,\r
-      Node->Info->CreateTime.Day,\r
-      Node->Info->CreateTime.Month,\r
-      Node->Info->CreateTime.Year,\r
-      Node->Info->LastAccessTime.Hour,\r
-      Node->Info->LastAccessTime.Minute,\r
-      Node->Info->LastAccessTime.Second,\r
-      Node->Info->LastAccessTime.Day,\r
-      Node->Info->LastAccessTime.Month,\r
-      Node->Info->LastAccessTime.Year,\r
-      Node->Info->ModificationTime.Hour,\r
-      Node->Info->ModificationTime.Minute,\r
-      Node->Info->ModificationTime.Second,\r
-      Node->Info->ModificationTime.Day,\r
-      Node->Info->ModificationTime.Month,\r
-      Node->Info->ModificationTime.Year\r
-     );\r
-    } else {\r
-      //\r
-      // print this one out...\r
-      // first print the universal start, next print the type specific name format, last print the CRLF\r
-      //\r
-      ShellPrintHiiEx (\r
-        -1,\r
-        -1,\r
-        NULL,\r
-        STRING_TOKEN (STR_LS_LINE_START_ALL),\r
-        gShellLevel2HiiHandle,\r
-        &Node->Info->ModificationTime,\r
-        (Node->Info->Attribute & EFI_FILE_DIRECTORY) != 0?L"<DIR>":L"",\r
-        (Node->Info->Attribute & EFI_FILE_READ_ONLY) != 0?L'r':L' ',\r
-        Node->Info->FileSize\r
-       );\r
-      if (Node->Info->Attribute & EFI_FILE_DIRECTORY) {\r
-        DirCount++;\r
-        ShellPrintHiiEx (\r
-          -1,\r
-          -1,\r
-          NULL,\r
-          STRING_TOKEN (STR_LS_LINE_END_DIR),\r
-          gShellLevel2HiiHandle,\r
-          Node->FileName\r
-         );\r
-      } else {\r
-        FileCount++;\r
-        FileSize += Node->Info->FileSize;\r
-        if ( (gUnicodeCollation->StriColl(gUnicodeCollation, (CHAR16*)L".nsh", (CHAR16*)&(Node->FileName[StrLen (Node->FileName) - 4])) == 0)\r
-          || (gUnicodeCollation->StriColl(gUnicodeCollation, (CHAR16*)L".efi", (CHAR16*)&(Node->FileName[StrLen (Node->FileName) - 4])) == 0)\r
-         ){\r
-          ShellPrintHiiEx (\r
-            -1,\r
-            -1,\r
-            NULL,\r
-            STRING_TOKEN (STR_LS_LINE_END_EXE),\r
-            gShellLevel2HiiHandle,\r
-            Node->FileName\r
-           );\r
-        } else {\r
-          ShellPrintHiiEx (\r
-            -1,\r
-            -1,\r
-            NULL,\r
-            STRING_TOKEN (STR_LS_LINE_END_FILE),\r
-            gShellLevel2HiiHandle,\r
-            Node->FileName\r
-           );\r
-        }\r
+      if (!Sfo && HeaderPrinted == FALSE) {\r
+        PrintNonSfoHeader(CorrectedPath);\r
       }\r
+      PrintFileInformation(Sfo, Node, &FileCount, &FileSize, &DirCount);\r
+      FoundOne = TRUE;\r
+      HeaderPrinted = TRUE;\r
+    }\r
+\r
+    if (!Sfo) {\r
+      PrintNonSfoFooter(FileCount, FileSize, DirCount);\r
     }\r
   }\r
 \r
-  if (!Sfo) {\r
+  if (Rec) {\r
     //\r
-    // print footer\r
+    // Re-Open all the files under the starting path for directories that didnt necessarily match our file filter\r
     //\r
-    ShellPrintHiiEx (\r
-      -1,\r
-      -1,\r
-      NULL,\r
-      STRING_TOKEN (STR_LS_FOOTER_LINE),\r
-      gShellLevel2HiiHandle,\r
-      FileCount,\r
-      FileSize,\r
-      DirCount\r
-     );\r
-  }\r
-\r
-  if (Rec){\r
-    DirectoryName = AllocatePool(LongestPath + 2*sizeof(CHAR16));\r
-    if (DirectoryName == NULL) {\r
-      ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_NO_MEM), gShellLevel2HiiHandle);\r
-      ShellStatus = SHELL_OUT_OF_RESOURCES;\r
-    } else {\r
+    ShellCloseFileMetaArg(&ListHead);\r
+    CorrectedPath[0] = CHAR_NULL;\r
+    CorrectedPath = StrnCatGrow(&CorrectedPath, &LongestPath, RootPath, 0);\r
+    if (CorrectedPath[StrLen(CorrectedPath)-1] != L'\\'\r
+      &&CorrectedPath[StrLen(CorrectedPath)-1] != L'/') {\r
+      CorrectedPath = StrnCatGrow(&CorrectedPath, &LongestPath, L"\\",     0);\r
+    }\r
+    CorrectedPath = StrnCatGrow(&CorrectedPath, &LongestPath, L"*",     0);\r
+    Status = ShellOpenFileMetaArg((CHAR16*)CorrectedPath, EFI_FILE_MODE_READ, &ListHead);\r
+   \r
+    if (!EFI_ERROR(Status)) {\r
       for ( Node = (EFI_SHELL_FILE_INFO *)GetFirstNode(&ListHead->Link)\r
-          ; !IsNull(&ListHead->Link, &Node->Link)\r
+          ; !IsNull(&ListHead->Link, &Node->Link) && ShellStatus == SHELL_SUCCESS\r
           ; Node = (EFI_SHELL_FILE_INFO *)GetNextNode(&ListHead->Link, &Node->Link)\r
          ){\r
+        if (ShellGetExecutionBreakFlag ()) {\r
+          ShellStatus = SHELL_ABORTED;\r
+          break;\r
+        }\r
+\r
         //\r
         // recurse on any directory except the traversing ones...\r
         //\r
@@ -364,25 +481,31 @@ PrintLsOutput(
           && StrCmp(Node->FileName, L".") != 0\r
           && StrCmp(Node->FileName, L"..") != 0\r
          ){\r
-          StrCpy(DirectoryName, Node->FullName);\r
-          StrCat(DirectoryName, L"\\*");\r
-          PrintLsOutput(\r
+          ShellStatus = PrintLsOutput(\r
             Rec,\r
             Attribs,\r
             Sfo,\r
-            DirectoryName,\r
-            FALSE,\r
+            Node->FullName,\r
+            SearchString,\r
+            &FoundOne,\r
             Count,\r
             TimeZone);\r
         }\r
       }\r
-      FreePool(DirectoryName);\r
     }\r
   }\r
 \r
-  FreePool(CorrectedPath);\r
+  SHELL_FREE_NON_NULL(CorrectedPath);\r
   ShellCloseFileMetaArg(&ListHead);\r
-  FreePool(ListHead);\r
+\r
+  if (Found == NULL && FoundOne == FALSE) {\r
+    return (SHELL_NOT_FOUND);\r
+  }\r
+\r
+  if (Found != NULL) {\r
+    *Found = FoundOne;\r
+  }\r
+\r
   return (ShellStatus);\r
 }\r
 \r
@@ -417,8 +540,8 @@ ShellCommandRunLs (
   UINTN         Count;\r
   CHAR16        *FullPath;\r
   UINTN         Size;\r
-  EFI_TIME      theTime;\r
-  BOOLEAN       SfoMode;\r
+  EFI_TIME      TheTime;\r
+  CHAR16        *SearchString;\r
 \r
   Size                = 0;\r
   FullPath            = NULL;\r
@@ -427,6 +550,7 @@ ShellCommandRunLs (
   ShellStatus         = SHELL_SUCCESS;\r
   RequiredAttributes  = 0;\r
   PathName            = NULL;\r
+  SearchString        = NULL;\r
   CurDir              = NULL;\r
   Count               = 0;\r
 \r
@@ -516,39 +640,87 @@ ShellCommandRunLs (
       if (ShellStatus == SHELL_SUCCESS) {\r
         PathName = ShellCommandLineGetRawValue(Package, 1);\r
         if (PathName == NULL) {\r
+          //\r
+          // Nothing specified... must start from current directory\r
+          //\r
           CurDir = gEfiShellProtocol->GetCurDir(NULL);\r
           if (CurDir == NULL) {\r
             ShellStatus = SHELL_NOT_FOUND;\r
             ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_NO_CWD), gShellLevel2HiiHandle);\r
           }\r
-        }\r
-        if (PathName != NULL) {\r
-          ASSERT((FullPath == NULL && Size == 0) || (FullPath != NULL));\r
-          StrnCatGrow(&FullPath, &Size, PathName, 0);\r
-          if  (ShellIsDirectory(PathName) == EFI_SUCCESS) {\r
-            StrnCatGrow(&FullPath, &Size, L"\\*", 0);\r
-          }\r
-        } else {\r
+          //\r
+          // Copy to the 2 strings for starting path and file search string\r
+          //\r
+          ASSERT(SearchString == NULL);\r
           ASSERT(FullPath == NULL);\r
-          StrnCatGrow(&FullPath, NULL, L"*", 0);\r
+          StrnCatGrow(&SearchString, NULL, L"*", 0);\r
+          StrnCatGrow(&FullPath, NULL, CurDir, 0);\r
+        } else {\r
+          if (StrStr(PathName, L":") == NULL && gEfiShellProtocol->GetCurDir(NULL) == NULL) {\r
+            //\r
+            // If we got something and it doesnt have a fully qualified path, then we needed to have a CWD.\r
+            //\r
+            ShellStatus = SHELL_NOT_FOUND;\r
+            ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_NO_CWD), gShellLevel2HiiHandle);\r
+          } else {\r
+            //\r
+            // We got a valid fully qualified path or we have a CWD\r
+            //\r
+            ASSERT((FullPath == NULL && Size == 0) || (FullPath != NULL));\r
+            if (StrStr(PathName, L":") == NULL) {\r
+              StrnCatGrow(&FullPath, &Size, gEfiShellProtocol->GetCurDir(NULL), 0);\r
+              if (FullPath == NULL) {\r
+                ShellCommandLineFreeVarList (Package);\r
+                return SHELL_OUT_OF_RESOURCES;\r
+              }\r
+            }\r
+            StrnCatGrow(&FullPath, &Size, PathName, 0);\r
+            if (FullPath == NULL) {\r
+                ShellCommandLineFreeVarList (Package);\r
+                return SHELL_OUT_OF_RESOURCES;\r
+            }\r
+               \r
+            if  (ShellIsDirectory(PathName) == EFI_SUCCESS) {\r
+              //\r
+              // is listing ends with a directory, then we list all files in that directory\r
+              //\r
+              StrnCatGrow(&SearchString, NULL, L"*", 0);\r
+            } else {\r
+              //\r
+              // must split off the search part that applies to files from the end of the directory part\r
+              //\r
+              for (StrnCatGrow(&SearchString, NULL, PathName, 0)\r
+                ; SearchString != NULL && StrStr(SearchString, L"\\") != NULL\r
+                ; CopyMem(SearchString, StrStr(SearchString, L"\\") + 1, 1 + StrSize(StrStr(SearchString, L"\\") + 1))) ;\r
+              FullPath[StrLen(FullPath) - StrLen(SearchString)] = CHAR_NULL;\r
+            }\r
+          }\r
         }\r
-        Status = gRT->GetTime(&theTime, NULL);\r
-        ASSERT_EFI_ERROR(Status);\r
-        SfoMode = ShellCommandLineGetFlag(Package, L"-sfo");\r
+        Status = gRT->GetTime(&TheTime, NULL);\r
+        if (EFI_ERROR(Status)) {\r
+          ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_UEFI_FUNC_WARN), gShellLevel2HiiHandle, L"gRT->GetTime", Status);\r
+          TheTime.TimeZone = EFI_UNSPECIFIED_TIMEZONE;\r
+        }\r
+\r
         if (ShellStatus == SHELL_SUCCESS) {\r
           ShellStatus = PrintLsOutput(\r
             ShellCommandLineGetFlag(Package, L"-r"),\r
             RequiredAttributes,\r
-            SfoMode,\r
+            ShellCommandLineGetFlag(Package, L"-sfo"),\r
             FullPath,\r
-            TRUE,\r
+            SearchString,\r
+            NULL,\r
             Count,\r
-            (INT16)(theTime.TimeZone==2047?0:theTime.TimeZone)\r
+            (INT16)(TheTime.TimeZone==EFI_UNSPECIFIED_TIMEZONE?0:TheTime.TimeZone)\r
            );\r
           if (ShellStatus == SHELL_NOT_FOUND) {\r
-            ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_NO_FILES), gShellLevel2HiiHandle);\r
+            ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_LS_FILE_NOT_FOUND), gShellLevel2HiiHandle);\r
           } else if (ShellStatus == SHELL_INVALID_PARAMETER) {\r
             ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PARAM_INV), gShellLevel2HiiHandle);\r
+          } else if (ShellStatus == SHELL_ABORTED) {\r
+            //\r
+            // Ignore aborting.\r
+            //\r
           } else if (ShellStatus != SHELL_SUCCESS) {\r
             ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PARAM_INV), gShellLevel2HiiHandle);\r
           }\r
@@ -557,12 +729,11 @@ ShellCommandRunLs (
     }\r
   }\r
 \r
-  if (FullPath != NULL) {\r
-    FreePool(FullPath);\r
-  }\r
   //\r
-  // free the command line package\r
+  // Free memory allocated\r
   //\r
+  SHELL_FREE_NON_NULL(SearchString);\r
+  SHELL_FREE_NON_NULL(FullPath);\r
   ShellCommandLineFreeVarList (Package);\r
 \r
   return (ShellStatus);\r