Modify code according suggestion from code review meeting.

[mirror_edk2.git] / Tools / Source / GenBuild / org / tianocore / build / autogen / AutogenLibOrder.java

diff --git a/Tools/Source/GenBuild/org/tianocore/build/autogen/AutogenLibOrder.java b/Tools/Source/GenBuild/org/tianocore/build/autogen/AutogenLibOrder.java
index 403b8c32eec8b6a36b769467f10dc70cc742301f..9fb7a43ce9bde3eb77e1b0431a3e34e8d36a5843 100644 (file)
--- a/Tools/Source/GenBuild/org/tianocore/build/autogen/AutogenLibOrder.java
+++ b/Tools/Source/GenBuild/org/tianocore/build/autogen/AutogenLibOrder.java
@@ -22,7 +22,6 @@ import java.util.List;
 import java.util.Map;\r
 \r
 import org.apache.xmlbeans.XmlObject;\r
-\r
 import org.tianocore.build.global.GlobalData;\r
 import org.tianocore.build.global.SurfaceAreaQuery;\r
 import org.tianocore.build.id.ModuleIdentification;\r
@@ -75,7 +74,7 @@ public class AutogenLibOrder {
             // libInstanceMap.\r
             //\r
             libClassConsmList = SurfaceAreaQuery\r
-                    .getLibraryClasses(CommonDefinition.AlwaysConsumed, arch);\r
+                    .getLibraryClasses(CommonDefinition.ALWAYSCONSUMED, arch);\r
             if (libClassConsmList != null) {\r
                 String[] classStr = new String[libClassConsmList.length];\r
                 for (int k = 0; k < libClassConsmList.length; k++) {\r
@@ -94,7 +93,7 @@ public class AutogenLibOrder {
             // Add library class and library instance map.\r
             //\r
             libClassDeclList = SurfaceAreaQuery\r
-                    .getLibraryClasses(CommonDefinition.AlwaysProduced, arch);\r
+                    .getLibraryClasses(CommonDefinition.ALWAYSPRODUCED, arch);\r
             if (libClassDeclList != null) {\r
                 for (int j = 0; j < libClassDeclList.length; j++) {\r
                     if (this.libClassMap.containsKey(libClassDeclList[j])) {\r
@@ -114,12 +113,12 @@ public class AutogenLibOrder {
         //\r
         // Check is the library instance list meet the require;\r
         //\r
-        for (int s = 0; s < this.libInstanceList.size(); s++) {\r
-            String[] libClass = this.libInstanceMap.get(this.libInstanceList\r
-                    .get(s));\r
-            if (libClass != null) {\r
-                for (int t = 0; t < libClass.length; t++) {\r
-                    if (this.libClassMap.get(libClass[t]) == null) {\r
+        //for (int s = 0; s < this.libInstanceList.size(); s++) {\r
+        //    String[] libClass = this.libInstanceMap.get(this.libInstanceList\r
+        //            .get(s));\r
+        //    if (libClass != null) {\r
+        //        for (int t = 0; t < libClass.length; t++) {\r
+        //            if (this.libClassMap.get(libClass[t]) == null) {\r
                         //\r
                         // Note: There exist a kind of module which depend on \r
                         // library class with no instance or whose instance will\r
@@ -130,10 +129,10 @@ public class AutogenLibOrder {
                         // will be a warnig message given here after a standard \r
                         // log way has been decided.\r
                         //\r
-                    }\r
-                }\r
-            }\r
-        }\r
+        //           }\r
+        //       }\r
+        //   }\r
+        //}\r
     }\r
 \r
     /**\r