X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=blobdiff_plain;f=MdeModulePkg%2FUniversal%2FHiiDatabaseDxe%2FDatabase.c;h=4a2dc8d0304399810344f05b5d246a57f5f3d66b;hp=3ee8b4ca349348a5ccd5f3bea1f316182b10a652;hb=9eefa2eca070255762b75cae4cca41b8ba537202;hpb=6c46a5abbabc89d50d4e01bcd027c7f9bcf2f7eb diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/Database.c b/MdeModulePkg/Universal/HiiDatabaseDxe/Database.c index 3ee8b4ca34..4a2dc8d030 100644 --- a/MdeModulePkg/Universal/HiiDatabaseDxe/Database.c +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/Database.c @@ -1,7 +1,8 @@ /** @file +Implementation for EFI_HII_DATABASE_PROTOCOL. -Copyright (c) 2007, Intel Corporation -All rights reserved. This program and the accompanying materials +Copyright (c) 2007 - 2017, Intel Corporation. All rights reserved.
+This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at http://opensource.org/licenses/bsd-license.php @@ -9,33 +10,28 @@ http://opensource.org/licenses/bsd-license.php THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. -Module Name: - - Database.c - -Abstract: - - Implementation for EFI_HII_DATABASE_PROTOCOL. - -Revision History - - **/ #include "HiiDatabase.h" -// -// Global variables -// -STATIC EFI_GUID mHiiDatabaseNotifyGuid = HII_DATABASE_NOTIFY_GUID; +#define BASE_NUMBER 10 +EFI_HII_PACKAGE_LIST_HEADER *gRTDatabaseInfoBuffer = NULL; +EFI_STRING gRTConfigRespBuffer = NULL; +UINTN gDatabaseInfoSize = 0; +UINTN gConfigRespSize = 0; +BOOLEAN gExportConfigResp = TRUE; +UINTN gNvDefaultStoreSize = 0; +SKU_ID gSkuId = 0xFFFFFFFFFFFFFFFF; +LIST_ENTRY gVarStorageList = INITIALIZE_LIST_HEAD_VARIABLE (gVarStorageList); /** This function generates a HII_DATABASE_RECORD node and adds into hii database. + This is a internal function. @param Private hii database private structure - @param DatabaseRecord HII_DATABASE_RECORD node which is used to store a + @param DatabaseNode HII_DATABASE_RECORD node which is used to store a package list @retval EFI_SUCCESS A database record is generated successfully. @@ -44,7 +40,6 @@ STATIC EFI_GUID mHiiDatabaseNotifyGuid = HII_DATABASE_NOTIFY_GUID; @retval EFI_INVALID_PARAMETER Private is NULL or DatabaseRecord is NULL. **/ -STATIC EFI_STATUS GenerateHiiDatabaseRecord ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -67,7 +62,7 @@ GenerateHiiDatabaseRecord ( DatabaseRecord->PackageList = AllocateZeroPool (sizeof (HII_DATABASE_PACKAGE_LIST_INSTANCE)); if (DatabaseRecord->PackageList == NULL) { - SafeFreePool (DatabaseRecord); + FreePool (DatabaseRecord); return EFI_OUT_OF_RESOURCES; } @@ -87,8 +82,8 @@ GenerateHiiDatabaseRecord ( // HiiHandle = (HII_HANDLE *) AllocateZeroPool (sizeof (HII_HANDLE)); if (HiiHandle == NULL) { - SafeFreePool (DatabaseRecord->PackageList); - SafeFreePool (DatabaseRecord); + FreePool (DatabaseRecord->PackageList); + FreePool (DatabaseRecord); return EFI_OUT_OF_RESOURCES; } HiiHandle->Signature = HII_HANDLE_SIGNATURE; @@ -96,7 +91,7 @@ GenerateHiiDatabaseRecord ( // Backup the number of Hii handles // Private->HiiHandleCount++; - HiiHandle->Key = Private->HiiHandleCount; + HiiHandle->Key = (UINTN) Private->HiiHandleCount; // // Insert the handle to hii handle list of the whole database. // @@ -118,6 +113,7 @@ GenerateHiiDatabaseRecord ( /** This function checks whether a handle is a valid EFI_HII_HANDLE + This is a internal function. @param Handle Pointer to a EFI_HII_HANDLE @@ -148,6 +144,7 @@ IsHiiHandleValid ( /** This function invokes the matching registered function. + This is a internal function. @param Private HII Database driver private structure. @param NotifyType The type of change concerning the database. @@ -162,7 +159,6 @@ IsHiiHandleValid ( @retval EFI_INVALID_PARAMETER Any input parameter is not valid. **/ -STATIC EFI_STATUS InvokeRegisteredFunction ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -203,7 +199,7 @@ InvokeRegisteredFunction ( Package = (EFI_HII_PACKAGE_HEADER *) (((HII_GUID_PACKAGE_INSTANCE *) PackageInstance)->GuidPkg); break; - case EFI_HII_PACKAGE_FORM: + case EFI_HII_PACKAGE_FORMS: BufferSize = ((HII_IFR_PACKAGE_INSTANCE *) PackageInstance)->FormPkgHdr.Length; Buffer = (UINT8 *) AllocateZeroPool (BufferSize); ASSERT (Buffer != NULL); @@ -348,8 +344,9 @@ InvokeRegisteredFunction ( } } - SafeFreePool (Buffer); - Buffer = NULL; + if (Buffer != NULL) { + FreePool (Buffer); + } return EFI_SUCCESS; } @@ -357,13 +354,14 @@ InvokeRegisteredFunction ( /** This function insert a GUID package to a package list node. + This is a internal function. @param PackageHdr Pointer to a buffer stored with GUID package information. @param NotifyType The type of change concerning the database. @param PackageList Pointer to a package list which will be inserted to. - @param Package Created GUID pacakge + @param Package Created GUID package @retval EFI_SUCCESS Guid Package is inserted successfully. @retval EFI_OUT_OF_RESOURCES Unable to allocate necessary resources for the new @@ -371,7 +369,6 @@ InvokeRegisteredFunction ( @retval EFI_INVALID_PARAMETER PackageHdr is NULL or PackageList is NULL. **/ -STATIC EFI_STATUS InsertGuidPackage ( IN VOID *PackageHdr, @@ -398,7 +395,7 @@ InsertGuidPackage ( } GuidPackage->GuidPkg = (UINT8 *) AllocateZeroPool (PackageHeader.Length); if (GuidPackage->GuidPkg == NULL) { - SafeFreePool (GuidPackage); + FreePool (GuidPackage); return EFI_OUT_OF_RESOURCES; } @@ -417,6 +414,7 @@ InsertGuidPackage ( /** This function exports GUID packages to a buffer. + This is a internal function. @param Private Hii database private structure. @param Handle Identification of a package list. @@ -431,7 +429,6 @@ InsertGuidPackage ( @retval EFI_INVALID_PARAMETER Any input parameter is invalid. **/ -STATIC EFI_STATUS ExportGuidPackages ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -485,6 +482,7 @@ ExportGuidPackages ( /** This function deletes all GUID packages from a package list node. + This is a internal function. @param Private Hii database private data. @param Handle Handle of the package list which contains the to @@ -496,7 +494,6 @@ ExportGuidPackages ( @retval EFI_INVALID_PARAMETER Any input parameter is not valid. **/ -STATIC EFI_STATUS RemoveGuidPackages ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -532,16 +529,534 @@ RemoveGuidPackages ( RemoveEntryList (&Package->GuidEntry); CopyMem (&PackageHeader, Package->GuidPkg, sizeof (EFI_HII_PACKAGE_HEADER)); PackageList->PackageListHdr.PackageLength -= PackageHeader.Length; - SafeFreePool (Package->GuidPkg); - SafeFreePool (Package); + FreePool (Package->GuidPkg); + FreePool (Package); + } + + return EFI_SUCCESS; +} + +/** + Check the input question related to EFI variable + + @param IfrQuestionHdr Point to Question header + @param EfiVarStoreList Point to EFI VarStore List + @param EfiVarStoreNumber The number of EFI VarStore + + @retval Index The index of the found EFI varstore in EFI varstore list + EfiVarStoreNumber will return if no EFI varstore is found. +**/ +UINTN +IsEfiVarStoreQuestion ( + EFI_IFR_QUESTION_HEADER *IfrQuestionHdr, + EFI_IFR_VARSTORE_EFI **EfiVarStoreList, + UINTN EfiVarStoreNumber + ) +{ + UINTN Index; + for (Index = 0; Index < EfiVarStoreNumber; Index ++) { + if (IfrQuestionHdr->VarStoreId == EfiVarStoreList[Index]->VarStoreId) { + return Index; + } + } + + return EfiVarStoreNumber; +} + +/** + Find the matched variable from the input variable storage. + + @param[in] VariableStorage Point to the variable storage header. + @param[in] VarGuid A unique identifier for the variable. + @param[in] VarAttribute The attributes bitmask for the variable. + @param[in] VarName A Null-terminated ascii string that is the name of the variable. + + @return Pointer to the matched variable header or NULL if not found. +**/ +VARIABLE_HEADER * +FindVariableData ( + IN VARIABLE_STORE_HEADER *VariableStorage, + IN EFI_GUID *VarGuid, + IN UINT32 VarAttribute, + IN CHAR16 *VarName + ) +{ + VARIABLE_HEADER *VariableHeader; + VARIABLE_HEADER *VariableEnd; + + VariableEnd = (VARIABLE_HEADER *) ((UINT8 *) VariableStorage + VariableStorage->Size); + VariableHeader = (VARIABLE_HEADER *) (VariableStorage + 1); + VariableHeader = (VARIABLE_HEADER *) HEADER_ALIGN (VariableHeader); + while (VariableHeader < VariableEnd) { + if (CompareGuid (&VariableHeader->VendorGuid, VarGuid) && + VariableHeader->Attributes == VarAttribute && + StrCmp (VarName, (CHAR16 *) (VariableHeader + 1)) == 0) { + return VariableHeader; + } + VariableHeader = (VARIABLE_HEADER *) ((UINT8 *) VariableHeader + sizeof (VARIABLE_HEADER) + VariableHeader->NameSize + VariableHeader->DataSize); + VariableHeader = (VARIABLE_HEADER *) HEADER_ALIGN (VariableHeader); + } + + return NULL; +} + +/** + Find question default value from PcdNvStoreDefaultValueBuffer + + @param DefaultId Default store ID + @param EfiVarStore Point to EFI VarStore header + @param IfrQuestionHdr Point to Question header + @param ValueBuffer Point to Buffer includes the found default setting + @param Width Width of the default value + @param BitFieldQuestion Whether the Question is stored in Bit field. + + @retval EFI_SUCCESS Question default value is found. + @retval EFI_NOT_FOUND Question default value is not found. +**/ +EFI_STATUS +FindQuestionDefaultSetting ( + IN UINT16 DefaultId, + IN EFI_IFR_VARSTORE_EFI *EfiVarStore, + IN EFI_IFR_QUESTION_HEADER *IfrQuestionHdr, + OUT VOID *ValueBuffer, + IN UINTN Width, + IN BOOLEAN BitFieldQuestion + ) +{ + VARIABLE_HEADER *VariableHeader; + VARIABLE_STORE_HEADER *VariableStorage; + LIST_ENTRY *Link; + VARSTORAGE_DEFAULT_DATA *Entry; + VARIABLE_STORE_HEADER *NvStoreBuffer; + UINT8 *DataBuffer; + UINT8 *BufferEnd; + BOOLEAN IsFound; + UINTN Index; + UINT32 BufferValue; + UINT32 BitFieldVal; + UINTN BitOffset; + UINTN ByteOffset; + UINTN BitWidth; + UINTN StartBit; + UINTN EndBit; + PCD_DEFAULT_DATA *DataHeader; + PCD_DEFAULT_INFO *DefaultInfo; + PCD_DATA_DELTA *DeltaData; + + if (gSkuId == 0xFFFFFFFFFFFFFFFF) { + gSkuId = LibPcdGetSku (); + } + + // + // Find the DefaultId setting from the full DefaultSetting + // + VariableStorage = NULL; + Link = gVarStorageList.ForwardLink; + while (Link != &gVarStorageList) { + Entry = BASE_CR (Link, VARSTORAGE_DEFAULT_DATA, Entry); + if (Entry->DefaultId == DefaultId) { + VariableStorage = Entry->VariableStorage; + break; + } + Link = Link->ForwardLink; + } + + if (Link == &gVarStorageList) { + DataBuffer = (UINT8 *) PcdGetPtr (PcdNvStoreDefaultValueBuffer); + gNvDefaultStoreSize = ((PCD_NV_STORE_DEFAULT_BUFFER_HEADER *)DataBuffer)->Length; + // + // The first section data includes NV storage default setting. + // + DataHeader = (PCD_DEFAULT_DATA *) (DataBuffer + sizeof (PCD_NV_STORE_DEFAULT_BUFFER_HEADER)); + NvStoreBuffer = (VARIABLE_STORE_HEADER *) ((UINT8 *) DataHeader + sizeof (DataHeader->DataSize) + DataHeader->HeaderSize); + VariableStorage = AllocatePool (NvStoreBuffer->Size); + ASSERT (VariableStorage != NULL); + CopyMem (VariableStorage, NvStoreBuffer, NvStoreBuffer->Size); + + // + // Find the matched SkuId and DefaultId in the first section + // + IsFound = FALSE; + DefaultInfo = &(DataHeader->DefaultInfo[0]); + BufferEnd = (UINT8 *) DataHeader + sizeof (DataHeader->DataSize) + DataHeader->HeaderSize; + while ((UINT8 *) DefaultInfo < BufferEnd) { + if (DefaultInfo->DefaultId == DefaultId && DefaultInfo->SkuId == gSkuId) { + IsFound = TRUE; + break; + } + DefaultInfo ++; + } + // + // Find the matched SkuId and DefaultId in the remaining section + // + Index = sizeof (PCD_NV_STORE_DEFAULT_BUFFER_HEADER) + ((DataHeader->DataSize + 7) & (~7)); + DataHeader = (PCD_DEFAULT_DATA *) (DataBuffer + Index); + while (!IsFound && Index < gNvDefaultStoreSize && DataHeader->DataSize != 0xFFFF) { + DefaultInfo = &(DataHeader->DefaultInfo[0]); + BufferEnd = (UINT8 *) DataHeader + sizeof (DataHeader->DataSize) + DataHeader->HeaderSize; + while ((UINT8 *) DefaultInfo < BufferEnd) { + if (DefaultInfo->DefaultId == DefaultId && DefaultInfo->SkuId == gSkuId) { + IsFound = TRUE; + break; + } + DefaultInfo ++; + } + if (IsFound) { + DeltaData = (PCD_DATA_DELTA *) BufferEnd; + BufferEnd = (UINT8 *) DataHeader + DataHeader->DataSize; + while ((UINT8 *) DeltaData < BufferEnd) { + *((UINT8 *) VariableStorage + DeltaData->Offset) = (UINT8) DeltaData->Value; + DeltaData ++; + } + break; + } + Index = (Index + DataHeader->DataSize + 7) & (~7); + DataHeader = (PCD_DEFAULT_DATA *) (DataBuffer + Index); + } + // + // Cache the found result in VarStorageList + // + if (!IsFound) { + FreePool (VariableStorage); + VariableStorage = NULL; + } + Entry = AllocatePool (sizeof (VARSTORAGE_DEFAULT_DATA)); + Entry->DefaultId = DefaultId; + Entry->VariableStorage = VariableStorage; + InsertTailList (&gVarStorageList, &Entry->Entry); + } + // + // The matched variable storage is not found. + // + if (VariableStorage == NULL) { + return EFI_NOT_FOUND; + } + + // + // Find the question default value from the variable storage + // + VariableHeader = FindVariableData (VariableStorage, &EfiVarStore->Guid, EfiVarStore->Attributes, (CHAR16 *) EfiVarStore->Name); + if (VariableHeader == NULL) { + return EFI_NOT_FOUND; + } + StartBit = 0; + EndBit = 0; + ByteOffset = IfrQuestionHdr->VarStoreInfo.VarOffset; + if (BitFieldQuestion) { + BitOffset = IfrQuestionHdr->VarStoreInfo.VarOffset; + ByteOffset = BitOffset / 8; + BitWidth = Width; + StartBit = BitOffset % 8; + EndBit = StartBit + BitWidth - 1; + Width = EndBit / 8 + 1; + } + if (VariableHeader->DataSize < ByteOffset + Width) { + return EFI_INVALID_PARAMETER; + } + + // + // Copy the question value + // + if (ValueBuffer != NULL) { + if (BitFieldQuestion) { + CopyMem (&BufferValue, (UINT8 *) VariableHeader + sizeof (VARIABLE_HEADER) + VariableHeader->NameSize + ByteOffset, Width); + BitFieldVal = BitFieldRead32 (BufferValue, StartBit, EndBit); + CopyMem (ValueBuffer, &BitFieldVal, Width); + } else { + CopyMem (ValueBuffer, (UINT8 *) VariableHeader + sizeof (VARIABLE_HEADER) + VariableHeader->NameSize + IfrQuestionHdr->VarStoreInfo.VarOffset, Width); + } } return EFI_SUCCESS; } +/** + Update IFR default setting in Form Package. + + @param FormPackage Form Package to be updated + +**/ +VOID +UpdateDefaultSettingInFormPackage ( + HII_IFR_PACKAGE_INSTANCE *FormPackage + ) +{ + UINTN IfrOffset; + UINTN PackageLength; + EFI_IFR_VARSTORE_EFI *IfrEfiVarStore; + EFI_IFR_OP_HEADER *IfrOpHdr; + EFI_IFR_ONE_OF_OPTION *IfrOneOfOption; + UINT8 IfrQuestionType; + UINT8 IfrScope; + EFI_IFR_QUESTION_HEADER *IfrQuestionHdr; + EFI_IFR_VARSTORE_EFI **EfiVarStoreList; + UINTN EfiVarStoreMaxNum; + UINTN EfiVarStoreNumber; + UINT16 *DefaultIdList; + UINTN DefaultIdNumber; + UINTN DefaultIdMaxNum; + UINTN Index; + UINTN EfiVarStoreIndex; + EFI_IFR_TYPE_VALUE IfrValue; + EFI_IFR_TYPE_VALUE IfrManufactValue; + BOOLEAN StandardDefaultIsSet; + BOOLEAN ManufactDefaultIsSet; + EFI_IFR_CHECKBOX *IfrCheckBox; + EFI_STATUS Status; + EFI_IFR_DEFAULT *IfrDefault; + UINTN Width; + EFI_IFR_QUESTION_HEADER VarStoreQuestionHeader; + BOOLEAN QuestionReferBitField; + + // + // If no default setting, do nothing + // + if (gNvDefaultStoreSize == 0) { + gNvDefaultStoreSize = PcdGetSize (PcdNvStoreDefaultValueBuffer); + } + if (gNvDefaultStoreSize < sizeof (PCD_NV_STORE_DEFAULT_BUFFER_HEADER)) { + return; + } + + ZeroMem (&VarStoreQuestionHeader, sizeof (VarStoreQuestionHeader)); + PackageLength = FormPackage->FormPkgHdr.Length - sizeof (EFI_HII_PACKAGE_HEADER); + Width = 0; + IfrOffset = 0; + IfrScope = 0; + IfrOpHdr = (EFI_IFR_OP_HEADER *) FormPackage->IfrData; + IfrQuestionHdr = NULL; + IfrQuestionType = 0; + EfiVarStoreMaxNum = 0; + EfiVarStoreNumber = 0; + DefaultIdMaxNum = 0; + DefaultIdNumber = 0; + EfiVarStoreList = NULL; + DefaultIdList = NULL; + StandardDefaultIsSet = FALSE; + ManufactDefaultIsSet = FALSE; + QuestionReferBitField = FALSE; + + while (IfrOffset < PackageLength) { + switch (IfrOpHdr->OpCode) { + case EFI_IFR_VARSTORE_EFI_OP: + if (EfiVarStoreNumber >= EfiVarStoreMaxNum) { + // + // Reallocate EFI VarStore Buffer + // + EfiVarStoreList = ReallocatePool (EfiVarStoreMaxNum * sizeof (UINTN), (EfiVarStoreMaxNum + BASE_NUMBER) * sizeof (UINTN), EfiVarStoreList); + if (EfiVarStoreList == NULL) { + goto Done; + } + EfiVarStoreMaxNum = EfiVarStoreMaxNum + BASE_NUMBER; + } + IfrEfiVarStore = (EFI_IFR_VARSTORE_EFI *) IfrOpHdr; + // + // Convert VarStore Name from ASCII string to Unicode string. + // + EfiVarStoreList [EfiVarStoreNumber] = AllocatePool (IfrEfiVarStore->Header.Length + AsciiStrSize ((CHAR8 *)IfrEfiVarStore->Name)); + if (EfiVarStoreList [EfiVarStoreNumber] == NULL) { + break; + } + CopyMem (EfiVarStoreList [EfiVarStoreNumber], IfrEfiVarStore, IfrEfiVarStore->Header.Length); + AsciiStrToUnicodeStrS ((CHAR8 *)IfrEfiVarStore->Name, (CHAR16 *) &(EfiVarStoreList [EfiVarStoreNumber]->Name[0]), AsciiStrSize ((CHAR8 *)IfrEfiVarStore->Name) * sizeof (CHAR16)); + Status = FindQuestionDefaultSetting (EFI_HII_DEFAULT_CLASS_STANDARD, EfiVarStoreList[EfiVarStoreNumber], &VarStoreQuestionHeader, NULL, IfrEfiVarStore->Size, FALSE); + if (!EFI_ERROR (Status)) { + EfiVarStoreNumber ++; + } else { + FreePool (EfiVarStoreList [EfiVarStoreNumber]); + EfiVarStoreList [EfiVarStoreNumber] = NULL; + } + break; + case EFI_IFR_DEFAULTSTORE_OP: + if (DefaultIdNumber >= DefaultIdMaxNum) { + // + // Reallocate DefaultIdNumber + // + DefaultIdList = ReallocatePool (DefaultIdMaxNum * sizeof (UINT16), (DefaultIdMaxNum + BASE_NUMBER) * sizeof (UINT16), DefaultIdList); + if (DefaultIdList == NULL) { + goto Done; + } + DefaultIdMaxNum = DefaultIdMaxNum + BASE_NUMBER; + } + DefaultIdList[DefaultIdNumber ++] = ((EFI_IFR_DEFAULTSTORE *) IfrOpHdr)->DefaultId; + break; + case EFI_IFR_FORM_OP: + case EFI_IFR_FORM_MAP_OP: + // + // No EFI varstore is found and directly return. + // + if (EfiVarStoreNumber == 0 || DefaultIdNumber == 0) { + goto Done; + } + break; + case EFI_IFR_CHECKBOX_OP: + IfrScope = IfrOpHdr->Scope; + IfrQuestionType = IfrOpHdr->OpCode; + IfrQuestionHdr = (EFI_IFR_QUESTION_HEADER *) (IfrOpHdr + 1); + IfrCheckBox = (EFI_IFR_CHECKBOX *) (IfrOpHdr + 1); + EfiVarStoreIndex = IsEfiVarStoreQuestion (IfrQuestionHdr, EfiVarStoreList, EfiVarStoreNumber); + Width = sizeof (BOOLEAN); + if (EfiVarStoreIndex < EfiVarStoreNumber) { + for (Index = 0; Index < DefaultIdNumber; Index ++) { + if (DefaultIdList[Index] == EFI_HII_DEFAULT_CLASS_STANDARD) { + Status = FindQuestionDefaultSetting (DefaultIdList[Index], EfiVarStoreList[EfiVarStoreIndex], IfrQuestionHdr, &IfrValue, sizeof (BOOLEAN), QuestionReferBitField); + if (!EFI_ERROR (Status)) { + if (IfrValue.b) { + IfrCheckBox->Flags = IfrCheckBox->Flags | EFI_IFR_CHECKBOX_DEFAULT; + } else { + IfrCheckBox->Flags = IfrCheckBox->Flags & (~EFI_IFR_CHECKBOX_DEFAULT); + } + } + } else if (DefaultIdList[Index] == EFI_HII_DEFAULT_CLASS_MANUFACTURING) { + Status = FindQuestionDefaultSetting (DefaultIdList[Index], EfiVarStoreList[EfiVarStoreIndex], IfrQuestionHdr, &IfrValue, sizeof (BOOLEAN), QuestionReferBitField); + if (!EFI_ERROR (Status)) { + if (IfrValue.b) { + IfrCheckBox->Flags = IfrCheckBox->Flags | EFI_IFR_CHECKBOX_DEFAULT_MFG; + } else { + IfrCheckBox->Flags = IfrCheckBox->Flags & (~EFI_IFR_CHECKBOX_DEFAULT_MFG); + } + } + } + } + } + break; + case EFI_IFR_NUMERIC_OP: + IfrScope = IfrOpHdr->Scope; + IfrQuestionType = IfrOpHdr->OpCode; + IfrQuestionHdr = (EFI_IFR_QUESTION_HEADER *) (IfrOpHdr + 1); + if (QuestionReferBitField) { + Width = (UINTN) (((EFI_IFR_ONE_OF *) IfrOpHdr)->Flags & EDKII_IFR_NUMERIC_SIZE_BIT); + } else { + Width = (UINTN) ((UINT32) 1 << (((EFI_IFR_ONE_OF *) IfrOpHdr)->Flags & EFI_IFR_NUMERIC_SIZE)); + } + break; + case EFI_IFR_ONE_OF_OP: + IfrScope = IfrOpHdr->Scope; + IfrQuestionType = IfrOpHdr->OpCode; + IfrQuestionHdr = (EFI_IFR_QUESTION_HEADER *) (IfrOpHdr + 1); + if (QuestionReferBitField) { + Width = (UINTN) (((EFI_IFR_ONE_OF *) IfrOpHdr)->Flags & EDKII_IFR_NUMERIC_SIZE_BIT); + } else { + Width = (UINTN) ((UINT32) 1 << (((EFI_IFR_ONE_OF *) IfrOpHdr)->Flags & EFI_IFR_NUMERIC_SIZE)); + } + EfiVarStoreIndex = IsEfiVarStoreQuestion (IfrQuestionHdr, EfiVarStoreList, EfiVarStoreNumber); + StandardDefaultIsSet = FALSE; + ManufactDefaultIsSet = FALSE; + // + // Find Default and Manufacturing default for OneOf question + // + if (EfiVarStoreIndex < EfiVarStoreNumber) { + for (Index = 0; Index < DefaultIdNumber; Index ++) { + if (DefaultIdList[Index] == EFI_HII_DEFAULT_CLASS_STANDARD) { + Status = FindQuestionDefaultSetting (EFI_HII_DEFAULT_CLASS_STANDARD, EfiVarStoreList[EfiVarStoreIndex], IfrQuestionHdr, &IfrValue, Width, QuestionReferBitField); + if (!EFI_ERROR (Status)) { + StandardDefaultIsSet = TRUE; + } + } else if (DefaultIdList[Index] == EFI_HII_DEFAULT_CLASS_MANUFACTURING) { + Status = FindQuestionDefaultSetting (EFI_HII_DEFAULT_CLASS_MANUFACTURING, EfiVarStoreList[EfiVarStoreIndex], IfrQuestionHdr, &IfrManufactValue, Width, QuestionReferBitField); + if (!EFI_ERROR (Status)) { + ManufactDefaultIsSet = TRUE; + } + } + } + } + break; + case EFI_IFR_ORDERED_LIST_OP: + IfrScope = IfrOpHdr->Scope; + IfrQuestionType = IfrOpHdr->OpCode; + IfrQuestionHdr = (EFI_IFR_QUESTION_HEADER *) (IfrOpHdr + 1); + break; + case EFI_IFR_ONE_OF_OPTION_OP: + if (IfrQuestionHdr != NULL && IfrScope > 0) { + IfrOneOfOption = (EFI_IFR_ONE_OF_OPTION *) IfrOpHdr; + if (IfrQuestionType == EFI_IFR_ONE_OF_OP) { + Width = (UINTN) ((UINT32) 1 << (IfrOneOfOption->Flags & EFI_IFR_NUMERIC_SIZE)); + if (StandardDefaultIsSet) { + if (CompareMem (&IfrOneOfOption->Value, &IfrValue, Width) == 0) { + IfrOneOfOption->Flags |= EFI_IFR_OPTION_DEFAULT; + } else { + IfrOneOfOption->Flags &= ~EFI_IFR_OPTION_DEFAULT; + } + } + if (ManufactDefaultIsSet) { + if (CompareMem (&IfrOneOfOption->Value, &IfrManufactValue, Width) == 0) { + IfrOneOfOption->Flags |= EFI_IFR_OPTION_DEFAULT_MFG; + } else { + IfrOneOfOption->Flags &= ~EFI_IFR_OPTION_DEFAULT_MFG; + } + } + } + } + break; + case EFI_IFR_DEFAULT_OP: + if (IfrQuestionHdr != NULL && IfrScope > 0) { + IfrDefault = (EFI_IFR_DEFAULT *) IfrOpHdr; + // + // Collect default value width + // + if (!QuestionReferBitField) { + Width = 0; + if (IfrDefault->Type == EFI_IFR_TYPE_NUM_SIZE_8 || IfrDefault->Type == EFI_IFR_TYPE_BOOLEAN) { + Width = 1; + } else if (IfrDefault->Type == EFI_IFR_TYPE_NUM_SIZE_16) { + Width = 2; + } else if (IfrDefault->Type == EFI_IFR_TYPE_NUM_SIZE_32) { + Width = 4; + } else if (IfrDefault->Type == EFI_IFR_TYPE_NUM_SIZE_64) { + Width = 8; + } else if (IfrDefault->Type == EFI_IFR_TYPE_BUFFER) { + Width = IfrDefault->Header.Length - OFFSET_OF (EFI_IFR_DEFAULT, Value); + } + } + // + // Update the default value + // + if (Width > 0) { + EfiVarStoreIndex = IsEfiVarStoreQuestion (IfrQuestionHdr, EfiVarStoreList, EfiVarStoreNumber); + if (EfiVarStoreIndex < EfiVarStoreNumber) { + Status = FindQuestionDefaultSetting (IfrDefault->DefaultId, EfiVarStoreList[EfiVarStoreIndex], IfrQuestionHdr, &IfrDefault->Value, Width, QuestionReferBitField); + } + } + } + break; + case EFI_IFR_END_OP: + if (IfrQuestionHdr != NULL) { + if (IfrScope > 0) { + IfrScope --; + } + if (IfrScope == 0) { + IfrQuestionHdr = NULL; + QuestionReferBitField = FALSE; + } + } + break; + case EFI_IFR_GUID_OP: + if (CompareGuid ((EFI_GUID *)((UINT8 *)IfrOpHdr + sizeof (EFI_IFR_OP_HEADER)), &gEdkiiIfrBitVarstoreGuid)) { + QuestionReferBitField = TRUE; + } + break; + default: + break; + } + IfrOffset = IfrOffset + IfrOpHdr->Length; + IfrOpHdr = (EFI_IFR_OP_HEADER *) ((UINT8 *) IfrOpHdr + IfrOpHdr->Length); + if (IfrScope > 0) { + IfrScope += IfrOpHdr->Scope; + } + } + +Done: + if (EfiVarStoreList != NULL) { + for (Index = 0; Index < EfiVarStoreNumber; Index ++) { + FreePool (EfiVarStoreList [Index]); + } + } + return; +} /** This function insert a Form package to a package list node. + This is a internal function. @param PackageHdr Pointer to a buffer stored with Form package information. @@ -556,7 +1071,6 @@ RemoveGuidPackages ( @retval EFI_INVALID_PARAMETER PackageHdr is NULL or PackageList is NULL. **/ -STATIC EFI_STATUS InsertFormPackage ( IN VOID *PackageHdr, @@ -587,7 +1101,7 @@ InsertFormPackage ( FormPackage->IfrData = (UINT8 *) AllocateZeroPool (PackageHeader.Length - sizeof (EFI_HII_PACKAGE_HEADER)); if (FormPackage->IfrData == NULL) { - SafeFreePool (FormPackage); + FreePool (FormPackage); return EFI_OUT_OF_RESOURCES; } @@ -609,6 +1123,11 @@ InsertFormPackage ( InsertTailList (&PackageList->FormPkgHdr, &FormPackage->IfrEntry); *Package = FormPackage; + // + // Update FormPackage with the default setting + // + UpdateDefaultSettingInFormPackage (FormPackage); + if (NotifyType == EFI_HII_DATABASE_NOTIFY_ADD_PACK) { PackageList->PackageListHdr.PackageLength += FormPackage->FormPkgHdr.Length; } @@ -618,6 +1137,7 @@ InsertFormPackage ( /** This function exports Form packages to a buffer. + This is a internal function. @param Private Hii database private structure. @param Handle Identification of a package list. @@ -632,7 +1152,6 @@ InsertFormPackage ( @retval EFI_INVALID_PARAMETER Any input parameter is invalid. **/ -STATIC EFI_STATUS ExportFormPackages ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -666,7 +1185,7 @@ ExportFormPackages ( for (Link = PackageList->FormPkgHdr.ForwardLink; Link != &PackageList->FormPkgHdr; Link = Link->ForwardLink) { FormPackage = CR (Link, HII_IFR_PACKAGE_INSTANCE, IfrEntry, HII_IFR_PACKAGE_SIGNATURE); PackageLength += FormPackage->FormPkgHdr.Length; - if (PackageLength + *ResultSize + UsedSize <= BufferSize) { + if ((Buffer != NULL) && (PackageLength + *ResultSize + UsedSize <= BufferSize)) { // // Invoke registered notification if exists // @@ -674,7 +1193,7 @@ ExportFormPackages ( Private, EFI_HII_DATABASE_NOTIFY_EXPORT_PACK, (VOID *) FormPackage, - EFI_HII_PACKAGE_FORM, + EFI_HII_PACKAGE_FORMS, Handle ); ASSERT_EFI_ERROR (Status); @@ -701,6 +1220,7 @@ ExportFormPackages ( /** This function deletes all Form packages from a package list node. + This is a internal function. @param Private Hii database private data. @param Handle Handle of the package list which contains the to @@ -712,7 +1232,6 @@ ExportFormPackages ( @retval EFI_INVALID_PARAMETER Any input parameter is not valid. **/ -STATIC EFI_STATUS RemoveFormPackages ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -737,7 +1256,7 @@ RemoveFormPackages ( Private, EFI_HII_DATABASE_NOTIFY_REMOVE_PACK, (VOID *) Package, - EFI_HII_PACKAGE_FORM, + EFI_HII_PACKAGE_FORMS, Handle ); if (EFI_ERROR (Status)) { @@ -746,9 +1265,18 @@ RemoveFormPackages ( RemoveEntryList (&Package->IfrEntry); PackageList->PackageListHdr.PackageLength -= Package->FormPkgHdr.Length; - SafeFreePool (Package->IfrData); - SafeFreePool (Package); - + FreePool (Package->IfrData); + FreePool (Package); + // + // If Hii runtime support feature is enabled, + // will export Hii info for runtime use after ReadyToBoot event triggered. + // If some driver add/update/remove packages from HiiDatabase after ReadyToBoot, + // will need to export the content of HiiDatabase. + // But if form packages removed, also need to export the ConfigResp string + // + if (gExportAfterReadyToBoot) { + gExportConfigResp = TRUE; + } } return EFI_SUCCESS; @@ -758,6 +1286,7 @@ RemoveFormPackages ( /** This function insert a String package to a package list node. + This is a internal function. @param Private Hii database private structure. @param PackageHdr Pointer to a buffer stored with String package @@ -775,7 +1304,6 @@ RemoveFormPackages ( exists in current package list. **/ -STATIC EFI_STATUS InsertStringPackage ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -783,7 +1311,6 @@ InsertStringPackage ( IN EFI_HII_DATABASE_NOTIFY_TYPE NotifyType, IN OUT HII_DATABASE_PACKAGE_LIST_INSTANCE *PackageList, OUT HII_STRING_PACKAGE_INSTANCE **Package - ) { HII_STRING_PACKAGE_INSTANCE *StringPackage; @@ -813,15 +1340,15 @@ InsertStringPackage ( if (Language == NULL) { return EFI_OUT_OF_RESOURCES; } - AsciiStrCpy (Language, (CHAR8 *) PackageHdr + HeaderSize - LanguageSize); + AsciiStrCpyS (Language, LanguageSize / sizeof (CHAR8), (CHAR8 *) PackageHdr + HeaderSize - LanguageSize); for (Link = PackageList->StringPkgHdr.ForwardLink; Link != &PackageList->StringPkgHdr; Link = Link->ForwardLink) { StringPackage = CR (Link, HII_STRING_PACKAGE_INSTANCE, StringEntry, HII_STRING_PACKAGE_SIGNATURE); - if (R8_EfiLibCompareLanguage (Language, StringPackage->StringPkgHdr->Language)) { - SafeFreePool (Language); + if (HiiCompareLanguage (Language, StringPackage->StringPkgHdr->Language)) { + FreePool (Language); return EFI_UNSUPPORTED; } } - SafeFreePool (Language); + FreePool (Language); // // Create a String package node @@ -865,7 +1392,7 @@ InsertStringPackage ( // // Collect all font block info // - Status = FindStringBlock (Private, StringPackage, (EFI_STRING_ID) (-1), NULL, NULL, NULL, NULL); + Status = FindStringBlock (Private, StringPackage, (EFI_STRING_ID) (-1), NULL, NULL, NULL, &StringPackage->MaxStringId, NULL); if (EFI_ERROR (Status)) { return Status; } @@ -884,16 +1411,100 @@ InsertStringPackage ( Error: - SafeFreePool (StringPackage->StringBlock); - SafeFreePool (StringPackage->StringPkgHdr); - SafeFreePool (StringPackage); + if (StringPackage != NULL) { + if (StringPackage->StringBlock != NULL) { + FreePool (StringPackage->StringBlock); + } + if (StringPackage->StringPkgHdr != NULL) { + FreePool (StringPackage->StringPkgHdr); + } + FreePool (StringPackage); + } return Status; } +/** + Adjust all string packages in a single package list to have the same max string ID. + + @param PackageList Pointer to a package list which will be adjusted. + + @retval EFI_SUCCESS Adjust all string packages successfully. + @retval others Can't adjust string packages. + +**/ +EFI_STATUS +AdjustStringPackage ( + IN OUT HII_DATABASE_PACKAGE_LIST_INSTANCE *PackageList +) +{ + LIST_ENTRY *Link; + HII_STRING_PACKAGE_INSTANCE *StringPackage; + UINT32 Skip2BlockSize; + UINT32 OldBlockSize; + UINT8 *StringBlock; + UINT8 *BlockPtr; + EFI_STRING_ID MaxStringId; + UINT16 SkipCount; + + MaxStringId = 0; + for (Link = PackageList->StringPkgHdr.ForwardLink; + Link != &PackageList->StringPkgHdr; + Link = Link->ForwardLink + ) { + StringPackage = CR (Link, HII_STRING_PACKAGE_INSTANCE, StringEntry, HII_STRING_PACKAGE_SIGNATURE); + if (MaxStringId < StringPackage->MaxStringId) { + MaxStringId = StringPackage->MaxStringId; + } + } + + for (Link = PackageList->StringPkgHdr.ForwardLink; + Link != &PackageList->StringPkgHdr; + Link = Link->ForwardLink + ) { + StringPackage = CR (Link, HII_STRING_PACKAGE_INSTANCE, StringEntry, HII_STRING_PACKAGE_SIGNATURE); + if (StringPackage->MaxStringId < MaxStringId) { + OldBlockSize = StringPackage->StringPkgHdr->Header.Length - StringPackage->StringPkgHdr->HdrSize; + // + // Create SKIP2 EFI_HII_SIBT_SKIP2_BLOCKs to reserve the missing string IDs. + // + SkipCount = (UINT16) (MaxStringId - StringPackage->MaxStringId); + Skip2BlockSize = (UINT32) sizeof (EFI_HII_SIBT_SKIP2_BLOCK); + + StringBlock = (UINT8 *) AllocateZeroPool (OldBlockSize + Skip2BlockSize); + if (StringBlock == NULL) { + return EFI_OUT_OF_RESOURCES; + } + // + // Copy original string blocks, except the EFI_HII_SIBT_END. + // + CopyMem (StringBlock, StringPackage->StringBlock, OldBlockSize - sizeof (EFI_HII_SIBT_END_BLOCK)); + // + // Create SKIP2 EFI_HII_SIBT_SKIP2_BLOCK blocks + // + BlockPtr = StringBlock + OldBlockSize - sizeof (EFI_HII_SIBT_END_BLOCK); + *BlockPtr = EFI_HII_SIBT_SKIP2; + CopyMem (BlockPtr + 1, &SkipCount, sizeof (UINT16)); + BlockPtr += sizeof (EFI_HII_SIBT_SKIP2_BLOCK); + + // + // Append a EFI_HII_SIBT_END block to the end. + // + *BlockPtr = EFI_HII_SIBT_END; + FreePool (StringPackage->StringBlock); + StringPackage->StringBlock = StringBlock; + StringPackage->StringPkgHdr->Header.Length += Skip2BlockSize; + PackageList->PackageListHdr.PackageLength += Skip2BlockSize; + StringPackage->MaxStringId = MaxStringId; + } + } + + return EFI_SUCCESS; +} /** This function exports String packages to a buffer. + This is a internal function. @param Private Hii database private structure. @param Handle Identification of a package list. @@ -908,7 +1519,6 @@ Error: @retval EFI_INVALID_PARAMETER Any input parameter is invalid. **/ -STATIC EFI_STATUS ExportStringPackages ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -976,6 +1586,7 @@ ExportStringPackages ( /** This function deletes all String packages from a package list node. + This is a internal function. @param Private Hii database private data. @param Handle Handle of the package list which contains the to @@ -987,7 +1598,6 @@ ExportStringPackages ( @retval EFI_INVALID_PARAMETER Any input parameter is not valid. **/ -STATIC EFI_STATUS RemoveStringPackages ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -1022,8 +1632,8 @@ RemoveStringPackages ( RemoveEntryList (&Package->StringEntry); PackageList->PackageListHdr.PackageLength -= Package->StringPkgHdr->Header.Length; - SafeFreePool (Package->StringBlock); - SafeFreePool (Package->StringPkgHdr); + FreePool (Package->StringBlock); + FreePool (Package->StringPkgHdr); // // Delete font information // @@ -1035,10 +1645,10 @@ RemoveStringPackages ( HII_FONT_INFO_SIGNATURE ); RemoveEntryList (&FontInfo->Entry); - SafeFreePool (FontInfo); + FreePool (FontInfo); } - SafeFreePool (Package); + FreePool (Package); } return EFI_SUCCESS; @@ -1047,6 +1657,7 @@ RemoveStringPackages ( /** This function insert a Font package to a package list node. + This is a internal function. @param Private Hii database private structure. @param PackageHdr Pointer to a buffer stored with Font package @@ -1064,7 +1675,6 @@ RemoveStringPackages ( exists in current hii database. **/ -STATIC EFI_STATUS InsertFontPackage ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -1114,7 +1724,7 @@ InsertFontPackage ( } FontInfo->FontStyle = FontPkgHdr->FontStyle; FontInfo->FontSize = FontPkgHdr->Cell.Height; - StrCpy (FontInfo->FontName, FontPkgHdr->FontFamily); + StrCpyS (FontInfo->FontName, (FontInfoSize - OFFSET_OF(EFI_FONT_INFO,FontName)) / sizeof (CHAR16), FontPkgHdr->FontFamily); if (IsFontInfoExisted (Private, FontInfo, NULL, NULL, NULL)) { Status = EFI_UNSUPPORTED; @@ -1177,11 +1787,21 @@ InsertFontPackage ( Error: - SafeFreePool (FontPkgHdr); - SafeFreePool (FontInfo); - SafeFreePool (FontPackage->GlyphBlock); - SafeFreePool (FontPackage); - SafeFreePool (GlobalFont); + if (FontPkgHdr != NULL) { + FreePool (FontPkgHdr); + } + if (FontInfo != NULL) { + FreePool (FontInfo); + } + if (FontPackage != NULL) { + if (FontPackage->GlyphBlock != NULL) { + FreePool (FontPackage->GlyphBlock); + } + FreePool (FontPackage); + } + if (GlobalFont != NULL) { + FreePool (GlobalFont); + } return Status; @@ -1190,6 +1810,7 @@ Error: /** This function exports Font packages to a buffer. + This is a internal function. @param Private Hii database private structure. @param Handle Identification of a package list. @@ -1204,7 +1825,6 @@ Error: @retval EFI_INVALID_PARAMETER Any input parameter is invalid. **/ -STATIC EFI_STATUS ExportFontPackages ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -1273,6 +1893,7 @@ ExportFontPackages ( /** This function deletes all Font packages from a package list node. + This is a internal function. @param Private Hii database private data. @param Handle Handle of the package list which contains the to @@ -1284,7 +1905,6 @@ ExportFontPackages ( @retval EFI_INVALID_PARAMETER Any input parameter is not valid. **/ -STATIC EFI_STATUS RemoveFontPackages ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -1321,8 +1941,11 @@ RemoveFontPackages ( RemoveEntryList (&Package->FontEntry); PackageList->PackageListHdr.PackageLength -= Package->FontPkgHdr->Header.Length; - SafeFreePool (Package->GlyphBlock); - SafeFreePool (Package->FontPkgHdr); + + if (Package->GlyphBlock != NULL) { + FreePool (Package->GlyphBlock); + } + FreePool (Package->FontPkgHdr); // // Delete default character cell information // @@ -1334,7 +1957,7 @@ RemoveFontPackages ( HII_GLYPH_INFO_SIGNATURE ); RemoveEntryList (&GlyphInfo->Entry); - SafeFreePool (GlyphInfo); + FreePool (GlyphInfo); } // @@ -1344,13 +1967,13 @@ RemoveFontPackages ( GlobalFont = CR (Link, HII_GLOBAL_FONT_INFO, Entry, HII_GLOBAL_FONT_INFO_SIGNATURE); if (GlobalFont->FontPackage == Package) { RemoveEntryList (&GlobalFont->Entry); - SafeFreePool (GlobalFont->FontInfo); - SafeFreePool (GlobalFont); + FreePool (GlobalFont->FontInfo); + FreePool (GlobalFont); break; } } - SafeFreePool (Package); + FreePool (Package); } return EFI_SUCCESS; @@ -1359,6 +1982,7 @@ RemoveFontPackages ( /** This function insert a Image package to a package list node. + This is a internal function. @param PackageHdr Pointer to a buffer stored with Image package information. @@ -1373,7 +1997,6 @@ RemoveFontPackages ( @retval EFI_INVALID_PARAMETER PackageHdr is NULL or PackageList is NULL. **/ -STATIC EFI_STATUS InsertImagePackage ( IN VOID *PackageHdr, @@ -1438,7 +2061,7 @@ InsertImagePackage ( ImagePackage->PaletteBlock = (UINT8 *) AllocateZeroPool (PaletteSize); if (ImagePackage->PaletteBlock == NULL) { - SafeFreePool (ImagePackage); + FreePool (ImagePackage); return EFI_OUT_OF_RESOURCES; } CopyMem ( @@ -1456,10 +2079,10 @@ InsertImagePackage ( if (ImageInfoOffset != 0) { ImageSize = ImagePackage->ImagePkgHdr.Header.Length - sizeof (EFI_HII_IMAGE_PACKAGE_HDR) - PaletteSize; - ImagePackage->ImageBlock = (UINT8 *) AllocateZeroPool (ImageSize); + ImagePackage->ImageBlock = AllocateZeroPool (ImageSize); if (ImagePackage->ImageBlock == NULL) { - SafeFreePool (ImagePackage->PaletteBlock); - SafeFreePool (ImagePackage); + FreePool (ImagePackage->PaletteBlock); + FreePool (ImagePackage); return EFI_OUT_OF_RESOURCES; } CopyMem ( @@ -1484,6 +2107,7 @@ InsertImagePackage ( /** This function exports Image packages to a buffer. + This is a internal function. @param Private Hii database private structure. @param Handle Identification of a package list. @@ -1498,7 +2122,6 @@ InsertImagePackage ( @retval EFI_INVALID_PARAMETER Any input parameter is invalid. **/ -STATIC EFI_STATUS ExportImagePackages ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -1575,6 +2198,7 @@ ExportImagePackages ( /** This function deletes Image package from a package list node. + This is a internal function. @param Private Hii database private data. @param Handle Handle of the package list which contains the to @@ -1586,7 +2210,6 @@ ExportImagePackages ( @retval EFI_INVALID_PARAMETER Any input parameter is not valid. **/ -STATIC EFI_STATUS RemoveImagePackages ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -1619,9 +2242,11 @@ RemoveImagePackages ( PackageList->PackageListHdr.PackageLength -= Package->ImagePkgHdr.Header.Length; - SafeFreePool (Package->ImageBlock); - SafeFreePool (Package->PaletteBlock); - SafeFreePool (Package); + FreePool (Package->ImageBlock); + if (Package->PaletteBlock != NULL) { + FreePool (Package->PaletteBlock); + } + FreePool (Package); PackageList->ImagePkg = NULL; @@ -1631,6 +2256,7 @@ RemoveImagePackages ( /** This function insert a Simple Font package to a package list node. + This is a internal function. @param PackageHdr Pointer to a buffer stored with Simple Font package information. @@ -1645,7 +2271,6 @@ RemoveImagePackages ( @retval EFI_INVALID_PARAMETER PackageHdr is NULL or PackageList is NULL. **/ -STATIC EFI_STATUS InsertSimpleFontPackage ( IN VOID *PackageHdr, @@ -1699,14 +2324,19 @@ InsertSimpleFontPackage ( Error: - SafeFreePool (SimpleFontPackage->SimpleFontPkgHdr); - SafeFreePool (SimpleFontPackage); + if (SimpleFontPackage != NULL) { + if (SimpleFontPackage->SimpleFontPkgHdr != NULL) { + FreePool (SimpleFontPackage->SimpleFontPkgHdr); + } + FreePool (SimpleFontPackage); + } return Status; } /** This function exports SimpleFont packages to a buffer. + This is a internal function. @param Private Hii database private structure. @param Handle Identification of a package list. @@ -1721,7 +2351,6 @@ Error: @retval EFI_INVALID_PARAMETER Any input parameter is invalid. **/ -STATIC EFI_STATUS ExportSimpleFontPackages ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -1780,6 +2409,7 @@ ExportSimpleFontPackages ( /** This function deletes all Simple Font packages from a package list node. + This is a internal function. @param Private Hii database private data. @param Handle Handle of the package list which contains the to @@ -1791,7 +2421,6 @@ ExportSimpleFontPackages ( @retval EFI_INVALID_PARAMETER Any input parameter is not valid. **/ -STATIC EFI_STATUS RemoveSimpleFontPackages ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -1825,8 +2454,8 @@ RemoveSimpleFontPackages ( RemoveEntryList (&Package->SimpleFontEntry); PackageList->PackageListHdr.PackageLength -= Package->SimpleFontPkgHdr->Header.Length; - SafeFreePool (Package->SimpleFontPkgHdr); - SafeFreePool (Package); + FreePool (Package->SimpleFontPkgHdr); + FreePool (Package); } return EFI_SUCCESS; @@ -1835,6 +2464,7 @@ RemoveSimpleFontPackages ( /** This function insert a Device path package to a package list node. + This is a internal function. @param DevicePath Pointer to a EFI_DEVICE_PATH_PROTOCOL protocol instance @@ -1848,7 +2478,6 @@ RemoveSimpleFontPackages ( @retval EFI_INVALID_PARAMETER DevicePath is NULL or PackageList is NULL. **/ -STATIC EFI_STATUS InsertDevicePathPackage ( IN EFI_DEVICE_PATH_PROTOCOL *DevicePath, @@ -1895,6 +2524,7 @@ InsertDevicePathPackage ( /** This function exports device path package to a buffer. + This is a internal function. @param Private Hii database private structure. @param Handle Identification of a package list. @@ -1909,7 +2539,6 @@ InsertDevicePathPackage ( @retval EFI_INVALID_PARAMETER Any input parameter is invalid. **/ -STATIC EFI_STATUS ExportDevicePathPackage ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -1966,6 +2595,7 @@ ExportDevicePathPackage ( /** This function deletes Device Path package from a package list node. + This is a internal function. @param Private Hii database private data. @param Handle Handle of the package list. @@ -1976,7 +2606,6 @@ ExportDevicePathPackage ( @retval EFI_INVALID_PARAMETER Any input parameter is not valid. **/ -STATIC EFI_STATUS RemoveDevicePathPackage ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -2011,7 +2640,7 @@ RemoveDevicePathPackage ( CopyMem (&Header, Package, sizeof (EFI_HII_PACKAGE_HEADER)); PackageList->PackageListHdr.PackageLength -= Header.Length; - SafeFreePool (Package); + FreePool (Package); PackageList->DevicePathPkg = NULL; @@ -2022,6 +2651,7 @@ RemoveDevicePathPackage ( /** This function will insert a device path package to package list firstly then invoke notification functions if any. + This is a internal function. @param Private Hii database private structure. @param NotifyType The type of change concerning the database. @@ -2036,7 +2666,6 @@ RemoveDevicePathPackage ( @retval EFI_INVALID_PARAMETER DevicePath is NULL or PackageList is NULL. **/ -STATIC EFI_STATUS AddDevicePathPackage ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -2078,6 +2707,7 @@ AddDevicePathPackage ( /** This function insert a Keyboard Layout package to a package list node. + This is a internal function. @param PackageHdr Pointer to a buffer stored with Keyboard Layout package information. @@ -2092,7 +2722,6 @@ AddDevicePathPackage ( @retval EFI_INVALID_PARAMETER PackageHdr is NULL or PackageList is NULL. **/ -STATIC EFI_STATUS InsertKeyboardLayoutPackage ( IN VOID *PackageHdr, @@ -2140,8 +2769,13 @@ InsertKeyboardLayoutPackage ( Error: - SafeFreePool (KeyboardLayoutPackage->KeyboardPkg); - SafeFreePool (KeyboardLayoutPackage); + + if (KeyboardLayoutPackage != NULL) { + if (KeyboardLayoutPackage->KeyboardPkg != NULL) { + FreePool (KeyboardLayoutPackage->KeyboardPkg); + } + FreePool (KeyboardLayoutPackage); + } return Status; } @@ -2149,6 +2783,7 @@ Error: /** This function exports Keyboard Layout packages to a buffer. + This is a internal function. @param Private Hii database private structure. @param Handle Identification of a package list. @@ -2164,7 +2799,6 @@ Error: @retval EFI_INVALID_PARAMETER Any input parameter is invalid. **/ -STATIC EFI_STATUS ExportKeyboardLayoutPackages ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -2225,6 +2859,7 @@ ExportKeyboardLayoutPackages ( /** This function deletes all Keyboard Layout packages from a package list node. + This is a internal function. @param Private Hii database private data. @param Handle Handle of the package list which contains the to @@ -2237,7 +2872,6 @@ ExportKeyboardLayoutPackages ( @retval EFI_INVALID_PARAMETER Any input parameter is not valid. **/ -STATIC EFI_STATUS RemoveKeyboardLayoutPackages ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -2273,8 +2907,8 @@ RemoveKeyboardLayoutPackages ( RemoveEntryList (&Package->KeyboardEntry); CopyMem (&PackageHeader, Package->KeyboardPkg, sizeof (EFI_HII_PACKAGE_HEADER)); PackageList->PackageListHdr.PackageLength -= PackageHeader.Length; - SafeFreePool (Package->KeyboardPkg); - SafeFreePool (Package); + FreePool (Package->KeyboardPkg); + FreePool (Package); } return EFI_SUCCESS; @@ -2286,6 +2920,8 @@ RemoveKeyboardLayoutPackages ( invoke notification functions if any. It is the worker function of HiiNewPackageList and HiiUpdatePackageList. + This is a internal function. + @param Private Hii database private structure. @param NotifyType The type of change concerning the database. @param PackageList Pointer to a package list. @@ -2299,7 +2935,6 @@ RemoveKeyboardLayoutPackages ( @retval EFI_INVALID_PARAMETER Any input parameter is invalid. **/ -STATIC EFI_STATUS AddPackages ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -2319,11 +2954,19 @@ AddPackages ( EFI_HII_PACKAGE_HEADER *PackageHdrPtr; EFI_HII_PACKAGE_HEADER PackageHeader; UINT32 OldPackageListLen; + BOOLEAN StringPkgIsAdd; // // Initialize Variables // - FontPackage = NULL; + StringPkgIsAdd = FALSE; + FontPackage = NULL; + StringPackage = NULL; + GuidPackage = NULL; + FormPackage = NULL; + ImagePackage = NULL; + SimpleFontPackage = NULL; + KeyboardLayoutPackage = NULL; // // Process the package list header @@ -2363,7 +3006,7 @@ AddPackages ( DatabaseRecord->Handle ); break; - case EFI_HII_PACKAGE_FORM: + case EFI_HII_PACKAGE_FORMS: Status = InsertFormPackage ( PackageHdrPtr, NotifyType, @@ -2380,6 +3023,16 @@ AddPackages ( (UINT8) (PackageHeader.Type), DatabaseRecord->Handle ); + // + // If Hii runtime support feature is enabled, + // will export Hii info for runtime use after ReadyToBoot event triggered. + // If some driver add/update/remove packages from HiiDatabase after ReadyToBoot, + // will need to export the content of HiiDatabase. + // But if form packages added/updated, also need to export the ConfigResp string. + // + if (gExportAfterReadyToBoot) { + gExportConfigResp = TRUE; + } break; case EFI_HII_PACKAGE_KEYBOARD_LAYOUT: Status = InsertKeyboardLayoutPackage ( @@ -2410,6 +3063,7 @@ AddPackages ( if (EFI_ERROR (Status)) { return Status; } + ASSERT (StringPackage != NULL); Status = InvokeRegisteredFunction ( Private, NotifyType, @@ -2417,6 +3071,7 @@ AddPackages ( (UINT8) (PackageHeader.Type), DatabaseRecord->Handle ); + StringPkgIsAdd = TRUE; break; case EFI_HII_PACKAGE_FONTS: Status = InsertFontPackage ( @@ -2494,6 +3149,13 @@ AddPackages ( PackageHdrPtr = (EFI_HII_PACKAGE_HEADER *) ((UINT8 *) PackageHdrPtr + PackageHeader.Length); CopyMem (&PackageHeader, PackageHdrPtr, sizeof (EFI_HII_PACKAGE_HEADER)); } + + // + // Adjust String Package to make sure all string packages have the same max string ID. + // + if (!EFI_ERROR (Status) && StringPkgIsAdd) { + Status = AdjustStringPackage (DatabaseRecord->PackageList); + } return Status; } @@ -2503,6 +3165,8 @@ AddPackages ( This function exports a package list to a buffer. It is the worker function of HiiExportPackageList. + This is a internal function. + @param Private Hii database private structure. @param Handle Identification of a package list. @param PackageList Pointer to a package list which will be exported. @@ -2516,7 +3180,6 @@ AddPackages ( @retval EFI_INVALID_PARAMETER Any input parameter is invalid. **/ -STATIC EFI_STATUS ExportPackageList ( IN HII_DATABASE_PRIVATE_DATA *Private, @@ -2531,7 +3194,7 @@ ExportPackageList ( UINTN ResultSize; EFI_HII_PACKAGE_HEADER EndofPackageList; - ASSERT (Private != NULL || PackageList != NULL || UsedSize != NULL); + ASSERT (Private != NULL && PackageList != NULL && UsedSize != NULL); ASSERT (Private->Signature == HII_DATABASE_PRIVATE_DATA_SIGNATURE); ASSERT (IsHiiHandleValid (Handle)); @@ -2664,6 +3327,141 @@ ExportPackageList ( return EFI_SUCCESS; } +/** +This function mainly use to get and update ConfigResp string. + +@param This A pointer to the EFI_HII_DATABASE_PROTOCOL instance. + +@retval EFI_SUCCESS Get the information successfully. +@retval EFI_OUT_OF_RESOURCES Not enough memory to store the Configuration Setting data. + +**/ +EFI_STATUS +HiiGetConfigRespInfo( + IN CONST EFI_HII_DATABASE_PROTOCOL *This + ) +{ + EFI_STATUS Status; + HII_DATABASE_PRIVATE_DATA *Private; + EFI_STRING ConfigAltResp; + UINTN ConfigSize; + + ConfigAltResp = NULL; + ConfigSize = 0; + + Private = HII_DATABASE_DATABASE_PRIVATE_DATA_FROM_THIS (This); + + // + // Get ConfigResp string + // + Status = HiiConfigRoutingExportConfig(&Private->ConfigRouting,&ConfigAltResp); + + if (!EFI_ERROR (Status)){ + ConfigSize = StrSize(ConfigAltResp); + if (ConfigSize > gConfigRespSize){ + gConfigRespSize = ConfigSize; + if (gRTConfigRespBuffer != NULL){ + FreePool(gRTConfigRespBuffer); + } + gRTConfigRespBuffer = (EFI_STRING)AllocateRuntimeZeroPool(ConfigSize); + if (gRTConfigRespBuffer == NULL){ + FreePool(ConfigAltResp); + DEBUG ((DEBUG_ERROR, "Not enough memory resource to get the ConfigResp string.\n")); + return EFI_OUT_OF_RESOURCES; + } + } else { + ZeroMem(gRTConfigRespBuffer,gConfigRespSize); + } + CopyMem(gRTConfigRespBuffer,ConfigAltResp,ConfigSize); + gBS->InstallConfigurationTable (&gEfiHiiConfigRoutingProtocolGuid, gRTConfigRespBuffer); + FreePool(ConfigAltResp); + } + + return EFI_SUCCESS; + +} + +/** +This is an internal function,mainly use to get HiiDatabase information. + +@param This A pointer to the EFI_HII_DATABASE_PROTOCOL instance. + +@retval EFI_SUCCESS Get the information successfully. +@retval EFI_OUT_OF_RESOURCES Not enough memory to store the Hiidatabase data. + +**/ +EFI_STATUS +HiiGetDatabaseInfo( + IN CONST EFI_HII_DATABASE_PROTOCOL *This + ) +{ + EFI_STATUS Status; + EFI_HII_PACKAGE_LIST_HEADER *DatabaseInfo; + UINTN DatabaseInfoSize; + + DatabaseInfo = NULL; + DatabaseInfoSize = 0; + + // + // Get HiiDatabase information. + // + Status = HiiExportPackageLists(This, NULL, &DatabaseInfoSize, DatabaseInfo); + + ASSERT(Status == EFI_BUFFER_TOO_SMALL); + + if(DatabaseInfoSize > gDatabaseInfoSize ) { + gDatabaseInfoSize = DatabaseInfoSize; + if (gRTDatabaseInfoBuffer != NULL){ + FreePool(gRTDatabaseInfoBuffer); + } + gRTDatabaseInfoBuffer = AllocateRuntimeZeroPool(DatabaseInfoSize); + if (gRTDatabaseInfoBuffer == NULL){ + DEBUG ((DEBUG_ERROR, "Not enough memory resource to get the HiiDatabase info.\n")); + return EFI_OUT_OF_RESOURCES; + } + } else { + ZeroMem(gRTDatabaseInfoBuffer,gDatabaseInfoSize); + } + Status = HiiExportPackageLists(This, NULL, &DatabaseInfoSize, gRTDatabaseInfoBuffer); + ASSERT_EFI_ERROR (Status); + gBS->InstallConfigurationTable (&gEfiHiiDatabaseProtocolGuid, gRTDatabaseInfoBuffer); + + return EFI_SUCCESS; + +} + +/** +This function mainly use to get and update configuration settings information. + +@param This A pointer to the EFI_HII_DATABASE_PROTOCOL instance. + +@retval EFI_SUCCESS Get the information successfully. +@retval EFI_OUT_OF_RESOURCES Not enough memory to store the Configuration Setting data. + +**/ +EFI_STATUS +HiiGetConfigurationSetting( + IN CONST EFI_HII_DATABASE_PROTOCOL *This + ) +{ + EFI_STATUS Status; + + // + // Get the HiiDatabase info. + // + Status = HiiGetDatabaseInfo(This); + + // + // Get ConfigResp string + // + if (gExportConfigResp) { + Status = HiiGetConfigRespInfo (This); + gExportConfigResp = FALSE; + } + return Status; + +} + /** This function adds the packages in the package list to the database and returns a handle. If there is a @@ -2675,6 +3473,8 @@ ExportPackageList ( @param PackageList A pointer to an EFI_HII_PACKAGE_LIST_HEADER structure. @param DriverHandle Associate the package list with this EFI handle. + If a NULL is specified, this data will not be associate + with any drivers and cannot have a callback induced. @param Handle A pointer to the EFI_HII_HANDLE instance. @retval EFI_SUCCESS The package list associated with the Handle was @@ -2690,7 +3490,7 @@ EFIAPI HiiNewPackageList ( IN CONST EFI_HII_DATABASE_PROTOCOL *This, IN CONST EFI_HII_PACKAGE_LIST_HEADER *PackageList, - IN CONST EFI_HANDLE DriverHandle, + IN CONST EFI_HANDLE DriverHandle, OPTIONAL OUT EFI_HII_HANDLE *Handle ) { @@ -2715,9 +3515,8 @@ HiiNewPackageList ( DatabaseRecord = CR (Link, HII_DATABASE_RECORD, DatabaseEntry, HII_DATABASE_RECORD_SIGNATURE); if (CompareGuid ( &(DatabaseRecord->PackageList->PackageListHdr.PackageListGuid), - &PackageListGuid - ) - ) { + &PackageListGuid) && + DatabaseRecord->DriverHandle == DriverHandle) { return EFI_INVALID_PARAMETER; } } @@ -2755,12 +3554,21 @@ HiiNewPackageList ( } *Handle = DatabaseRecord->Handle; + + // + // Check whether need to get the Database and configuration setting info. + // Only after ReadyToBoot, need to do the export. + // + if (gExportAfterReadyToBoot) { + HiiGetConfigurationSetting(This); + } + return EFI_SUCCESS; } /** - This function removes the package list that is associated with a handle Handle + This function removes the package list that is associated with Handle from the HII database. Before removing the package, any registered functions with the notification type REMOVE_PACK and the same package type will be called. @@ -2771,8 +3579,7 @@ HiiNewPackageList ( @retval EFI_SUCCESS The data associated with the Handle was removed from the HII database. - @retval EFI_NOT_FOUND The specified PackageList could not be found in - database. + @retval EFI_NOT_FOUND The specified handle is not in database. @retval EFI_INVALID_PARAMETER The Handle was not valid. **/ @@ -2790,10 +3597,14 @@ HiiRemovePackageList ( HII_DATABASE_PACKAGE_LIST_INSTANCE *PackageList; HII_HANDLE *HiiHandle; - if (This == NULL || !IsHiiHandleValid (Handle)) { + if (This == NULL) { return EFI_INVALID_PARAMETER; } + if (!IsHiiHandleValid (Handle)) { + return EFI_NOT_FOUND; + } + Private = HII_DATABASE_DATABASE_PRIVATE_DATA_FROM_THIS (This); // @@ -2853,10 +3664,17 @@ HiiRemovePackageList ( ASSERT (Private->HiiHandleCount >= 0); HiiHandle->Signature = 0; - SafeFreePool (HiiHandle); - SafeFreePool (Node->PackageList); - SafeFreePool (Node); + FreePool (HiiHandle); + FreePool (Node->PackageList); + FreePool (Node); + // + // Check whether need to get the Database and configuration setting info. + // Only after ReadyToBoot, need to do the export. + // + if (gExportAfterReadyToBoot) { + HiiGetConfigurationSetting(This); + } return EFI_SUCCESS; } } @@ -2879,9 +3697,8 @@ HiiRemovePackageList ( @retval EFI_SUCCESS The HII database was successfully updated. @retval EFI_OUT_OF_RESOURCES Unable to allocate enough memory for the updated database. - @retval EFI_INVALID_PARAMETER Handle or PackageList was NULL. - @retval EFI_NOT_FOUND The Handle was not valid or could not be found in - database. + @retval EFI_INVALID_PARAMETER PackageList was NULL. + @retval EFI_NOT_FOUND The specified Handle is not in database. **/ EFI_STATUS @@ -2900,7 +3717,7 @@ HiiUpdatePackageList ( HII_DATABASE_PACKAGE_LIST_INSTANCE *OldPackageList; EFI_HII_PACKAGE_HEADER PackageHeader; - if (This == NULL || PackageList == NULL || Handle == NULL) { + if (This == NULL || PackageList == NULL) { return EFI_INVALID_PARAMETER; } @@ -2931,7 +3748,7 @@ HiiUpdatePackageList ( case EFI_HII_PACKAGE_TYPE_GUID: Status = RemoveGuidPackages (Private, Handle, OldPackageList); break; - case EFI_HII_PACKAGE_FORM: + case EFI_HII_PACKAGE_FORMS: Status = RemoveFormPackages (Private, Handle, OldPackageList); break; case EFI_HII_PACKAGE_KEYBOARD_LAYOUT: @@ -2965,7 +3782,19 @@ HiiUpdatePackageList ( // // Add all of the packages within the new package list // - return AddPackages (Private, EFI_HII_DATABASE_NOTIFY_ADD_PACK, PackageList, Node); + Status = AddPackages (Private, EFI_HII_DATABASE_NOTIFY_ADD_PACK, PackageList, Node); + + // + // Check whether need to get the Database and configuration setting info. + // Only after ReadyToBoot, need to do the export. + // + if (gExportAfterReadyToBoot) { + if (Status == EFI_SUCCESS){ + HiiGetConfigurationSetting(This); + } + } + + return Status; } } @@ -2992,13 +3821,19 @@ HiiUpdatePackageList ( buffer that is required for the handles found. @param Handle An array of EFI_HII_HANDLE instances returned. - @retval EFI_SUCCESS The matching handles are outputed successfully. + @retval EFI_SUCCESS The matching handles are outputted successfully. + HandleBufferLength is updated with the actual length. @retval EFI_BUFFER_TO_SMALL The HandleBufferLength parameter indicates that Handle is too small to support the number of handles. HandleBufferLength is updated with a value that will enable the data to fit. @retval EFI_NOT_FOUND No matching handle could not be found in database. - @retval EFI_INVALID_PARAMETER Handle or HandleBufferLength was NULL. + @retval EFI_INVALID_PARAMETER HandleBufferLength was NULL. + @retval EFI_INVALID_PARAMETER The value referenced by HandleBufferLength was not + zero and Handle was NULL. + @retval EFI_INVALID_PARAMETER PackageType is not a EFI_HII_PACKAGE_TYPE_GUID but + PackageGuid is not NULL, PackageType is a EFI_HII_ + PACKAGE_TYPE_GUID but PackageGuid is NULL. **/ EFI_STATUS @@ -3056,7 +3891,7 @@ HiiListPackageLists ( } } break; - case EFI_HII_PACKAGE_FORM: + case EFI_HII_PACKAGE_FORMS: if (!IsListEmpty (&PackageList->FormPkgHdr)) { Matched = TRUE; } @@ -3092,7 +3927,7 @@ HiiListPackageLists ( } break; // - // Pesudo-type EFI_HII_PACKAGE_TYPE_ALL will cause all package handles + // Pseudo-type EFI_HII_PACKAGE_TYPE_ALL will cause all package handles // to be listed. // case EFI_HII_PACKAGE_TYPE_ALL: @@ -3149,9 +3984,11 @@ HiiListPackageLists ( Handle is too small to support the number of handles. HandleBufferLength is updated with a value that will enable the data to fit. - @retval EFI_NOT_FOUND The specifiecd Handle could not be found in the + @retval EFI_NOT_FOUND The specified Handle could not be found in the current database. - @retval EFI_INVALID_PARAMETER Handle or Buffer or BufferSize was NULL. + @retval EFI_INVALID_PARAMETER BufferSize was NULL. + @retval EFI_INVALID_PARAMETER The value referenced by BufferSize was not zero + and Buffer was NULL. **/ EFI_STATUS @@ -3169,13 +4006,13 @@ HiiExportPackageLists ( HII_DATABASE_RECORD *Node; UINTN UsedSize; - if (This == NULL || BufferSize == NULL || Handle == NULL) { + if (This == NULL || BufferSize == NULL) { return EFI_INVALID_PARAMETER; } if (*BufferSize > 0 && Buffer == NULL) { return EFI_INVALID_PARAMETER; } - if (!IsHiiHandleValid (Handle)) { + if ((Handle != NULL) && (!IsHiiHandleValid (Handle))) { return EFI_NOT_FOUND; } @@ -3197,8 +4034,7 @@ HiiExportPackageLists ( (EFI_HII_PACKAGE_LIST_HEADER *)((UINT8 *) Buffer + UsedSize) ); ASSERT_EFI_ERROR (Status); - } - else if (Handle != NULL && Node->Handle == Handle) { + } else if (Handle != NULL && Node->Handle == Handle) { Status = ExportPackageList ( Private, Handle, @@ -3302,7 +4138,7 @@ HiiRegisterPackageNotify ( // Status = gBS->InstallMultipleProtocolInterfaces ( &Notify->NotifyHandle, - &mHiiDatabaseNotifyGuid, + &gEfiCallerIdGuid, NULL, NULL ); @@ -3329,7 +4165,7 @@ HiiRegisterPackageNotify ( @param This A pointer to the EFI_HII_DATABASE_PROTOCOL instance. - @param NotifyHandle The handle of the notification function being + @param NotificationHandle The handle of the notification function being unregistered. @retval EFI_SUCCESS Notification is unregistered successfully. @@ -3350,20 +4186,24 @@ HiiUnregisterPackageNotify ( LIST_ENTRY *Link; EFI_STATUS Status; - if (This == NULL || NotificationHandle == NULL) { + if (This == NULL) { return EFI_INVALID_PARAMETER; } + if (NotificationHandle == NULL) { + return EFI_NOT_FOUND; + } + Status = gBS->OpenProtocol ( NotificationHandle, - &mHiiDatabaseNotifyGuid, + &gEfiCallerIdGuid, NULL, NULL, NULL, EFI_OPEN_PROTOCOL_TEST_PROTOCOL ); if (EFI_ERROR (Status)) { - return EFI_INVALID_PARAMETER; + return EFI_NOT_FOUND; } Private = HII_DATABASE_DATABASE_PRIVATE_DATA_FROM_THIS (This); @@ -3377,13 +4217,12 @@ HiiUnregisterPackageNotify ( RemoveEntryList (&Notify->DatabaseNotifyEntry); Status = gBS->UninstallMultipleProtocolInterfaces ( Notify->NotifyHandle, - &mHiiDatabaseNotifyGuid, + &gEfiCallerIdGuid, NULL, NULL ); ASSERT_EFI_ERROR (Status); - SafeFreePool (Notify); - Notify = NULL; + FreePool (Notify); return EFI_SUCCESS; } @@ -3411,7 +4250,9 @@ HiiUnregisterPackageNotify ( number of GUIDs. KeyGuidBufferLength is updated with a value that will enable the data to fit. - @retval EFI_INVALID_PARAMETER The KeyGuidBuffer or KeyGuidBufferLength was NULL. + @retval EFI_INVALID_PARAMETER The KeyGuidBufferLength is NULL. + @retval EFI_INVALID_PARAMETER The value referenced by KeyGuidBufferLength is not + zero and KeyGuidBuffer is NULL. @retval EFI_NOT_FOUND There was no keyboard layout. **/ @@ -3474,7 +4315,7 @@ HiiFindKeyboardLayouts ( for (Index = 0; Index < LayoutCount; Index++) { ResultSize += sizeof (EFI_GUID); if (ResultSize <= *KeyGuidBufferLength) { - CopyMem (KeyGuidBuffer + Index, Layout + sizeof (UINT16), sizeof (EFI_GUID)); + CopyMem (KeyGuidBuffer + (ResultSize / sizeof (EFI_GUID) - 1), Layout + sizeof (UINT16), sizeof (EFI_GUID)); CopyMem (&LayoutLength, Layout, sizeof (UINT16)); Layout = Layout + LayoutLength; } @@ -3665,7 +4506,9 @@ HiiSetKeyboardLayout ( // Backup current keyboard layout. // CopyMem (&Private->CurrentLayoutGuid, KeyGuid, sizeof (EFI_GUID)); - SafeFreePool(Private->CurrentLayout); + if (Private->CurrentLayout != NULL) { + FreePool(Private->CurrentLayout); + } Private->CurrentLayout = KeyboardLayout; //