X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=blobdiff_plain;f=MdeModulePkg%2FUniversal%2FNetwork%2FUefiPxeBcDxe%2FPxeBcImpl.c;h=659f638930eaac63a506075ff835476ea62fb5cb;hp=f8bdf5c9453e74321a5f930d87d5dda2165b669d;hb=2ce5c88a7adaea3eeeccc932b18da5f02440f8cd;hpb=619eff3f290c7e893d858c16e70b641471a5a704 diff --git a/MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.c b/MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.c index f8bdf5c945..659f638930 100644 --- a/MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.c +++ b/MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.c @@ -1,6 +1,7 @@ /** @file - -Copyright (c) 2007 - 2008, Intel Corporation + Interface routines for PxeBc. + +Copyright (c) 2007 - 2009, Intel Corporation.
All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -9,30 +10,22 @@ http://opensource.org/licenses/bsd-license.php THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. -Module Name: - - PxeBcImpl.c - -Abstract: - - Interface routines for PxeBc - - **/ #include "PxeBcImpl.h" +UINT32 mPxeDhcpTimeout[4] = { 4, 8, 16, 32 }; + /** - Get and record the arp cache + Get and record the arp cache. @param This Pointer to EFI_PXE_BC_PROTOCOL @retval EFI_SUCCESS Arp cache updated successfully - @retval others If error occurs when updating arp cache + @retval others If error occurs when getting arp cache **/ -STATIC EFI_STATUS UpdateArpCache ( IN EFI_PXE_BASE_CODE_PROTOCOL * This @@ -49,32 +42,50 @@ UpdateArpCache ( Private = PXEBC_PRIVATE_DATA_FROM_PXEBC (This); Mode = Private->PxeBc.Mode; - Status = Private->Arp->Find (Private->Arp, TRUE, NULL, &EntryLength, &EntryCount, &Entries, TRUE); + Status = Private->Arp->Find ( + Private->Arp, + TRUE, + NULL, + &EntryLength, + &EntryCount, + &Entries, + TRUE + ); if (EFI_ERROR (Status)) { return Status; } - Mode->ArpCacheEntries = MIN (EntryCount, EFI_PXE_BASE_CODE_MAX_ARP_ENTRIES); + Mode->ArpCacheEntries = MIN ( + EntryCount, + EFI_PXE_BASE_CODE_MAX_ARP_ENTRIES + ); for (Index = 0; Index < Mode->ArpCacheEntries; Index ++) { - CopyMem (&Mode->ArpCache[Index].IpAddr, Entries + 1, Entries->SwAddressLength); - CopyMem (&Mode->ArpCache[Index].MacAddr, (UINT8 *)(Entries + 1) + Entries->SwAddressLength, Entries->HwAddressLength); + CopyMem ( + &Mode->ArpCache[Index].IpAddr, + Entries + 1, + Entries->SwAddressLength + ); + CopyMem ( + &Mode->ArpCache[Index].MacAddr, + (UINT8 *) (Entries + 1) + Entries->SwAddressLength, + Entries->HwAddressLength + ); // // Slip to the next FindData. // - Entries = (EFI_ARP_FIND_DATA *)((UINT8 *)Entries + EntryLength); + Entries = (EFI_ARP_FIND_DATA *) ((UINT8 *) Entries + EntryLength); } return EFI_SUCCESS; } /** - Timeout routine to catch arp cache. + Timeout routine to update arp cache. @param Event Pointer to EFI_PXE_BC_PROTOCOL @param Context Context of the timer event **/ -STATIC VOID EFIAPI ArpCacheUpdateTimeout ( @@ -86,25 +97,33 @@ ArpCacheUpdateTimeout ( } /** - Timeout routine to catch arp cache. - - @param Event Pointer to EFI_PXE_BC_PROTOCOL - @param Context + Do arp resolution from arp cache in PxeBcMode. + + @param PxeBcMode The PXE BC mode to look into. + @param Ip4Addr The Ip4 address for resolution. + @param MacAddress The resoluted MAC address if the resolution is successful. + The value is undefined if resolution fails. + + @retval TRUE The resolution is successful. + @retval FALSE Otherwise. **/ -STATIC BOOLEAN FindInArpCache ( - EFI_PXE_BASE_CODE_MODE *PxeBcMode, - EFI_IPv4_ADDRESS *Ip4Addr, - EFI_MAC_ADDRESS *MacAddress + IN EFI_PXE_BASE_CODE_MODE *PxeBcMode, + IN EFI_IPv4_ADDRESS *Ip4Addr, + OUT EFI_MAC_ADDRESS *MacAddress ) { UINT32 Index; for (Index = 0; Index < PxeBcMode->ArpCacheEntries; Index ++) { if (EFI_IP4_EQUAL (&PxeBcMode->ArpCache[Index].IpAddr.v4, Ip4Addr)) { - CopyMem (MacAddress, &PxeBcMode->ArpCache[Index].MacAddr, sizeof (EFI_MAC_ADDRESS)); + CopyMem ( + MacAddress, + &PxeBcMode->ArpCache[Index].MacAddr, + sizeof (EFI_MAC_ADDRESS) + ); return TRUE; } } @@ -116,12 +135,9 @@ FindInArpCache ( Notify function for the ICMP receive token, used to process the received ICMP packets. - @param Context The context passed in by the event notifier. - - @return None. + @param Context The PXEBC private data. **/ -STATIC VOID EFIAPI IcmpErrorListenHandlerDpc ( @@ -143,14 +159,14 @@ IcmpErrorListenHandlerDpc ( RxData = Private->IcmpErrorRcvToken.Packet.RxData; Ip4 = Private->Ip4; - if (EFI_ABORTED == Status) { + if (Status == EFI_ABORTED) { // // The reception is actively aborted by the consumer, directly return. // return; } - if ((EFI_SUCCESS != Status) || (NULL == RxData)) { + if (EFI_ERROR (Status) || (RxData == NULL)) { // // Only process the normal packets and the icmp error packets, if RxData is NULL // with Status == EFI_SUCCESS or EFI_ICMP_ERROR, just resume the receive although @@ -159,8 +175,8 @@ IcmpErrorListenHandlerDpc ( goto Resume; } - if ((EFI_IP4 (RxData->Header->SourceAddress) != 0) && - !Ip4IsUnicast (EFI_NTOHL (RxData->Header->SourceAddress), 0)) { + if (EFI_IP4 (RxData->Header->SourceAddress) != 0 && + !Ip4IsUnicast (EFI_NTOHL (RxData->Header->SourceAddress), 0)) { // // The source address is not zero and it's not a unicast IP address, discard it. // @@ -183,9 +199,17 @@ IcmpErrorListenHandlerDpc ( for (Index = 0; Index < RxData->FragmentCount; Index ++) { CopiedLen += RxData->FragmentTable[Index].FragmentLength; if (CopiedLen <= sizeof (EFI_PXE_BASE_CODE_ICMP_ERROR)) { - CopyMem (CopiedPointer, RxData->FragmentTable[Index].FragmentBuffer, RxData->FragmentTable[Index].FragmentLength); + CopyMem ( + CopiedPointer, + RxData->FragmentTable[Index].FragmentBuffer, + RxData->FragmentTable[Index].FragmentLength + ); } else { - CopyMem (CopiedPointer, RxData->FragmentTable[Index].FragmentBuffer, CopiedLen - sizeof (EFI_PXE_BASE_CODE_ICMP_ERROR)); + CopyMem ( + CopiedPointer, + RxData->FragmentTable[Index].FragmentBuffer, + CopiedLen - sizeof (EFI_PXE_BASE_CODE_ICMP_ERROR) + ); } CopiedPointer += CopiedLen; } @@ -205,10 +229,7 @@ Resume: @param Event The event signaled. @param Context The context passed in by the event notifier. - @return None. - **/ -STATIC VOID EFIAPI IcmpErrorListenHandler ( @@ -219,26 +240,72 @@ IcmpErrorListenHandler ( // // Request IpIoListenHandlerDpc as a DPC at TPL_CALLBACK // - NetLibQueueDpc (TPL_CALLBACK, IcmpErrorListenHandlerDpc, Context); + QueueDpc (TPL_CALLBACK, IcmpErrorListenHandlerDpc, Context); } -/** - GC_NOTO: Add function description - - @param This GC_NOTO: add argument - description - @param UseIpv6 GC_NOTO: add argument - description - - @retval EFI_INVALID_PARAMETER GC_NOTO: Add description for - return value - @retval EFI_ALREADY_STARTED GC_NOTO: Add description for - return value - @retval EFI_UNSUPPORTED GC_NOTO: Add description for - return value - @retval EFI_SUCCESS GC_NOTO: Add description for - return value - +/** + Enables the use of the PXE Base Code Protocol functions. + + This function enables the use of the PXE Base Code Protocol functions. If the + Started field of the EFI_PXE_BASE_CODE_MODE structure is already TRUE, then + EFI_ALREADY_STARTED will be returned. If UseIpv6 is TRUE, then IPv6 formatted + addresses will be used in this session. If UseIpv6 is FALSE, then IPv4 formatted + addresses will be used in this session. If UseIpv6 is TRUE, and the Ipv6Supported + field of the EFI_PXE_BASE_CODE_MODE structure is FALSE, then EFI_UNSUPPORTED will + be returned. If there is not enough memory or other resources to start the PXE + Base Code Protocol, then EFI_OUT_OF_RESOURCES will be returned. Otherwise, the + PXE Base Code Protocol will be started, and all of the fields of the EFI_PXE_BASE_CODE_MODE + structure will be initialized as follows: + StartedSet to TRUE. + Ipv6SupportedUnchanged. + Ipv6AvailableUnchanged. + UsingIpv6Set to UseIpv6. + BisSupportedUnchanged. + BisDetectedUnchanged. + AutoArpSet to TRUE. + SendGUIDSet to FALSE. + TTLSet to DEFAULT_TTL. + ToSSet to DEFAULT_ToS. + DhcpCompletedSet to FALSE. + ProxyOfferReceivedSet to FALSE. + StationIpSet to an address of all zeros. + SubnetMaskSet to a subnet mask of all zeros. + DhcpDiscoverZero-filled. + DhcpAckZero-filled. + ProxyOfferZero-filled. + PxeDiscoverValidSet to FALSE. + PxeDiscoverZero-filled. + PxeReplyValidSet to FALSE. + PxeReplyZero-filled. + PxeBisReplyValidSet to FALSE. + PxeBisReplyZero-filled. + IpFilterSet the Filters field to 0 and the IpCnt field to 0. + ArpCacheEntriesSet to 0. + ArpCacheZero-filled. + RouteTableEntriesSet to 0. + RouteTableZero-filled. + IcmpErrorReceivedSet to FALSE. + IcmpErrorZero-filled. + TftpErroReceivedSet to FALSE. + TftpErrorZero-filled. + MakeCallbacksSet to TRUE if the PXE Base Code Callback Protocol is available. + Set to FALSE if the PXE Base Code Callback Protocol is not available. + + @param This Pointer to the EFI_PXE_BASE_CODE_PROTOCOL instance. + @param UseIpv6 Specifies the type of IP addresses that are to be used during the session + that is being started. Set to TRUE for IPv6 addresses, and FALSE for + IPv4 addresses. + + @retval EFI_SUCCESS The PXE Base Code Protocol was started. + @retval EFI_DEVICE_ERROR The network device encountered an error during this oper + @retval EFI_UNSUPPORTED UseIpv6 is TRUE, but the Ipv6Supported field of the + EFI_PXE_BASE_CODE_MODE structure is FALSE. + @retval EFI_ALREADY_STARTED The PXE Base Code Protocol is already in the started state. + @retval EFI_INVALID_PARAMETER The This parameter is NULL or does not point to a valid + EFI_PXE_BASE_CODE_PROTOCOL structure. + @retval EFI_OUT_OF_RESOURCES Could not allocate enough memory or other resources to start the + PXE Base Code Protocol. + **/ EFI_STATUS EFIAPI @@ -272,7 +339,10 @@ EfiPxeBcStart ( // // Configure the udp4 instance to let it receive data // - Status = Private->Udp4Read->Configure (Private->Udp4Read, &Private->Udp4CfgData); + Status = Private->Udp4Read->Configure ( + Private->Udp4Read, + &Private->Udp4CfgData + ); if (EFI_ERROR (Status)) { return Status; } @@ -361,19 +431,22 @@ ON_EXIT: } -/** - GC_NOTO: Add function description - - @param This GC_NOTO: add argument - description - - @retval EFI_INVALID_PARAMETER GC_NOTO: Add description for - return value - @retval EFI_NOT_STARTED GC_NOTO: Add description for - return value - @retval EFI_SUCCESS GC_NOTO: Add description for - return value - +/** + Disables the use of the PXE Base Code Protocol functions. + + This function stops all activity on the network device. All the resources allocated + in Start() are released, the Started field of the EFI_PXE_BASE_CODE_MODE structure is + set to FALSE and EFI_SUCCESS is returned. If the Started field of the EFI_PXE_BASE_CODE_MODE + structure is already FALSE, then EFI_NOT_STARTED will be returned. + + @param This Pointer to the EFI_PXE_BASE_CODE_PROTOCOL instance. + + @retval EFI_SUCCESS The PXE Base Code Protocol was stopped. + @retval EFI_NOT_STARTED The PXE Base Code Protocol is already in the stopped state. + @retval EFI_INVALID_PARAMETER The This parameter is NULL or does not point to a valid + EFI_PXE_BASE_CODE_PROTOCOL structure. + @retval EFI_DEVICE_ERROR The network device encountered an error during this operation. + **/ EFI_STATUS EFIAPI @@ -400,7 +473,7 @@ EfiPxeBcStop ( // Dispatch the DPCs queued by the NotifyFunction of the canceled rx token's // events. // - NetLibDispatchDpc (); + DispatchDpc (); Private->Ip4->Configure (Private->Ip4, NULL); @@ -423,6 +496,7 @@ EfiPxeBcStop ( Private->CurrentUdpSrcPort = 0; Private->Udp4Write->Configure (Private->Udp4Write, NULL); + Private->Udp4Read->Groups (Private->Udp4Read, FALSE, NULL); Private->Udp4Read->Configure (Private->Udp4Read, NULL); Private->Dhcp4->Stop (Private->Dhcp4); @@ -434,19 +508,38 @@ EfiPxeBcStop ( } -/** - GC_NOTO: Add function description - - @param This GC_NOTO: add argument - description - @param SortOffers GC_NOTO: add argument - description - - @retval EFI_INVALID_PARAMETER GC_NOTO: Add description for - return value - @retval EFI_NOT_STARTED GC_NOTO: Add description for - return value - +/** + Attempts to complete a DHCPv4 D.O.R.A. (discover / offer / request / acknowledge) or DHCPv6 + S.A.R.R (solicit / advertise / request / reply) sequence. + + This function attempts to complete the DHCP sequence. If this sequence is completed, + then EFI_SUCCESS is returned, and the DhcpCompleted, ProxyOfferReceived, StationIp, + SubnetMask, DhcpDiscover, DhcpAck, and ProxyOffer fields of the EFI_PXE_BASE_CODE_MODE + structure are filled in. + If SortOffers is TRUE, then the cached DHCP offer packets will be sorted before + they are tried. If SortOffers is FALSE, then the cached DHCP offer packets will + be tried in the order in which they are received. Please see the Preboot Execution + Environment (PXE) Specification for additional details on the implementation of DHCP. + This function can take at least 31 seconds to timeout and return control to the + caller. If the DHCP sequence does not complete, then EFI_TIMEOUT will be returned. + If the Callback Protocol does not return EFI_PXE_BASE_CODE_CALLBACK_STATUS_CONTINUE, + then the DHCP sequence will be stopped and EFI_ABORTED will be returned. + + @param This Pointer to the EFI_PXE_BASE_CODE_PROTOCOL instance. + @param SortOffers TRUE if the offers received should be sorted. Set to FALSE to try the + offers in the order that they are received. + + @retval EFI_SUCCESS Valid DHCP has completed. + @retval EFI_NOT_STARTED The PXE Base Code Protocol is in the stopped state. + @retval EFI_INVALID_PARAMETER The This parameter is NULL or does not point to a valid + EFI_PXE_BASE_CODE_PROTOCOL structure. + @retval EFI_DEVICE_ERROR The network device encountered an error during this operation. + @retval EFI_OUT_OF_RESOURCES Could not allocate enough memory to complete the DHCP Protocol. + @retval EFI_ABORTED The callback function aborted the DHCP Protocol. + @retval EFI_TIMEOUT The DHCP Protocol timed out. + @retval EFI_ICMP_ERROR An ICMP error packet was received during the DHCP session. + @retval EFI_NO_RESPONSE Valid PXE offer was not received. + **/ EFI_STATUS EFIAPI @@ -462,8 +555,6 @@ EfiPxeBcDhcp ( EFI_DHCP4_MODE_DATA Dhcp4Mode; EFI_DHCP4_PACKET_OPTION *OptList[PXEBC_DHCP4_MAX_OPTION_NUM]; UINT32 OptCount; - UINT32 DiscoverTimeout; - UINTN Index; EFI_STATUS Status; EFI_ARP_CONFIG_DATA ArpConfigData; @@ -491,72 +582,62 @@ EfiPxeBcDhcp ( // // Set the DHCP4 config data. + // The four discovery timeouts are 4, 8, 16, 32 seconds respectively. // ZeroMem (&Dhcp4CfgData, sizeof (EFI_DHCP4_CONFIG_DATA)); Dhcp4CfgData.OptionCount = OptCount; Dhcp4CfgData.OptionList = OptList; Dhcp4CfgData.Dhcp4Callback = PxeBcDhcpCallBack; Dhcp4CfgData.CallbackContext = Private; - Dhcp4CfgData.DiscoverTryCount = 1; - Dhcp4CfgData.DiscoverTimeout = &DiscoverTimeout; + Dhcp4CfgData.DiscoverTryCount = 4; + Dhcp4CfgData.DiscoverTimeout = mPxeDhcpTimeout; - for (Index = 0; Index < PXEBC_DHCP4_DISCOVER_RETRIES; Index++) { - // - // The four discovery timeouts are 4, 8, 16, 32 seconds respectively. - // - DiscoverTimeout = (PXEBC_DHCP4_DISCOVER_INIT_TIMEOUT << Index); + Status = Dhcp4->Configure (Dhcp4, &Dhcp4CfgData); + if (EFI_ERROR (Status)) { + goto ON_EXIT; + } + + // + // Zero those arrays to record the varies numbers of DHCP OFFERS. + // + Private->GotProxyOffer = FALSE; + Private->NumOffers = 0; + Private->BootpIndex = 0; + ZeroMem (Private->ServerCount, sizeof (Private->ServerCount)); + ZeroMem (Private->ProxyIndex, sizeof (Private->ProxyIndex)); - Status = Dhcp4->Configure (Dhcp4, &Dhcp4CfgData); - if (EFI_ERROR (Status)) { - break; + Status = Dhcp4->Start (Dhcp4, NULL); + if (EFI_ERROR (Status)) { + if (Status == EFI_ICMP_ERROR) { + Mode->IcmpErrorReceived = TRUE; } - // - // Zero those arrays to record the varies numbers of DHCP OFFERS. - // - Private->NumOffers = 0; - Private->BootpIndex = 0; - ZeroMem (Private->ServerCount, sizeof (Private->ServerCount)); - ZeroMem (Private->ProxyIndex, sizeof (Private->ProxyIndex)); + goto ON_EXIT; + } - Status = Dhcp4->Start (Dhcp4, NULL); - if (EFI_ERROR (Status)) { - if (Status == EFI_TIMEOUT) { - // - // If no response is received or all received offers don't match - // the PXE boot requirements, EFI_TIMEOUT will be returned. - // - continue; - } - if (Status == EFI_ICMP_ERROR) { - Mode->IcmpErrorReceived = TRUE; - } - // - // Other error status means the DHCP really fails. - // - break; - } + Status = Dhcp4->GetModeData (Dhcp4, &Dhcp4Mode); + if (EFI_ERROR (Status)) { + goto ON_EXIT; + } - Status = Dhcp4->GetModeData (Dhcp4, &Dhcp4Mode); - if (EFI_ERROR (Status)) { - break; - } + ASSERT (Dhcp4Mode.State == Dhcp4Bound); - ASSERT (Dhcp4Mode.State == Dhcp4Bound); + CopyMem (&Private->StationIp, &Dhcp4Mode.ClientAddress, sizeof (EFI_IPv4_ADDRESS)); + CopyMem (&Private->SubnetMask, &Dhcp4Mode.SubnetMask, sizeof (EFI_IPv4_ADDRESS)); + CopyMem (&Private->GatewayIp, &Dhcp4Mode.RouterAddress, sizeof (EFI_IPv4_ADDRESS)); - CopyMem (&Private->StationIp, &Dhcp4Mode.ClientAddress, sizeof (EFI_IPv4_ADDRESS)); - CopyMem (&Private->SubnetMask, &Dhcp4Mode.SubnetMask, sizeof (EFI_IPv4_ADDRESS)); - CopyMem (&Private->GatewayIp, &Dhcp4Mode.RouterAddress, sizeof (EFI_IPv4_ADDRESS)); + CopyMem (&Mode->StationIp, &Private->StationIp, sizeof (EFI_IPv4_ADDRESS)); + CopyMem (&Mode->SubnetMask, &Private->SubnetMask, sizeof (EFI_IPv4_ADDRESS)); - // - // Check the selected offer to see whether BINL is required, if no or BINL is - // finished, set the various Mode members. - // - Status = PxeBcCheckSelectedOffer (Private); - if (!EFI_ERROR (Status)) { - break; - } + // + // Check the selected offer to see whether BINL is required, if no or BINL is + // finished, set the various Mode members. + // + Status = PxeBcCheckSelectedOffer (Private); + if (!EFI_ERROR (Status)) { + goto ON_EXIT; } +ON_EXIT: if (EFI_ERROR (Status)) { Dhcp4->Stop (Dhcp4); Dhcp4->Configure (Dhcp4, NULL); @@ -607,33 +688,48 @@ EfiPxeBcDhcp ( } -/** - GC_NOTO: Add function description - - @param This GC_NOTO: add argument - description - @param Type GC_NOTO: add argument - description - @param Layer GC_NOTO: add argument - description - @param UseBis GC_NOTO: add argument - description - @param Info GC_NOTO: add argument - description - - @retval EFI_INVALID_PARAMETER GC_NOTO: Add description for - return value - @retval EFI_NOT_STARTED GC_NOTO: Add description for - return value - @retval EFI_INVALID_PARAMETER GC_NOTO: Add description for - return value - @retval EFI_INVALID_PARAMETER GC_NOTO: Add description for - return value - @retval EFI_INVALID_PARAMETER GC_NOTO: Add description for - return value - @retval EFI_INVALID_PARAMETER GC_NOTO: Add description for - return value - +/** + Attempts to complete the PXE Boot Server and/or boot image discovery sequence. + + This function attempts to complete the PXE Boot Server and/or boot image discovery + sequence. If this sequence is completed, then EFI_SUCCESS is returned, and the + PxeDiscoverValid, PxeDiscover, PxeReplyReceived, and PxeReply fields of the + EFI_PXE_BASE_CODE_MODE structure are filled in. If UseBis is TRUE, then the + PxeBisReplyReceived and PxeBisReply fields of the EFI_PXE_BASE_CODE_MODE structure + will also be filled in. If UseBis is FALSE, then PxeBisReplyValid will be set to FALSE. + In the structure referenced by parameter Info, the PXE Boot Server list, SrvList[], + has two uses: It is the Boot Server IP address list used for unicast discovery + (if the UseUCast field is TRUE), and it is the list used for Boot Server verification + (if the MustUseList field is TRUE). Also, if the MustUseList field in that structure + is TRUE and the AcceptAnyResponse field in the SrvList[] array is TRUE, any Boot + Server reply of that type will be accepted. If the AcceptAnyResponse field is + FALSE, only responses from Boot Servers with matching IP addresses will be accepted. + This function can take at least 10 seconds to timeout and return control to the + caller. If the Discovery sequence does not complete, then EFI_TIMEOUT will be + returned. Please see the Preboot Execution Environment (PXE) Specification for + additional details on the implementation of the Discovery sequence. + If the Callback Protocol does not return EFI_PXE_BASE_CODE_CALLBACK_STATUS_CONTINUE, + then the Discovery sequence is stopped and EFI_ABORTED will be returned. + + @param This Pointer to the EFI_PXE_BASE_CODE_PROTOCOL instance. + @param Type The type of bootstrap to perform. + @param Layer Pointer to the boot server layer number to discover, which must be + PXE_BOOT_LAYER_INITIAL when a new server type is being + discovered. + @param UseBis TRUE if Boot Integrity Services are to be used. FALSE otherwise. + @param Info Pointer to a data structure that contains additional information on the + type of discovery operation that is to be performed. + + @retval EFI_SUCCESS The Discovery sequence has been completed. + @retval EFI_NOT_STARTED The PXE Base Code Protocol is in the stopped state. + @retval EFI_INVALID_PARAMETER One or more parameters are invalid. + @retval EFI_DEVICE_ERROR The network device encountered an error during this operation. + @retval EFI_OUT_OF_RESOURCES Could not allocate enough memory to complete Discovery. + @retval EFI_ABORTED The callback function aborted the Discovery sequence. + @retval EFI_TIMEOUT The Discovery sequence timed out. + @retval EFI_ICMP_ERROR An ICMP error packet was received during the PXE discovery + session. + **/ EFI_STATUS EFIAPI @@ -651,7 +747,7 @@ EfiPxeBcDiscover ( EFI_PXE_BASE_CODE_SRVLIST *SrvList; EFI_PXE_BASE_CODE_SRVLIST DefaultSrvList; PXEBC_CACHED_DHCP4_PACKET *Packet; - PXEBC_VENDOR_OPTION *VendorOpt; + PXEBC_VENDOR_OPTION *VendorOpt; UINT16 Index; EFI_STATUS Status; PXEBC_BOOT_SVR_ENTRY *BootSvrEntry; @@ -722,7 +818,11 @@ EfiPxeBcDiscover ( // // Get the multicast discover ip address from vendor option. // - CopyMem (&DefaultInfo.ServerMCastIp.Addr, &VendorOpt->DiscoverMcastIp, sizeof (EFI_IPv4_ADDRESS)); + CopyMem ( + &DefaultInfo.ServerMCastIp.Addr, + &VendorOpt->DiscoverMcastIp, + sizeof (EFI_IPv4_ADDRESS) + ); } DefaultInfo.IpCnt = 0; @@ -781,7 +881,11 @@ EfiPxeBcDiscover ( if (BootSvrEntry == NULL) { Private->ServerIp.Addr[0] = SrvList[Index].IpAddr.Addr[0]; } else { - CopyMem (&Private->ServerIp, &BootSvrEntry->IpAddr[Index], sizeof (EFI_IPv4_ADDRESS)); + CopyMem ( + &Private->ServerIp, + &BootSvrEntry->IpAddr[Index], + sizeof (EFI_IPv4_ADDRESS) + ); } Status = PxeBcDiscvBootService ( @@ -837,40 +941,87 @@ EfiPxeBcDiscover ( } if (Mode->PxeBisReplyReceived) { - CopyMem (&Private->ServerIp, &Mode->PxeReply.Dhcpv4.BootpSiAddr, sizeof (EFI_IPv4_ADDRESS)); + CopyMem ( + &Private->ServerIp, + &Mode->PxeReply.Dhcpv4.BootpSiAddr, + sizeof (EFI_IPv4_ADDRESS) + ); } return Status; } -/** - GC_NOTO: Add function description - - @param This GC_NOTO: add argument - description - @param Operation GC_NOTO: add argument - description - @param BufferPtr GC_NOTO: add argument - description - @param Overwrite GC_NOTO: add argument - description - @param BufferSize GC_NOTO: add argument - description - @param BlockSize GC_NOTO: add argument - description - @param ServerIp GC_NOTO: add argument - description - @param Filename GC_NOTO: add argument - description - @param Info GC_NOTO: add argument - description - @param DontUseBuffer GC_NOTO: add argument - description - - @retval EFI_INVALID_PARAMETER GC_NOTO: Add description for - return value - +/** + Used to perform TFTP and MTFTP services. + + This function is used to perform TFTP and MTFTP services. This includes the + TFTP operations to get the size of a file, read a directory, read a file, and + write a file. It also includes the MTFTP operations to get the size of a file, + read a directory, and read a file. The type of operation is specified by Operation. + If the callback function that is invoked during the TFTP/MTFTP operation does + not return EFI_PXE_BASE_CODE_CALLBACK_STATUS_CONTINUE, then EFI_ABORTED will + be returned. + For read operations, the return data will be placed in the buffer specified by + BufferPtr. If BufferSize is too small to contain the entire downloaded file, + then EFI_BUFFER_TOO_SMALL will be returned and BufferSize will be set to zero + or the size of the requested file (the size of the requested file is only returned + if the TFTP server supports TFTP options). If BufferSize is large enough for the + read operation, then BufferSize will be set to the size of the downloaded file, + and EFI_SUCCESS will be returned. Applications using the PxeBc.Mtftp() services + should use the get-file-size operations to determine the size of the downloaded + file prior to using the read-file operations-especially when downloading large + (greater than 64 MB) files-instead of making two calls to the read-file operation. + Following this recommendation will save time if the file is larger than expected + and the TFTP server does not support TFTP option extensions. Without TFTP option + extension support, the client has to download the entire file, counting and discarding + the received packets, to determine the file size. + For write operations, the data to be sent is in the buffer specified by BufferPtr. + BufferSize specifies the number of bytes to send. If the write operation completes + successfully, then EFI_SUCCESS will be returned. + For TFTP "get file size" operations, the size of the requested file or directory + is returned in BufferSize, and EFI_SUCCESS will be returned. If the TFTP server + does not support options, the file will be downloaded into a bit bucket and the + length of the downloaded file will be returned. For MTFTP "get file size" operations, + if the MTFTP server does not support the "get file size" option, EFI_UNSUPPORTED + will be returned. + This function can take up to 10 seconds to timeout and return control to the caller. + If the TFTP sequence does not complete, EFI_TIMEOUT will be returned. + If the Callback Protocol does not return EFI_PXE_BASE_CODE_CALLBACK_STATUS_CONTINUE, + then the TFTP sequence is stopped and EFI_ABORTED will be returned. + The format of the data returned from a TFTP read directory operation is a null-terminated + filename followed by a null-terminated information string, of the form + "size year-month-day hour:minute:second" (i.e. %d %d-%d-%d %d:%d:%f - note that + the seconds field can be a decimal number), where the date and time are UTC. For + an MTFTP read directory command, there is additionally a null-terminated multicast + IP address preceding the filename of the form %d.%d.%d.%d for IP v4. The final + entry is itself null-terminated, so that the final information string is terminated + with two null octets. + + @param This Pointer to the EFI_PXE_BASE_CODE_PROTOCOL instance. + @param Operation The type of operation to perform. + @param BufferPtr A pointer to the data buffer. + @param Overwrite Only used on write file operations. TRUE if a file on a remote server can + be overwritten. + @param BufferSize For get-file-size operations, *BufferSize returns the size of the + requested file. + @param BlockSize The requested block size to be used during a TFTP transfer. + @param ServerIp The TFTP / MTFTP server IP address. + @param Filename A Null-terminated ASCII string that specifies a directory name or a file + name. + @param Info Pointer to the MTFTP information. + @param DontUseBuffer Set to FALSE for normal TFTP and MTFTP read file operation. + + @retval EFI_SUCCESS The TFTP/MTFTP operation was completed. + @retval EFI_NOT_STARTED The PXE Base Code Protocol is in the stopped state. + @retval EFI_INVALID_PARAMETER One or more parameters are invalid. + @retval EFI_DEVICE_ERROR The network device encountered an error during this operation. + @retval EFI_BUFFER_TOO_SMALL The buffer is not large enough to complete the read operation. + @retval EFI_ABORTED The callback function aborted the TFTP/MTFTP operation. + @retval EFI_TIMEOUT The TFTP/MTFTP operation timed out. + @retval EFI_ICMP_ERROR An ICMP error packet was received during the MTFTP session. + @retval EFI_TFTP_ERROR A TFTP error packet was received during the MTFTP session. + **/ EFI_STATUS EFIAPI @@ -893,11 +1044,11 @@ EfiPxeBcMtftp ( EFI_PXE_BASE_CODE_MODE *Mode; EFI_MAC_ADDRESS TempMacAddr; - if ((This == NULL) || - (Filename == NULL) || - (BufferSize == NULL) || + if ((This == NULL) || + (Filename == NULL) || + (BufferSize == NULL) || ((ServerIp == NULL) || !Ip4IsUnicast (NTOHL (ServerIp->Addr[0]), 0)) || - ((BufferPtr == NULL) && DontUseBuffer) || + ((BufferPtr == NULL) && DontUseBuffer) || ((BlockSize != NULL) && (*BlockSize < 512))) { return EFI_INVALID_PARAMETER; @@ -924,10 +1075,26 @@ EfiPxeBcMtftp ( Mtftp4Config.TimeoutValue = PXEBC_MTFTP_TIMEOUT; Mtftp4Config.TryCount = PXEBC_MTFTP_RETRIES; - CopyMem (&Mtftp4Config.StationIp, &Private->StationIp, sizeof (EFI_IPv4_ADDRESS)); - CopyMem (&Mtftp4Config.SubnetMask, &Private->SubnetMask, sizeof (EFI_IPv4_ADDRESS)); - CopyMem (&Mtftp4Config.GatewayIp, &Private->GatewayIp, sizeof (EFI_IPv4_ADDRESS)); - CopyMem (&Mtftp4Config.ServerIp, ServerIp, sizeof (EFI_IPv4_ADDRESS)); + CopyMem ( + &Mtftp4Config.StationIp, + &Private->StationIp, + sizeof (EFI_IPv4_ADDRESS) + ); + CopyMem ( + &Mtftp4Config.SubnetMask, + &Private->SubnetMask, + sizeof (EFI_IPv4_ADDRESS) + ); + CopyMem ( + &Mtftp4Config.GatewayIp, + &Private->GatewayIp, + sizeof (EFI_IPv4_ADDRESS) + ); + CopyMem ( + &Mtftp4Config.ServerIp, + ServerIp, + sizeof (EFI_IPv4_ADDRESS) + ); switch (Operation) { @@ -941,10 +1108,6 @@ EfiPxeBcMtftp ( BufferSize ); - if (!EFI_ERROR (Status)) { - Status = EFI_BUFFER_TOO_SMALL; - } - break; case EFI_PXE_BASE_CODE_TFTP_READ_FILE: @@ -1009,43 +1172,42 @@ EfiPxeBcMtftp ( } -/** - GC_NOTO: Add function description - - @param This GC_NOTO: add argument - description - @param OpFlags GC_NOTO: add argument - description - @param DestIp GC_NOTO: add argument - description - @param DestPort GC_NOTO: add argument - description - @param GatewayIp GC_NOTO: add argument - description - @param SrcIp GC_NOTO: add argument - description - @param SrcPort GC_NOTO: add argument - description - @param HeaderSize GC_NOTO: add argument - description - @param HeaderPtr GC_NOTO: add argument - description - @param BufferSize GC_NOTO: add argument - description - @param BufferPtr GC_NOTO: add argument - description - - @retval EFI_INVALID_PARAMETER GC_NOTO: Add description for - return value - @retval EFI_INVALID_PARAMETER GC_NOTO: Add description for - return value - @retval EFI_INVALID_PARAMETER GC_NOTO: Add description for - return value - @retval EFI_INVALID_PARAMETER GC_NOTO: Add description for - return value - @retval EFI_OUT_OF_RESOURCES GC_NOTO: Add description for - return value - +/** + Writes a UDP packet to the network interface. + + This function writes a UDP packet specified by the (optional HeaderPtr and) + BufferPtr parameters to the network interface. The UDP header is automatically + built by this routine. It uses the parameters OpFlags, DestIp, DestPort, GatewayIp, + SrcIp, and SrcPort to build this header. If the packet is successfully built and + transmitted through the network interface, then EFI_SUCCESS will be returned. + If a timeout occurs during the transmission of the packet, then EFI_TIMEOUT will + be returned. If an ICMP error occurs during the transmission of the packet, then + the IcmpErrorReceived field is set to TRUE, the IcmpError field is filled in and + EFI_ICMP_ERROR will be returned. If the Callback Protocol does not return + EFI_PXE_BASE_CODE_CALLBACK_STATUS_CONTINUE, then EFI_ABORTED will be returned. + + @param This Pointer to the EFI_PXE_BASE_CODE_PROTOCOL instance. + @param OpFlags The UDP operation flags. + @param DestIp The destination IP address. + @param DestPort The destination UDP port number. + @param GatewayIp The gateway IP address. + @param SrcIp The source IP address. + @param SrcPort The source UDP port number. + @param HeaderSize An optional field which may be set to the length of a header at + HeaderPtr to be prefixed to the data at BufferPtr. + @param HeaderPtr If HeaderSize is not NULL, a pointer to a header to be prefixed to the + data at BufferPtr. + @param BufferSize A pointer to the size of the data at BufferPtr. + @param BufferPtr A pointer to the data to be written. + + @retval EFI_SUCCESS The UDP Write operation was completed. + @retval EFI_NOT_STARTED The PXE Base Code Protocol is in the stopped state. + @retval EFI_INVALID_PARAMETER One or more parameters are invalid. + @retval EFI_BAD_BUFFER_SIZE The buffer is too long to be transmitted. + @retval EFI_ABORTED The callback function aborted the UDP Write operation. + @retval EFI_TIMEOUT The UDP Write operation timed out. + @retval EFI_ICMP_ERROR An ICMP error packet was received during the UDP write session. + **/ EFI_STATUS EFIAPI @@ -1124,7 +1286,7 @@ EfiPxeBcUdpWrite ( Mode->IcmpErrorReceived = FALSE; if ((Private->CurrentUdpSrcPort == 0) || - ((SrcPort != NULL) && (*SrcPort != Private->CurrentUdpSrcPort))) { + ((SrcPort != NULL) && (*SrcPort != Private->CurrentUdpSrcPort))) { // // Port is changed, (re)configure the Udp4Write instance // @@ -1158,7 +1320,7 @@ EfiPxeBcUdpWrite ( } FragCount = (HeaderSize != NULL) ? 2 : 1; - Udp4TxData = (EFI_UDP4_TRANSMIT_DATA *) AllocatePool (sizeof (EFI_UDP4_TRANSMIT_DATA) + (FragCount - 1) * sizeof (EFI_UDP4_FRAGMENT_DATA)); + Udp4TxData = (EFI_UDP4_TRANSMIT_DATA *) AllocateZeroPool (sizeof (EFI_UDP4_TRANSMIT_DATA) + (FragCount - 1) * sizeof (EFI_UDP4_FRAGMENT_DATA)); if (Udp4TxData == NULL) { return EFI_OUT_OF_RESOURCES; } @@ -1220,29 +1382,27 @@ ON_EXIT: } /** - Validate IP packages by IP filter settings - - @param PxeBcMode Pointer to EFI_PXEBC_MODE - - @param Session Received UDP session + Decide whether the incoming UDP packet is acceptable per IP filter settings + in provided PxeBcMode. - @retval TRUE The UDP package matches IP filters + @param PxeBcMode Pointer to EFI_PXE_BASE_CODE_MODE. + @param Session Received UDP session. - @retval FLASE The UDP package doesn't matches IP filters + @retval TRUE The UDP package matches IP filters. + @retval FALSE The UDP package doesn't matches IP filters. **/ -STATIC BOOLEAN CheckIpByFilter ( - EFI_PXE_BASE_CODE_MODE *PxeBcMode, - EFI_UDP4_SESSION_DATA *Session + IN EFI_PXE_BASE_CODE_MODE *PxeBcMode, + IN EFI_UDP4_SESSION_DATA *Session ) { UINTN Index; EFI_IPv4_ADDRESS Ip4Address; EFI_IPv4_ADDRESS DestIp4Address; - if (PxeBcMode->IpFilter.Filters & EFI_PXE_BASE_CODE_IP_FILTER_PROMISCUOUS) { + if ((PxeBcMode->IpFilter.Filters & EFI_PXE_BASE_CODE_IP_FILTER_PROMISCUOUS) != 0) { return TRUE; } @@ -1266,8 +1426,14 @@ CheckIpByFilter ( return TRUE; } - for (Index = 0; Index < PxeBcMode->IpFilter.IpCnt; ++Index) { - CopyMem (&Ip4Address, &PxeBcMode->IpFilter.IpList[Index].v4, sizeof (Ip4Address)); + ASSERT (PxeBcMode->IpFilter.IpCnt < EFI_PXE_BASE_CODE_MAX_IPCNT); + + for (Index = 0; Index < PxeBcMode->IpFilter.IpCnt; Index++) { + CopyMem ( + &Ip4Address, + &PxeBcMode->IpFilter.IpList[Index].v4, + sizeof (Ip4Address) + ); if (EFI_IP4_EQUAL (&Ip4Address, &DestIp4Address)) { return TRUE; } @@ -1276,57 +1442,56 @@ CheckIpByFilter ( return FALSE; } -/** - GC_NOTO: Add function description - - @param This GC_NOTO: add argument - description - @param OpFlags GC_NOTO: add argument - description - @param DestIp GC_NOTO: add argument - description - @param DestPort GC_NOTO: add argument - description - @param SrcIp GC_NOTO: add argument - description - @param SrcPort GC_NOTO: add argument - description - @param HeaderSize GC_NOTO: add argument - description - @param HeaderPtr GC_NOTO: add argument - description - @param BufferSize GC_NOTO: add argument - description - @param BufferPtr GC_NOTO: add argument - description - - @retval EFI_INVALID_PARAMETER GC_NOTO: Add description for - return value - @retval EFI_INVALID_PARAMETER GC_NOTO: Add description for - return value - @retval EFI_INVALID_PARAMETER GC_NOTO: Add description for - return value - @retval EFI_INVALID_PARAMETER GC_NOTO: Add description for - return value - @retval EFI_NOT_STARTED GC_NOTO: Add description for - return value - @retval EFI_OUT_OF_RESOURCES GC_NOTO: Add description for - return value - +/** + Reads a UDP packet from the network interface. + + This function reads a UDP packet from a network interface. The data contents + are returned in (the optional HeaderPtr and) BufferPtr, and the size of the + buffer received is returned in BufferSize . If the input BufferSize is smaller + than the UDP packet received (less optional HeaderSize), it will be set to the + required size, and EFI_BUFFER_TOO_SMALL will be returned. In this case, the + contents of BufferPtr are undefined, and the packet is lost. If a UDP packet is + successfully received, then EFI_SUCCESS will be returned, and the information + from the UDP header will be returned in DestIp, DestPort, SrcIp, and SrcPort if + they are not NULL. Depending on the values of OpFlags and the DestIp, DestPort, + SrcIp, and SrcPort input values, different types of UDP packet receive filtering + will be performed. The following tables summarize these receive filter operations. + + @param This Pointer to the EFI_PXE_BASE_CODE_PROTOCOL instance. + @param OpFlags The UDP operation flags. + @param DestIp The destination IP address. + @param DestPort The destination UDP port number. + @param SrcIp The source IP address. + @param SrcPort The source UDP port number. + @param HeaderSize An optional field which may be set to the length of a header at + HeaderPtr to be prefixed to the data at BufferPtr. + @param HeaderPtr If HeaderSize is not NULL, a pointer to a header to be prefixed to the + data at BufferPtr. + @param BufferSize A pointer to the size of the data at BufferPtr. + @param BufferPtr A pointer to the data to be read. + + @retval EFI_SUCCESS The UDP Read operation was completed. + @retval EFI_NOT_STARTED The PXE Base Code Protocol is in the stopped state. + @retval EFI_INVALID_PARAMETER One or more parameters are invalid. + @retval EFI_DEVICE_ERROR The network device encountered an error during this operation. + @retval EFI_BUFFER_TOO_SMALL The packet is larger than Buffer can hold. + @retval EFI_ABORTED The callback function aborted the UDP Read operation. + @retval EFI_TIMEOUT The UDP Read operation timed out. + **/ EFI_STATUS EFIAPI EfiPxeBcUdpRead ( - IN EFI_PXE_BASE_CODE_PROTOCOL *This, - IN UINT16 OpFlags, - IN OUT EFI_IP_ADDRESS *DestIp, OPTIONAL - IN OUT EFI_PXE_BASE_CODE_UDP_PORT *DestPort, OPTIONAL - IN OUT EFI_IP_ADDRESS *SrcIp, OPTIONAL - IN OUT EFI_PXE_BASE_CODE_UDP_PORT *SrcPort, OPTIONAL - IN UINTN *HeaderSize, OPTIONAL - IN VOID *HeaderPtr, OPTIONAL - IN OUT UINTN *BufferSize, - IN VOID *BufferPtr + IN EFI_PXE_BASE_CODE_PROTOCOL *This, + IN UINT16 OpFlags, + IN OUT EFI_IP_ADDRESS *DestIp OPTIONAL, + IN OUT EFI_PXE_BASE_CODE_UDP_PORT *DestPort OPTIONAL, + IN OUT EFI_IP_ADDRESS *SrcIp OPTIONAL, + IN OUT EFI_PXE_BASE_CODE_UDP_PORT *SrcPort OPTIONAL, + IN UINTN *HeaderSize OPTIONAL, + IN VOID *HeaderPtr OPTIONAL, + IN OUT UINTN *BufferSize, + IN VOID *BufferPtr ) { PXEBC_PRIVATE_DATA *Private; @@ -1344,9 +1509,9 @@ EfiPxeBcUdpRead ( return EFI_INVALID_PARAMETER; } - if ((!(OpFlags & EFI_PXE_BASE_CODE_UDP_OPFLAGS_ANY_DEST_PORT) && (DestPort == NULL)) || - (!(OpFlags & EFI_PXE_BASE_CODE_UDP_OPFLAGS_ANY_DEST_PORT) && (SrcIp == NULL)) || - (!(OpFlags & EFI_PXE_BASE_CODE_UDP_OPFLAGS_ANY_SRC_PORT) && (SrcPort == NULL))) { + if (((OpFlags & EFI_PXE_BASE_CODE_UDP_OPFLAGS_ANY_DEST_PORT) == 0 && (DestPort == NULL)) || + ((OpFlags & EFI_PXE_BASE_CODE_UDP_OPFLAGS_ANY_DEST_PORT) == 0 && (SrcIp == NULL)) || + ((OpFlags & EFI_PXE_BASE_CODE_UDP_OPFLAGS_ANY_SRC_PORT) == 0 && (SrcPort == NULL))) { return EFI_INVALID_PARAMETER; } @@ -1406,9 +1571,10 @@ TRY_AGAIN: RxData = Token.Packet.RxData; Session = &RxData->UdpSession; - Matched = FALSE; + Matched = TRUE; - if (OpFlags & EFI_PXE_BASE_CODE_UDP_OPFLAGS_USE_FILTER) { + if ((OpFlags & EFI_PXE_BASE_CODE_UDP_OPFLAGS_USE_FILTER) != 0) { + Matched = FALSE; // // Check UDP package by IP filter settings // @@ -1423,7 +1589,7 @@ TRY_AGAIN: // // Match the destination ip of the received udp dgram // - if (OpFlags & EFI_PXE_BASE_CODE_UDP_OPFLAGS_ANY_DEST_IP) { + if ((OpFlags & EFI_PXE_BASE_CODE_UDP_OPFLAGS_ANY_DEST_IP) != 0) { Matched = TRUE; if (DestIp != NULL) { @@ -1446,7 +1612,7 @@ TRY_AGAIN: // // Match the destination port of the received udp dgram // - if (OpFlags & EFI_PXE_BASE_CODE_UDP_OPFLAGS_ANY_DEST_PORT) { + if ((OpFlags & EFI_PXE_BASE_CODE_UDP_OPFLAGS_ANY_DEST_PORT) != 0) { if (DestPort != NULL) { *DestPort = Session->DestinationPort; @@ -1463,7 +1629,7 @@ TRY_AGAIN: // // Match the source ip of the received udp dgram // - if (OpFlags & EFI_PXE_BASE_CODE_UDP_OPFLAGS_ANY_SRC_IP) { + if ((OpFlags & EFI_PXE_BASE_CODE_UDP_OPFLAGS_ANY_SRC_IP) != 0) { if (SrcIp != NULL) { CopyMem (SrcIp, &Session->SourceAddress, sizeof (EFI_IPv4_ADDRESS)); @@ -1480,7 +1646,7 @@ TRY_AGAIN: // // Match the source port of the received udp dgram // - if (OpFlags & EFI_PXE_BASE_CODE_UDP_OPFLAGS_ANY_SRC_PORT) { + if ((OpFlags & EFI_PXE_BASE_CODE_UDP_OPFLAGS_ANY_SRC_PORT) != 0) { if (SrcPort != NULL) { *SrcPort = Session->SourcePort; @@ -1509,7 +1675,11 @@ TRY_AGAIN: } else { *BufferSize = RxData->DataLength - CopyLen; - CopyMem (BufferPtr, (UINT8 *) RxData->FragmentTable[0].FragmentBuffer + CopyLen, *BufferSize); + CopyMem ( + BufferPtr, + (UINT8 *) RxData->FragmentTable[0].FragmentBuffer + CopyLen, + *BufferSize + ); } } else { @@ -1535,18 +1705,37 @@ ON_EXIT: return Status; } - -/** - GC_NOTO: Add function description - - @param This GC_NOTO: add argument - description - @param NewFilter GC_NOTO: add argument - description - - @retval EFI_UNSUPPORTED GC_NOTO: Add description for - return value - +/** + Updates the IP receive filters of a network device and enables software filtering. + + The NewFilter field is used to modify the network device's current IP receive + filter settings and to enable a software filter. This function updates the IpFilter + field of the EFI_PXE_BASE_CODE_MODE structure with the contents of NewIpFilter. + The software filter is used when the USE_FILTER in OpFlags is set to UdpRead(). + The current hardware filter remains in effect no matter what the settings of OpFlags + are, so that the meaning of ANY_DEST_IP set in OpFlags to UdpRead() is from those + packets whose reception is enabled in hardware-physical NIC address (unicast), + broadcast address, logical address or addresses (multicast), or all (promiscuous). + UdpRead() does not modify the IP filter settings. + Dhcp(), Discover(), and Mtftp() set the IP filter, and return with the IP receive + filter list emptied and the filter set to EFI_PXE_BASE_CODE_IP_FILTER_STATION_IP. + If an application or driver wishes to preserve the IP receive filter settings, + it will have to preserve the IP receive filter settings before these calls, and + use SetIpFilter() to restore them after the calls. If incompatible filtering is + requested (for example, PROMISCUOUS with anything else) or if the device does not + support a requested filter setting and it cannot be accommodated in software + (for example, PROMISCUOUS not supported), EFI_INVALID_PARAMETER will be returned. + The IPlist field is used to enable IPs other than the StationIP. They may be + multicast or unicast. If IPcnt is set as well as EFI_PXE_BASE_CODE_IP_FILTER_STATION_IP, + then both the StationIP and the IPs from the IPlist will be used. + + @param This Pointer to the EFI_PXE_BASE_CODE_PROTOCOL instance. + @param NewFilter Pointer to the new set of IP receive filters. + + @retval EFI_SUCCESS The IP receive filter settings were updated. + @retval EFI_NOT_STARTED The PXE Base Code Protocol is in the stopped state. + @retval EFI_INVALID_PARAMETER One or more parameters are invalid. + **/ EFI_STATUS EFIAPI @@ -1562,20 +1751,20 @@ EfiPxeBcSetIpFilter ( BOOLEAN PromiscuousNeed; if (This == NULL) { - DEBUG ((EFI_D_ERROR, "BC *This pointer == NULL.\n")); + DEBUG ((EFI_D_ERROR, "This == NULL.\n")); return EFI_INVALID_PARAMETER; } Private = PXEBC_PRIVATE_DATA_FROM_PXEBC (This); Mode = Private->PxeBc.Mode; - if (Private == NULL) { - DEBUG ((EFI_D_ERROR, "PXEBC_PRIVATE_DATA poiner == NULL.\n")); + if (NewFilter == NULL) { + DEBUG ((EFI_D_ERROR, "NewFilter == NULL.\n")); return EFI_INVALID_PARAMETER; } - if (NewFilter == NULL) { - DEBUG ((EFI_D_ERROR, "IP Filter *NewFilter == NULL.\n")); + if (NewFilter->IpCnt > EFI_PXE_BASE_CODE_MAX_IPCNT) { + DEBUG ((EFI_D_ERROR, "NewFilter->IpCnt > %d.\n", EFI_PXE_BASE_CODE_MAX_IPCNT)); return EFI_INVALID_PARAMETER; } @@ -1585,6 +1774,7 @@ EfiPxeBcSetIpFilter ( } PromiscuousNeed = FALSE; + for (Index = 0; Index < NewFilter->IpCnt; ++Index) { if (IP4_IS_LOCAL_BROADCAST (EFI_IP4 (NewFilter->IpList[Index].v4))) { // @@ -1672,19 +1862,32 @@ EfiPxeBcSetIpFilter ( } -/** - GC_NOTO: Add function description - - @param This GC_NOTO: add argument - description - @param IpAddr GC_NOTO: add argument - description - @param MacAddr GC_NOTO: add argument - description - - @retval EFI_UNSUPPORTED GC_NOTO: Add description for - return value - +/** + Uses the ARP protocol to resolve a MAC address. + + This function uses the ARP protocol to resolve a MAC address. The UsingIpv6 field + of the EFI_PXE_BASE_CODE_MODE structure is used to determine if IPv4 or IPv6 + addresses are being used. The IP address specified by IpAddr is used to resolve + a MAC address. If the ARP protocol succeeds in resolving the specified address, + then the ArpCacheEntries and ArpCache fields of the EFI_PXE_BASE_CODE_MODE structure + are updated, and EFI_SUCCESS is returned. If MacAddr is not NULL, the resolved + MAC address is placed there as well. If the PXE Base Code protocol is in the + stopped state, then EFI_NOT_STARTED is returned. If the ARP protocol encounters + a timeout condition while attempting to resolve an address, then EFI_TIMEOUT is + returned. If the Callback Protocol does not return EFI_PXE_BASE_CODE_CALLBACK_STATUS_CONTINUE, + then EFI_ABORTED is returned. + + @param This Pointer to the EFI_PXE_BASE_CODE_PROTOCOL instance. + @param IpAddr Pointer to the IP address that is used to resolve a MAC address. + @param MacAddr If not NULL, a pointer to the MAC address that was resolved with the + ARP protocol. + + @retval EFI_SUCCESS The IP or MAC address was resolved. + @retval EFI_NOT_STARTED The PXE Base Code Protocol is in the stopped state. + @retval EFI_INVALID_PARAMETER One or more parameters are invalid. + @retval EFI_DEVICE_ERROR The network device encountered an error during this operation. + @retval EFI_ICMP_ERROR Something error occur with the ICMP packet message. + **/ EFI_STATUS EFIAPI @@ -1745,35 +1948,46 @@ EfiPxeBcArp ( return EFI_SUCCESS; } - - -/** - GC_NOTO: Add function description - - @param This GC_NOTO: add argument - description - @param NewAutoArp GC_NOTO: add argument - description - @param NewSendGUID GC_NOTO: add argument - description - @param NewTTL GC_NOTO: add argument - description - @param NewToS GC_NOTO: add argument - description - @param NewMakeCallback GC_NOTO: add argument - description - - @return GC_NOTO: add return values - +/** + Updates the parameters that affect the operation of the PXE Base Code Protocol. + + This function sets parameters that affect the operation of the PXE Base Code Protocol. + The parameter specified by NewAutoArp is used to control the generation of ARP + protocol packets. If NewAutoArp is TRUE, then ARP Protocol packets will be generated + as required by the PXE Base Code Protocol. If NewAutoArp is FALSE, then no ARP + Protocol packets will be generated. In this case, the only mappings that are + available are those stored in the ArpCache of the EFI_PXE_BASE_CODE_MODE structure. + If there are not enough mappings in the ArpCache to perform a PXE Base Code Protocol + service, then the service will fail. This function updates the AutoArp field of + the EFI_PXE_BASE_CODE_MODE structure to NewAutoArp. + The SetParameters() call must be invoked after a Callback Protocol is installed + to enable the use of callbacks. + + @param This Pointer to the EFI_PXE_BASE_CODE_PROTOCOL instance. + @param NewAutoArp If not NULL, a pointer to a value that specifies whether to replace the + current value of AutoARP. + @param NewSendGUID If not NULL, a pointer to a value that specifies whether to replace the + current value of SendGUID. + @param NewTTL If not NULL, a pointer to be used in place of the current value of TTL, + the "time to live" field of the IP header. + @param NewToS If not NULL, a pointer to be used in place of the current value of ToS, + the "type of service" field of the IP header. + @param NewMakeCallback If not NULL, a pointer to a value that specifies whether to replace the + current value of the MakeCallback field of the Mode structure. + + @retval EFI_SUCCESS The new parameters values were updated. + @retval EFI_NOT_STARTED The PXE Base Code Protocol is in the stopped state. + @retval EFI_INVALID_PARAMETER One or more parameters are invalid. + **/ EFI_STATUS EFIAPI EfiPxeBcSetParameters ( IN EFI_PXE_BASE_CODE_PROTOCOL *This, - IN BOOLEAN *NewAutoArp, OPTIONAL - IN BOOLEAN *NewSendGUID, OPTIONAL - IN UINT8 *NewTTL, OPTIONAL - IN UINT8 *NewToS, OPTIONAL + IN BOOLEAN *NewAutoArp OPTIONAL, + IN BOOLEAN *NewSendGUID OPTIONAL, + IN UINT8 *NewTTL OPTIONAL, + IN UINT8 *NewToS OPTIONAL, IN BOOLEAN *NewMakeCallback // OPTIONAL ) { @@ -1791,13 +2005,13 @@ EfiPxeBcSetParameters ( Private = PXEBC_PRIVATE_DATA_FROM_PXEBC (This); Mode = Private->PxeBc.Mode; - if (NewSendGUID != NULL && *NewSendGUID == TRUE) { + if (NewSendGUID != NULL && *NewSendGUID) { // // FixMe, cann't locate SendGuid // } - if (NewMakeCallback != NULL && *NewMakeCallback == TRUE) { + if (NewMakeCallback != NULL && *NewMakeCallback) { Status = gBS->HandleProtocol ( Private->Controller, @@ -1859,34 +2073,32 @@ ON_EXIT: return Status; } - -/** - GC_NOTO: Add function description - - @param This GC_NOTO: add argument - description - @param NewStationIp GC_NOTO: add argument - description - @param NewSubnetMask GC_NOTO: add argument - description - - @retval EFI_INVALID_PARAMETER GC_NOTO: Add description for - return value - @retval EFI_INVALID_PARAMETER GC_NOTO: Add description for - return value - @retval EFI_INVALID_PARAMETER GC_NOTO: Add description for - return value - @retval EFI_NOT_STARTED GC_NOTO: Add description for - return value - @retval EFI_SUCCESS GC_NOTO: Add description for - return value - +/** + Updates the station IP address and/or subnet mask values of a network device. + + This function updates the station IP address and/or subnet mask values of a network + device. The NewStationIp field is used to modify the network device's current IP address. + If NewStationIP is NULL, then the current IP address will not be modified. Otherwise, + this function updates the StationIp field of the EFI_PXE_BASE_CODE_MODE structure + with NewStationIp. The NewSubnetMask field is used to modify the network device's current subnet + mask. If NewSubnetMask is NULL, then the current subnet mask will not be modified. + Otherwise, this function updates the SubnetMask field of the EFI_PXE_BASE_CODE_MODE + structure with NewSubnetMask. + + @param This Pointer to the EFI_PXE_BASE_CODE_PROTOCOL instance. + @param NewStationIp Pointer to the new IP address to be used by the network device. + @param NewSubnetMask Pointer to the new subnet mask to be used by the network device. + + @retval EFI_SUCCESS The new station IP address and/or subnet mask were updated. + @retval EFI_NOT_STARTED The PXE Base Code Protocol is in the stopped state. + @retval EFI_INVALID_PARAMETER One or more parameters are invalid. + **/ EFI_STATUS EFIAPI EfiPxeBcSetStationIP ( IN EFI_PXE_BASE_CODE_PROTOCOL * This, - IN EFI_IP_ADDRESS * NewStationIp, OPTIONAL + IN EFI_IP_ADDRESS * NewStationIp OPTIONAL, IN EFI_IP_ADDRESS * NewSubnetMask OPTIONAL ) { @@ -1914,13 +2126,13 @@ EfiPxeBcSetStationIP ( } if (NewStationIp != NULL) { - Mode->StationIp = *NewStationIp; - Private->StationIp = *NewStationIp; + CopyMem (&Mode->StationIp, NewStationIp, sizeof (EFI_IP_ADDRESS)); + CopyMem (&Private->StationIp, NewStationIp, sizeof (EFI_IP_ADDRESS)); } if (NewSubnetMask != NULL) { - Mode->SubnetMask = *NewSubnetMask; - Private->SubnetMask = *NewSubnetMask; + CopyMem (&Mode->SubnetMask, NewSubnetMask, sizeof (EFI_IP_ADDRESS)); + CopyMem (&Private->SubnetMask ,NewSubnetMask, sizeof (EFI_IP_ADDRESS)); } Private->AddressIsOk = TRUE; @@ -1951,60 +2163,52 @@ EfiPxeBcSetStationIP ( return EFI_SUCCESS; } - -/** - GC_NOTO: Add function description - - @param This GC_NOTO: add argument - description - @param NewDhcpDiscoverValid GC_NOTO: add argument - description - @param NewDhcpAckReceived GC_NOTO: add argument - description - @param NewProxyOfferReceived GC_NOTO: add argument - description - @param NewPxeDiscoverValid GC_NOTO: add argument - description - @param NewPxeReplyReceived GC_NOTO: add argument - description - @param NewPxeBisReplyReceived GC_NOTO: add argument - description - @param NewDhcpDiscover GC_NOTO: add argument - description - @param NewDhcpAck GC_NOTO: add argument - description - @param NewProxyOffer GC_NOTO: add argument - description - @param NewPxeDiscover GC_NOTO: add argument - description - @param NewPxeReply GC_NOTO: add argument - description - @param NewPxeBisReply GC_NOTO: add argument - description - - @retval EFI_INVALID_PARAMETER GC_NOTO: Add description for - return value - @retval EFI_NOT_STARTED GC_NOTO: Add description for - return value - @retval EFI_SUCCESS GC_NOTO: Add description for - return value - +/** + Updates the contents of the cached DHCP and Discover packets. + + The pointers to the new packets are used to update the contents of the cached + packets in the EFI_PXE_BASE_CODE_MODE structure. + + @param This Pointer to the EFI_PXE_BASE_CODE_PROTOCOL instance. + @param NewDhcpDiscoverValid Pointer to a value that will replace the current + DhcpDiscoverValid field. + @param NewDhcpAckReceived Pointer to a value that will replace the current + DhcpAckReceived field. + @param NewProxyOfferReceived Pointer to a value that will replace the current + ProxyOfferReceived field. + @param NewPxeDiscoverValid Pointer to a value that will replace the current + ProxyOfferReceived field. + @param NewPxeReplyReceived Pointer to a value that will replace the current + PxeReplyReceived field. + @param NewPxeBisReplyReceived Pointer to a value that will replace the current + PxeBisReplyReceived field. + @param NewDhcpDiscover Pointer to the new cached DHCP Discover packet contents. + @param NewDhcpAck Pointer to the new cached DHCP Ack packet contents. + @param NewProxyOffer Pointer to the new cached Proxy Offer packet contents. + @param NewPxeDiscover Pointer to the new cached PXE Discover packet contents. + @param NewPxeReply Pointer to the new cached PXE Reply packet contents. + @param NewPxeBisReply Pointer to the new cached PXE BIS Reply packet contents. + + @retval EFI_SUCCESS The cached packet contents were updated. + @retval EFI_NOT_STARTED The PXE Base Code Protocol is in the stopped state. + @retval EFI_INVALID_PARAMETER This is NULL or not point to a valid EFI_PXE_BASE_CODE_PROTOCOL structure. + **/ EFI_STATUS EFIAPI EfiPxeBcSetPackets ( IN EFI_PXE_BASE_CODE_PROTOCOL * This, - IN BOOLEAN * NewDhcpDiscoverValid, OPTIONAL - IN BOOLEAN * NewDhcpAckReceived, OPTIONAL - IN BOOLEAN * NewProxyOfferReceived, OPTIONAL - IN BOOLEAN * NewPxeDiscoverValid, OPTIONAL - IN BOOLEAN * NewPxeReplyReceived, OPTIONAL - IN BOOLEAN * NewPxeBisReplyReceived, OPTIONAL - IN EFI_PXE_BASE_CODE_PACKET * NewDhcpDiscover, OPTIONAL - IN EFI_PXE_BASE_CODE_PACKET * NewDhcpAck, OPTIONAL - IN EFI_PXE_BASE_CODE_PACKET * NewProxyOffer, OPTIONAL - IN EFI_PXE_BASE_CODE_PACKET * NewPxeDiscover, OPTIONAL - IN EFI_PXE_BASE_CODE_PACKET * NewPxeReply, OPTIONAL + IN BOOLEAN * NewDhcpDiscoverValid OPTIONAL, + IN BOOLEAN * NewDhcpAckReceived OPTIONAL, + IN BOOLEAN * NewProxyOfferReceived OPTIONAL, + IN BOOLEAN * NewPxeDiscoverValid OPTIONAL, + IN BOOLEAN * NewPxeReplyReceived OPTIONAL, + IN BOOLEAN * NewPxeBisReplyReceived OPTIONAL, + IN EFI_PXE_BASE_CODE_PACKET * NewDhcpDiscover OPTIONAL, + IN EFI_PXE_BASE_CODE_PACKET * NewDhcpAck OPTIONAL, + IN EFI_PXE_BASE_CODE_PACKET * NewProxyOffer OPTIONAL, + IN EFI_PXE_BASE_CODE_PACKET * NewPxeDiscover OPTIONAL, + IN EFI_PXE_BASE_CODE_PACKET * NewPxeReply OPTIONAL, IN EFI_PXE_BASE_CODE_PACKET * NewPxeBisReply OPTIONAL ) { @@ -2092,32 +2296,32 @@ EFI_PXE_BASE_CODE_PROTOCOL mPxeBcProtocolTemplate = { NULL }; - -/** - GC_NOTO: Add function description - - @param This GC_NOTO: add argument - description - @param Function GC_NOTO: add argument - description - @param Received GC_NOTO: add argument - description - @param PacketLength GC_NOTO: add argument - description - @param PacketPtr GC_NOTO: add argument - description - - @retval EFI_PXE_BASE_CODE_CALLBACK_STATUS_ABORT GC_NOTO: Add description for - return value - @retval EFI_PXE_BASE_CODE_CALLBACK_STATUS_CONTINUE GC_NOTO: Add description for - return value - @retval EFI_PXE_BASE_CODE_CALLBACK_STATUS_CONTINUE GC_NOTO: Add description for - return value - @retval EFI_PXE_BASE_CODE_CALLBACK_STATUS_CONTINUE GC_NOTO: Add description for - return value - @retval EFI_PXE_BASE_CODE_CALLBACK_STATUS_CONTINUE GC_NOTO: Add description for - return value - +/** + Callback function that is invoked when the PXE Base Code Protocol is about to transmit, has + received, or is waiting to receive a packet. + + This function is invoked when the PXE Base Code Protocol is about to transmit, has received, + or is waiting to receive a packet. Parameters Function and Received specify the type of event. + Parameters PacketLen and Packet specify the packet that generated the event. If these fields + are zero and NULL respectively, then this is a status update callback. If the operation specified + by Function is to continue, then CALLBACK_STATUS_CONTINUE should be returned. If the operation + specified by Function should be aborted, then CALLBACK_STATUS_ABORT should be returned. Due to + the polling nature of UEFI device drivers, a callback function should not execute for more than 5 ms. + The SetParameters() function must be called after a Callback Protocol is installed to enable the + use of callbacks. + + @param This Pointer to the EFI_PXE_BASE_CODE_CALLBACK_PROTOCOL instance. + @param Function The PXE Base Code Protocol function that is waiting for an event. + @param Received TRUE if the callback is being invoked due to a receive event. FALSE if + the callback is being invoked due to a transmit event. + @param PacketLength The length, in bytes, of Packet. This field will have a value of zero if + this is a wait for receive event. + @param PacketPtr If Received is TRUE, a pointer to the packet that was just received; + otherwise a pointer to the packet that is about to be transmitted. + + @retval EFI_PXE_BASE_CODE_CALLBACK_STATUS_CONTINUE if Function specifies a continue operation + @retval EFI_PXE_BASE_CODE_CALLBACK_STATUS_ABORT if Function specifies an abort operation + **/ EFI_PXE_BASE_CODE_CALLBACK_STATUS EFIAPI @@ -2192,17 +2396,17 @@ EFI_PXE_BASE_CODE_CALLBACK_PROTOCOL mPxeBcCallBackTemplate = { /** - GC_NOTO: Add function description + Find the boot file. - @param Private GC_NOTO: add argument - description - @param BufferSize GC_NOTO: add argument - description - @param Buffer GC_NOTO: add argument - description - - @return GC_NOTO: add return values + @param Private Pointer to PxeBc private data. + @param BufferSize Pointer to buffer size. + @param Buffer Pointer to buffer. + @retval EFI_SUCCESS Discover the boot file successfully. + @retval EFI_TIMEOUT The TFTP/MTFTP operation timed out. + @retval EFI_ABORTED PXE bootstrap server, so local boot need abort. + @retval EFI_BUFFER_TOO_SMALL The buffer is too small to load the boot file. + **/ EFI_STATUS DiscoverBootFile ( @@ -2275,16 +2479,26 @@ DiscoverBootFile ( Packet = &Private->Dhcp4Ack; } - CopyMem (&Private->ServerIp, &Packet->Packet.Offer.Dhcp4.Header.ServerAddr, sizeof (EFI_IPv4_ADDRESS)); - if (Private->ServerIp.Addr[0] == 0) { - // - // next server ip address is zero, use option 54 instead - // + // + // Use siaddr(next server) in DHCPOFFER packet header, if zero, use option 54(server identifier) + // in DHCPOFFER packet. + // (It does not comply with PXE Spec, Ver2.1) + // + if (EFI_IP4_EQUAL (&Packet->Packet.Offer.Dhcp4.Header.ServerAddr, &mZeroIp4Addr)) { CopyMem ( &Private->ServerIp, Packet->Dhcp4Option[PXEBC_DHCP4_TAG_INDEX_SERVER_ID]->Data, sizeof (EFI_IPv4_ADDRESS) ); + } else { + CopyMem ( + &Private->ServerIp, + &Packet->Packet.Offer.Dhcp4.Header.ServerAddr, + sizeof (EFI_IPv4_ADDRESS) + ); + } + if (Private->ServerIp.Addr[0] == 0) { + return EFI_DEVICE_ERROR; } ASSERT (Packet->Dhcp4Option[PXEBC_DHCP4_TAG_INDEX_BOOTFILE] != NULL); @@ -2325,25 +2539,32 @@ DiscoverBootFile ( return Status; } - /** - GC_NOTO: Add function description - - @param This GC_NOTO: add argument - description - @param FilePath GC_NOTO: add argument - description - @param BootPolicy GC_NOTO: add argument - description - @param BufferSize GC_NOTO: add argument - description - @param Buffer GC_NOTO: add argument - description - - @retval EFI_INVALID_PARAMETER GC_NOTO: Add description for - return value - @retval EFI_UNSUPPORTED GC_NOTO: Add description for - return value + Causes the driver to load a specified file. + + @param This Protocol instance pointer. + @param FilePath The device specific path of the file to load. + @param BootPolicy If TRUE, indicates that the request originates from the + boot manager is attempting to load FilePath as a boot + selection. If FALSE, then FilePath must match as exact file + to be loaded. + @param BufferSize On input the size of Buffer in bytes. On output with a return + code of EFI_SUCCESS, the amount of data transferred to + Buffer. On output with a return code of EFI_BUFFER_TOO_SMALL, + the size of Buffer required to retrieve the requested file. + @param Buffer The memory buffer to transfer the file to. IF Buffer is NULL, + then no the size of the requested file is returned in + BufferSize. + + @retval EFI_SUCCESS The file was loaded. + @retval EFI_UNSUPPORTED The device does not support the provided BootPolicy + @retval EFI_INVALID_PARAMETER FilePath is not a valid device path, or + BufferSize is NULL. + @retval EFI_NO_MEDIA No medium was present to load the file. + @retval EFI_DEVICE_ERROR The file was not loaded due to a device error. + @retval EFI_NO_RESPONSE The remote system did not respond. + @retval EFI_NOT_FOUND The file was not found. + @retval EFI_ABORTED The file load process was manually cancelled. **/ EFI_STATUS @@ -2417,10 +2638,25 @@ EfiPxeLoadFile ( if (sizeof (UINTN) < sizeof (UINT64) && (TmpBufSize > 0xFFFFFFFF)) { Status = EFI_DEVICE_ERROR; - } else { + } else if (TmpBufSize > 0 && *BufferSize >= (UINTN) TmpBufSize && Buffer != NULL) { + *BufferSize = (UINTN) TmpBufSize; + Status = PxeBc->Mtftp ( + PxeBc, + EFI_PXE_BASE_CODE_TFTP_READ_FILE, + Buffer, + FALSE, + &TmpBufSize, + &BlockSize, + &Private->ServerIp, + (UINT8 *) Private->BootFileName, + NULL, + FALSE + ); + } else if (TmpBufSize > 0) { *BufferSize = (UINTN) TmpBufSize; + Status = EFI_BUFFER_TOO_SMALL; } - } else if (Buffer == NULL) { + } else if (Buffer == NULL || Private->FileSize > *BufferSize) { *BufferSize = Private->FileSize; Status = EFI_BUFFER_TOO_SMALL; } else {