X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=blobdiff_plain;f=NetworkPkg%2FIScsiDxe%2FIScsiMisc.c;h=38ad67917c300d0369c4df0466b421210a07917c;hp=93c0d0c67294f32ef1b0f3c609fed8b6921ecc41;hb=ecf98fbcf858b9cb09ff0ac1c2a09c0111b4026b;hpb=b9679cd7458110573dd4614148433312b61a1e26 diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c b/NetworkPkg/IScsiDxe/IScsiMisc.c index 93c0d0c672..38ad67917c 100644 --- a/NetworkPkg/IScsiDxe/IScsiMisc.c +++ b/NetworkPkg/IScsiDxe/IScsiMisc.c @@ -1,14 +1,8 @@ /** @file Miscellaneous routines for iSCSI driver. -Copyright (c) 2004 - 2016, Intel Corporation. All rights reserved.
-This program and the accompanying materials -are licensed and made available under the terms and conditions of the BSD License -which accompanies this distribution. The full text of the license may be found at -http://opensource.org/licenses/bsd-license.php - -THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, -WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. +Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.
+SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -20,7 +14,7 @@ GLOBAL_REMOVE_IF_UNREFERENCED CONST CHAR8 IScsiHexString[] = "0123456789ABCDEFa Removes (trims) specified leading and trailing characters from a string. @param[in, out] Str Pointer to the null-terminated string to be trimmed. - On return, Str will hold the trimmed string. + On return, Str will hold the trimmed string. @param[in] CharC Character will be trimmed from str. @@ -33,18 +27,18 @@ IScsiStrTrim ( { CHAR16 *Pointer1; CHAR16 *Pointer2; - + if (*Str == 0) { return ; } - + // // Trim off the leading and trailing characters c // for (Pointer1 = Str; (*Pointer1 != 0) && (*Pointer1 == CharC); Pointer1++) { ; } - + Pointer2 = Str; if (Pointer2 == Pointer1) { while (*Pointer1 != 0) { @@ -52,19 +46,19 @@ IScsiStrTrim ( Pointer1++; } } else { - while (*Pointer1 != 0) { - *Pointer2 = *Pointer1; + while (*Pointer1 != 0) { + *Pointer2 = *Pointer1; Pointer1++; Pointer2++; } *Pointer2 = 0; } - - + + for (Pointer1 = Str + StrLen(Str) - 1; Pointer1 >= Str && *Pointer1 == CharC; Pointer1--) { ; } - if (Pointer1 != Str + StrLen(Str) - 1) { + if (Pointer1 != Str + StrLen(Str) - 1) { *(Pointer1 + 1) = 0; } } @@ -131,11 +125,11 @@ IScsiAsciiStrToLun ( CHAR8 TemStr[2]; UINT8 TemValue; UINT16 Value[4]; - + ZeroMem (Lun, 8); ZeroMem (TemStr, 2); ZeroMem ((UINT8 *) Value, sizeof (Value)); - SizeStr = AsciiStrLen (Str); + SizeStr = AsciiStrLen (Str); IndexValue = 0; IndexNum = 0; @@ -150,7 +144,7 @@ IScsiAsciiStrToLun ( return EFI_INVALID_PARAMETER; } } - + if ((TemValue == 0) && (TemStr[0] == '-')) { // // Next Lun value. @@ -167,24 +161,24 @@ IScsiAsciiStrToLun ( IndexNum = 0; continue; } - + if (++IndexNum > 4) { - // + // // Each Lun Str can't exceed size 4, because it will be as UINT16 value. // return EFI_INVALID_PARAMETER; } - + // // Combine UINT16 value. // Value[IndexValue] = (UINT16) ((Value[IndexValue] << 4) + TemValue); } - + for (Index = 0; Index <= IndexValue; Index ++) { *((UINT16 *) &Lun[Index * 2]) = HTONS (Value[Index]); } - + return EFI_SUCCESS; } @@ -319,7 +313,7 @@ IScsiMacAddrToStr ( @param[in, out] HexStr Pointer to the string. @param[in, out] HexLength The length of the string. - @retval EFI_SUCCESS The binary data is converted to the hexadecimal string + @retval EFI_SUCCESS The binary data is converted to the hexadecimal string and the length of the string is updated. @retval EFI_BUFFER_TOO_SMALL The string is too small. @retval EFI_INVALID_PARAMETER The IP string is malformatted. @@ -385,7 +379,7 @@ IScsiHexToBin ( UINTN Length; UINT8 Digit; CHAR8 TemStr[2]; - + ZeroMem (TemStr, sizeof (TemStr)); // @@ -394,7 +388,7 @@ IScsiHexToBin ( if ((HexStr[0] == '0') && ((HexStr[1] == 'x') || (HexStr[1] == 'X'))) { HexStr += 2; } - + Length = AsciiStrLen (HexStr); for (Index = 0; Index < Length; Index ++) { @@ -412,7 +406,7 @@ IScsiHexToBin ( BinBuffer [Index/2] = (UINT8) ((BinBuffer [Index/2] << 4) + Digit); } } - + *BinLength = (UINT32) ((Index + 1)/2); return EFI_SUCCESS; @@ -465,10 +459,115 @@ IScsiGenRandom ( } +/** + Check whether UNDI protocol supports IPv6. + + @param[in] ControllerHandle Controller handle. + @param[in] Image Handle of the image. + @param[out] Ipv6Support TRUE if UNDI supports IPv6. + + @retval EFI_SUCCESS Get the result whether UNDI supports IPv6 by NII or AIP protocol successfully. + @retval EFI_NOT_FOUND Don't know whether UNDI supports IPv6 since NII or AIP is not available. + +**/ +EFI_STATUS +IScsiCheckIpv6Support ( + IN EFI_HANDLE ControllerHandle, + IN EFI_HANDLE Image, + OUT BOOLEAN *Ipv6Support + ) +{ + EFI_HANDLE Handle; + EFI_ADAPTER_INFORMATION_PROTOCOL *Aip; + EFI_STATUS Status; + EFI_GUID *InfoTypesBuffer; + UINTN InfoTypeBufferCount; + UINTN TypeIndex; + BOOLEAN Supported; + VOID *InfoBlock; + UINTN InfoBlockSize; + + EFI_NETWORK_INTERFACE_IDENTIFIER_PROTOCOL *Nii; + + ASSERT (Ipv6Support != NULL); + + // + // Check whether the UNDI supports IPv6 by NII protocol. + // + Status = gBS->OpenProtocol ( + ControllerHandle, + &gEfiNetworkInterfaceIdentifierProtocolGuid_31, + (VOID **) &Nii, + Image, + ControllerHandle, + EFI_OPEN_PROTOCOL_GET_PROTOCOL + ); + if (Status == EFI_SUCCESS) { + *Ipv6Support = Nii->Ipv6Supported; + return EFI_SUCCESS; + } + + // + // Get the NIC handle by SNP protocol. + // + Handle = NetLibGetSnpHandle (ControllerHandle, NULL); + if (Handle == NULL) { + return EFI_NOT_FOUND; + } + + Aip = NULL; + Status = gBS->HandleProtocol ( + Handle, + &gEfiAdapterInformationProtocolGuid, + (VOID *) &Aip + ); + if (EFI_ERROR (Status) || Aip == NULL) { + return EFI_NOT_FOUND; + } + + InfoTypesBuffer = NULL; + InfoTypeBufferCount = 0; + Status = Aip->GetSupportedTypes (Aip, &InfoTypesBuffer, &InfoTypeBufferCount); + if (EFI_ERROR (Status) || InfoTypesBuffer == NULL) { + FreePool (InfoTypesBuffer); + return EFI_NOT_FOUND; + } + + Supported = FALSE; + for (TypeIndex = 0; TypeIndex < InfoTypeBufferCount; TypeIndex++) { + if (CompareGuid (&InfoTypesBuffer[TypeIndex], &gEfiAdapterInfoUndiIpv6SupportGuid)) { + Supported = TRUE; + break; + } + } + + FreePool (InfoTypesBuffer); + if (!Supported) { + return EFI_NOT_FOUND; + } + + // + // We now have adapter information block. + // + InfoBlock = NULL; + InfoBlockSize = 0; + Status = Aip->GetInformation (Aip, &gEfiAdapterInfoUndiIpv6SupportGuid, &InfoBlock, &InfoBlockSize); + if (EFI_ERROR (Status) || InfoBlock == NULL) { + FreePool (InfoBlock); + return EFI_NOT_FOUND; + } + + *Ipv6Support = ((EFI_ADAPTER_INFO_UNDI_IPV6_SUPPORT *) InfoBlock)->Ipv6Support; + FreePool (InfoBlock); + + return EFI_SUCCESS; +} + /** Record the NIC info in global structure. @param[in] Controller The handle of the controller. + @param[in] Image Handle of the image. @retval EFI_SUCCESS The operation is completed. @retval EFI_OUT_OF_RESOURCES Do not have sufficient resources to finish this @@ -477,7 +576,8 @@ IScsiGenRandom ( **/ EFI_STATUS IScsiAddNic ( - IN EFI_HANDLE Controller + IN EFI_HANDLE Controller, + IN EFI_HANDLE Image ) { EFI_STATUS Status; @@ -509,6 +609,19 @@ IScsiAddNic ( CompareMem (&NicInfo->PermanentAddress, MacAddr.Addr, HwAddressSize) == 0 && NicInfo->VlanId == VlanId) { mPrivate->CurrentNic = NicInfo->NicIndex; + + // + // Set IPv6 available flag. + // + Status = IScsiCheckIpv6Support (Controller, Image, &NicInfo->Ipv6Available); + if (EFI_ERROR (Status)) { + // + // Fail to get the data whether UNDI supports IPv6. + // Set default value to TRUE. + // + NicInfo->Ipv6Available = TRUE; + } + return EFI_SUCCESS; } @@ -531,6 +644,18 @@ IScsiAddNic ( NicInfo->NicIndex = (UINT8) (mPrivate->MaxNic + 1); mPrivate->MaxNic = NicInfo->NicIndex; + // + // Set IPv6 available flag. + // + Status = IScsiCheckIpv6Support (Controller, Image, &NicInfo->Ipv6Available); + if (EFI_ERROR (Status)) { + // + // Fail to get the data whether UNDI supports IPv6. + // Set default value to TRUE. + // + NicInfo->Ipv6Available = TRUE; + } + // // Get the PCI location. // @@ -643,17 +768,795 @@ IScsiRemoveNic ( } } - // - // Free attempt is created but not saved to system. - // - if (mPrivate->NewAttempt != NULL) { - FreePool (mPrivate->NewAttempt); - mPrivate->NewAttempt = NULL; + return EFI_SUCCESS; +} + +/** + Create and initialize the Attempts. + + @param[in] AttemptNum The number of Attempts will be created. + + @retval EFI_SUCCESS The Attempts have been created successfully. + @retval Others Failed to create the Attempt. + +**/ +EFI_STATUS +IScsiCreateAttempts ( + IN UINTN AttemptNum +) +{ + ISCSI_ATTEMPT_CONFIG_NVDATA *AttemptConfigData; + ISCSI_SESSION_CONFIG_NVDATA *ConfigData; + UINT8 *AttemptConfigOrder; + UINTN AttemptConfigOrderSize; + UINT8 *AttemptOrderTmp; + UINTN TotalNumber; + UINT8 Index; + EFI_STATUS Status; + + for (Index = 1; Index <= AttemptNum; Index ++) { + // + // Get the initialized attempt order. This is used to essure creating attempts by order. + // + AttemptConfigOrder = IScsiGetVariableAndSize ( + L"InitialAttemptOrder", + &gIScsiConfigGuid, + &AttemptConfigOrderSize + ); + TotalNumber = AttemptConfigOrderSize / sizeof (UINT8); + if (TotalNumber == AttemptNum) { + Status = EFI_SUCCESS; + break; + } + TotalNumber++; + + // + // Append the new created attempt to the end. + // + AttemptOrderTmp = AllocateZeroPool (TotalNumber * sizeof (UINT8)); + if (AttemptOrderTmp == NULL) { + if (AttemptConfigOrder != NULL) { + FreePool (AttemptConfigOrder); + } + return EFI_OUT_OF_RESOURCES; + } + + if (AttemptConfigOrder != NULL) { + CopyMem (AttemptOrderTmp, AttemptConfigOrder, AttemptConfigOrderSize); + FreePool (AttemptConfigOrder); + } + + AttemptOrderTmp[TotalNumber - 1] = Index; + AttemptConfigOrder = AttemptOrderTmp; + AttemptConfigOrderSize = TotalNumber * sizeof (UINT8); + + Status = gRT->SetVariable ( + L"InitialAttemptOrder", + &gIScsiConfigGuid, + EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_NON_VOLATILE, + AttemptConfigOrderSize, + AttemptConfigOrder + ); + FreePool (AttemptConfigOrder); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, + "%a: Failed to set 'InitialAttemptOrder' with Guid (%g): " + "%r\n", + __FUNCTION__, &gIScsiConfigGuid, Status)); + return Status; + } + + // + // Create new Attempt + // + AttemptConfigData = AllocateZeroPool (sizeof (ISCSI_ATTEMPT_CONFIG_NVDATA)); + if (AttemptConfigData == NULL) { + return EFI_OUT_OF_RESOURCES; + } + ConfigData = &AttemptConfigData->SessionConfigData; + ConfigData->TargetPort = ISCSI_WELL_KNOWN_PORT; + ConfigData->ConnectTimeout = CONNECT_DEFAULT_TIMEOUT; + ConfigData->ConnectRetryCount = CONNECT_MIN_RETRY; + + AttemptConfigData->AuthenticationType = ISCSI_AUTH_TYPE_CHAP; + AttemptConfigData->AuthConfigData.CHAP.CHAPType = ISCSI_CHAP_UNI; + // + // Configure the Attempt index and set variable. + // + AttemptConfigData->AttemptConfigIndex = Index; + + // + // Set the attempt name according to the order. + // + UnicodeSPrint ( + mPrivate->PortString, + (UINTN) ISCSI_NAME_IFR_MAX_SIZE, + L"Attempt %d", + (UINTN) AttemptConfigData->AttemptConfigIndex + ); + UnicodeStrToAsciiStrS (mPrivate->PortString, AttemptConfigData->AttemptName, ATTEMPT_NAME_SIZE); + + Status = gRT->SetVariable ( + mPrivate->PortString, + &gEfiIScsiInitiatorNameProtocolGuid, + ISCSI_CONFIG_VAR_ATTR, + sizeof (ISCSI_ATTEMPT_CONFIG_NVDATA), + AttemptConfigData + ); + FreePool (AttemptConfigData); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, + "%a: Failed to set variable (mPrivate->PortString) with Guid (%g): " + "%r\n", + __FUNCTION__, &gEfiIScsiInitiatorNameProtocolGuid, Status)); + return Status; + } } return EFI_SUCCESS; } +/** + Create the iSCSI configuration Keywords for each attempt. You can find the keywords + defined in the "x-UEFI-ns" namespace (http://www.uefi.org/confignamespace). + + @param[in] KeywordNum The number Sets of Keywords will be created. + + @retval EFI_SUCCESS The operation is completed. + @retval Others Failed to create the Keywords. + +**/ +EFI_STATUS +IScsiCreateKeywords ( + IN UINTN KeywordNum +) +{ + VOID *StartOpCodeHandle; + EFI_IFR_GUID_LABEL *StartLabel; + VOID *EndOpCodeHandle; + EFI_IFR_GUID_LABEL *EndLabel; + UINTN Index; + EFI_STRING_ID StringToken; + CHAR16 StringId[64]; + CHAR16 KeywordId[32]; + EFI_STATUS Status; + + Status = IScsiCreateOpCode ( + KEYWORD_ENTRY_LABEL, + &StartOpCodeHandle, + &StartLabel, + &EndOpCodeHandle, + &EndLabel + ); + if (EFI_ERROR (Status)) { + return EFI_OUT_OF_RESOURCES; + } + + for (Index = 1; Index <= KeywordNum; Index ++) { + // + // Create iSCSIAttemptName Keyword. + // + UnicodeSPrint (StringId, sizeof (StringId), L"STR_ISCSI_ATTEMPTT_NAME_PROMPT%d", Index); + StringToken = HiiSetString ( + mCallbackInfo->RegisteredHandle, + 0, + StringId, + NULL + ); + UnicodeSPrint (KeywordId, sizeof (KeywordId), L"iSCSIAttemptName:%d", Index); + HiiSetString (mCallbackInfo->RegisteredHandle, StringToken, KeywordId, "x-UEFI-ns"); + HiiCreateStringOpCode ( + StartOpCodeHandle, + (EFI_QUESTION_ID) (ATTEMPT_ATTEMPT_NAME_QUESTION_ID + (Index - 1)), + CONFIGURATION_VARSTORE_ID, + (UINT16) (ATTEMPT_ATTEMPT_NAME_VAR_OFFSET + ATTEMPT_NAME_SIZE * (Index - 1) * sizeof (CHAR16)), + StringToken, + StringToken, + EFI_IFR_FLAG_READ_ONLY, + 0, + 0, + ATTEMPT_NAME_SIZE, + NULL + ); + + // + // Create iSCSIBootEnable Keyword. + // + UnicodeSPrint (StringId, sizeof (StringId), L"STR_ISCSI_MODE_PROMPT%d", Index); + StringToken = HiiSetString ( + mCallbackInfo->RegisteredHandle, + 0, + StringId, + NULL + ); + UnicodeSPrint (KeywordId, sizeof (KeywordId), L"iSCSIBootEnable:%d", Index); + HiiSetString (mCallbackInfo->RegisteredHandle, StringToken, KeywordId, "x-UEFI-ns"); + HiiCreateNumericOpCode ( + StartOpCodeHandle, + (EFI_QUESTION_ID) (ATTEMPT_BOOTENABLE_QUESTION_ID + (Index - 1)), + CONFIGURATION_VARSTORE_ID, + (UINT16) (ATTEMPT_BOOTENABLE_VAR_OFFSET + (Index - 1)), + StringToken, + StringToken, + 0, + EFI_IFR_NUMERIC_SIZE_1, + 0, + 2, + 0, + NULL + ); + + // + // Create iSCSIIpAddressType Keyword. + // + UnicodeSPrint (StringId, sizeof (StringId), L"STR_ISCSI_IP_MODE_PROMPT%d", Index); + StringToken = HiiSetString ( + mCallbackInfo->RegisteredHandle, + 0, + StringId, + NULL + ); + UnicodeSPrint (KeywordId, sizeof (KeywordId), L"iSCSIIpAddressType:%d", Index); + HiiSetString (mCallbackInfo->RegisteredHandle, StringToken, KeywordId, "x-UEFI-ns"); + HiiCreateNumericOpCode ( + StartOpCodeHandle, + (EFI_QUESTION_ID) (ATTEMPT_ADDRESS_TYPE_QUESTION_ID + (Index - 1)), + CONFIGURATION_VARSTORE_ID, + (UINT16) (ATTEMPT_ADDRESS_TYPE_VAR_OFFSET + (Index - 1)), + StringToken, + StringToken, + 0, + EFI_IFR_NUMERIC_SIZE_1, + 0, + 2, + 0, + NULL + ); + + // + // Create iSCSIConnectRetry Keyword. + // + UnicodeSPrint (StringId, sizeof (StringId), L"STR_ISCSI_CONNECT_RETRY_PROMPT%d", Index); + StringToken = HiiSetString ( + mCallbackInfo->RegisteredHandle, + 0, + StringId, + NULL + ); + UnicodeSPrint (KeywordId, sizeof (KeywordId), L"iSCSIConnectRetry:%d", Index); + HiiSetString (mCallbackInfo->RegisteredHandle, StringToken, KeywordId, "x-UEFI-ns"); + HiiCreateNumericOpCode ( + StartOpCodeHandle, + (EFI_QUESTION_ID) (ATTEMPT_CONNECT_RETRY_QUESTION_ID + (Index - 1)), + CONFIGURATION_VARSTORE_ID, + (UINT16) (ATTEMPT_CONNECT_RETRY_VAR_OFFSET + (Index - 1)), + StringToken, + StringToken, + 0, + EFI_IFR_NUMERIC_SIZE_1, + 0, + 16, + 0, + NULL + ); + + // + // Create iSCSIConnectTimeout Keyword. + // + UnicodeSPrint (StringId, sizeof (StringId), L"STR_ISCSI_CONNECT_TIMEOUT_PROMPT%d", Index); + StringToken = HiiSetString ( + mCallbackInfo->RegisteredHandle, + 0, + StringId, + NULL + ); + UnicodeSPrint (KeywordId, sizeof (KeywordId), L"iSCSIConnectTimeout:%d", Index); + HiiSetString (mCallbackInfo->RegisteredHandle, StringToken, KeywordId, "x-UEFI-ns"); + HiiCreateNumericOpCode ( + StartOpCodeHandle, + (EFI_QUESTION_ID) (ATTEMPT_CONNECT_TIMEOUT_QUESTION_ID + (Index - 1)), + CONFIGURATION_VARSTORE_ID, + (UINT16) (ATTEMPT_CONNECT_TIMEOUT_VAR_OFFSET + 2 * (Index - 1)), + StringToken, + StringToken, + 0, + EFI_IFR_NUMERIC_SIZE_2, + CONNECT_MIN_TIMEOUT, + CONNECT_MAX_TIMEOUT, + 0, + NULL + ); + + // + // Create ISID Keyword. + // + UnicodeSPrint (StringId, sizeof (StringId), L"STR_ISCSI_ISID_PROMPT%d", Index); + StringToken = HiiSetString ( + mCallbackInfo->RegisteredHandle, + 0, + StringId, + NULL + ); + UnicodeSPrint (KeywordId, sizeof (KeywordId), L"iSCSIISID:%d", Index); + HiiSetString (mCallbackInfo->RegisteredHandle, StringToken, KeywordId, "x-UEFI-ns"); + HiiCreateStringOpCode ( + StartOpCodeHandle, + (EFI_QUESTION_ID) (ATTEMPT_ISID_QUESTION_ID + (Index - 1)), + CONFIGURATION_VARSTORE_ID, + (UINT16) (ATTEMPT_ISID_VAR_OFFSET + sizeof (KEYWORD_STR) * (Index - 1)), + StringToken, + STRING_TOKEN (STR_ISCSI_ISID_HELP), + 0, + 0, + ISID_CONFIGURABLE_MIN_LEN, + ISID_CONFIGURABLE_STORAGE, + NULL + ); + + // + // Create iSCSIInitiatorInfoViaDHCP Keyword. + // + UnicodeSPrint (StringId, sizeof (StringId), L"STR_ISCSI_INITIATOR_VIA_DHCP_PROMPT%d", Index); + StringToken = HiiSetString ( + mCallbackInfo->RegisteredHandle, + 0, + StringId, + NULL + ); + UnicodeSPrint (KeywordId, sizeof (KeywordId), L"iSCSIInitiatorInfoViaDHCP:%d", Index); + HiiSetString (mCallbackInfo->RegisteredHandle, StringToken, KeywordId, "x-UEFI-ns"); + HiiCreateNumericOpCode ( + StartOpCodeHandle, + (EFI_QUESTION_ID) (ATTEMPT_INITIATOR_VIA_DHCP_QUESTION_ID + (Index - 1)), + CONFIGURATION_VARSTORE_ID, + (UINT16) (ATTEMPT_INITIATOR_VIA_DHCP_VAR_OFFSET + (Index - 1)), + StringToken, + StringToken, + 0, + 0, + 0, + 1, + 0, + NULL + ); + + // + // Create iSCSIInitiatorIpAddress Keyword. + // + UnicodeSPrint (StringId, sizeof (StringId), L"STR_ISCSI_INITIATOR_IP_ADDRESS_PROMPT%d", Index); + StringToken = HiiSetString ( + mCallbackInfo->RegisteredHandle, + 0, + StringId, + NULL + ); + UnicodeSPrint (KeywordId, sizeof (KeywordId), L"iSCSIInitiatorIpAddress:%d", Index); + HiiSetString (mCallbackInfo->RegisteredHandle, StringToken, KeywordId, "x-UEFI-ns"); + HiiCreateStringOpCode ( + StartOpCodeHandle, + (EFI_QUESTION_ID) (ATTEMPT_INITIATOR_IP_ADDRESS_QUESTION_ID + (Index - 1)), + CONFIGURATION_VARSTORE_ID, + (UINT16) (ATTEMPT_INITIATOR_IP_ADDRESS_VAR_OFFSET + sizeof (KEYWORD_STR) * (Index - 1)), + StringToken, + StringToken, + 0, + 0, + IP4_MIN_SIZE, + IP4_STR_MAX_SIZE, + NULL + ); + + // + // Create iSCSIInitiatorNetmask Keyword. + // + UnicodeSPrint (StringId, sizeof (StringId), L"STR_ISCSI_INITIATOR_NET_MASK_PROMPT%d", Index); + StringToken = HiiSetString ( + mCallbackInfo->RegisteredHandle, + 0, + StringId, + NULL + ); + UnicodeSPrint (KeywordId, sizeof (KeywordId), L"iSCSIInitiatorNetmask:%d", Index); + HiiSetString (mCallbackInfo->RegisteredHandle, StringToken, KeywordId, "x-UEFI-ns"); + HiiCreateStringOpCode ( + StartOpCodeHandle, + (EFI_QUESTION_ID) (ATTEMPT_INITIATOR_NET_MASK_QUESTION_ID + (Index - 1)), + CONFIGURATION_VARSTORE_ID, + (UINT16) (ATTEMPT_INITIATOR_NET_MASK_VAR_OFFSET + sizeof (KEYWORD_STR) * (Index - 1)), + StringToken, + StringToken, + 0, + 0, + IP4_MIN_SIZE, + IP4_STR_MAX_SIZE, + NULL + ); + + // + // Create iSCSIInitiatorGateway Keyword. + // + UnicodeSPrint (StringId, sizeof (StringId), L"STR_ISCSI_INITIATOR_GATE_PROMPT%d", Index); + StringToken = HiiSetString ( + mCallbackInfo->RegisteredHandle, + 0, + StringId, + NULL + ); + UnicodeSPrint (KeywordId, sizeof (KeywordId), L"iSCSIInitiatorGateway:%d", Index); + HiiSetString (mCallbackInfo->RegisteredHandle, StringToken, KeywordId, "x-UEFI-ns"); + HiiCreateStringOpCode ( + StartOpCodeHandle, + (EFI_QUESTION_ID) (ATTEMPT_INITIATOR_GATE_WAY_QUESTION_ID + (Index - 1)), + CONFIGURATION_VARSTORE_ID, + (UINT16) (ATTEMPT_INITIATOR_GATE_WAY_VAR_OFFSET + sizeof (KEYWORD_STR) * (Index - 1)), + StringToken, + StringToken, + 0, + 0, + IP4_MIN_SIZE, + IP4_STR_MAX_SIZE, + NULL + ); + + // + // Create iSCSITargetInfoViaDHCP Keyword. + // + UnicodeSPrint (StringId, sizeof (StringId), L"STR_ISCSI_TARGET_VIA_DHCP_PROMPT%d", Index); + StringToken = HiiSetString ( + mCallbackInfo->RegisteredHandle, + 0, + StringId, + NULL + ); + UnicodeSPrint (KeywordId, sizeof (KeywordId), L"iSCSITargetInfoViaDHCP:%d", Index); + HiiSetString (mCallbackInfo->RegisteredHandle, StringToken, KeywordId, "x-UEFI-ns"); + HiiCreateNumericOpCode ( + StartOpCodeHandle, + (EFI_QUESTION_ID) (ATTEMPT_TARGET_VIA_DHCP_QUESTION_ID + (Index - 1)), + CONFIGURATION_VARSTORE_ID, + (UINT16) (ATTEMPT_TARGET_VIA_DHCP_VAR_OFFSET + (Index - 1)), + StringToken, + StringToken, + 0, + 0, + 0, + 1, + 0, + NULL + ); + + // + // Create iSCSITargetTcpPort Keyword. + // + UnicodeSPrint (StringId, sizeof (StringId), L"STR_ISCSI_TARGET_TCP_PORT_PROMPT%d", Index); + StringToken = HiiSetString ( + mCallbackInfo->RegisteredHandle, + 0, + StringId, + NULL + ); + UnicodeSPrint (KeywordId, sizeof (KeywordId), L"iSCSITargetTcpPort:%d", Index); + HiiSetString (mCallbackInfo->RegisteredHandle, StringToken, KeywordId, "x-UEFI-ns"); + HiiCreateNumericOpCode ( + StartOpCodeHandle, + (EFI_QUESTION_ID) (ATTEMPT_TARGET_TCP_PORT_QUESTION_ID + (Index - 1)), + CONFIGURATION_VARSTORE_ID, + (UINT16) (ATTEMPT_TARGET_TCP_PORT_VAR_OFFSET + 2 * (Index - 1)), + StringToken, + StringToken, + 0, + EFI_IFR_NUMERIC_SIZE_2, + TARGET_PORT_MIN_NUM, + TARGET_PORT_MAX_NUM, + 0, + NULL + ); + + // + // Create iSCSITargetName Keyword. + // + UnicodeSPrint (StringId, sizeof (StringId), L"STR_ISCSI_TARGET_NAME_PROMPT%d", Index); + StringToken = HiiSetString ( + mCallbackInfo->RegisteredHandle, + 0, + StringId, + NULL + ); + UnicodeSPrint (KeywordId, sizeof (KeywordId), L"iSCSITargetName:%d", Index); + HiiSetString (mCallbackInfo->RegisteredHandle, StringToken, KeywordId, "x-UEFI-ns"); + HiiCreateStringOpCode ( + StartOpCodeHandle, + (EFI_QUESTION_ID) (ATTEMPT_TARGET_NAME_QUESTION_ID + (Index - 1)), + CONFIGURATION_VARSTORE_ID, + (UINT16) (ATTEMPT_TARGET_NAME_VAR_OFFSET + sizeof (KEYWORD_STR) * (Index - 1)), + StringToken, + StringToken, + 0, + 0, + ISCSI_NAME_IFR_MIN_SIZE, + ISCSI_NAME_IFR_MAX_SIZE, + NULL + ); + + // + // Create iSCSITargetIpAddress Keyword. + // + UnicodeSPrint (StringId, sizeof (StringId), L"STR_ISCSI_TARGET_IP_ADDRESS_PROMPT%d", Index); + StringToken = HiiSetString ( + mCallbackInfo->RegisteredHandle, + 0, + StringId, + NULL + ); + UnicodeSPrint (KeywordId, sizeof (KeywordId), L"iSCSITargetIpAddress:%d", Index); + HiiSetString (mCallbackInfo->RegisteredHandle, StringToken, KeywordId, "x-UEFI-ns"); + HiiCreateStringOpCode ( + StartOpCodeHandle, + (EFI_QUESTION_ID) (ATTEMPT_TARGET_IP_ADDRESS_QUESTION_ID + (Index - 1)), + CONFIGURATION_VARSTORE_ID, + (UINT16) (ATTEMPT_TARGET_IP_ADDRESS_VAR_OFFSET + sizeof (KEYWORD_STR) * (Index - 1)), + StringToken, + StringToken, + 0, + 0, + IP_MIN_SIZE, + IP_STR_MAX_SIZE, + NULL + ); + + // + // Create iSCSILUN Keyword. + // + UnicodeSPrint (StringId, sizeof (StringId), L"STR_ISCSI_LUN_PROMPT%d", Index); + StringToken = HiiSetString ( + mCallbackInfo->RegisteredHandle, + 0, + StringId, + NULL + ); + UnicodeSPrint (KeywordId, sizeof (KeywordId), L"iSCSILUN:%d", Index); + HiiSetString (mCallbackInfo->RegisteredHandle, StringToken, KeywordId, "x-UEFI-ns"); + HiiCreateStringOpCode ( + StartOpCodeHandle, + (EFI_QUESTION_ID) (ATTEMPT_LUN_QUESTION_ID + (Index - 1)), + CONFIGURATION_VARSTORE_ID, + (UINT16) (ATTEMPT_LUN_VAR_OFFSET + sizeof (KEYWORD_STR) * (Index - 1)), + StringToken, + StringToken, + 0, + 0, + LUN_MIN_SIZE, + LUN_MAX_SIZE, + NULL + ); + + // + // Create iSCSIAuthenticationMethod Keyword. + // + UnicodeSPrint (StringId, sizeof (StringId), L"STR_ISCSI_AUTHENTICATION_METHOD_PROMPT%d", Index); + StringToken = HiiSetString ( + mCallbackInfo->RegisteredHandle, + 0, + StringId, + NULL + ); + UnicodeSPrint (KeywordId, sizeof (KeywordId), L"iSCSIAuthenticationMethod:%d", Index); + HiiSetString (mCallbackInfo->RegisteredHandle, StringToken, KeywordId, "x-UEFI-ns"); + HiiCreateNumericOpCode ( + StartOpCodeHandle, + (EFI_QUESTION_ID) (ATTEMPT_AUTHENTICATION_METHOD_QUESTION_ID + (Index - 1)), + CONFIGURATION_VARSTORE_ID, + (UINT16) (ATTEMPT_AUTHENTICATION_METHOD_VAR_OFFSET + (Index - 1)), + StringToken, + StringToken, + 0, + 0, + 0, + 1, + 0, + NULL + ); + + // + // Create iSCSIChapType Keyword. + // + UnicodeSPrint (StringId, sizeof (StringId), L"STR_ISCSI_CHARTYPE_PROMPT%d", Index); + StringToken = HiiSetString ( + mCallbackInfo->RegisteredHandle, + 0, + StringId, + NULL + ); + UnicodeSPrint (KeywordId, sizeof (KeywordId), L"iSCSIChapType:%d", Index); + HiiSetString (mCallbackInfo->RegisteredHandle, StringToken, KeywordId, "x-UEFI-ns"); + HiiCreateNumericOpCode ( + StartOpCodeHandle, + (EFI_QUESTION_ID) (ATTEMPT_CHARTYPE_QUESTION_ID + (Index - 1)), + CONFIGURATION_VARSTORE_ID, + (UINT16) (ATTEMPT_CHARTYPE_VAR_OFFSET + (Index - 1)), + StringToken, + StringToken, + 0, + 0, + 0, + 1, + 0, + NULL + ); + + // + // Create iSCSIChapUsername Keyword. + // + UnicodeSPrint (StringId, sizeof (StringId), L"STR_ISCSI_CHAR_USER_NAME_PROMPT%d", Index); + StringToken = HiiSetString ( + mCallbackInfo->RegisteredHandle, + 0, + StringId, + NULL + ); + UnicodeSPrint (KeywordId, sizeof (KeywordId), L"iSCSIChapUsername:%d", Index); + HiiSetString (mCallbackInfo->RegisteredHandle, StringToken, KeywordId, "x-UEFI-ns"); + HiiCreateStringOpCode ( + StartOpCodeHandle, + (EFI_QUESTION_ID) (ATTEMPT_CHAR_USER_NAME_QUESTION_ID + (Index - 1)), + CONFIGURATION_VARSTORE_ID, + (UINT16) (ATTEMPT_CHAR_USER_NAME_VAR_OFFSET + sizeof (KEYWORD_STR) * (Index - 1)), + StringToken, + StringToken, + 0, + 0, + 0, + ISCSI_CHAP_NAME_MAX_LEN, + NULL + ); + + // + // Create iSCSIChapSecret Keyword. + // + UnicodeSPrint (StringId, sizeof (StringId), L"STR_ISCSI_CHAR_SECRET_PROMPT%d", Index); + StringToken = HiiSetString ( + mCallbackInfo->RegisteredHandle, + 0, + StringId, + NULL + ); + UnicodeSPrint (KeywordId, sizeof (KeywordId), L"iSCSIChapSecret:%d", Index); + HiiSetString (mCallbackInfo->RegisteredHandle, StringToken, KeywordId, "x-UEFI-ns"); + HiiCreateStringOpCode ( + StartOpCodeHandle, + (EFI_QUESTION_ID) (ATTEMPT_CHAR_SECRET_QUESTION_ID + (Index - 1)), + CONFIGURATION_VARSTORE_ID, + (UINT16) (ATTEMPT_CHAR_SECRET_VAR_OFFSET + sizeof (KEYWORD_STR) * (Index - 1)), + StringToken, + StringToken, + 0, + 0, + ISCSI_CHAP_SECRET_MIN_LEN, + ISCSI_CHAP_SECRET_MAX_LEN, + NULL + ); + + // + // Create iSCSIReverseChapUsername Keyword. + // + UnicodeSPrint (StringId, sizeof (StringId), L"STR_ISCSI_CHAR_REVERSE_USER_NAME_PROMPT%d", Index); + StringToken = HiiSetString ( + mCallbackInfo->RegisteredHandle, + 0, + StringId, + NULL + ); + UnicodeSPrint (KeywordId, sizeof (KeywordId), L"iSCSIReverseChapUsername:%d", Index); + HiiSetString (mCallbackInfo->RegisteredHandle, StringToken, KeywordId, "x-UEFI-ns"); + HiiCreateStringOpCode ( + StartOpCodeHandle, + (EFI_QUESTION_ID) (ATTEMPT_CHAR_REVERSE_USER_NAME_QUESTION_ID + (Index - 1)), + CONFIGURATION_VARSTORE_ID, + (UINT16) (ATTEMPT_CHAR_REVERSE_USER_NAME_VAR_OFFSET + sizeof (KEYWORD_STR) * (Index - 1)), + StringToken, + StringToken, + 0, + 0, + 0, + ISCSI_CHAP_NAME_MAX_LEN, + NULL + ); + + // + // Create iSCSIReverseChapSecret Keyword. + // + UnicodeSPrint (StringId, sizeof (StringId), L"STR_ISCSI_CHAR_REVERSE_SECRET_PROMPT%d", Index); + StringToken = HiiSetString ( + mCallbackInfo->RegisteredHandle, + 0, + StringId, + NULL + ); + UnicodeSPrint (KeywordId, sizeof (KeywordId), L"iSCSIReverseChapSecret:%d", Index); + HiiSetString (mCallbackInfo->RegisteredHandle, StringToken, KeywordId, "x-UEFI-ns"); + HiiCreateStringOpCode ( + StartOpCodeHandle, + (EFI_QUESTION_ID) (ATTEMPT_CHAR_REVERSE_SECRET_QUESTION_ID + (Index - 1)), + CONFIGURATION_VARSTORE_ID, + (UINT16) (ATTEMPT_CHAR_REVERSE_SECRET_VAR_OFFSET + sizeof (KEYWORD_STR) * (Index - 1)), + StringToken, + StringToken, + 0, + 0, + ISCSI_CHAP_SECRET_MIN_LEN, + ISCSI_CHAP_SECRET_MAX_LEN, + NULL + ); + } + + Status = HiiUpdateForm ( + mCallbackInfo->RegisteredHandle, // HII handle + &gIScsiConfigGuid, // Formset GUID + FORMID_ATTEMPT_FORM, // Form ID + StartOpCodeHandle, // Label for where to insert opcodes + EndOpCodeHandle // Replace data + ); + + HiiFreeOpCodeHandle (StartOpCodeHandle); + HiiFreeOpCodeHandle (EndOpCodeHandle); + + return Status; +} + +/** + + Free the attempt configure data variable. + +**/ +VOID +IScsiCleanAttemptVariable ( + IN VOID +) +{ + ISCSI_ATTEMPT_CONFIG_NVDATA *AttemptConfigData; + UINT8 *AttemptConfigOrder; + UINTN AttemptConfigOrderSize; + UINTN Index; + + // + // Get the initialized attempt order. + // + AttemptConfigOrder = IScsiGetVariableAndSize ( + L"InitialAttemptOrder", + &gIScsiConfigGuid, + &AttemptConfigOrderSize + ); + if (AttemptConfigOrder == NULL || AttemptConfigOrderSize == 0) { + return; + } + + for (Index = 1; Index < AttemptConfigOrderSize / sizeof (UINT8); Index++) { + UnicodeSPrint ( + mPrivate->PortString, + (UINTN) ISCSI_NAME_IFR_MAX_SIZE, + L"Attempt %d", + Index + ); + + GetVariable2 ( + mPrivate->PortString, + &gEfiIScsiInitiatorNameProtocolGuid, + (VOID**)&AttemptConfigData, + NULL + ); + + if (AttemptConfigData != NULL) { + gRT->SetVariable ( + mPrivate->PortString, + &gEfiIScsiInitiatorNameProtocolGuid, + 0, + 0, + NULL + ); + } + } + return; +} /** Get the recorded NIC info from global structure by the Index. @@ -897,8 +1800,11 @@ IScsiCleanDriverData ( } EXIT: + if (Private->ExitBootServiceEvent != NULL) { + gBS->CloseEvent (Private->ExitBootServiceEvent); + } - gBS->CloseEvent (Private->ExitBootServiceEvent); + mCallbackInfo->Current = NULL; FreePool (Private); return Status; @@ -909,10 +1815,10 @@ EXIT: @param[in] Controller The handle of the controller. @param[in] IpVersion IP_VERSION_4 or IP_VERSION_6. - + @retval TRUE The handle of the controller need the Dhcp protocol. @retval FALSE The handle of the controller does not need the Dhcp protocol. - + **/ BOOLEAN IScsiDhcpIsConfigured ( @@ -929,8 +1835,9 @@ IScsiDhcpIsConfigured ( UINTN HwAddressSize; UINT16 VlanId; CHAR16 MacString[ISCSI_MAX_MAC_STRING_LEN]; + CHAR16 AttemptMacString[ISCSI_MAX_MAC_STRING_LEN]; CHAR16 AttemptName[ISCSI_NAME_IFR_MAX_SIZE]; - + AttemptConfigOrder = IScsiGetVariableAndSize ( L"AttemptOrder", &gIScsiConfigGuid, @@ -939,7 +1846,7 @@ IScsiDhcpIsConfigured ( if (AttemptConfigOrder == NULL || AttemptConfigOrderSize == 0) { return FALSE; } - + // // Get MAC address of this network device. // @@ -952,13 +1859,12 @@ IScsiDhcpIsConfigured ( // VlanId = NetLibGetVlanId (Controller); IScsiMacAddrToStr (&MacAddr, (UINT32) HwAddressSize, VlanId, MacString); - + for (Index = 0; Index < AttemptConfigOrderSize / sizeof (UINT8); Index++) { UnicodeSPrint ( AttemptName, (UINTN) 128, - L"%s%d", - MacString, + L"Attempt %d", (UINTN) AttemptConfigOrder[Index] ); Status = GetVariable2 ( @@ -970,7 +1876,7 @@ IScsiDhcpIsConfigured ( if(AttemptTmp == NULL || EFI_ERROR (Status)) { continue; } - + ASSERT (AttemptConfigOrder[Index] == AttemptTmp->AttemptConfigIndex); if (AttemptTmp->SessionConfigData.Enabled == ISCSI_DISABLED) { @@ -978,15 +1884,21 @@ IScsiDhcpIsConfigured ( continue; } - if (AttemptTmp->SessionConfigData.IpMode != IP_MODE_AUTOCONFIG && + if (AttemptTmp->SessionConfigData.IpMode != IP_MODE_AUTOCONFIG && AttemptTmp->SessionConfigData.IpMode != ((IpVersion == IP_VERSION_4) ? IP_MODE_IP4 : IP_MODE_IP6)) { FreePool (AttemptTmp); continue; } - + + AsciiStrToUnicodeStrS (AttemptTmp->MacString, AttemptMacString, sizeof (AttemptMacString) / sizeof (AttemptMacString[0])); + + if (AttemptTmp->Actived == ISCSI_ACTIVE_DISABLED || StrCmp (MacString, AttemptMacString)) { + continue; + } + if(AttemptTmp->SessionConfigData.IpMode == IP_MODE_AUTOCONFIG || AttemptTmp->SessionConfigData.InitiatorInfoFromDhcp == TRUE || - AttemptTmp->SessionConfigData.TargetInfoFromDhcp == TRUE) { + AttemptTmp->SessionConfigData.TargetInfoFromDhcp == TRUE) { FreePool (AttemptTmp); FreePool (AttemptConfigOrder); return TRUE; @@ -994,9 +1906,100 @@ IScsiDhcpIsConfigured ( FreePool (AttemptTmp); } - + + FreePool (AttemptConfigOrder); + return FALSE; +} + +/** + Check whether the Controller handle is configured to use DNS protocol. + + @param[in] Controller The handle of the controller. + + @retval TRUE The handle of the controller need the Dns protocol. + @retval FALSE The handle of the controller does not need the Dns protocol. + +**/ +BOOLEAN +IScsiDnsIsConfigured ( + IN EFI_HANDLE Controller + ) +{ + ISCSI_ATTEMPT_CONFIG_NVDATA *AttemptTmp; + UINT8 *AttemptConfigOrder; + UINTN AttemptConfigOrderSize; + UINTN Index; + EFI_STATUS Status; + EFI_MAC_ADDRESS MacAddr; + UINTN HwAddressSize; + UINT16 VlanId; + CHAR16 AttemptMacString[ISCSI_MAX_MAC_STRING_LEN]; + CHAR16 MacString[ISCSI_MAX_MAC_STRING_LEN]; + CHAR16 AttemptName[ISCSI_NAME_IFR_MAX_SIZE]; + + AttemptConfigOrder = IScsiGetVariableAndSize ( + L"AttemptOrder", + &gIScsiConfigGuid, + &AttemptConfigOrderSize + ); + if (AttemptConfigOrder == NULL || AttemptConfigOrderSize == 0) { + return FALSE; + } + + // + // Get MAC address of this network device. + // + Status = NetLibGetMacAddress (Controller, &MacAddr, &HwAddressSize); + if(EFI_ERROR (Status)) { + return FALSE; + } + // + // Get VLAN ID of this network device. + // + VlanId = NetLibGetVlanId (Controller); + IScsiMacAddrToStr (&MacAddr, (UINT32) HwAddressSize, VlanId, MacString); + + for (Index = 0; Index < AttemptConfigOrderSize / sizeof (UINT8); Index++) { + UnicodeSPrint ( + AttemptName, + (UINTN) 128, + L"Attempt %d", + (UINTN) AttemptConfigOrder[Index] + ); + + Status = GetVariable2 ( + AttemptName, + &gEfiIScsiInitiatorNameProtocolGuid, + (VOID**)&AttemptTmp, + NULL + ); + if(AttemptTmp == NULL || EFI_ERROR (Status)) { + continue; + } + + ASSERT (AttemptConfigOrder[Index] == AttemptTmp->AttemptConfigIndex); + + AsciiStrToUnicodeStrS (AttemptTmp->MacString, AttemptMacString, sizeof (AttemptMacString) / sizeof (AttemptMacString[0])); + + if (AttemptTmp->SessionConfigData.Enabled == ISCSI_DISABLED || StrCmp (MacString, AttemptMacString)) { + FreePool (AttemptTmp); + continue; + } + + if (AttemptTmp->SessionConfigData.DnsMode || AttemptTmp->SessionConfigData.TargetInfoFromDhcp) { + FreePool (AttemptTmp); + FreePool (AttemptConfigOrder); + return TRUE; + } else { + FreePool (AttemptTmp); + continue; + } + + } + FreePool (AttemptConfigOrder); return FALSE; + } /** @@ -1006,6 +2009,7 @@ IScsiDhcpIsConfigured ( @retval EFI_SUCCESS The configuration data is retrieved. @retval EFI_NOT_FOUND This iSCSI driver is not configured yet. + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory. **/ EFI_STATUS @@ -1015,6 +2019,7 @@ IScsiGetConfigData ( { EFI_STATUS Status; CHAR16 MacString[ISCSI_MAX_MAC_STRING_LEN]; + CHAR16 AttemptMacString[ISCSI_MAX_MAC_STRING_LEN]; UINTN Index; ISCSI_NIC_INFO *NicInfo; ISCSI_ATTEMPT_CONFIG_NVDATA *AttemptConfigData; @@ -1057,7 +2062,7 @@ IScsiGetConfigData ( // // Check whether the attempt exists in AttemptConfig. // - AttemptTmp = IScsiConfigGetAttemptByConfigIndex (AttemptConfigOrder[Index]); + AttemptTmp = IScsiConfigGetAttemptByConfigIndex (AttemptConfigOrder[Index]); if (AttemptTmp != NULL && AttemptTmp->SessionConfigData.Enabled == ISCSI_DISABLED) { continue; } else if (AttemptTmp != NULL && AttemptTmp->SessionConfigData.Enabled != ISCSI_DISABLED) { @@ -1106,12 +2111,10 @@ IScsiGetConfigData ( // // Refresh the state of this attempt to NVR. // - AsciiStrToUnicodeStrS (AttemptTmp->MacString, MacString, sizeof (MacString) / sizeof (MacString[0])); UnicodeSPrint ( mPrivate->PortString, (UINTN) ISCSI_NAME_IFR_MAX_SIZE, - L"%s%d", - MacString, + L"Attempt %d", (UINTN) AttemptTmp->AttemptConfigIndex ); @@ -1125,9 +2128,12 @@ IScsiGetConfigData ( continue; } - } else if (AttemptTmp->SessionConfigData.InitiatorInfoFromDhcp && !AttemptTmp->ValidPath) { + } else if (AttemptTmp->SessionConfigData.InitiatorInfoFromDhcp && + !AttemptTmp->ValidPath && + AttemptTmp->NicIndex == mPrivate->CurrentNic) { // - // Get DHCP information for already added, but failed, attempt. + // If the attempt associates with the current NIC, we can + // get DHCP information for already added, but failed, attempt. // AttemptTmp->DhcpSuccess = FALSE; if (!mPrivate->Ipv6Flag && (AttemptTmp->SessionConfigData.IpMode == IP_MODE_IP4)) { @@ -1145,12 +2151,10 @@ IScsiGetConfigData ( // // Refresh the state of this attempt to NVR. // - AsciiStrToUnicodeStrS (AttemptTmp->MacString, MacString, sizeof (MacString) / sizeof (MacString[0])); UnicodeSPrint ( mPrivate->PortString, (UINTN) ISCSI_NAME_IFR_MAX_SIZE, - L"%s%d", - MacString, + L"Attempt %d", (UINTN) AttemptTmp->AttemptConfigIndex ); @@ -1178,20 +2182,21 @@ IScsiGetConfigData ( IScsiMacAddrToStr (&NicInfo->PermanentAddress, NicInfo->HwAddressSize, NicInfo->VlanId, MacString); UnicodeSPrint ( mPrivate->PortString, - (UINTN) 128, - L"%s%d", - MacString, + (UINTN) ISCSI_NAME_IFR_MAX_SIZE, + L"Attempt %d", (UINTN) AttemptConfigOrder[Index] ); GetVariable2 ( - mPrivate->PortString, - &gEfiIScsiInitiatorNameProtocolGuid, - (VOID**)&AttemptConfigData, - NULL - ); + mPrivate->PortString, + &gEfiIScsiInitiatorNameProtocolGuid, + (VOID**)&AttemptConfigData, + NULL + ); + AsciiStrToUnicodeStrS (AttemptConfigData->MacString, AttemptMacString, sizeof (AttemptMacString) / sizeof (AttemptMacString[0])); - if (AttemptConfigData == NULL) { + if (AttemptConfigData == NULL || AttemptConfigData->Actived == ISCSI_ACTIVE_DISABLED || + StrCmp (MacString, AttemptMacString)) { continue; } @@ -1210,7 +2215,7 @@ IScsiGetConfigData ( (UINT8) (mPrivate->Ipv6Flag ? IP_MODE_AUTOCONFIG_IP6 : IP_MODE_AUTOCONFIG_IP4); AttemptConfigData->AutoConfigureSuccess = FALSE; } - + // // Get some information from dhcp server. // @@ -1236,12 +2241,10 @@ IScsiGetConfigData ( // // Refresh the state of this attempt to NVR. // - AsciiStrToUnicodeStrS (AttemptConfigData->MacString, MacString, sizeof (MacString) / sizeof (MacString[0])); UnicodeSPrint ( mPrivate->PortString, (UINTN) ISCSI_NAME_IFR_MAX_SIZE, - L"%s%d", - MacString, + L"Attempt %d", (UINTN) AttemptConfigData->AttemptConfigIndex ); @@ -1292,7 +2295,9 @@ IScsiGetConfigData ( mPrivate->PortString, NULL ); - ASSERT (AttemptConfigData->AttemptTitleHelpToken != 0); + if (AttemptConfigData->AttemptTitleHelpToken == 0) { + return EFI_OUT_OF_RESOURCES; + } // // Record the attempt in global link list. @@ -1381,7 +2386,7 @@ IScsiGetTcpConnDevicePath ( Conn->TcpIo.Handle, &gEfiDevicePathProtocolGuid, (VOID **) &DevicePath - ); + ); if (EFI_ERROR (Status)) { return NULL; } @@ -1400,7 +2405,7 @@ IScsiGetTcpConnDevicePath ( if (!Conn->Ipv6Flag && DevicePathSubType (&DPathNode->DevPath) == MSG_IPv4_DP) { DPathNode->Ipv4.LocalPort = 0; - DPathNode->Ipv4.StaticIpAddress = + DPathNode->Ipv4.StaticIpAddress = (BOOLEAN) (!Session->ConfigData->SessionConfigData.InitiatorInfoFromDhcp); // @@ -1411,9 +2416,9 @@ IScsiGetTcpConnDevicePath ( // PathLen = DevicePathNodeLength (&DPathNode->Ipv4); - - if (PathLen == IP4_NODE_LEN_NEW_VERSIONS) { - + + if (PathLen == IP4_NODE_LEN_NEW_VERSIONS) { + IP4_COPY_ADDRESS ( &DPathNode->Ipv4.GatewayIpAddress, &Session->ConfigData->SessionConfigData.Gateway @@ -1424,7 +2429,7 @@ IScsiGetTcpConnDevicePath ( &Session->ConfigData->SessionConfigData.SubnetMask ); } - + break; } else if (Conn->Ipv6Flag && DevicePathSubType (&DPathNode->DevPath) == MSG_IPv6_DP) { DPathNode->Ipv6.LocalPort = 0; @@ -1433,28 +2438,28 @@ IScsiGetTcpConnDevicePath ( // Add a judgement here to support previous versions of IPv6_DEVICE_PATH. // In previous versions of IPv6_DEVICE_PATH, IpAddressOrigin, PrefixLength // and GatewayIpAddress do not exist. - // In new version of IPv6_DEVICE_PATH, structure length is 60, while in + // In new version of IPv6_DEVICE_PATH, structure length is 60, while in // old versions, the length is 43. // PathLen = DevicePathNodeLength (&DPathNode->Ipv6); - - if (PathLen == IP6_NODE_LEN_NEW_VERSIONS ) { + + if (PathLen == IP6_NODE_LEN_NEW_VERSIONS ) { DPathNode->Ipv6.IpAddressOrigin = 0; DPathNode->Ipv6.PrefixLength = IP6_PREFIX_LENGTH; ZeroMem (&DPathNode->Ipv6.GatewayIpAddress, sizeof (EFI_IPv6_ADDRESS)); } - else if (PathLen == IP6_NODE_LEN_OLD_VERSIONS) { + else if (PathLen == IP6_NODE_LEN_OLD_VERSIONS) { // - // StaticIPAddress is a field in old versions of IPv6_DEVICE_PATH, while ignored in new + // StaticIPAddress is a field in old versions of IPv6_DEVICE_PATH, while ignored in new // version. Set StaticIPAddress through its' offset in old IPv6_DEVICE_PATH. // - *((UINT8 *)(&DPathNode->Ipv6) + IP6_OLD_IPADDRESS_OFFSET) = + *((UINT8 *)(&DPathNode->Ipv6) + IP6_OLD_IPADDRESS_OFFSET) = (BOOLEAN) (!Session->ConfigData->SessionConfigData.InitiatorInfoFromDhcp); } - + break; } } @@ -1483,7 +2488,9 @@ IScsiOnExitBootService ( ISCSI_DRIVER_DATA *Private; Private = (ISCSI_DRIVER_DATA *) Context; + gBS->CloseEvent (Private->ExitBootServiceEvent); + Private->ExitBootServiceEvent = NULL; if (Private->Session != NULL) { IScsiSessionAbort (Private->Session); @@ -1497,7 +2504,7 @@ IScsiOnExitBootService ( currently managing the controller specified by ControllerHandle. This test is performed by evaluating if the the protocol specified by ProtocolGuid is present on ControllerHandle and is was opened by DriverBindingHandle and Nic - Device handle with an attribute of EFI_OPEN_PROTOCOL_BY_DRIVER. + Device handle with an attribute of EFI_OPEN_PROTOCOL_BY_DRIVER. If ProtocolGuid is NULL, then ASSERT(). @param ControllerHandle A handle for a controller to test.