X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=blobdiff_plain;f=ShellPkg%2FLibrary%2FUefiShellLevel2CommandsLib%2FMap.c;h=9166ca2205ca2631a62c81aaf20505233c2ebdbc;hp=d74a47ba52585f2a95355fbb58f34bf22af0e4c4;hb=4887443e4f03ec42ba422483f191ffe25a78eb3d;hpb=c154b9970849127546f50481b586d61d78c9bbec diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Map.c b/ShellPkg/Library/UefiShellLevel2CommandsLib/Map.c index d74a47ba52..9166ca2205 100644 --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Map.c +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Map.c @@ -1,7 +1,10 @@ /** @file Main file for map shell level 2 command. - Copyright (c) 2009 - 2010, Intel Corporation. All rights reserved.
+ Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
+ (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
+ (C) Copyright 2016 Hewlett Packard Enterprise Development LP
+ This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -19,8 +22,48 @@ #include #include +/** + Determine if a string has only numbers and letters. + + This is useful for such things as Map names which can only be letters and numbers. + + @param[in] String pointer to the string to analyze, + @param[in] Len Number of characters to analyze. + + @retval TRUE String has only numbers and letters + @retval FALSE String has at least one other character. +**/ +BOOLEAN +IsNumberLetterOnly( + IN CONST CHAR16 *String, + IN CONST UINTN Len + ) +{ + UINTN Count; + for (Count = 0 ; Count < Len && String != NULL && *String != CHAR_NULL ; String++,Count++) { + if (! ((*String >= L'a' && *String <= L'z') || + (*String >= L'A' && *String <= L'Z') || + (*String >= L'0' && *String <= L'9')) + ){ + return (FALSE); + } + } + return (TRUE); +} + +/** + Do a search in the Target delimited list. + + @param[in] List The list to seatch in. + @param[in] MetaTarget The item to search for. MetaMatching supported. + @param[out] FullName Optional pointer to an allocated buffer containing + the match. + @param[in] Meta TRUE to use MetaMatching. + @param[in] SkipTrailingNumbers TRUE to allow for numbers after the MetaTarget. + @param[in] Target The single character that delimits list + items (";" normally). +**/ BOOLEAN -EFIAPI SearchList( IN CONST CHAR16 *List, IN CONST CHAR16 *MetaTarget, @@ -75,105 +118,19 @@ SearchList( return (FALSE); } -EFI_STATUS -EFIAPI -UpdateMapping ( - VOID - ) -{ - EFI_STATUS Status; - EFI_HANDLE *HandleList; - UINTN Count; - EFI_DEVICE_PATH_PROTOCOL **DevicePathList; - CHAR16 *NewDefaultName; - CHAR16 *NewConsistName; - EFI_DEVICE_PATH_PROTOCOL **ConsistMappingTable; - - HandleList = NULL; - Status = EFI_SUCCESS; - - // - // remove mappings that represent removed devices. - // - - // - // Find each handle with Simple File System - // - HandleList = GetHandleListByProtocol(&gEfiSimpleFileSystemProtocolGuid); - if (HandleList != NULL) { - // - // Do a count of the handles - // - for (Count = 0 ; HandleList[Count] != NULL ; Count++); - - // - // Get all Device Paths - // - DevicePathList = AllocatePool(sizeof(EFI_DEVICE_PATH_PROTOCOL*) * Count); - ASSERT(DevicePathList != NULL); - - for (Count = 0 ; HandleList[Count] != NULL ; Count++) { - DevicePathList[Count] = DevicePathFromHandle(HandleList[Count]); - } - - // - // Sort all DevicePaths - // - PerformQuickSort(DevicePathList, Count, sizeof(EFI_DEVICE_PATH_PROTOCOL*), DevicePathCompare); - - ShellCommandConsistMappingInitialize(&ConsistMappingTable); - - // - // Assign new Mappings to remainders - // - for (Count = 0 ; HandleList[Count] != NULL && !EFI_ERROR(Status); Count++) { - // - // Skip ones that already have - // - if (gEfiShellProtocol->GetMapFromDevicePath(&DevicePathList[Count]) != NULL) { - continue; - } - // - // Get default name - // - NewDefaultName = ShellCommandCreateNewMappingName(MappingTypeFileSystem); - ASSERT(NewDefaultName != NULL); - - // - // Call shell protocol SetMap function now... - // - Status = gEfiShellProtocol->SetMap(DevicePathList[Count], NewDefaultName); - - if (!EFI_ERROR(Status)) { - // - // Now do consistent name - // - NewConsistName = ShellCommandConsistMappingGenMappingName(DevicePathList[Count], ConsistMappingTable); - if (NewConsistName != NULL) { - Status = gEfiShellProtocol->SetMap(DevicePathList[Count], NewConsistName); - FreePool(NewConsistName); - } - } - - FreePool(NewDefaultName); - } - ShellCommandConsistMappingUnInitialize(ConsistMappingTable); - SHELL_FREE_NON_NULL(HandleList); - SHELL_FREE_NON_NULL(DevicePathList); - - HandleList = NULL; - } else { - Count = (UINTN)-1; - } - // - // Do it all over again for gEfiBlockIoProtocolGuid - // +/** + Determine what type of device is represented and return it's string. The + string is in allocated memory and must be callee freed. The HII is is listed below. + The actual string cannot be determined. - return (Status); -} + @param[in] DevicePath The device to analyze. + @retval STR_MAP_MEDIA_UNKNOWN The media type is unknown. + @retval STR_MAP_MEDIA_HARDDISK The media is a hard drive. + @retval STR_MAP_MEDIA_CDROM The media is a CD ROM. + @retval STR_MAP_MEDIA_FLOPPY The media is a floppy drive. +**/ CHAR16* -EFIAPI GetDeviceMediaType ( IN EFI_DEVICE_PATH_PROTOCOL *DevicePath ) @@ -219,7 +176,6 @@ GetDeviceMediaType ( @retval FALSE The handle does not have removable storage. **/ BOOLEAN -EFIAPI IsRemoveableDevice ( IN EFI_DEVICE_PATH_PROTOCOL *DevicePath ) @@ -256,7 +212,6 @@ IsRemoveableDevice ( @retval FALSE The map should not be displayed. **/ BOOLEAN -EFIAPI MappingListHasType( IN CONST CHAR16 *MapList, IN CONST CHAR16 *Specific, @@ -265,15 +220,39 @@ MappingListHasType( IN CONST BOOLEAN Consist ) { + CHAR16 *NewSpecific; + RETURN_STATUS Status; + UINTN Length; + // // specific has priority // - if ( Specific != NULL - && SearchList(MapList, Specific, NULL, TRUE, FALSE, L";")) { - return (TRUE); - } + if (Specific != NULL) { + Length = StrLen (Specific); + // + // Allocate enough buffer for Specific and potential ":" + // + NewSpecific = AllocatePool ((Length + 2) * sizeof(CHAR16)); + if (NewSpecific == NULL){ + return FALSE; + } + StrCpyS (NewSpecific, Length + 2, Specific); + if (Specific[Length - 1] != L':') { + Status = StrnCatS(NewSpecific, Length + 2, L":", StrLen(L":")); + if (EFI_ERROR (Status)) { + FreePool(NewSpecific); + return FALSE; + } + } + if (SearchList(MapList, NewSpecific, NULL, TRUE, FALSE, L";")) { + FreePool(NewSpecific); + return (TRUE); + } + FreePool(NewSpecific); + } if ( Consist + && Specific == NULL && (SearchList(MapList, L"HD*", NULL, TRUE, TRUE, L";") ||SearchList(MapList, L"CD*", NULL, TRUE, TRUE, L";") ||SearchList(MapList, L"F*", NULL, TRUE, TRUE, L";") @@ -282,6 +261,7 @@ MappingListHasType( } if ( Normal + && Specific == NULL && (SearchList(MapList, L"FS", NULL, FALSE, TRUE, L";") ||SearchList(MapList, L"BLK", NULL, FALSE, TRUE, L";"))){ return (TRUE); @@ -294,8 +274,20 @@ MappingListHasType( } -VOID -EFIAPI +/** + Display a single map line for device Handle if conditions are met. + + @param[in] Verbose TRUE to display (extra) verbose information. + @param[in] Consist TRUE to display consistent mappings. + @param[in] Normal TRUE to display normal (not consist) mappings. + @param[in] TypeString pointer to string of filter types. + @param[in] SFO TRUE to display output in Standard Output Format. + @param[in] Specific pointer to string for specific map to display. + @param[in] Handle The handle to display from. + + @retval EFI_SUCCESS The mapping was displayed. +**/ +EFI_STATUS PerformSingleMappingDisplay( IN CONST BOOLEAN Verbose, IN CONST BOOLEAN Consist, @@ -313,30 +305,102 @@ PerformSingleMappingDisplay( CHAR16 *MediaType; CHAR16 *DevPathString; CHAR16 *TempSpot; + CHAR16 *Alias; UINTN TempLen; BOOLEAN Removable; CONST CHAR16 *TempSpot2; + Alias = NULL; + TempSpot2 = NULL; + CurrentName = NULL; DevPath = DevicePathFromHandle(Handle); DevPathCopy = DevPath; MapList = gEfiShellProtocol->GetMapFromDevicePath(&DevPathCopy); if (MapList == NULL) { - return; + return EFI_NOT_FOUND; } if (!MappingListHasType(MapList, Specific, TypeString, Normal, Consist)){ - return; + return EFI_NOT_FOUND; } - CurrentName = NULL; - CurrentName = StrnCatGrow(&CurrentName, 0, MapList, 0); - TempSpot = StrStr(CurrentName, L";"); - if (TempSpot != NULL) { - *TempSpot = CHAR_NULL; + if (Normal || !Consist) { + // + // need the Normal here since people can use both on command line. otherwise unused. + // + + // + // Allocate a name + // + CurrentName = NULL; + CurrentName = StrnCatGrow(&CurrentName, 0, MapList, 0); + if (CurrentName == NULL) { + return (EFI_OUT_OF_RESOURCES); + } + + // + // Chop off the other names that become "Alias(s)" + // leaving just the normal name + // + TempSpot = StrStr(CurrentName, L";"); + if (TempSpot != NULL) { + *TempSpot = CHAR_NULL; + } + } else { + CurrentName = NULL; + + // + // Skip the first name. This is the standard name. + // + TempSpot = StrStr(MapList, L";"); + if (TempSpot != NULL) { + TempSpot++; + } + SearchList(TempSpot, L"HD*", &CurrentName, TRUE, FALSE, L";"); + if (CurrentName == NULL) { + SearchList(TempSpot, L"CD*", &CurrentName, TRUE, FALSE, L";"); + } + if (CurrentName == NULL) { + SearchList(TempSpot, L"FP*", &CurrentName, TRUE, FALSE, L";"); + } + if (CurrentName == NULL) { + SearchList(TempSpot, L"F*", &CurrentName, TRUE, FALSE, L";"); + } + if (CurrentName == NULL) { + // + // We didnt find anything, so just the first one in the list... + // + CurrentName = StrnCatGrow(&CurrentName, 0, MapList, 0); + if (CurrentName == NULL) { + return (EFI_OUT_OF_RESOURCES); + } + TempSpot = StrStr(CurrentName, L";"); + if (TempSpot != NULL) { + *TempSpot = CHAR_NULL; + } + } else { + Alias = StrnCatGrow(&Alias, 0, MapList, 0); + if (Alias == NULL) { + return EFI_OUT_OF_RESOURCES; + } + TempSpot = StrStr(Alias, CurrentName); + if (TempSpot != NULL) { + TempSpot2 = StrStr(TempSpot, L";"); + if (TempSpot2 != NULL) { + TempSpot2++; // Move past ";" from CurrentName + CopyMem(TempSpot, TempSpot2, StrSize(TempSpot2)); + } else { + *TempSpot = CHAR_NULL; + } + } + if (Alias[StrLen(Alias)-1] == L';') { + Alias[StrLen(Alias)-1] = CHAR_NULL; + } + } } - DevPathString = gDevPathToText->ConvertDevicePathToText(DevPath, TRUE, FALSE); + DevPathString = ConvertDevicePathToText(DevPath, TRUE, FALSE); + TempLen = StrLen(CurrentName); if (!SFO) { - TempLen = StrLen(CurrentName); ShellPrintHiiEx ( -1, -1, @@ -344,7 +408,7 @@ PerformSingleMappingDisplay( STRING_TOKEN (STR_MAP_ENTRY), gShellLevel2HiiHandle, CurrentName, - TempLen < StrLen(MapList)?MapList + TempLen+1:L"", + Alias!=NULL?Alias:(TempLen < StrLen(MapList)?MapList + TempLen+1:L""), DevPathString ); if (Verbose) { @@ -367,10 +431,9 @@ PerformSingleMappingDisplay( TempSpot2 ); } - FreePool(MediaType); + SHELL_FREE_NON_NULL(MediaType); } } else { - TempLen = StrLen(CurrentName); ShellPrintHiiEx ( -1, -1, @@ -379,16 +442,25 @@ PerformSingleMappingDisplay( gShellLevel2HiiHandle, CurrentName, DevPathString, - TempLen < StrLen(MapList)?MapList + TempLen+1:L"" + Consist?L"":(TempLen < StrLen(MapList)?MapList + TempLen+1:L"") ); } - FreePool(DevPathString); - FreePool(CurrentName); - return; + SHELL_FREE_NON_NULL(DevPathString); + SHELL_FREE_NON_NULL(CurrentName); + SHELL_FREE_NON_NULL(Alias); + return EFI_SUCCESS; } +/** + Delete Specific from the list of maps for device Handle. + + @param[in] Specific The name to delete. + @param[in] Handle The device to look on. + + @retval EFI_SUCCESS The delete was successful. + @retval EFI_NOT_FOUND Name was not a map on Handle. +**/ EFI_STATUS -EFIAPI PerformSingleMappingDelete( IN CONST CHAR16 *Specific, IN CONST EFI_HANDLE Handle @@ -416,29 +488,29 @@ PerformSingleMappingDelete( return (gEfiShellProtocol->SetMap(NULL, CurrentName)); } +CONST CHAR16 Cd[] = L"cd*"; +CONST CHAR16 Hd[] = L"hd*"; +CONST CHAR16 Fp[] = L"fp*"; +CONST CHAR16 AnyF[] = L"F*"; /** Function to display mapping information to the user. - if Specific is specified then Consist and Normal will be ignored since information will + If Specific is specified then Consist and Normal will be ignored since information will be printed for the specific item only. - @param[in] Verbose TRUE to display (extra) verbose information - @param[in] Consist TRUE to display consistent mappings - @param[in] Normal TRUE to display normal (not consist) mappings - @param[in] TypeString pointer to string of filter types - @param[in] SFO TRUE to display output in Standard Output Format - @param[in] Specific pointer to string for specific map to display + @param[in] Verbose TRUE to display (extra) verbose information. + @param[in] Consist TRUE to display consistent mappings. + @param[in] Normal TRUE to display normal (not consist) mappings. + @param[in] TypeString Pointer to string of filter types. + @param[in] SFO TRUE to display output in Standard Output Format. + @param[in] Specific Pointer to string for specific map to display. + @param[in] Header TRUE to print the header block. - @retval SHELL_SUCCESS the display was printed - @retval SHELL_INVALID_PARAMETER one of Consist or Normal must be TRUE if no Specific + @retval SHELL_SUCCESS The display was printed. + @retval SHELL_INVALID_PARAMETER One of Consist or Normal must be TRUE if no Specific. **/ -CONST CHAR16 Cd[] = L"cd*"; -CONST CHAR16 Hd[] = L"hd*"; -CONST CHAR16 Fp[] = L"fp*"; -CONST CHAR16 F[] = L"F*"; SHELL_STATUS -EFIAPI PerformMappingDisplay( IN CONST BOOLEAN Verbose, IN CONST BOOLEAN Consist, @@ -454,9 +526,10 @@ PerformMappingDisplay( UINTN BufferSize; UINTN LoopVar; CHAR16 *Test; + BOOLEAN Found; if (!Consist && !Normal && Specific == NULL && TypeString == NULL) { - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_TOO_FEW), gShellLevel2HiiHandle); + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_TOO_FEW), gShellLevel2HiiHandle, L"map"); return (SHELL_INVALID_PARAMETER); } @@ -467,11 +540,11 @@ PerformMappingDisplay( if (StrnCmp(TypeString, Test, StrLen(Test)-1) != 0) { Test = (CHAR16*)Fp; if (StrnCmp(TypeString, Test, StrLen(Test)-1) != 0) { - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PROBLEM), gShellLevel2HiiHandle, TypeString); + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PARAM_INV), gShellLevel2HiiHandle, L"map", TypeString); return (SHELL_INVALID_PARAMETER); } } else if (Test == NULL) { - Test = (CHAR16*)F; + Test = (CHAR16*)AnyF; } } } else { @@ -497,33 +570,31 @@ PerformMappingDisplay( // Status = gBS->LocateHandle( ByProtocol, - &gEfiDevicePathProtocolGuid, + &gEfiSimpleFileSystemProtocolGuid, NULL, &BufferSize, HandleBuffer); if (Status == EFI_BUFFER_TOO_SMALL) { - HandleBuffer = AllocatePool(BufferSize); + HandleBuffer = AllocateZeroPool(BufferSize); if (HandleBuffer == NULL) { return (SHELL_OUT_OF_RESOURCES); } Status = gBS->LocateHandle( ByProtocol, - &gEfiDevicePathProtocolGuid, + &gEfiSimpleFileSystemProtocolGuid, NULL, &BufferSize, HandleBuffer); } - ASSERT_EFI_ERROR(Status); - ASSERT(HandleBuffer != NULL); // // Get the map name(s) for each one. // - for ( LoopVar = 0 - ; LoopVar < (BufferSize / sizeof(EFI_HANDLE)) + for ( LoopVar = 0, Found = FALSE + ; LoopVar < (BufferSize / sizeof(EFI_HANDLE)) && HandleBuffer != NULL ; LoopVar ++ ){ - PerformSingleMappingDisplay( + Status = PerformSingleMappingDisplay( Verbose, Consist, Normal, @@ -531,6 +602,9 @@ PerformMappingDisplay( SFO, Specific, HandleBuffer[LoopVar]); + if (!EFI_ERROR(Status)) { + Found = TRUE; + } } // @@ -543,8 +617,8 @@ PerformMappingDisplay( &BufferSize, HandleBuffer); if (Status == EFI_BUFFER_TOO_SMALL) { - FreePool(HandleBuffer); - HandleBuffer = AllocatePool(BufferSize); + SHELL_FREE_NON_NULL(HandleBuffer); + HandleBuffer = AllocateZeroPool(BufferSize); if (HandleBuffer == NULL) { return (SHELL_OUT_OF_RESOURCES); } @@ -555,7 +629,7 @@ PerformMappingDisplay( &BufferSize, HandleBuffer); } - if (!EFI_ERROR(Status)) { + if (!EFI_ERROR(Status) && HandleBuffer != NULL) { // // Get the map name(s) for each one. // @@ -568,14 +642,14 @@ PerformMappingDisplay( // if (gBS->OpenProtocol( HandleBuffer[LoopVar], - &gEfiDevicePathProtocolGuid, + &gEfiSimpleFileSystemProtocolGuid, NULL, gImageHandle, NULL, EFI_OPEN_PROTOCOL_TEST_PROTOCOL) == EFI_SUCCESS) { continue; } - PerformSingleMappingDisplay( + Status = PerformSingleMappingDisplay( Verbose, Consist, Normal, @@ -583,14 +657,37 @@ PerformMappingDisplay( SFO, Specific, HandleBuffer[LoopVar]); + if (!EFI_ERROR(Status)) { + Found = TRUE; + } } FreePool(HandleBuffer); } + if (!Found) { + if (Specific != NULL) { + ShellPrintHiiEx(gST->ConOut->Mode->CursorColumn, gST->ConOut->Mode->CursorRow-1, NULL, STRING_TOKEN (STR_MAP_NF), gShellLevel2HiiHandle, L"map", Specific); + } else { + ShellPrintHiiEx(gST->ConOut->Mode->CursorColumn, gST->ConOut->Mode->CursorRow-1, NULL, STRING_TOKEN (STR_CD_NF), gShellLevel2HiiHandle, L"map"); + } + } return (SHELL_SUCCESS); } +/** + Perform a mapping display and parse for multiple types in the TypeString. + + @param[in] Verbose TRUE to use verbose output. + @param[in] Consist TRUE to display consistent names. + @param[in] Normal TRUE to display normal names. + @param[in] TypeString An optional comma-delimited list of types. + @param[in] SFO TRUE to display in SFO format. See Spec. + @param[in] Specific An optional specific map name to display alone. + + @retval SHELL_INVALID_PARAMETER A parameter was invalid. + @retval SHELL_SUCCESS The display was successful. + @sa PerformMappingDisplay +**/ SHELL_STATUS -EFIAPI PerformMappingDisplay2( IN CONST BOOLEAN Verbose, IN CONST BOOLEAN Consist, @@ -633,8 +730,16 @@ PerformMappingDisplay2( return (ShellStatus); } +/** + Delete a specific map. + + @param[in] Specific The pointer to the name of the map to delete. + + @retval EFI_INVALID_PARAMETER Specific was NULL. + @retval EFI_SUCCESS The operation was successful. + @retval EFI_NOT_FOUND Specific could not be found. +**/ EFI_STATUS -EFIAPI PerformMappingDelete( IN CONST CHAR16 *Specific ) @@ -663,7 +768,7 @@ PerformMappingDelete( &BufferSize, HandleBuffer); if (Status == EFI_BUFFER_TOO_SMALL) { - HandleBuffer = AllocatePool(BufferSize); + HandleBuffer = AllocateZeroPool(BufferSize); if (HandleBuffer == NULL) { return (EFI_OUT_OF_RESOURCES); } @@ -703,7 +808,7 @@ PerformMappingDelete( HandleBuffer); if (Status == EFI_BUFFER_TOO_SMALL) { FreePool(HandleBuffer); - HandleBuffer = AllocatePool(BufferSize); + HandleBuffer = AllocateZeroPool(BufferSize); if (HandleBuffer == NULL) { return (EFI_OUT_OF_RESOURCES); } @@ -765,7 +870,6 @@ PerformMappingDelete( **/ SHELL_STATUS -EFIAPI AddMappingFromMapping( IN CONST CHAR16 *Map, IN CONST CHAR16 *SName @@ -773,54 +877,40 @@ AddMappingFromMapping( { CONST EFI_DEVICE_PATH_PROTOCOL *DevPath; EFI_STATUS Status; + CHAR16 *NewSName; + RETURN_STATUS StrRetStatus; + + NewSName = AllocateCopyPool(StrSize(SName) + sizeof(CHAR16), SName); + if (NewSName == NULL) { + return (SHELL_OUT_OF_RESOURCES); + } + if (NewSName[StrLen(NewSName)-1] != L':') { + StrRetStatus = StrnCatS(NewSName, (StrSize(SName) + sizeof(CHAR16))/sizeof(CHAR16), L":", StrLen(L":")); + if (EFI_ERROR(StrRetStatus)) { + FreePool(NewSName); + return ((SHELL_STATUS) (StrRetStatus & (~MAX_BIT))); + } + } - if (StrStr(SName, L"*") != NULL - ||StrStr(SName, L"?") != NULL - ||StrStr(SName, L"[") != NULL - ||StrStr(SName, L"]") != NULL) { + if (!IsNumberLetterOnly(NewSName, StrLen(NewSName)-1)) { + FreePool(NewSName); return (SHELL_INVALID_PARAMETER); } DevPath = gEfiShellProtocol->GetDevicePathFromMap(Map); if (DevPath == NULL) { + FreePool(NewSName); return (SHELL_INVALID_PARAMETER); } - Status = gEfiShellProtocol->SetMap(DevPath, SName); + Status = gEfiShellProtocol->SetMap(DevPath, NewSName); + FreePool(NewSName); if (EFI_ERROR(Status)) { return (SHELL_DEVICE_ERROR); } return (SHELL_SUCCESS); } -/** - function to determine if a string has only numbers and letters - - This is useful for such things as Map names which can only be letters and numbers - - @param[in] String pointer to the string to analyze - - @retval TRUE String has only numbers and letters - @retval FALSE String has at least one other character. -**/ -BOOLEAN -EFIAPI -IsNumberLetterOnly( - IN CONST CHAR16 *String - ) -{ - while(String != NULL && *String != CHAR_NULL) { - if (! ((*String >= L'a' && *String <= L'z') || - (*String >= L'A' && *String <= L'Z') || - (*String >= L'0' && *String <= L'9')) - ){ - return (FALSE); - } - String++; - } - return (TRUE); -} - /** function to add a mapping from an EFI_HANDLE. @@ -836,7 +926,6 @@ IsNumberLetterOnly( **/ SHELL_STATUS -EFIAPI AddMappingFromHandle( IN CONST EFI_HANDLE Handle, IN CONST CHAR16 *SName @@ -844,8 +933,23 @@ AddMappingFromHandle( { EFI_DEVICE_PATH_PROTOCOL *DevPath; EFI_STATUS Status; + CHAR16 *NewSName; + RETURN_STATUS StrRetStatus; + + NewSName = AllocateCopyPool(StrSize(SName) + sizeof(CHAR16), SName); + if (NewSName == NULL) { + return (SHELL_OUT_OF_RESOURCES); + } + if (NewSName[StrLen(NewSName)-1] != L':') { + StrRetStatus = StrnCatS(NewSName, (StrSize(SName) + sizeof(CHAR16))/sizeof(CHAR16), L":", StrLen(L":")); + if (EFI_ERROR(StrRetStatus)) { + FreePool(NewSName); + return ((SHELL_STATUS) (StrRetStatus & (~MAX_BIT))); + } + } - if (!IsNumberLetterOnly(SName)) { + if (!IsNumberLetterOnly(NewSName, StrLen(NewSName)-1)) { + FreePool(NewSName); return (SHELL_INVALID_PARAMETER); } @@ -858,9 +962,11 @@ AddMappingFromHandle( EFI_OPEN_PROTOCOL_GET_PROTOCOL ); if (EFI_ERROR(Status)) { + FreePool(NewSName); return (SHELL_DEVICE_ERROR); } - Status = gEfiShellProtocol->SetMap(DevPath, SName); + Status = gEfiShellProtocol->SetMap(DevPath, NewSName); + FreePool(NewSName); if (EFI_ERROR(Status)) { return (SHELL_DEVICE_ERROR); } @@ -879,6 +985,57 @@ STATIC CONST SHELL_PARAM_ITEM MapParamList[] = { {NULL, TypeMax} }; +/** + The routine issues dummy read for every physical block device to cause + the BlockIo re-installed if media change happened. +**/ +VOID +ProbeForMediaChange ( + VOID + ) +{ + EFI_STATUS Status; + UINTN HandleCount; + EFI_HANDLE *Handles; + EFI_BLOCK_IO_PROTOCOL *BlockIo; + UINTN Index; + + gBS->LocateHandleBuffer ( + ByProtocol, + &gEfiBlockIoProtocolGuid, + NULL, + &HandleCount, + &Handles + ); + // + // Probe for media change for every physical block io + // + for (Index = 0; Index < HandleCount; Index++) { + Status = gBS->HandleProtocol ( + Handles[Index], + &gEfiBlockIoProtocolGuid, + (VOID **) &BlockIo + ); + if (!EFI_ERROR (Status)) { + if (!BlockIo->Media->LogicalPartition) { + // + // Per spec: + // The function (ReadBlocks) must return EFI_NO_MEDIA or + // EFI_MEDIA_CHANGED even if LBA, BufferSize, or Buffer are invalid so the caller can probe + // for changes in media state. + // + BlockIo->ReadBlocks ( + BlockIo, + BlockIo->Media->MediaId, + 0, + 0, + NULL + ); + } + } + } +} + /** Function for 'map' command. @@ -897,21 +1054,20 @@ ShellCommandRunMap ( CHAR16 *ProblemParam; CONST CHAR16 *SName; CONST CHAR16 *Mapping; - EFI_HANDLE MappingAsHandle; - CONST EFI_DEVICE_PATH_PROTOCOL *DevPath; + EFI_HANDLE MapAsHandle; SHELL_STATUS ShellStatus; BOOLEAN SfoMode; BOOLEAN ConstMode; BOOLEAN NormlMode; CONST CHAR16 *Param1; CONST CHAR16 *TypeString; + UINTN TempStringLength; ProblemParam = NULL; Mapping = NULL; SName = NULL; - DevPath = NULL; ShellStatus = SHELL_SUCCESS; - MappingAsHandle = NULL; + MapAsHandle = NULL; // // initialize the shell lib (we must be in non-auto-init...) @@ -928,7 +1084,7 @@ ShellCommandRunMap ( Status = ShellCommandLineParse (MapParamList, &Package, &ProblemParam, TRUE); if (EFI_ERROR(Status)) { if (Status == EFI_VOLUME_CORRUPTED && ProblemParam != NULL) { - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PROBLEM), gShellLevel2HiiHandle, ProblemParam); + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PROBLEM), gShellLevel2HiiHandle, L"map", ProblemParam); FreePool(ProblemParam); ShellStatus = SHELL_INVALID_PARAMETER; } else { @@ -944,7 +1100,7 @@ ShellCommandRunMap ( if (ShellCommandLineGetFlag(Package, L"-?")) { ASSERT(FALSE); } else if (ShellCommandLineGetRawValue(Package, 3) != NULL) { - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_TOO_MANY), gShellLevel2HiiHandle); + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_TOO_MANY), gShellLevel2HiiHandle, L"map"); ShellStatus = SHELL_INVALID_PARAMETER; } else { // @@ -958,29 +1114,26 @@ ShellCommandRunMap ( || ShellCommandLineGetFlag(Package, L"-u") || ShellCommandLineGetFlag(Package, L"-t") ){ - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PARAM_CON), gShellLevel2HiiHandle); + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PARAM_CON), gShellLevel2HiiHandle, L"map"); ShellStatus = SHELL_INVALID_PARAMETER; } else { SName = ShellCommandLineGetValue(Package, L"-d"); if (SName != NULL) { Status = PerformMappingDelete(SName); if (EFI_ERROR(Status)) { - switch (Status) { - case EFI_ACCESS_DENIED: - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_AD), gShellLevel2HiiHandle); - ShellStatus = SHELL_ACCESS_DENIED; - break; - case EFI_NOT_FOUND: - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_MAP_NF), gShellLevel2HiiHandle, SName); - ShellStatus = SHELL_INVALID_PARAMETER; - break; - default: - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_UK), gShellLevel2HiiHandle, Status); - ShellStatus = SHELL_UNSUPPORTED; + if (Status == EFI_ACCESS_DENIED) { + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_AD), gShellLevel2HiiHandle, L"map"); + ShellStatus = SHELL_ACCESS_DENIED; + } else if (Status == EFI_NOT_FOUND) { + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_MAP_NF), gShellLevel2HiiHandle, L"map", SName); + ShellStatus = SHELL_INVALID_PARAMETER; + } else { + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_UK), gShellLevel2HiiHandle, L"map", Status); + ShellStatus = SHELL_UNSUPPORTED; } } } else { - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_TOO_FEW), gShellLevel2HiiHandle); + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_TOO_FEW), gShellLevel2HiiHandle, L"map"); ShellStatus = SHELL_INVALID_PARAMETER; } } @@ -991,13 +1144,14 @@ ShellCommandRunMap ( || ShellCommandLineGetFlag(Package, L"-u") || ShellCommandLineGetFlag(Package, L"-t") ){ + ProbeForMediaChange (); if ( ShellCommandLineGetFlag(Package, L"-r")) { // // Do the reset // Status = ShellCommandCreateInitialMappingsAndPaths(); if (EFI_ERROR(Status)) { - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_UK), gShellLevel2HiiHandle, Status); + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_UK), gShellLevel2HiiHandle, L"map", Status); ShellStatus = SHELL_UNSUPPORTED; } } @@ -1005,9 +1159,9 @@ ShellCommandRunMap ( // // Do the Update // - Status = UpdateMapping(); + Status = ShellCommandUpdateMapping (); if (EFI_ERROR(Status)) { - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_UK), gShellLevel2HiiHandle, Status); + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_UK), gShellLevel2HiiHandle, L"map", Status); ShellStatus = SHELL_UNSUPPORTED; } } @@ -1082,44 +1236,56 @@ ShellCommandRunMap ( ); } else { if (ShellIsHexOrDecimalNumber(Mapping, TRUE, FALSE)) { - MappingAsHandle = ConvertHandleIndexToHandle(StrHexToUintn(Mapping)); + MapAsHandle = ConvertHandleIndexToHandle(ShellStrToUintn(Mapping)); } else { - MappingAsHandle = NULL; + MapAsHandle = NULL; } - if (MappingAsHandle == NULL && Mapping[StrLen(Mapping)-1] != L':') { - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PROBLEM), gShellLevel2HiiHandle, Mapping); + if (MapAsHandle == NULL && Mapping[StrLen(Mapping)-1] != L':') { + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PARAM_INV), gShellLevel2HiiHandle, L"map", Mapping); ShellStatus = SHELL_INVALID_PARAMETER; } else { - if (MappingAsHandle != NULL) { - ShellStatus = AddMappingFromHandle(MappingAsHandle, SName); - } else { - ShellStatus = AddMappingFromMapping(Mapping, SName); + TempStringLength = StrLen(SName); + if (!IsNumberLetterOnly(SName, TempStringLength-(SName[TempStringLength-1]==L':'?1:0))) { + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PARAM_INV), gShellLevel2HiiHandle, L"map", SName); + ShellStatus = SHELL_INVALID_PARAMETER; } - if (ShellStatus != SHELL_SUCCESS) { - switch (ShellStatus) { - case SHELL_ACCESS_DENIED: - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_AD), gShellLevel2HiiHandle); - break; - case SHELL_INVALID_PARAMETER: - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PARAM_INV), gShellLevel2HiiHandle); - break; - default: - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_UK), gShellLevel2HiiHandle, ShellStatus|MAX_BIT); + + if (ShellStatus == SHELL_SUCCESS) { + if (MapAsHandle != NULL) { + ShellStatus = AddMappingFromHandle(MapAsHandle, SName); + } else { + ShellStatus = AddMappingFromMapping(Mapping, SName); } - } else { - // - // now do the display... - // - ShellStatus = PerformMappingDisplay( - FALSE, - FALSE, - FALSE, - NULL, - SfoMode, - SName, - TRUE - ); - } // we were sucessful so do an output + + if (ShellStatus != SHELL_SUCCESS) { + switch (ShellStatus) { + case SHELL_ACCESS_DENIED: + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_AD), gShellLevel2HiiHandle, L"map"); + break; + case SHELL_INVALID_PARAMETER: + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PARAM_INV), gShellLevel2HiiHandle, L"map", Mapping); + break; + case SHELL_DEVICE_ERROR: + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_MAP_NOF), gShellLevel2HiiHandle, L"map", Mapping); + break; + default: + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_UK), gShellLevel2HiiHandle, L"map", ShellStatus|MAX_BIT); + } + } else { + // + // now do the display... + // + ShellStatus = PerformMappingDisplay( + FALSE, + FALSE, + FALSE, + NULL, + SfoMode, + SName, + TRUE + ); + } // we were sucessful so do an output + } } // got a valid map target } // got 2 variables } // we are adding a mapping