X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=blobdiff_plain;f=ShellPkg%2FLibrary%2FUefiShellLevel2CommandsLib%2FMap.c;h=9166ca2205ca2631a62c81aaf20505233c2ebdbc;hp=e7d19c9bed702c84d339c68265010282991aba3c;hb=4887443e4f03ec42ba422483f191ffe25a78eb3d;hpb=33c031ee2092282a069ce07d30202082ceaf61fe diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Map.c b/ShellPkg/Library/UefiShellLevel2CommandsLib/Map.c index e7d19c9bed..9166ca2205 100644 --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Map.c +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Map.c @@ -1,7 +1,10 @@ /** @file Main file for map shell level 2 command. - Copyright (c) 2009 - 2011, Intel Corporation. All rights reserved.
+ Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
+ (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
+ (C) Copyright 2016 Hewlett Packard Enterprise Development LP
+ This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -31,7 +34,6 @@ @retval FALSE String has at least one other character. **/ BOOLEAN -EFIAPI IsNumberLetterOnly( IN CONST CHAR16 *String, IN CONST UINTN Len @@ -62,7 +64,6 @@ IsNumberLetterOnly( items (";" normally). **/ BOOLEAN -EFIAPI SearchList( IN CONST CHAR16 *List, IN CONST CHAR16 *MetaTarget, @@ -117,108 +118,6 @@ SearchList( return (FALSE); } -/** - Add mappings for any devices without one. Do not change any existing maps. - - @retval EFI_SUCCESS The operation was successful. -**/ -EFI_STATUS -EFIAPI -UpdateMapping ( - VOID - ) -{ - EFI_STATUS Status; - EFI_HANDLE *HandleList; - UINTN Count; - EFI_DEVICE_PATH_PROTOCOL **DevicePathList; - CHAR16 *NewDefaultName; - CHAR16 *NewConsistName; - EFI_DEVICE_PATH_PROTOCOL **ConsistMappingTable; - - HandleList = NULL; - Status = EFI_SUCCESS; - - // - // remove mappings that represent removed devices. - // - - // - // Find each handle with Simple File System - // - HandleList = GetHandleListByProtocol(&gEfiSimpleFileSystemProtocolGuid); - if (HandleList != NULL) { - // - // Do a count of the handles - // - for (Count = 0 ; HandleList[Count] != NULL ; Count++); - - // - // Get all Device Paths - // - DevicePathList = AllocateZeroPool(sizeof(EFI_DEVICE_PATH_PROTOCOL*) * Count); - ASSERT(DevicePathList != NULL); - - for (Count = 0 ; HandleList[Count] != NULL ; Count++) { - DevicePathList[Count] = DevicePathFromHandle(HandleList[Count]); - } - - // - // Sort all DevicePaths - // - PerformQuickSort(DevicePathList, Count, sizeof(EFI_DEVICE_PATH_PROTOCOL*), DevicePathCompare); - - ShellCommandConsistMappingInitialize(&ConsistMappingTable); - - // - // Assign new Mappings to remainders - // - for (Count = 0 ; HandleList[Count] != NULL && !EFI_ERROR(Status); Count++) { - // - // Skip ones that already have - // - if (gEfiShellProtocol->GetMapFromDevicePath(&DevicePathList[Count]) != NULL) { - continue; - } - // - // Get default name - // - NewDefaultName = ShellCommandCreateNewMappingName(MappingTypeFileSystem); - ASSERT(NewDefaultName != NULL); - - // - // Call shell protocol SetMap function now... - // - Status = gEfiShellProtocol->SetMap(DevicePathList[Count], NewDefaultName); - - if (!EFI_ERROR(Status)) { - // - // Now do consistent name - // - NewConsistName = ShellCommandConsistMappingGenMappingName(DevicePathList[Count], ConsistMappingTable); - if (NewConsistName != NULL) { - Status = gEfiShellProtocol->SetMap(DevicePathList[Count], NewConsistName); - FreePool(NewConsistName); - } - } - - FreePool(NewDefaultName); - } - ShellCommandConsistMappingUnInitialize(ConsistMappingTable); - SHELL_FREE_NON_NULL(HandleList); - SHELL_FREE_NON_NULL(DevicePathList); - - HandleList = NULL; - } else { - Count = (UINTN)-1; - } - // - // Do it all over again for gEfiBlockIoProtocolGuid - // - - return (Status); -} - /** Determine what type of device is represented and return it's string. The string is in allocated memory and must be callee freed. The HII is is listed below. @@ -232,7 +131,6 @@ UpdateMapping ( @retval STR_MAP_MEDIA_FLOPPY The media is a floppy drive. **/ CHAR16* -EFIAPI GetDeviceMediaType ( IN EFI_DEVICE_PATH_PROTOCOL *DevicePath ) @@ -278,7 +176,6 @@ GetDeviceMediaType ( @retval FALSE The handle does not have removable storage. **/ BOOLEAN -EFIAPI IsRemoveableDevice ( IN EFI_DEVICE_PATH_PROTOCOL *DevicePath ) @@ -315,7 +212,6 @@ IsRemoveableDevice ( @retval FALSE The map should not be displayed. **/ BOOLEAN -EFIAPI MappingListHasType( IN CONST CHAR16 *MapList, IN CONST CHAR16 *Specific, @@ -324,18 +220,29 @@ MappingListHasType( IN CONST BOOLEAN Consist ) { - CHAR16 *NewSpecific; + CHAR16 *NewSpecific; + RETURN_STATUS Status; + UINTN Length; + // // specific has priority // if (Specific != NULL) { - NewSpecific = AllocateZeroPool(StrSize(Specific) + sizeof(CHAR16)); + Length = StrLen (Specific); + // + // Allocate enough buffer for Specific and potential ":" + // + NewSpecific = AllocatePool ((Length + 2) * sizeof(CHAR16)); if (NewSpecific == NULL){ return FALSE; } - StrCpy(NewSpecific, Specific); - if (NewSpecific[StrLen(NewSpecific)-1] != L':') { - StrCat(NewSpecific, L":"); + StrCpyS (NewSpecific, Length + 2, Specific); + if (Specific[Length - 1] != L':') { + Status = StrnCatS(NewSpecific, Length + 2, L":", StrLen(L":")); + if (EFI_ERROR (Status)) { + FreePool(NewSpecific); + return FALSE; + } } if (SearchList(MapList, NewSpecific, NULL, TRUE, FALSE, L";")) { @@ -345,14 +252,16 @@ MappingListHasType( FreePool(NewSpecific); } if ( Consist + && Specific == NULL && (SearchList(MapList, L"HD*", NULL, TRUE, TRUE, L";") ||SearchList(MapList, L"CD*", NULL, TRUE, TRUE, L";") - ||SearchList(MapList, L"AnyF*", NULL, TRUE, TRUE, L";") + ||SearchList(MapList, L"F*", NULL, TRUE, TRUE, L";") ||SearchList(MapList, L"FP*", NULL, TRUE, TRUE, L";"))){ return (TRUE); } if ( Normal + && Specific == NULL && (SearchList(MapList, L"FS", NULL, FALSE, TRUE, L";") ||SearchList(MapList, L"BLK", NULL, FALSE, TRUE, L";"))){ return (TRUE); @@ -379,7 +288,6 @@ MappingListHasType( @retval EFI_SUCCESS The mapping was displayed. **/ EFI_STATUS -EFIAPI PerformSingleMappingDisplay( IN CONST BOOLEAN Verbose, IN CONST BOOLEAN Consist, @@ -397,10 +305,14 @@ PerformSingleMappingDisplay( CHAR16 *MediaType; CHAR16 *DevPathString; CHAR16 *TempSpot; + CHAR16 *Alias; UINTN TempLen; BOOLEAN Removable; CONST CHAR16 *TempSpot2; + Alias = NULL; + TempSpot2 = NULL; + CurrentName = NULL; DevPath = DevicePathFromHandle(Handle); DevPathCopy = DevPath; MapList = gEfiShellProtocol->GetMapFromDevicePath(&DevPathCopy); @@ -412,15 +324,83 @@ PerformSingleMappingDisplay( return EFI_NOT_FOUND; } - CurrentName = NULL; - CurrentName = StrnCatGrow(&CurrentName, 0, MapList, 0); - TempSpot = StrStr(CurrentName, L";"); - if (TempSpot != NULL) { - *TempSpot = CHAR_NULL; + if (Normal || !Consist) { + // + // need the Normal here since people can use both on command line. otherwise unused. + // + + // + // Allocate a name + // + CurrentName = NULL; + CurrentName = StrnCatGrow(&CurrentName, 0, MapList, 0); + if (CurrentName == NULL) { + return (EFI_OUT_OF_RESOURCES); + } + + // + // Chop off the other names that become "Alias(s)" + // leaving just the normal name + // + TempSpot = StrStr(CurrentName, L";"); + if (TempSpot != NULL) { + *TempSpot = CHAR_NULL; + } + } else { + CurrentName = NULL; + + // + // Skip the first name. This is the standard name. + // + TempSpot = StrStr(MapList, L";"); + if (TempSpot != NULL) { + TempSpot++; + } + SearchList(TempSpot, L"HD*", &CurrentName, TRUE, FALSE, L";"); + if (CurrentName == NULL) { + SearchList(TempSpot, L"CD*", &CurrentName, TRUE, FALSE, L";"); + } + if (CurrentName == NULL) { + SearchList(TempSpot, L"FP*", &CurrentName, TRUE, FALSE, L";"); + } + if (CurrentName == NULL) { + SearchList(TempSpot, L"F*", &CurrentName, TRUE, FALSE, L";"); + } + if (CurrentName == NULL) { + // + // We didnt find anything, so just the first one in the list... + // + CurrentName = StrnCatGrow(&CurrentName, 0, MapList, 0); + if (CurrentName == NULL) { + return (EFI_OUT_OF_RESOURCES); + } + TempSpot = StrStr(CurrentName, L";"); + if (TempSpot != NULL) { + *TempSpot = CHAR_NULL; + } + } else { + Alias = StrnCatGrow(&Alias, 0, MapList, 0); + if (Alias == NULL) { + return EFI_OUT_OF_RESOURCES; + } + TempSpot = StrStr(Alias, CurrentName); + if (TempSpot != NULL) { + TempSpot2 = StrStr(TempSpot, L";"); + if (TempSpot2 != NULL) { + TempSpot2++; // Move past ";" from CurrentName + CopyMem(TempSpot, TempSpot2, StrSize(TempSpot2)); + } else { + *TempSpot = CHAR_NULL; + } + } + if (Alias[StrLen(Alias)-1] == L';') { + Alias[StrLen(Alias)-1] = CHAR_NULL; + } + } } - DevPathString = gDevPathToText->ConvertDevicePathToText(DevPath, TRUE, FALSE); + DevPathString = ConvertDevicePathToText(DevPath, TRUE, FALSE); + TempLen = StrLen(CurrentName); if (!SFO) { - TempLen = StrLen(CurrentName); ShellPrintHiiEx ( -1, -1, @@ -428,7 +408,7 @@ PerformSingleMappingDisplay( STRING_TOKEN (STR_MAP_ENTRY), gShellLevel2HiiHandle, CurrentName, - TempLen < StrLen(MapList)?MapList + TempLen+1:L"", + Alias!=NULL?Alias:(TempLen < StrLen(MapList)?MapList + TempLen+1:L""), DevPathString ); if (Verbose) { @@ -451,10 +431,9 @@ PerformSingleMappingDisplay( TempSpot2 ); } - FreePool(MediaType); + SHELL_FREE_NON_NULL(MediaType); } } else { - TempLen = StrLen(CurrentName); ShellPrintHiiEx ( -1, -1, @@ -463,11 +442,12 @@ PerformSingleMappingDisplay( gShellLevel2HiiHandle, CurrentName, DevPathString, - TempLen < StrLen(MapList)?MapList + TempLen+1:L"" + Consist?L"":(TempLen < StrLen(MapList)?MapList + TempLen+1:L"") ); } - FreePool(DevPathString); - FreePool(CurrentName); + SHELL_FREE_NON_NULL(DevPathString); + SHELL_FREE_NON_NULL(CurrentName); + SHELL_FREE_NON_NULL(Alias); return EFI_SUCCESS; } @@ -481,7 +461,6 @@ PerformSingleMappingDisplay( @retval EFI_NOT_FOUND Name was not a map on Handle. **/ EFI_STATUS -EFIAPI PerformSingleMappingDelete( IN CONST CHAR16 *Specific, IN CONST EFI_HANDLE Handle @@ -516,22 +495,22 @@ CONST CHAR16 AnyF[] = L"F*"; /** Function to display mapping information to the user. - if Specific is specified then Consist and Normal will be ignored since information will + If Specific is specified then Consist and Normal will be ignored since information will be printed for the specific item only. - @param[in] Verbose TRUE to display (extra) verbose information - @param[in] Consist TRUE to display consistent mappings - @param[in] Normal TRUE to display normal (not consist) mappings - @param[in] TypeString pointer to string of filter types - @param[in] SFO TRUE to display output in Standard Output Format - @param[in] Specific pointer to string for specific map to display + @param[in] Verbose TRUE to display (extra) verbose information. + @param[in] Consist TRUE to display consistent mappings. + @param[in] Normal TRUE to display normal (not consist) mappings. + @param[in] TypeString Pointer to string of filter types. + @param[in] SFO TRUE to display output in Standard Output Format. + @param[in] Specific Pointer to string for specific map to display. + @param[in] Header TRUE to print the header block. - @retval SHELL_SUCCESS the display was printed - @retval SHELL_INVALID_PARAMETER one of Consist or Normal must be TRUE if no Specific + @retval SHELL_SUCCESS The display was printed. + @retval SHELL_INVALID_PARAMETER One of Consist or Normal must be TRUE if no Specific. **/ SHELL_STATUS -EFIAPI PerformMappingDisplay( IN CONST BOOLEAN Verbose, IN CONST BOOLEAN Consist, @@ -550,7 +529,7 @@ PerformMappingDisplay( BOOLEAN Found; if (!Consist && !Normal && Specific == NULL && TypeString == NULL) { - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_TOO_FEW), gShellLevel2HiiHandle); + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_TOO_FEW), gShellLevel2HiiHandle, L"map"); return (SHELL_INVALID_PARAMETER); } @@ -561,7 +540,7 @@ PerformMappingDisplay( if (StrnCmp(TypeString, Test, StrLen(Test)-1) != 0) { Test = (CHAR16*)Fp; if (StrnCmp(TypeString, Test, StrLen(Test)-1) != 0) { - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PROBLEM), gShellLevel2HiiHandle, TypeString); + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PARAM_INV), gShellLevel2HiiHandle, L"map", TypeString); return (SHELL_INVALID_PARAMETER); } } else if (Test == NULL) { @@ -650,7 +629,7 @@ PerformMappingDisplay( &BufferSize, HandleBuffer); } - if (!EFI_ERROR(Status)) { + if (!EFI_ERROR(Status) && HandleBuffer != NULL) { // // Get the map name(s) for each one. // @@ -685,7 +664,11 @@ PerformMappingDisplay( FreePool(HandleBuffer); } if (!Found) { - ShellPrintHiiEx(gST->ConOut->Mode->CursorColumn, gST->ConOut->Mode->CursorRow-1, NULL, STRING_TOKEN (STR_MAP_NF), gShellLevel2HiiHandle, Specific); + if (Specific != NULL) { + ShellPrintHiiEx(gST->ConOut->Mode->CursorColumn, gST->ConOut->Mode->CursorRow-1, NULL, STRING_TOKEN (STR_MAP_NF), gShellLevel2HiiHandle, L"map", Specific); + } else { + ShellPrintHiiEx(gST->ConOut->Mode->CursorColumn, gST->ConOut->Mode->CursorRow-1, NULL, STRING_TOKEN (STR_CD_NF), gShellLevel2HiiHandle, L"map"); + } } return (SHELL_SUCCESS); } @@ -705,7 +688,6 @@ PerformMappingDisplay( @sa PerformMappingDisplay **/ SHELL_STATUS -EFIAPI PerformMappingDisplay2( IN CONST BOOLEAN Verbose, IN CONST BOOLEAN Consist, @@ -758,7 +740,6 @@ PerformMappingDisplay2( @retval EFI_NOT_FOUND Specific could not be found. **/ EFI_STATUS -EFIAPI PerformMappingDelete( IN CONST CHAR16 *Specific ) @@ -889,7 +870,6 @@ PerformMappingDelete( **/ SHELL_STATUS -EFIAPI AddMappingFromMapping( IN CONST CHAR16 *Map, IN CONST CHAR16 *SName @@ -898,14 +878,18 @@ AddMappingFromMapping( CONST EFI_DEVICE_PATH_PROTOCOL *DevPath; EFI_STATUS Status; CHAR16 *NewSName; + RETURN_STATUS StrRetStatus; - NewSName = AllocateZeroPool(StrSize(SName) + sizeof(CHAR16)); + NewSName = AllocateCopyPool(StrSize(SName) + sizeof(CHAR16), SName); if (NewSName == NULL) { return (SHELL_OUT_OF_RESOURCES); } - StrCpy(NewSName, SName); if (NewSName[StrLen(NewSName)-1] != L':') { - StrCat(NewSName, L":"); + StrRetStatus = StrnCatS(NewSName, (StrSize(SName) + sizeof(CHAR16))/sizeof(CHAR16), L":", StrLen(L":")); + if (EFI_ERROR(StrRetStatus)) { + FreePool(NewSName); + return ((SHELL_STATUS) (StrRetStatus & (~MAX_BIT))); + } } if (!IsNumberLetterOnly(NewSName, StrLen(NewSName)-1)) { @@ -942,7 +926,6 @@ AddMappingFromMapping( **/ SHELL_STATUS -EFIAPI AddMappingFromHandle( IN CONST EFI_HANDLE Handle, IN CONST CHAR16 *SName @@ -951,14 +934,18 @@ AddMappingFromHandle( EFI_DEVICE_PATH_PROTOCOL *DevPath; EFI_STATUS Status; CHAR16 *NewSName; + RETURN_STATUS StrRetStatus; - NewSName = AllocateZeroPool(StrSize(SName) + sizeof(CHAR16)); + NewSName = AllocateCopyPool(StrSize(SName) + sizeof(CHAR16), SName); if (NewSName == NULL) { return (SHELL_OUT_OF_RESOURCES); } - StrCpy(NewSName, SName); if (NewSName[StrLen(NewSName)-1] != L':') { - StrCat(NewSName, L":"); + StrRetStatus = StrnCatS(NewSName, (StrSize(SName) + sizeof(CHAR16))/sizeof(CHAR16), L":", StrLen(L":")); + if (EFI_ERROR(StrRetStatus)) { + FreePool(NewSName); + return ((SHELL_STATUS) (StrRetStatus & (~MAX_BIT))); + } } if (!IsNumberLetterOnly(NewSName, StrLen(NewSName)-1)) { @@ -998,6 +985,57 @@ STATIC CONST SHELL_PARAM_ITEM MapParamList[] = { {NULL, TypeMax} }; +/** + The routine issues dummy read for every physical block device to cause + the BlockIo re-installed if media change happened. +**/ +VOID +ProbeForMediaChange ( + VOID + ) +{ + EFI_STATUS Status; + UINTN HandleCount; + EFI_HANDLE *Handles; + EFI_BLOCK_IO_PROTOCOL *BlockIo; + UINTN Index; + + gBS->LocateHandleBuffer ( + ByProtocol, + &gEfiBlockIoProtocolGuid, + NULL, + &HandleCount, + &Handles + ); + // + // Probe for media change for every physical block io + // + for (Index = 0; Index < HandleCount; Index++) { + Status = gBS->HandleProtocol ( + Handles[Index], + &gEfiBlockIoProtocolGuid, + (VOID **) &BlockIo + ); + if (!EFI_ERROR (Status)) { + if (!BlockIo->Media->LogicalPartition) { + // + // Per spec: + // The function (ReadBlocks) must return EFI_NO_MEDIA or + // EFI_MEDIA_CHANGED even if LBA, BufferSize, or Buffer are invalid so the caller can probe + // for changes in media state. + // + BlockIo->ReadBlocks ( + BlockIo, + BlockIo->Media->MediaId, + 0, + 0, + NULL + ); + } + } + } +} + /** Function for 'map' command. @@ -1017,7 +1055,6 @@ ShellCommandRunMap ( CONST CHAR16 *SName; CONST CHAR16 *Mapping; EFI_HANDLE MapAsHandle; - CONST EFI_DEVICE_PATH_PROTOCOL *DevPath; SHELL_STATUS ShellStatus; BOOLEAN SfoMode; BOOLEAN ConstMode; @@ -1029,7 +1066,6 @@ ShellCommandRunMap ( ProblemParam = NULL; Mapping = NULL; SName = NULL; - DevPath = NULL; ShellStatus = SHELL_SUCCESS; MapAsHandle = NULL; @@ -1048,7 +1084,7 @@ ShellCommandRunMap ( Status = ShellCommandLineParse (MapParamList, &Package, &ProblemParam, TRUE); if (EFI_ERROR(Status)) { if (Status == EFI_VOLUME_CORRUPTED && ProblemParam != NULL) { - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PROBLEM), gShellLevel2HiiHandle, ProblemParam); + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PROBLEM), gShellLevel2HiiHandle, L"map", ProblemParam); FreePool(ProblemParam); ShellStatus = SHELL_INVALID_PARAMETER; } else { @@ -1064,7 +1100,7 @@ ShellCommandRunMap ( if (ShellCommandLineGetFlag(Package, L"-?")) { ASSERT(FALSE); } else if (ShellCommandLineGetRawValue(Package, 3) != NULL) { - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_TOO_MANY), gShellLevel2HiiHandle); + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_TOO_MANY), gShellLevel2HiiHandle, L"map"); ShellStatus = SHELL_INVALID_PARAMETER; } else { // @@ -1078,29 +1114,26 @@ ShellCommandRunMap ( || ShellCommandLineGetFlag(Package, L"-u") || ShellCommandLineGetFlag(Package, L"-t") ){ - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PARAM_CON), gShellLevel2HiiHandle); + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PARAM_CON), gShellLevel2HiiHandle, L"map"); ShellStatus = SHELL_INVALID_PARAMETER; } else { SName = ShellCommandLineGetValue(Package, L"-d"); if (SName != NULL) { Status = PerformMappingDelete(SName); if (EFI_ERROR(Status)) { - switch (Status) { - case EFI_ACCESS_DENIED: - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_AD), gShellLevel2HiiHandle); - ShellStatus = SHELL_ACCESS_DENIED; - break; - case EFI_NOT_FOUND: - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_MAP_NF), gShellLevel2HiiHandle, SName); - ShellStatus = SHELL_INVALID_PARAMETER; - break; - default: - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_UK), gShellLevel2HiiHandle, Status); - ShellStatus = SHELL_UNSUPPORTED; + if (Status == EFI_ACCESS_DENIED) { + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_AD), gShellLevel2HiiHandle, L"map"); + ShellStatus = SHELL_ACCESS_DENIED; + } else if (Status == EFI_NOT_FOUND) { + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_MAP_NF), gShellLevel2HiiHandle, L"map", SName); + ShellStatus = SHELL_INVALID_PARAMETER; + } else { + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_UK), gShellLevel2HiiHandle, L"map", Status); + ShellStatus = SHELL_UNSUPPORTED; } } } else { - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_TOO_FEW), gShellLevel2HiiHandle); + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_TOO_FEW), gShellLevel2HiiHandle, L"map"); ShellStatus = SHELL_INVALID_PARAMETER; } } @@ -1111,13 +1144,14 @@ ShellCommandRunMap ( || ShellCommandLineGetFlag(Package, L"-u") || ShellCommandLineGetFlag(Package, L"-t") ){ + ProbeForMediaChange (); if ( ShellCommandLineGetFlag(Package, L"-r")) { // // Do the reset // Status = ShellCommandCreateInitialMappingsAndPaths(); if (EFI_ERROR(Status)) { - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_UK), gShellLevel2HiiHandle, Status); + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_UK), gShellLevel2HiiHandle, L"map", Status); ShellStatus = SHELL_UNSUPPORTED; } } @@ -1125,9 +1159,9 @@ ShellCommandRunMap ( // // Do the Update // - Status = UpdateMapping(); + Status = ShellCommandUpdateMapping (); if (EFI_ERROR(Status)) { - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_UK), gShellLevel2HiiHandle, Status); + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_UK), gShellLevel2HiiHandle, L"map", Status); ShellStatus = SHELL_UNSUPPORTED; } } @@ -1207,54 +1241,51 @@ ShellCommandRunMap ( MapAsHandle = NULL; } if (MapAsHandle == NULL && Mapping[StrLen(Mapping)-1] != L':') { - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PROBLEM), gShellLevel2HiiHandle, Mapping); + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PARAM_INV), gShellLevel2HiiHandle, L"map", Mapping); ShellStatus = SHELL_INVALID_PARAMETER; } else { - if (MapAsHandle != NULL) { - TempStringLength = StrLen(SName); - if (!IsNumberLetterOnly(SName, TempStringLength-(SName[TempStringLength-1]==L':'?1:0))) { - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PROBLEM), gShellLevel2HiiHandle, SName); - ShellStatus = SHELL_INVALID_PARAMETER; - } else { + TempStringLength = StrLen(SName); + if (!IsNumberLetterOnly(SName, TempStringLength-(SName[TempStringLength-1]==L':'?1:0))) { + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PARAM_INV), gShellLevel2HiiHandle, L"map", SName); + ShellStatus = SHELL_INVALID_PARAMETER; + } + + if (ShellStatus == SHELL_SUCCESS) { + if (MapAsHandle != NULL) { ShellStatus = AddMappingFromHandle(MapAsHandle, SName); - } - } else { - TempStringLength = StrLen(SName); - if (!IsNumberLetterOnly(SName, TempStringLength-(SName[TempStringLength-1]==L':'?1:0))) { - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PROBLEM), gShellLevel2HiiHandle, SName); - ShellStatus = SHELL_INVALID_PARAMETER; } else { ShellStatus = AddMappingFromMapping(Mapping, SName); } + + if (ShellStatus != SHELL_SUCCESS) { + switch (ShellStatus) { + case SHELL_ACCESS_DENIED: + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_AD), gShellLevel2HiiHandle, L"map"); + break; + case SHELL_INVALID_PARAMETER: + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PARAM_INV), gShellLevel2HiiHandle, L"map", Mapping); + break; + case SHELL_DEVICE_ERROR: + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_MAP_NOF), gShellLevel2HiiHandle, L"map", Mapping); + break; + default: + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_UK), gShellLevel2HiiHandle, L"map", ShellStatus|MAX_BIT); + } + } else { + // + // now do the display... + // + ShellStatus = PerformMappingDisplay( + FALSE, + FALSE, + FALSE, + NULL, + SfoMode, + SName, + TRUE + ); + } // we were sucessful so do an output } - if (ShellStatus != SHELL_SUCCESS) { - switch (ShellStatus) { - case SHELL_ACCESS_DENIED: - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_AD), gShellLevel2HiiHandle); - break; - case SHELL_INVALID_PARAMETER: - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PARAM_INV), gShellLevel2HiiHandle); - break; - case SHELL_DEVICE_ERROR: - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_MAP_NOF), gShellLevel2HiiHandle, Mapping); - break; - default: - ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_UK), gShellLevel2HiiHandle, ShellStatus|MAX_BIT); - } - } else { - // - // now do the display... - // - ShellStatus = PerformMappingDisplay( - FALSE, - FALSE, - FALSE, - NULL, - SfoMode, - SName, - TRUE - ); - } // we were sucessful so do an output } // got a valid map target } // got 2 variables } // we are adding a mapping